147249 2015-07-23 19:24:21 -0700 REGRESSION (r184026): Safari AutoFill with Contact info for phone number is broken 2015-07-26 20:31:00 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz andersca darin mitz sam oldest_to_newest 1111881 0 mitz 2015-07-23 19:24:21 -0700 rdar://problem/21929532 Safari AutoFill is failing to fill some contact information. The reason appears to be that an object graph being sent via WKRemoteObjectRegistry includes NSMutableString instances, and after <http://trac.webkit.org/changeset/184026> those aren’t being decoded correctly: that change applies custom encoding for NSString and its subclasses, but only the corresponding custom decoding for NSString itself. Patch forthcoming. 1111920 1 257435 mitz 2015-07-23 21:45:05 -0700 Created attachment 257435 Use custom string coding for NSString and NSMutableString only 1111921 2 mitz 2015-07-23 21:55:10 -0700 Fixed in <http://trac.webkit.org/r187288>. 1112335 3 darin 2015-07-26 20:16:36 -0700 Given that NSString is a class cluster, allocating a string with methods of NSString can create an object of a class derived from NSString, not NSString itself. Given that, I’m surprised this code works, and I think we may need a different approach to remain robust in the future. 1112339 4 mitz 2015-07-26 20:27:45 -0700 (In reply to comment #3) > Given that NSString is a class cluster, allocating a string with methods of > NSString can create an object of a class derived from NSString, not NSString > itself. Given that, I’m surprised this code works, and I think we may need a > different approach to remain robust in the future. Note that the objectClass variable in encodeObject() is initialized with [object classForCoder], not [object class]. The NSString implementation of -classForCoder returns NSString, and the concrete subclasses (in Foundation) don’t override it, so they all encode as NSString. Similarly, all (Foundation) concrete subclasses of NSMutableString encode as NSMutableString. The assumption here is that anything that encodes as an NSString or NSMutableString uses the Foundation encoder that has the bug that r184026 was meant to work around, and that any subclass that has a different classForCoder probably uses a different encoder that doesn’t have the bug. 1112341 5 darin 2015-07-26 20:31:00 -0700 OK, great! 257435 2015-07-23 21:45:05 -0700 2015-07-23 21:52:31 -0700 Use custom string coding for NSString and NSMutableString only bug-147249-20150723214349.patch text/plain 1945 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NzI4MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTIzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxOTI5 NTMyPiBSRUdSRVNTSU9OIChyMTg0MDI2KTogU2FmYXJpIEF1dG9GaWxsIHdpdGggQ29udGFjdCBp bmZvIGZvciBwaG9uZSBudW1iZXIgaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RD b2Rlci5tbToKKyAgICAgICAgKGVuY29kZU9iamVjdCk6IFVzZSBlbmNvZGVTdHJpbmcgb25seSBm b3Igc3RyaW5ncyB0aGF0IGVuY29kZSBhcyBOU1N0cmluZyBvcgorICAgICAgICBOU011dGFibGVT dHJpbmcuIEl0IGNhbuKAmXQgZW5jb2RlIGFyYml0cmFyeSBOU1N0cmluZyBzdWJjbGFzc2VzLgor ICAgICAgICAoZGVjb2RlT2JqZWN0KTogVXNlIGRlY29kZVN0cmluZyBmb3IgTlNNdXRhYmxlU3Ry aW5nIGFzIHdlbGwuCisKIDIwMTUtMDctMjMgIE1hdHRoZXcgRGFpdGVyICA8bWRhaXRlckBhcHBs ZS5jb20+CiAKICAgICAgICAgTGlua2luZyBXZWJLaXQyIHRvIGJlIGFibGUgdG8gZ3JhYiBtZWRp YSBzb3VyY2VzIGZyb20gYSBVSUQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29j b2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0JKHJldmlzaW9uIDE4NzI2NSkK KysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5t bQkod29ya2luZyBjb3B5KQpAQCAtMjQxLDcgKzI0MSw3IEBAIHN0YXRpYyB2b2lkIGVuY29kZU9i amVjdChXS1JlbW90ZU9iamVjdEUKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChb b2JqZWN0IGlzS2luZE9mQ2xhc3M6W05TU3RyaW5nIGNsYXNzXV0pIHsKKyAgICBpZiAob2JqZWN0 Q2xhc3MgPT0gW05TU3RyaW5nIGNsYXNzXSB8fCBvYmplY3RDbGFzcyA9PSBbTlNNdXRhYmxlU3Ry aW5nIGNsYXNzXSkgewogICAgICAgICBlbmNvZGVTdHJpbmcoZW5jb2Rlciwgb2JqZWN0KTsKICAg ICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTU4Niw2ICs1ODYsOSBAQCBzdGF0aWMgaWQgZGVjb2Rl T2JqZWN0KFdLUmVtb3RlT2JqZWN0RGVjCiAgICAgaWYgKG9iamVjdENsYXNzID09IFtOU1N0cmlu ZyBjbGFzc10pCiAgICAgICAgIHJldHVybiBkZWNvZGVTdHJpbmcoZGVjb2Rlcik7CiAKKyAgICBp ZiAob2JqZWN0Q2xhc3MgPT0gW05TTXV0YWJsZVN0cmluZyBjbGFzc10pCisgICAgICAgIHJldHVy biBbTlNNdXRhYmxlU3RyaW5nIHN0cmluZ1dpdGhTdHJpbmc6ZGVjb2RlU3RyaW5nKGRlY29kZXIp XTsKKwogICAgIGlkIHJlc3VsdCA9IFtvYmplY3RDbGFzcyBhbGxvY1dpdGhab25lOmRlY29kZXIu em9uZV07CiAgICAgaWYgKCFyZXN1bHQpCiAgICAgICAgIFtOU0V4Y2VwdGlvbiByYWlzZTpOU0lu dmFsaWRVbmFyY2hpdmVPcGVyYXRpb25FeGNlcHRpb24gZm9ybWF0OkAiQ2xhc3MgXCIlc1wiIHJl dHVybmVkIG5pbCBmcm9tICthbGxvYyB3aGlsZSBiZWluZyBkZWNvZGVkIiwgY2xhc3NOYW1lLmRh dGEoKV07Cg==