<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>147242</bug_id>
          
          <creation_ts>2015-07-23 16:11:13 -0700</creation_ts>
          <short_desc>[Win] Support High DPI drawing with CACFLayers</short_desc>
          <delta_ts>2015-12-22 10:57:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=146335</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>146335</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1111808</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-07-23 16:11:13 -0700</bug_when>
    <thetext>This is a follow-up to Bug 146335, which added support for High DPI use in our non-accelerated drawing paths.

The Windows platform doesn&apos;t allow a single device scaling factor to be applied to individual windows. Instead, high DPI state is handled by working with larger pixel surfaces at higher DPIs, and performing scaling calculations to control widget size, positioning, etc. Yuck!

This patch applies the proper scaling at various phases of our CACFLayer sizing and positioning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1111810</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-07-23 16:12:10 -0700</bug_when>
    <thetext>Note: Just like with Bug 146335, these scaling calculations are all done at 1x, unless the WebKit client opts into a high DPI state.

Currently, testing is just to make sure no regressions to existing 1x drawing on Windows (and all drawing on other platforms) are not affected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143721</commentid>
    <comment_count>2</comment_count>
      <attachid>265975</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-11-20 11:49:50 -0800</bug_when>
    <thetext>Created attachment 265975
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143726</commentid>
    <comment_count>3</comment_count>
      <attachid>265975</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2015-11-20 12:11:06 -0800</bug_when>
    <thetext>Comment on attachment 265975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265975&amp;action=review

&gt; Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:128
&gt; +    CACFLayerSetContentsScale(layer-&gt;platformLayer(), scaleFactor);

Does the base layer actually have contents? Why do we have to set contentsScale?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143727</commentid>
    <comment_count>4</comment_count>
      <attachid>265975</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2015-11-20 12:11:40 -0800</bug_when>
    <thetext>Comment on attachment 265975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265975&amp;action=review

&gt; Source/WebCore/ChangeLog:15
&gt; +        operations are don properly.

don

&gt; Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:230
&gt; +#if HAVE(CACFLAYER_SETCONTENTSSCALE)
&gt; +    float scaleFactor = CACFLayerGetContentsScale(owner()-&gt;platformLayer());
&gt; +    CACFLayerSetContentsScale(layer.platformLayer(), scaleFactor);
&gt; +#endif

This is confusing; I&apos;m not sure how owner()-&gt;platformLayer() and layer.platformLayer() are different.

Why isn&apos;t this handled via GraphicsLayerCA::deviceOrPageScaleFactorChanged() as it is for other platforms?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143743</commentid>
    <comment_count>5</comment_count>
      <attachid>265975</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-11-20 12:32:27 -0800</bug_when>
    <thetext>Comment on attachment 265975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265975&amp;action=review

&gt;&gt; Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:230
&gt;&gt; +#endif
&gt; 
&gt; This is confusing; I&apos;m not sure how owner()-&gt;platformLayer() and layer.platformLayer() are different.
&gt; 
&gt; Why isn&apos;t this handled via GraphicsLayerCA::deviceOrPageScaleFactorChanged() as it is for other platforms?

Hmmmmm. I&apos;ll investigate before moving forward.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143778</commentid>
    <comment_count>6</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-11-20 13:26:07 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; Comment on attachment 265975 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=265975&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:128
&gt; &gt; +    CACFLayerSetContentsScale(layer-&gt;platformLayer(), scaleFactor);
&gt; 
&gt; Does the base layer actually have contents? Why do we have to set
&gt; contentsScale?

According to the CA engineer who did the Windows work, this is needed for some arcane Windows-related reason.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143779</commentid>
    <comment_count>7</comment_count>
      <attachid>265987</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-11-20 13:26:58 -0800</bug_when>
    <thetext>Created attachment 265987
Patch v2 (Ignore)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143780</commentid>
    <comment_count>8</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-11-20 13:28:11 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; Comment on attachment 265975 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=265975&amp;action=review
&gt; 
&gt; &gt;&gt; Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:230
&gt; &gt;&gt; +#endif
&gt; &gt; 
&gt; &gt; This is confusing; I&apos;m not sure how owner()-&gt;platformLayer() and layer.platformLayer() are different.
&gt; &gt; 
&gt; &gt; Why isn&apos;t this handled via GraphicsLayerCA::deviceOrPageScaleFactorChanged() as it is for other platforms?
&gt; 
&gt; Hmmmmm. I&apos;ll investigate before moving forward.

It looks like this isn&apos;t needed. In fact, I wasn&apos;t even being consistent, as the other places where CACFLayerInsertSublayer was being called did not have the scaling factor change included.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143782</commentid>
    <comment_count>9</comment_count>
      <attachid>265989</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-11-20 13:30:11 -0800</bug_when>
    <thetext>Created attachment 265989
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143831</commentid>
    <comment_count>10</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-11-20 14:35:03 -0800</bug_when>
    <thetext>Committed r192700: &lt;http://trac.webkit.org/changeset/192700&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>265975</attachid>
            <date>2015-11-20 11:49:50 -0800</date>
            <delta_ts>2015-11-20 13:26:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-147242-20151120120804.patch</filename>
            <type>text/plain</type>
            <size>3028</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjY4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTIwICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFN1cHBvcnQgSGln
aCBEUEkgZHJhd2luZyB3aXRoIENBQ0ZMYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzI0MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTk4
NjE5OTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vUGxhdGZvcm1DQUxheWVyV2luSW50ZXJuYWwuY3Bw
OgorICAgICAgICAoUGxhdGZvcm1DQUxheWVyV2luSW50ZXJuYWw6Omluc2VydFN1YmxheWVyKTog
U2V0IG5ldyBzdWJsYXllciBjb250ZW50cyBzY2FsZSB0byBtYXRjaAorICAgICAgICB0aGF0IG9m
IHRoZSBuZXcgcGFyZW50IGxheWVyLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL3dp
bi9XS0NBQ0ZWaWV3TGF5ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXS0NBQ0ZW
aWV3TGF5ZXJUcmVlSG9zdDo6aW5pdGlhbGl6ZUNvbnRleHQpOiBTZXQgY29ycmVjdCBjb250ZW50
IHNjYWxlIGZhY3RvcgorICAgICAgICBmb3IgY3VycmVudCBzY3JlZW4sIGFuZCBhcHBseSBhbiBh
cHByb3ByaWF0ZSBiYXNlIHRyYW5zZm9ybSB0byB0aGUgQ0FDRkxheWVyIHNvIGRyYXdpbmcKKyAg
ICAgICAgb3BlcmF0aW9ucyBhcmUgZG9uIHByb3Blcmx5LgorCiAyMDE1LTExLTIwICBaYWxhbiBC
dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2ltcGxlIGxpbmUgbGF5b3V0OiBB
ZGQgdGV4dC1pbmRlbnQgc3VwcG9ydC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2NhL3dpbi9QbGF0Zm9ybUNBTGF5ZXJXaW5JbnRlcm5hbC5jcHAKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXll
cldpbkludGVybmFsLmNwcAkocmV2aXNpb24gMTkyNjg4KQorKysgU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FMYXllcldpbkludGVybmFsLmNwcAkod29y
a2luZyBjb3B5KQpAQCAtMjIzLDYgKzIyMywxMiBAQCB2b2lkIFBsYXRmb3JtQ0FMYXllcldpbklu
dGVybmFsOjppbnNlcnRTCiAKICAgICBsYXllci5yZW1vdmVGcm9tU3VwZXJsYXllcigpOwogICAg
IENBQ0ZMYXllckluc2VydFN1YmxheWVyKG93bmVyKCktPnBsYXRmb3JtTGF5ZXIoKSwgbGF5ZXIu
cGxhdGZvcm1MYXllcigpLCBpbmRleCk7CisKKyNpZiBIQVZFKENBQ0ZMQVlFUl9TRVRDT05URU5U
U1NDQUxFKQorICAgIGZsb2F0IHNjYWxlRmFjdG9yID0gQ0FDRkxheWVyR2V0Q29udGVudHNTY2Fs
ZShvd25lcigpLT5wbGF0Zm9ybUxheWVyKCkpOworICAgIENBQ0ZMYXllclNldENvbnRlbnRzU2Nh
bGUobGF5ZXIucGxhdGZvcm1MYXllcigpLCBzY2FsZUZhY3Rvcik7CisjZW5kaWYKKwogICAgIG93
bmVyKCktPnNldE5lZWRzQ29tbWl0KCk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2NhL3dpbi9XS0NBQ0ZWaWV3TGF5ZXJUcmVlSG9zdC5jcHAKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1dLQ0FDRlZpZXdM
YXllclRyZWVIb3N0LmNwcAkocmV2aXNpb24gMTkyNjg4KQorKysgU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZ3JhcGhpY3MvY2Evd2luL1dLQ0FDRlZpZXdMYXllclRyZWVIb3N0LmNwcAkod29ya2lu
ZyBjb3B5KQpAQCAtMjYsOCArMjYsMTAgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRl
ICJXS0NBQ0ZWaWV3TGF5ZXJUcmVlSG9zdC5oIgogCisjaW5jbHVkZSAiR0RJVXRpbGl0aWVzLmgi
CiAjaW5jbHVkZSAiUGxhdGZvcm1DQUxheWVyLmgiCiAjaW5jbHVkZSAiU29mdExpbmtpbmcuaCIK
KyNpbmNsdWRlIDxRdWFydHpDb3JlL0NBQ0ZMYXllci5oPgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50
VGltZS5oPgogI2luY2x1ZGUgPHd0Zi9NYWluVGhyZWFkLmg+CiAKQEAgLTEyMCw2ICsxMjIsMTIg
QEAgdm9pZCBXS0NBQ0ZWaWV3TGF5ZXJUcmVlSG9zdDo6Y29udGV4dERpZAogCiB2b2lkIFdLQ0FD
RlZpZXdMYXllclRyZWVIb3N0Ojppbml0aWFsaXplQ29udGV4dCh2b2lkKiB1c2VyRGF0YSwgUGxh
dGZvcm1DQUxheWVyKiBsYXllcikKIHsKKyNpZiBIQVZFKENBQ0ZMQVlFUl9TRVRDT05URU5UU1ND
QUxFKQorICAgIGZsb2F0IHNjYWxlRmFjdG9yID0gZGV2aWNlU2NhbGVGYWN0b3JGb3JXaW5kb3co
bnVsbHB0cik7CisgICAgQ0FDRkxheWVyU2V0VHJhbnNmb3JtKGxheWVyLT5wbGF0Zm9ybUxheWVy
KCksIENBVHJhbnNmb3JtM0RNYWtlU2NhbGUoc2NhbGVGYWN0b3IsIHNjYWxlRmFjdG9yLCAxKSk7
CisgICAgQ0FDRkxheWVyU2V0Q29udGVudHNTY2FsZShsYXllci0+cGxhdGZvcm1MYXllcigpLCBz
Y2FsZUZhY3Rvcik7CisjZW5kaWYKKwogICAgIFdLQ0FDRlZpZXdTZXRDb250ZXh0VXNlckRhdGEo
bV92aWV3LmdldCgpLCB1c2VyRGF0YSk7CiAgICAgV0tDQUNGVmlld1NldExheWVyKG1fdmlldy5n
ZXQoKSwgbGF5ZXItPnBsYXRmb3JtTGF5ZXIoKSk7CiAgICAgV0tDQUNGVmlld1NldENvbnRleHRE
aWRDaGFuZ2VDYWxsYmFjayhtX3ZpZXcuZ2V0KCksIGNvbnRleHREaWRDaGFuZ2VDYWxsYmFjaywg
dGhpcyk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>265987</attachid>
            <date>2015-11-20 13:26:58 -0800</date>
            <delta_ts>2015-11-20 13:30:09 -0800</delta_ts>
            <desc>Patch v2 (Ignore)</desc>
            <filename>bug-147242-20151120134511.patch</filename>
            <type>text/plain</type>
            <size>2694</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjY4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTIwICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFN1cHBvcnQgSGln
aCBEUEkgZHJhd2luZyB3aXRoIENBQ0ZMYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzI0MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTk4
NjE5OTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vV0tDQUNGVmlld0xheWVyVHJlZUhvc3QuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6V0tDQUNGVmlld0xheWVyVHJlZUhvc3Q6OmluaXRpYWxpemVDb250
ZXh0KTogU2V0IGNvcnJlY3QgY29udGVudCBzY2FsZSBmYWN0b3IKKyAgICAgICAgZm9yIGN1cnJl
bnQgc2NyZWVuLCBhbmQgYXBwbHkgYW4gYXBwcm9wcmlhdGUgYmFzZSB0cmFuc2Zvcm0gdG8gdGhl
IENBQ0ZMYXllciBzbyBkcmF3aW5nCisgICAgICAgIG9wZXJhdGlvbnMgYXJlIGRvbmUgcHJvcGVy
bHkuCisKIDIwMTUtMTEtMjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg
ICAgICBTaW1wbGUgbGluZSBsYXlvdXQ6IEFkZCB0ZXh0LWluZGVudCBzdXBwb3J0LgpJbmRleDog
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FBbmltYXRp
b25XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L2NhL3dpbi9QbGF0Zm9ybUNBQW5pbWF0aW9uV2luLmNwcAkocmV2aXNpb24gMTkyNjg4KQorKysg
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FBbmltYXRp
b25XaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzgsNyArMjM4LDcgQEAgQ0ZUaW1lSW50ZXJ2
YWwgUGxhdGZvcm1DQUFuaW1hdGlvbldpbjo6ZAogCiB2b2lkIFBsYXRmb3JtQ0FBbmltYXRpb25X
aW46OnNldER1cmF0aW9uKENGVGltZUludGVydmFsIHZhbHVlKQogewotICAgIENBQ0ZBbmltYXRp
b25TZXREdXJhdGlvbihtX2FuaW1hdGlvbi5nZXQoKSwgdmFsdWUpOworICAgIENBQ0ZBbmltYXRp
b25TZXREdXJhdGlvbihtX2FuaW1hdGlvbi5nZXQoKSwgMiAqIHZhbHVlKTsKIH0KIAogZmxvYXQg
UGxhdGZvcm1DQUFuaW1hdGlvbldpbjo6c3BlZWQoKSBjb25zdApJbmRleDogU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1dLQ0FDRlZpZXdMYXllclRyZWVIb3N0LmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vV0tD
QUNGVmlld0xheWVyVHJlZUhvc3QuY3BwCShyZXZpc2lvbiAxOTI2ODgpCisrKyBTb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vV0tDQUNGVmlld0xheWVyVHJlZUhvc3QuY3Bw
CSh3b3JraW5nIGNvcHkpCkBAIC0yNiw4ICsyNiwxMCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgog
I2luY2x1ZGUgIldLQ0FDRlZpZXdMYXllclRyZWVIb3N0LmgiCiAKKyNpbmNsdWRlICJHRElVdGls
aXRpZXMuaCIKICNpbmNsdWRlICJQbGF0Zm9ybUNBTGF5ZXIuaCIKICNpbmNsdWRlICJTb2Z0TGlu
a2luZy5oIgorI2luY2x1ZGUgPFF1YXJ0ekNvcmUvQ0FDRkxheWVyLmg+CiAjaW5jbHVkZSA8d3Rm
L0N1cnJlbnRUaW1lLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KIApAQCAtMTIwLDYg
KzEyMiwxMiBAQCB2b2lkIFdLQ0FDRlZpZXdMYXllclRyZWVIb3N0Ojpjb250ZXh0RGlkCiAKIHZv
aWQgV0tDQUNGVmlld0xheWVyVHJlZUhvc3Q6OmluaXRpYWxpemVDb250ZXh0KHZvaWQqIHVzZXJE
YXRhLCBQbGF0Zm9ybUNBTGF5ZXIqIGxheWVyKQogeworI2lmIEhBVkUoQ0FDRkxBWUVSX1NFVENP
TlRFTlRTU0NBTEUpCisgICAgZmxvYXQgc2NhbGVGYWN0b3IgPSBkZXZpY2VTY2FsZUZhY3RvckZv
cldpbmRvdyhudWxscHRyKTsKKyAgICBDQUNGTGF5ZXJTZXRUcmFuc2Zvcm0obGF5ZXItPnBsYXRm
b3JtTGF5ZXIoKSwgQ0FUcmFuc2Zvcm0zRE1ha2VTY2FsZShzY2FsZUZhY3Rvciwgc2NhbGVGYWN0
b3IsIDEpKTsKKyAgICBDQUNGTGF5ZXJTZXRDb250ZW50c1NjYWxlKGxheWVyLT5wbGF0Zm9ybUxh
eWVyKCksIHNjYWxlRmFjdG9yKTsKKyNlbmRpZgorCiAgICAgV0tDQUNGVmlld1NldENvbnRleHRV
c2VyRGF0YShtX3ZpZXcuZ2V0KCksIHVzZXJEYXRhKTsKICAgICBXS0NBQ0ZWaWV3U2V0TGF5ZXIo
bV92aWV3LmdldCgpLCBsYXllci0+cGxhdGZvcm1MYXllcigpKTsKICAgICBXS0NBQ0ZWaWV3U2V0
Q29udGV4dERpZENoYW5nZUNhbGxiYWNrKG1fdmlldy5nZXQoKSwgY29udGV4dERpZENoYW5nZUNh
bGxiYWNrLCB0aGlzKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>265989</attachid>
            <date>2015-11-20 13:30:11 -0800</date>
            <delta_ts>2015-11-20 13:36:37 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-147242-20151120134824.patch</filename>
            <type>text/plain</type>
            <size>2079</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjY4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTIwICBCcmVudCBG
dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFN1cHBvcnQgSGln
aCBEUEkgZHJhd2luZyB3aXRoIENBQ0ZMYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzI0MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTk4
NjE5OTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vV0tDQUNGVmlld0xheWVyVHJlZUhvc3QuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6V0tDQUNGVmlld0xheWVyVHJlZUhvc3Q6OmluaXRpYWxpemVDb250
ZXh0KTogU2V0IGNvcnJlY3QgY29udGVudCBzY2FsZSBmYWN0b3IKKyAgICAgICAgZm9yIGN1cnJl
bnQgc2NyZWVuLCBhbmQgYXBwbHkgYW4gYXBwcm9wcmlhdGUgYmFzZSB0cmFuc2Zvcm0gdG8gdGhl
IENBQ0ZMYXllciBzbyBkcmF3aW5nCisgICAgICAgIG9wZXJhdGlvbnMgYXJlIGRvbmUgcHJvcGVy
bHkuCisKIDIwMTUtMTEtMjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg
ICAgICBTaW1wbGUgbGluZSBsYXlvdXQ6IEFkZCB0ZXh0LWluZGVudCBzdXBwb3J0LgpJbmRleDog
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1dLQ0FDRlZpZXdMYXllclRy
ZWVIb3N0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9jYS93aW4vV0tDQUNGVmlld0xheWVyVHJlZUhvc3QuY3BwCShyZXZpc2lvbiAxOTI2ODgpCisr
KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS93aW4vV0tDQUNGVmlld0xheWVy
VHJlZUhvc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw4ICsyNiwxMCBAQAogI2luY2x1ZGUg
ImNvbmZpZy5oIgogI2luY2x1ZGUgIldLQ0FDRlZpZXdMYXllclRyZWVIb3N0LmgiCiAKKyNpbmNs
dWRlICJHRElVdGlsaXRpZXMuaCIKICNpbmNsdWRlICJQbGF0Zm9ybUNBTGF5ZXIuaCIKICNpbmNs
dWRlICJTb2Z0TGlua2luZy5oIgorI2luY2x1ZGUgPFF1YXJ0ekNvcmUvQ0FDRkxheWVyLmg+CiAj
aW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4K
IApAQCAtMTIwLDYgKzEyMiwxMiBAQCB2b2lkIFdLQ0FDRlZpZXdMYXllclRyZWVIb3N0Ojpjb250
ZXh0RGlkCiAKIHZvaWQgV0tDQUNGVmlld0xheWVyVHJlZUhvc3Q6OmluaXRpYWxpemVDb250ZXh0
KHZvaWQqIHVzZXJEYXRhLCBQbGF0Zm9ybUNBTGF5ZXIqIGxheWVyKQogeworI2lmIEhBVkUoQ0FD
RkxBWUVSX1NFVENPTlRFTlRTU0NBTEUpCisgICAgZmxvYXQgc2NhbGVGYWN0b3IgPSBkZXZpY2VT
Y2FsZUZhY3RvckZvcldpbmRvdyhudWxscHRyKTsKKyAgICBDQUNGTGF5ZXJTZXRUcmFuc2Zvcm0o
bGF5ZXItPnBsYXRmb3JtTGF5ZXIoKSwgQ0FUcmFuc2Zvcm0zRE1ha2VTY2FsZShzY2FsZUZhY3Rv
ciwgc2NhbGVGYWN0b3IsIDEpKTsKKyAgICBDQUNGTGF5ZXJTZXRDb250ZW50c1NjYWxlKGxheWVy
LT5wbGF0Zm9ybUxheWVyKCksIHNjYWxlRmFjdG9yKTsKKyNlbmRpZgorCiAgICAgV0tDQUNGVmll
d1NldENvbnRleHRVc2VyRGF0YShtX3ZpZXcuZ2V0KCksIHVzZXJEYXRhKTsKICAgICBXS0NBQ0ZW
aWV3U2V0TGF5ZXIobV92aWV3LmdldCgpLCBsYXllci0+cGxhdGZvcm1MYXllcigpKTsKICAgICBX
S0NBQ0ZWaWV3U2V0Q29udGV4dERpZENoYW5nZUNhbGxiYWNrKG1fdmlldy5nZXQoKSwgY29udGV4
dERpZENoYW5nZUNhbGxiYWNrLCB0aGlzKTsK
</data>
<flag name="review"
          id="291014"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>