147238 2015-07-23 14:07:32 -0700 Adopt the new _previewItemControllerDidCancelPreview delegate method. 2015-07-23 15:01:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned bdakin commit-queue enrica sam thorton oldest_to_newest 1111735 0 yongjun_zhang 2015-07-23 14:07:32 -0700 We need to adopt the new _previewItemControllerDidCancelPreview: to also cancel tapping if a link is not preview-able. 1111736 1 yongjun_zhang 2015-07-23 14:07:54 -0700 <rdar://problem/21875510> 1111747 2 257381 yongjun_zhang 2015-07-23 14:16:50 -0700 Created attachment 257381 Patch. 1111752 3 257382 yongjun_zhang 2015-07-23 14:20:30 -0700 Created attachment 257382 Patch v2. 1111769 4 257382 commit-queue 2015-07-23 15:01:38 -0700 Comment on attachment 257382 Patch v2. Clearing flags on attachment: 257382 Committed r187255: <http://trac.webkit.org/changeset/187255> 1111770 5 commit-queue 2015-07-23 15:01:41 -0700 All reviewed patches have been landed. Closing bug. 257381 2015-07-23 14:16:50 -0700 2015-07-23 14:18:09 -0700 Patch. cancel_preview_delegate.patch text/plain 737 yongjun_zhang Y29tbWl0IDhiNjg5MWU5NWYxYzJhM2YyOWJiMmNiY2NlNTA3MTIwNWZjNjcwNTkKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUaHUgSnVsIDIz IDE0OjA3OjQ5IDIwMTUgLTA3MDAKCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ3MjM4CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCAyYjg1NWVkLi43NmYzNWRiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQpAQCAtMzM5OCw2ICszMzk4LDExIEBAIHN0YXRpYyBib29sIGlzQXNz aXN0YWJsZUlucHV0VHlwZShJbnB1dFR5cGUgdHlwZSkKICAgICByZXR1cm4gcmVjdEFycmF5LmF1 dG9yZWxlYXNlKCk7CiB9CiAKKy0gKHZvaWQpX3ByZXZpZXdJdGVtQ29udHJvbGxlckRpZENhbmNl bFByZXZpZXc6KFVJUHJldmlld0l0ZW1Db250cm9sbGVyICopY29udHJvbGxlcgoreworICAgIF9o aWdobGlnaHRMb25nUHJlc3NDYW5DbGljayA9IE5POworfQorCiBAZW5kCiAKICNlbmRpZgo= 257382 2015-07-23 14:20:30 -0700 2015-07-23 15:01:38 -0700 Patch v2. preview_cancel_delegate.patch text/plain 1600 yongjun_zhang Y29tbWl0IDE0Mjc1ODU2MWQwOGY4ODQ3MDVhMjhjY2IwZTJhZWU0YjhmMTRhZTkKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUaHUgSnVsIDIz IDE0OjA3OjQ5IDIwMTUgLTA3MDAKCiAgICBBZG9wdCB0aGUgbmV3IF9wcmV2aWV3SXRlbUNvbnRy b2xsZXJEaWRDYW5jZWxQcmV2aWV3IGRlbGVnYXRlIG1ldGhvZC4KICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcyMzgKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQ0MTE5OS4u ZWRmZTdlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA3LTIzICBZb25nanVu IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRvcHQgdGhlIG5l dyBfcHJldmlld0l0ZW1Db250cm9sbGVyRGlkQ2FuY2VsUHJldmlldyBkZWxlZ2F0ZSBtZXRob2Qu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcyMzgK KworICAgICAgICBEb24ndCBhbGxvdyBoaWdodGxpZ2h0IGxvbmcgcHJlc3MgdG8gdHJpZ2dlciB0 YXAgaWYgdGhlIGxpbmsgcHJldmlldyBpcyBjYW5jZWxsZWQgYmVjYXVzZQorICAgICAgICB0aGUg bGluayBpcyBub3QgcHJldmlldy1hYmxlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3ByZXZpZXdJdGVtQ29udHJvbGxlckRp ZENhbmNlbFByZXZpZXc6XSk6IAorCiAyMDE1LTA3LTIzICBUaW0gSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBmaWxlcyB0aGF0IHdlcmUgbWVhbnQg dG8gYmUgcmVtb3ZlZCBpbiByMTczOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDJiODU1ZWQuLjc2 ZjM1ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0zMzk4LDYgKzMzOTgsMTEgQEAgc3RhdGljIGJv b2wgaXNBc3Npc3RhYmxlSW5wdXRUeXBlKElucHV0VHlwZSB0eXBlKQogICAgIHJldHVybiByZWN0 QXJyYXkuYXV0b3JlbGVhc2UoKTsKIH0KIAorLSAodm9pZClfcHJldmlld0l0ZW1Db250cm9sbGVy RGlkQ2FuY2VsUHJldmlldzooVUlQcmV2aWV3SXRlbUNvbnRyb2xsZXIgKiljb250cm9sbGVyCit7 CisgICAgX2hpZ2hsaWdodExvbmdQcmVzc0NhbkNsaWNrID0gTk87Cit9CisKIEBlbmQKIAogI2Vu ZGlmCg==