147219 2015-07-22 20:06:44 -0700 Web Inspector: TimelineRuler shouldn't dispatch selection changed event unless it actually changes 2015-07-22 20:55:56 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1111548 0 mattbaker 2015-07-22 20:06:44 -0700 * SUMMARY TimelineRuler shouldn't dispatch selection changed event unless it actually changes. Currently, clicking the overview without dragging to create a new selection will generate a selection changed event. 1111550 1 webkit-bug-importer 2015-07-22 20:08:06 -0700 <rdar://problem/21954961> 1111556 2 257332 mattbaker 2015-07-22 20:21:58 -0700 Created attachment 257332 [Patch] Proposed Fix 1111569 3 257332 commit-queue 2015-07-22 20:55:53 -0700 Comment on attachment 257332 [Patch] Proposed Fix Clearing flags on attachment: 257332 Committed r187207: <http://trac.webkit.org/changeset/187207> 1111570 4 commit-queue 2015-07-22 20:55:56 -0700 All reviewed patches have been landed. Closing bug. 257332 2015-07-22 20:21:58 -0700 2015-07-22 20:55:53 -0700 [Patch] Proposed Fix bug-147219-20150722202044.patch text/plain 4285 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi YmM3NTEwNTdiZDgzYzE2Mzg4NzcxNzc1MDgzYThjNzM0NzdkMmZjLi41Yjc4NTgyMjQ0N2I1MzE1 ZWU5ZDEzNjE3MjEzNjQ4Yzg5NjNmZjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNS0wNy0yMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVSdWxlciBzaG91bGRuJ3QgZGlzcGF0 Y2ggc2VsZWN0aW9uIGNoYW5nZWQgZXZlbnQgdW5sZXNzIGl0IGFjdHVhbGx5IGNoYW5nZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzIxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmVkIHRvIGEg InN1cHByZXNzIG5leHQiIG1vZGVsIGZvciBzdXBwcmVzc2luZyBkaXNwYXRjaCBvZiBUaW1lbGlu ZVJ1bGVyJ3Mgc2VsZWN0aW9uIGNoYW5nZWQgZXZlbnQuIFRoZQorICAgICAgICBydWxlcidzIF90 aW1lUmFuZ2VTZWxlY3Rpb25DaGFuZ2VkIGZsYWcgaXMgbm93IHJlc2V0IG9ubHkgd2hlbiBhbiBl dmVudCBpcyBmaW5hbGx5IGRpc3BhdGNoZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lUnVsZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSdWxl cik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSdWxlci5wcm90b3R5cGUuX3VwZGF0 ZVNlbGVjdGlvbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSdWxlci5wcm90b3R5 cGUuX2Rpc3BhdGNoVGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50KToKKyAgICAgICAgQ2hl Y2sgZm9yIHRoaXMuX3RpbWVSYW5nZVNlbGVjdGlvbkNoYW5nZWQgbW92ZWQgaW50byBkaXNwYXRj aCBmdW5jdGlvbi4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1bGVyLnByb3RvdHlw ZS5faGFuZGxlTW91c2VEb3duKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1bGVy LnByb3RvdHlwZS5faGFuZGxlTW91c2VNb3ZlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1l bGluZVJ1bGVyLnByb3RvdHlwZS5faGFuZGxlTW91c2VVcCk6CisgICAgICAgIFdlIG5vdyBzdXBw cmVzcyB0aGUgbmV4dCBkaXNwYXRjaCBvbmx5LCByYXRoZXIgdGhhbiBhIHRvZ2dsZS4KKwogMjAx NS0wNy0yMiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogUkVHUkVTU0lPTiAoU2FmYXJpIDcpOiBQc2V1ZG8gZWxlbWVudCBydWxlcyBh cmUgbm90IGxhYmVsbGVkIHdpdGggbWVkaWEgcXVlcmllcyBpbiBTdHlsZXMgcGFuZWwKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5l UnVsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZVJ1bGVyLmpzCmluZGV4IDkzNDAyNjBjNzExM2JmMDBkMWFhZmY4YWVlYjU0MTg3ZWNmMDkz MjcuLmYwNGY5NjU1NzFjYzYwNGE1NDNjMDVmOTFiNmVlYWY2ZTVkZWEzOTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVSdWxlci5qcwpAQCAtNTEsNiArNTEsOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSdWxlciA9 IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9hbGxvd3NUaW1lUmFuZ2VTZWxlY3Rpb24gPSBmYWxzZTsK ICAgICB0aGlzLl9taW5pbXVtU2VsZWN0aW9uRHVyYXRpb24gPSAwLjAxOwogICAgIHRoaXMuX2Zv cm1hdExhYmVsQ2FsbGJhY2sgPSBudWxsOworICAgIHRoaXMuX3N1cHByZXNzTmV4dFRpbWVSYW5n ZVNlbGVjdGlvbkNoYW5nZWRFdmVudCA9IGZhbHNlOworICAgIHRoaXMuX3RpbWVSYW5nZVNlbGVj dGlvbkNoYW5nZWQgPSBmYWxzZTsKIAogICAgIHRoaXMuX21hcmtlckVsZW1lbnRNYXAgPSBuZXcg TWFwOwogfTsKQEAgLTYxNiw4ICs2MTgsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSdWxlci5w cm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMu X3JpZ2h0U2VsZWN0aW9uSGFuZGxlRWxlbWVudCk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAo dGhpcy5fdGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZCkKLSAgICAgICAgICAgIHRoaXMuX2Rpc3Bh dGNoVGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50KCk7CisgICAgICAgIHRoaXMuX2Rpc3Bh dGNoVGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50KCk7CiAgICAgfSwKIAogICAgIF9mb3Jt YXREaXZpZGVyTGFiZWxUZXh0OiBmdW5jdGlvbih2YWx1ZSkKQEAgLTYzOCwxMCArNjM5LDE1IEBA IFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1bGVyLnByb3RvdHlwZSA9IHsKIAogICAgIF9kaXNwYXRj aFRpbWVSYW5nZVNlbGVjdGlvbkNoYW5nZWRFdmVudDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAg ICAgZGVsZXRlIHRoaXMuX3RpbWVSYW5nZVNlbGVjdGlvbkNoYW5nZWQ7CisgICAgICAgIGlmICgh dGhpcy5fdGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZCkKKyAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICBpZiAodGhpcy5fc3VwcHJlc3NUaW1lUmFuZ2VTZWxlY3Rpb25DaGFuZ2VkRXZlbnQp CisgICAgICAgIGlmICh0aGlzLl9zdXBwcmVzc05leHRUaW1lUmFuZ2VTZWxlY3Rpb25DaGFuZ2Vk RXZlbnQpIHsKKyAgICAgICAgICAgIHRoaXMuX3N1cHByZXNzTmV4dFRpbWVSYW5nZVNlbGVjdGlv bkNoYW5nZWRFdmVudCA9IGZhbHNlOwogICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisK KyAgICAgICAgdGhpcy5fdGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZCA9IGZhbHNlOwogCiAgICAg ICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1 bGVyLkV2ZW50LlRpbWVSYW5nZVNlbGVjdGlvbkNoYW5nZWQpOwogICAgIH0sCkBAIC02NTgsNyAr NjY0LDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIucHJvdG90eXBlID0gewogICAgICAg ICAgICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMuX3NlbGVjdGlvbklzTW92ZSA9IGV2ZW50LnRh cmdldCA9PT0gdGhpcy5fc2VsZWN0aW9uRHJhZ0VsZW1lbnQ7Ci0gICAgICAgIHRoaXMuX3N1cHBy ZXNzVGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50ID0gIXRoaXMuX3NlbGVjdGlvbklzTW92 ZTsKICAgICAgICAgdGhpcy5fcnVsZXJCb3VuZGluZ0NsaWVudFJlY3QgPSB0aGlzLl9lbGVtZW50 LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOwogCiAgICAgICAgIGlmICh0aGlzLl9zZWxlY3Rpb25J c01vdmUpIHsKQEAgLTY4NCw2ICs2ODksOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSdWxlci5w cm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydChldmVudC5idXR0b24g PT09IDApOwogCisgICAgICAgIHRoaXMuX3N1cHByZXNzTmV4dFRpbWVSYW5nZVNlbGVjdGlvbkNo YW5nZWRFdmVudCA9ICF0aGlzLl9zZWxlY3Rpb25Jc01vdmU7CisKICAgICAgICAgaWYgKHRoaXMu X3NlbGVjdGlvbklzTW92ZSkgewogICAgICAgICAgICAgdmFyIGN1cnJlbnRNb3VzZVBvc2l0aW9u ID0gTWF0aC5tYXgodGhpcy5fbW92ZVNlbGVjdGlvbk1heGltdW1MZWZ0T2Zmc2V0LCBNYXRoLm1p bih0aGlzLl9tb3ZlU2VsZWN0aW9uTWF4aW11bVJpZ2h0T2Zmc2V0LCBldmVudC5wYWdlWCkpOwog CkBAIC03MzYsOCArNzQzLDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIucHJvdG90eXBl ID0gewogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgZGVsZXRlIHRoaXMuX3N1 cHByZXNzVGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50OwotCiAgICAgICAgIHRoaXMuX2Rp c3BhdGNoVGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50KCk7CiAKICAgICAgICAgZG9jdW1l bnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwgdGhpcy5fbW91c2VNb3ZlRXZlbnRM aXN0ZW5lcik7Cg==