147215 2015-07-22 18:37:09 -0700 Coordinates-based snap offsets don't update correctly when container is scrolled 2015-07-28 20:59:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh webkit-unassigned bfulgham cmarcelo commit-queue jamesr luiz tonikitoo webkit-bug-importer oldest_to_newest 1111518 0 wenson_hsieh 2015-07-22 18:37:09 -0700 If a snap scrolling container with child snap-coordinate elements is scrolled and then snap offsets are recomputed, the snap offset computation will not take the parent scroll offset into account, resulting in incorrectly computed snap offsets. You can reproduce this behavior by following these steps: 1. Go to whsieh.github.io/examples/grid.html 2. Scroll somewhere near the lower right corner 3. Resize the window by any amount 4. Try scrolling again. Observe that scroll snapping is completely broken 1111528 1 257321 wenson_hsieh 2015-07-22 18:56:51 -0700 Created attachment 257321 Patch 1111553 2 257321 bfulgham 2015-07-22 20:19:10 -0700 Comment on attachment 257321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257321&action=review This looks great! If the tests pass I think this is ready to go! > LayoutTests/css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html:33 > + container.style.width = "425px"; Great! We're finally testing resize cases. Nice work! 1111576 3 257321 commit-queue 2015-07-22 21:25:32 -0700 Comment on attachment 257321 Patch Clearing flags on attachment: 257321 Committed r187210: <http://trac.webkit.org/changeset/187210> 1111577 4 commit-queue 2015-07-22 21:25:35 -0700 All reviewed patches have been landed. Closing bug. 1113024 5 wenson_hsieh 2015-07-28 20:59:09 -0700 <rdar://problem/22044550> 257321 2015-07-22 18:56:51 -0700 2015-07-22 21:25:32 -0700 Patch bug-147215-20150722185536.patch text/plain 5687 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODcyNjdiODkzMThmNDZl YmY5MmY3ODVmZjliNGM3N2JkYjY1MWQ1MS4uNGI4MWIzNWI4NGRhYmRlZDE3ZDcwNTNlZmU1ZGFm MjVjN2YyNWQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA3LTIyICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIENvb3JkaW5hdGVz LWJhc2VkIHNuYXAgb2Zmc2V0cyBkb24ndCB1cGRhdGUgY29ycmVjdGx5IHdoZW4gY29udGFpbmVy IGlzIHNjcm9sbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDcyMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXhlcyB0aGUgd2F5IHdlIGFwcGVuZCB0aGUgc25hcCBvZmZzZXRzIG9mIGNoaWxkIGVs ZW1lbnRzIHdpdGggY29vcmRpbmF0ZXMuIFdlCisgICAgICAgIG5vdyBjb25zaWRlciB0aGUgc2Ny b2xsIG9mZnNldCBvZiB0aGUgcGFyZW50IHNjcm9sbCBzbmFwcGluZyBjb250YWluZXIsIHNvIHNu YXAKKyAgICAgICAgb2Zmc2V0IHJlY29tcHV0YXRpb25zIGRvbid0IGZhaWwgb24gc2Nyb2xsIHNu YXBwaW5nIGNvbnRhaW5lcnMuCisKKyAgICAgICAgVGVzdDogY3NzMy9zY3JvbGwtc25hcC9zY3Jv bGwtc25hcC1jb29yZGluYXRlLW92ZXJmbG93LXJlc2l6ZS5odG1sCisKKyAgICAgICAgKiBwYWdl L3Njcm9sbGluZy9BeGlzU2Nyb2xsU25hcE9mZnNldHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 YXBwZW5kQ2hpbGRTbmFwT2Zmc2V0cyk6IEZpeGVkIHRvIGNvbnNpZGVyIHRoZSBzY3JvbGwgb2Zm c2V0IG9mIHRoZQorICAgICAgICAgICAgcGFyZW50IGNvbnRhaW5lci4KKwogMjAxNS0wNy0yMiAg RGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgT3V0IG9mIGJvdW5kcyBp biBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnNpbXVsYXRlVmVydGV4QXR0cmliMApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXhpc1Njcm9sbFNuYXBPZmZzZXRzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0F4aXNTY3JvbGxTbmFwT2Zmc2V0cy5j cHAKaW5kZXggZjZkNGE0MGZhYzNkNTQwMDJlMGFkMjllMzc1NDAxMjBkM2JmNjkwNS4uODFkMWU5 N2QwYjYwNTI5MWY5MjRmMDNkNTg1YTBiZjRlMjc2ZTFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9zY3JvbGxpbmcvQXhpc1Njcm9sbFNuYXBPZmZzZXRzLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9BeGlzU2Nyb2xsU25hcE9mZnNldHMuY3BwCkBAIC02 MCw3ICs2MCw3IEBAIHN0YXRpYyB2b2lkIGFwcGVuZENoaWxkU25hcE9mZnNldHMoSFRNTEVsZW1l bnQmIHBhcmVudCwgYm9vbCBzaG91bGRBZGRIb3Jpem9udGFsCiAgICAgICAgICAgICBjb250aW51 ZTsKICAgICAgICAgCiAgICAgICAgIExheW91dFJlY3Qgdmlld1NpemUgPSBib3gtPmNvbnRlbnRC b3hSZWN0KCk7Ci0gICAgICAgIEZsb2F0UG9pbnQgcG9zaXRpb24gPSBib3gtPmxvY2FsVG9Db250 YWluZXJQb2ludChGbG9hdFBvaW50KCksIHBhcmVudC5yZW5kZXJCb3goKSk7CisgICAgICAgIEZs b2F0UG9pbnQgcG9zaXRpb24gPSBib3gtPmxvY2FsVG9Db250YWluZXJQb2ludChGbG9hdFBvaW50 KHBhcmVudC5yZW5kZXJCb3goKS0+c2Nyb2xsTGVmdCgpLCBwYXJlbnQucmVuZGVyQm94KCktPnNj cm9sbFRvcCgpKSwgcGFyZW50LnJlbmRlckJveCgpKTsKICAgICAgICAgZm9yIChhdXRvJiBjb29y ZGluYXRlIDogc2Nyb2xsU25hcENvb3JkaW5hdGVzKSB7CiAgICAgICAgICAgICBMYXlvdXRVbml0 IGxhc3RQb3RlbnRpYWxTbmFwUG9zaXRpb25YID0gcG9zaXRpb24ueCgpICsgdmFsdWVGb3JMZW5n dGgoY29vcmRpbmF0ZS53aWR0aCgpLCB2aWV3U2l6ZS53aWR0aCgpKTsKICAgICAgICAgICAgIGlm IChzaG91bGRBZGRIb3Jpem9udGFsQ2hpbGRPZmZzZXRzICYmIGxhc3RQb3RlbnRpYWxTbmFwUG9z aXRpb25YID4gMCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA4ZWE1NDYyMjA3NWZhODQ3ZTVjMjY4YWE0YWIxNDBiMjZiYWJl YjFlLi42OWFlMTNkZjJhOGE2YzY3NDYxOTYxNmEzMzhhNDMwZTY0ZGE5ZDQ0IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTUtMDctMjIgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CisKKyAgICAgICAgQ29vcmRpbmF0ZXMtYmFzZWQgc25hcCBvZmZzZXRzIGRvbid0IHVw ZGF0ZSBjb3JyZWN0bHkgd2hlbiBjb250YWluZXIgaXMgc2Nyb2xsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzIxNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzIHRoYXQgc25hcCBvZmZzZXRz IHVwZGF0ZSBwcm9wZXJseSBvbiBzY3JvbGxlZCBjb250YWluZXJzLgorCisgICAgICAgICogY3Nz My9zY3JvbGwtc25hcC9zY3JvbGwtc25hcC1jb29yZGluYXRlLW92ZXJmbG93LXJlc2l6ZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNzczMvc2Nyb2xsLXNuYXAvc2Nyb2xsLXNuYXAt Y29vcmRpbmF0ZS1vdmVyZmxvdy1yZXNpemUuaHRtbDogQWRkZWQuCisKIDIwMTUtMDctMjIgIERl YW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIE91dCBvZiBib3VuZHMgaW4g V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpzaW11bGF0ZVZlcnRleEF0dHJpYjAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2NzczMvc2Nyb2xsLXNuYXAvc2Nyb2xsLXNuYXAtY29vcmRpbmF0ZS1vdmVy Zmxvdy1yZXNpemUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY3NzMy9zY3JvbGwtc25hcC9z Y3JvbGwtc25hcC1jb29yZGluYXRlLW92ZXJmbG93LXJlc2l6ZS1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZWMyZjBhYTNlOGRmNGQ5YjRjZjU1MjAxMDViNjgzZWFkNGIwZDkxZAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvc2Nyb2xsLXNuYXAvc2Nyb2xsLXNuYXAtY29vcmRp bmF0ZS1vdmVyZmxvdy1yZXNpemUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOSBAQAorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitTY3JvbGwtc25hcCBv ZmZzZXRzOiB2ZXJ0aWNhbCA9IHsgMCwgNDAwLCA4MDAsIDEyMDAsIDE2MDAsIDIwMDAgfQorU2Ny b2xsLXNuYXAgb2Zmc2V0czogdmVydGljYWwgPSB7IDAsIDQwMCwgODAwLCAxMjAwLCAxNjAwLCAy MDAwIH0KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL3Njcm9sbC1zbmFwL3Njcm9sbC1zbmFwLWNv b3JkaW5hdGUtb3ZlcmZsb3ctcmVzaXplLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL3Njcm9sbC1z bmFwL3Njcm9sbC1zbmFwLWNvb3JkaW5hdGUtb3ZlcmZsb3ctcmVzaXplLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uMGQ5ZTNhOWE5Nzc4NWYwOWNhZjY0OGE5MGFjMWQwZDEwNWMzYTMxZgotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2NzczMvc2Nyb2xsLXNuYXAvc2Nyb2xsLXNuYXAtY29vcmRpbmF0 ZS1vdmVyZmxvdy1yZXNpemUuaHRtbApAQCAtMCwwICsxLDYwIEBACis8aHRtbD4KKworPGhlYWQ+ CisgICAgPHN0eWxlPgorICAgICAgICAjY29udGFpbmVyIHsKKyAgICAgICAgICAgIHdpZHRoOiA0 MjBweDsKKyAgICAgICAgICAgIGhlaWdodDogNDAwcHg7CisgICAgICAgICAgICBvdmVyZmxvdy15 OiBzY3JvbGw7CisgICAgICAgICAgICAtd2Via2l0LXNjcm9sbC1zbmFwLXR5cGU6IG1hbmRhdG9y eTsKKyAgICAgICAgfQorCisgICAgICAgIC5jZWxsIHsKKyAgICAgICAgICAgIHdpZHRoOiA0MDBw eDsKKyAgICAgICAgICAgIGhlaWdodDogNDAwcHg7CisgICAgICAgICAgICAtd2Via2l0LXNjcm9s bC1zbmFwLWNvb3JkaW5hdGU6IDAlIDAlOworICAgICAgICB9CisgICAgPC9zdHlsZT4KKyAgICA8 c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAg ICA8c2NyaXB0PgorICAgIGZ1bmN0aW9uIHNldHVwKCkKKyAgICB7CisgICAgICAgIHZhciBjb250 YWluZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGFpbmVyIik7CisKKyAgICAgICAg ZnVuY3Rpb24gZHVtcFNuYXBPZmZzZXRzQW5kRmluaXNoVGVzdCgpCisgICAgICAgIHsKKyAgICAg ICAgICAgIGRlYnVnKCJTY3JvbGwtc25hcCBvZmZzZXRzOiAiICsgd2luZG93LmludGVybmFscy5z Y3JvbGxTbmFwT2Zmc2V0cyhjb250YWluZXIpKTsKKyAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgp OworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gZHVtcFNuYXBPZmZzZXRzQW5kUmVzaXpl RWxlbWVudCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIGRlYnVnKCJTY3JvbGwtc25hcCBvZmZz ZXRzOiAiICsgd2luZG93LmludGVybmFscy5zY3JvbGxTbmFwT2Zmc2V0cyhjb250YWluZXIpKTsK KyAgICAgICAgICAgIGNvbnRhaW5lci5zdHlsZS53aWR0aCA9ICI0MjVweCI7CisgICAgICAgICAg ICBzZXRUaW1lb3V0KGR1bXBTbmFwT2Zmc2V0c0FuZEZpbmlzaFRlc3QsIDApOworICAgICAgICB9 CisKKyAgICAgICAgY29udGFpbmVyLnNjcm9sbFRvcCA9IDgwMDsKKyAgICAgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7 CisgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgIHRlc3RS dW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICAgICAgc2V0VGltZW91dChkdW1wU25hcE9m ZnNldHNBbmRSZXNpemVFbGVtZW50LCAwKTsKKyAgICAgICAgfQorICAgIH0KKyAgICA8L3Njcmlw dD4KKzwvaGVhZD4KKworPGJvZHkgb25sb2FkPSJzZXR1cCgpIj4KKyAgICA8ZGl2IGlkPSJjb250 YWluZXIiPgorICAgICAgICA8ZGl2IGNsYXNzPSJjZWxsIj48ZGl2IGlkPSJjb25zb2xlIj48L2Rp dj48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0iY2VsbCI+PC9kaXY+CisgICAgICAgIDxkaXYg Y2xhc3M9ImNlbGwiPjwvZGl2PgorICAgICAgICA8ZGl2IGNsYXNzPSJjZWxsIj48L2Rpdj4KKyAg ICAgICAgPGRpdiBjbGFzcz0iY2VsbCI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9ImNlbGwi PjwvZGl2PgorICAgIDwvZGl2PgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKworPC9odG1sPgo=