147204 2015-07-22 15:17:57 -0700 Web Inspector: Timeline's Current Time does not jump forward to new start time when starting a new recording, causes timeline to appear delayed and broken 2015-07-22 21:20:01 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev simon.fraser timothy webkit-bug-importer oldest_to_newest 1111443 0 joepeck 2015-07-22 15:17:57 -0700 * SUMMARY Timeline's Current Time does not jump forward to new start time when starting a new recording, causes timeline to appear delayed and broken. * STEPS TO REPRODUCE 1. Inspect https://en.wikipedia.org/wiki/Main_Page 2. Show timelines tab 3. Command-R to reload 4. Timeline starts automatically 5. Wait for timeline to stop or manually stop at about the 5s mark. 6. Wait 30 seconds 7. Click button to start recording 8. Scroll page a bit to ensure we have events. 9. Click button to stop recording => Timeline plays nothing for 30 seconds and the shows events for the 1s of recording => Expected timeline to immediately jump forward 30s and show the events for the 1s of recording 1111444 1 joepeck 2015-07-22 15:18:30 -0700 <rdar://problem/21946519> 1111445 2 257300 joepeck 2015-07-22 15:21:15 -0700 Created attachment 257300 [PATCH] Proposed Fix 1111459 3 257300 mattbaker 2015-07-22 15:50:52 -0700 Comment on attachment 257300 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=257300&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:-520 > - Child records of the rendering frame are added to the other timelines, so this change would potentially net us an earlier current time, but the difference should be very small. 1111466 4 257300 mattbaker 2015-07-22 16:07:30 -0700 Comment on attachment 257300 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=257300&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:-517 > - // The rendering frame timeline doesn't use a time axis. The axis type is irrelevant. A rendering frame record generally has an earlier start time than its first child, which we want to account for. We should remove this check. 1111574 5 257300 commit-queue 2015-07-22 21:19:58 -0700 Comment on attachment 257300 [PATCH] Proposed Fix Clearing flags on attachment: 257300 Committed r187209: <http://trac.webkit.org/changeset/187209> 1111575 6 commit-queue 2015-07-22 21:20:01 -0700 All reviewed patches have been landed. Closing bug. 257300 2015-07-22 15:21:15 -0700 2015-07-22 21:19:58 -0700 [PATCH] Proposed Fix le-issue.patch text/plain 1960 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUwMDJhNGUuLmZhZDBjMmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA3LTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUncyBDdXJyZW50IFRpbWUgZG9lcyBub3QganVtcCBmb3J3YXJkIHRvIG5ldyBzdGFydCB0aW1l IHdoZW4gc3RhcnRpbmcgYSBuZXcgcmVjb3JkaW5nLCBjYXVzZXMgdGltZWxpbmUgdG8gYXBwZWFy IGRlbGF5ZWQgYW5kIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ3MjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50 Vmlldy5wcm90b3R5cGUuX3JlY29yZGluZ1RpbWVzVXBkYXRlZCk6CisgICAgICAgIFdlIHdlcmUg c2tpcHBpbmcgYSB0aW1lbGluZSwgYnV0IGl0IG1pZ2h0IGhhdmUgYSBuZXcgZXZlbnQgcmVjb3Jk IHdpdGgKKyAgICAgICAgYSBuZXcgc3RhcnQgdGltZS4gVGhpcyBlbnN1cmVzIHdlIGdldCBhbiB1 cGRhdGVkIGN1cnJlbnQgdGltZSB3aGljaCBtYWtlcworICAgICAgICBzZW5zZSwgYW5kIHdlIGp1 bXAgZm9yd2FyZCB0byB0aGF0IHRpbWUgaW4gdGhlIG1haW4gdGltZWxpbmUuCisKIDIwMTUtMDct MjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBjb25zb2xlLmxvZygiJWQiLCAwKSBvciBjb25zb2xlLmxvZygiJWQiLCAic3Ry Iikgc2hvdyBub3RoaW5nLCBleHBlY3RlZCBOdW1iZXIgb3IgTmFOCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0Nv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwppbmRleCAyN2JlNTk3Li5jM2RmMDdiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKQEAgLTUx NCwxMCArNTE0LDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcu cHJvdG90eXBlID0gewogICAgICAgICAvLyBXZSBtaWdodCB3YW50IHRvIGhhdmUgdGhlIGJhY2tl bmQgc2VuZCBhICJzdGFydCIgcmVjb3JkIHRvIGdldCBjdXJyZW50IHRpbWUgbW92aW5nLgogCiAg ICAgICAgIGZvciAodmFyIHRpbWVsaW5lIG9mIHRoaXMuX3JlY29yZGluZy50aW1lbGluZXMudmFs dWVzKCkpIHsKLSAgICAgICAgICAgIC8vIFRoZSByZW5kZXJpbmcgZnJhbWUgdGltZWxpbmUgZG9l c24ndCB1c2UgYSB0aW1lIGF4aXMuCi0gICAgICAgICAgICBpZiAodGltZWxpbmUudHlwZSA9PT0g V2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkLlR5cGUuUmVuZGVyaW5nRnJhbWUpCi0gICAgICAg ICAgICAgICAgY29udGludWU7Ci0KICAgICAgICAgICAgIHZhciBsYXN0UmVjb3JkID0gdGltZWxp bmUucmVjb3Jkcy5sYXN0VmFsdWU7CiAgICAgICAgICAgICBpZiAoIWxhc3RSZWNvcmQpCiAgICAg ICAgICAgICAgICAgY29udGludWU7Cg==