147191 2015-07-22 07:57:09 -0700 [EFL] The "Missing Plug-in" buttons are not showing up on some flash contents 2015-07-22 20:37:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho commit-queue lucas.de.marchi oldest_to_newest 1111276 0 257268 sungmann.cho 2015-07-22 07:57:09 -0700 Created attachment 257268 a test content taken from http://www.youku.com/ Currently, WebKitEFL doesn't show the "Missing Plug-in" buttons if the plugin-related tags don't have a "type" attribute. In such a case, WebCore tries to guess the MIME type from the extensions by using MIMETypeRegistry::getMIMETypeForExtension(). For WebKitEFL, MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple array of <extension, mime type>, looking for the mime type for the given extension. But |extensionMap| in MIMETypeRegistryEfl.cpp doesn't have the information for ".swf", so WebCore fails to guess the MIME type and regard the content type as ObjectContentFrame, not ObjectContentNetscapePlugin. 1111279 1 257269 sungmann.cho 2015-07-22 08:00:49 -0700 Created attachment 257269 Patch 1111280 2 sungmann.cho 2015-07-22 08:11:38 -0700 WebKitGTK+ also had the same problem and the issue has now been resolved. http://trac.webkit.org/changeset/186581 1111494 3 257269 gyuyoung.kim 2015-07-22 17:28:24 -0700 Comment on attachment 257269 Patch nice fix. r=me. 1111561 4 257269 commit-queue 2015-07-22 20:37:51 -0700 Comment on attachment 257269 Patch Clearing flags on attachment: 257269 Committed r187206: <http://trac.webkit.org/changeset/187206> 1111562 5 commit-queue 2015-07-22 20:37:53 -0700 All reviewed patches have been landed. Closing bug. 257268 2015-07-22 07:57:09 -0700 2015-07-22 07:57:09 -0700 a test content taken from http://www.youku.com/ the-test-content-taken-from-youku-com.html text/html 354 sungmann.cho PGh0bWw+DQo8Ym9keT4NCjxlbWJlZCBzcmM9Imh0dHA6Ly9zdGF0aWMueW91a3UuY29tL3YxLjAu MDIyMy92L3N3Zi9sb2FkZXIuc3dmP3dpblR5cGU9YWRzaG93JmFtcDtWaWRlb0lEUz0zMTYzNDgw MTYmYW1wO2lzQXV0b1BsYXk9dHJ1ZSZhbXA7ZGVsYXlsb2FkPXRydWUmYW1wO2lzU2hvd1JlbGF0 ZWRWaWRlbz1mYWxzZSZhbXA7aW1nbG9nbz1odHRwOi8vc3RhdGljLmF0bS55b3VrdS5jb20vaWRl YS8yMDE1MDYvMDYxOS84MTg0OC8zMTAtMjA1LmpwZyIgd2lkdGg9IjMxMCIgaGVpZ2h0PSIyMjAi IGJvcmRlcj0iMCIgYWxpZ249ImNlbnRlciIgd21vZGU9Im9wYXF1ZSI+PC9vYmplY3Q+DQo8L2Jv ZHk+DQo8L2h0bWw+ 257269 2015-07-22 08:00:49 -0700 2015-07-22 20:37:51 -0700 Patch bug-147191-20150722235934.patch text/plain 2039 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM4MDcyNmJhMDcyMDZl NWM3YjJkMGUxZmIwY2NhYTE1OGM5N2QxNi4uYzQwOGQwY2EzMGIzZGQyZmRiMDQ1MjFjNWVmMjY5 MjQ4NWFiYWFlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA3LTIyICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBbRUZMXSBU aGUgIk1pc3NpbmcgUGx1Zy1pbiIgYnV0dG9ucyBhcmUgbm90IHNob3dpbmcgdXAgb24gc29tZSBm bGFzaCBjb250ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ3MTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3VycmVudGx5LCBXZWJLaXRFRkwgZG9lc24ndCBzaG93IHRoZSAiTWlzc2luZyBQbHVn LWluIiBidXR0b25zIGlmIHRoZSBwbHVnaW4tcmVsYXRlZCB0YWdzCisgICAgICAgIGRvbid0IGhh dmUgYSAidHlwZSIgYXR0cmlidXRlLiBJbiBzdWNoIGEgY2FzZSwgV2ViQ29yZSB0cmllcyB0byBn dWVzcyB0aGUgTUlNRSB0eXBlIGZyb20KKyAgICAgICAgdGhlIGV4dGVuc2lvbnMgYnkgdXNpbmcg TUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24oKS4gRm9yIFdlYktpdEVG TCwKKyAgICAgICAgTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24oKSBn b2VzIHRocm91Z2ggfGV4dGVuc2lvbk1hcHwsIHdoaWNoIGlzIGEgc2ltcGxlCisgICAgICAgIGFy cmF5IG9mIDxleHRlbnNpb24sIG1pbWUgdHlwZT4sIGxvb2tpbmcgZm9yIHRoZSBtaW1lIHR5cGUg Zm9yIHRoZSBnaXZlbiBleHRlbnNpb24uCisgICAgICAgIEJ1dCB8ZXh0ZW5zaW9uTWFwfCBpbiBN SU1FVHlwZVJlZ2lzdHJ5RWZsLmNwcCBkb2Vzbid0IGhhdmUgdGhlIGluZm9ybWF0aW9uIGZvciAi LnN3ZiIsCisgICAgICAgIHNvIFdlYkNvcmUgZmFpbHMgdG8gZ3Vlc3MgdGhlIE1JTUUgdHlwZSBh bmQgcmVnYXJkIHRoZSBjb250ZW50IHR5cGUgYXMgT2JqZWN0Q29udGVudEZyYW1lLAorICAgICAg ICBub3QgT2JqZWN0Q29udGVudE5ldHNjYXBlUGx1Z2luLgorCisgICAgICAgICogcGxhdGZvcm0v ZWZsL01JTUVUeXBlUmVnaXN0cnlFZmwuY3BwOgorCiAyMDE1LTA3LTIwICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWls ZCBmaXggYWZ0ZXIgcjE4NzA0OS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9NSU1FVHlwZVJlZ2lzdHJ5RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9NSU1FVHlwZVJlZ2lzdHJ5RWZsLmNwcAppbmRleCBhZTZhOTdlODRiMmRhZjdmYWNiNzk0NTUy NmFlN2JhYzZmYTYwM2NhLi4zMzY0MmIwNDE1NjY2M2U0NWU3ZDdmMGVmNTE4MThmODJjYzA2NDk2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTUlNRVR5cGVSZWdpc3Ry eUVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL01JTUVUeXBlUmVnaXN0 cnlFZmwuY3BwCkBAIC02Miw2ICs2Miw3IEBAIHN0YXRpYyBjb25zdCBFeHRlbnNpb25NYXAgZXh0 ZW5zaW9uTWFwW10gPSB7CiAgICAgeyAicHBtIiwgImltYWdlL3gtcG9ydGFibGUtcGl4bWFwIiB9 LAogICAgIHsgInJzcyIsICJhcHBsaWNhdGlvbi9yc3MreG1sIiB9LAogICAgIHsgInN2ZyIsICJp bWFnZS9zdmcreG1sIiB9LAorICAgIHsgInN3ZiIsICJhcHBsaWNhdGlvbi94LXNob2Nrd2F2ZS1m bGFzaCIgfSwKICAgICB7ICJ0ZXh0IiwgInRleHQvcGxhaW4iIH0sCiAgICAgeyAidGlmIiwgImlt YWdlL3RpZmYiIH0sCiAgICAgeyAidGlmZiIsICJpbWFnZS90aWZmIiB9LAo=