147177 2015-07-21 17:55:18 -0700 Web Inspector: Node highlights are wrong when the page is zoomed 2015-08-28 02:00:44 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev simon.fraser thorton timothy webkit-bug-importer oldest_to_newest 1111157 0 joepeck 2015-07-21 17:55:18 -0700 * SUMMARY Node highlights are wrong when the page is zoomed. * STEPS TO REPRODUCE 1. Inspect <http://daringfireball.net> 2. Double tap to zoom in to post content 3. Inspect the title of a post => node highlight is very large and misplaced 1111158 1 joepeck 2015-07-21 17:55:27 -0700 <rdar://problem/13583256> 1111159 2 257226 joepeck 2015-07-21 17:56:36 -0700 Created attachment 257226 [PATCH] Proposed Fix 1111162 3 257226 simon.fraser 2015-07-21 17:59:01 -0700 Comment on attachment 257226 [PATCH] Proposed Fix Whoo nice! 1111178 4 257226 commit-queue 2015-07-21 18:47:18 -0700 Comment on attachment 257226 [PATCH] Proposed Fix Clearing flags on attachment: 257226 Committed r187145: <http://trac.webkit.org/changeset/187145> 1111179 5 commit-queue 2015-07-21 18:47:21 -0700 All reviewed patches have been landed. Closing bug. 1121647 6 thorton 2015-08-28 02:00:44 -0700 *** Bug 145368 has been marked as a duplicate of this bug. *** 257226 2015-07-21 17:56:36 -0700 2015-07-21 18:47:18 -0700 [PATCH] Proposed Fix highlight.patch text/plain 1607 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2Yzg5ZDlkMi4uZTIyMWUwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA3LTIxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisK KyAgICAgICAgV2ViIEluc3BlY3RvcjogTm9kZSBoaWdobGlnaHRzIGFyZSB3cm9uZyB3aGVuIHRo ZSBwYWdlIGlzIHpvb21lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ3MTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JPdmVybGF5Ojp1cGRhdGUpOgorICAgICAgICBSZW1vdmUgc2NhbGluZyB0 aGF0IGFwcGVhcnMgdG8gbm8gbG9uZ2VyIGJlIG5lZWRlZCwgaXQgd2FzIGRvdWJsZQorICAgICAg ICBzY2FsaW5nIHRoZSBvdmVybGF5IGNvbnRlbnQgYW5kIG1pc3BsYWNpbmcgaXQgaW4gdGhlIHBy b2Nlc3MuCisKIDIwMTUtMDctMjAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBcHBDYWNoZSBtYW5pZmVzdCA0MDQgZG9lc24n dCBwcm9kdWNlIGVycm9ycyBpbiBjb25zb2xlLCBtYW5pZmVzdCByZXNvdXJjZSByZXF1ZXN0IGFs d2F5cyBsb2FkaW5nIGluZGljYXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3Rvck92ZXJsYXkuY3BwCmluZGV4IDY3MzNhZGUuLjc2N2YzNDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKQEAgLTMxNiw4ICszMTYsNiBAQCB2 b2lkIEluc3BlY3Rvck92ZXJsYXk6OnVwZGF0ZSgpCiAgICAgRnJhbWVWaWV3KiBvdmVybGF5Vmll dyA9IG92ZXJsYXlQYWdlKCktPm1haW5GcmFtZSgpLnZpZXcoKTsKICAgICBJbnRTaXplIHZpZXdw b3J0U2l6ZSA9IHZpZXctPnVuc2NhbGVkVmlzaWJsZUNvbnRlbnRTaXplSW5jbHVkaW5nT2JzY3Vy ZWRBcmVhKCk7CiAgICAgSW50U2l6ZSBmcmFtZVZpZXdGdWxsU2l6ZSA9IHZpZXctPnVuc2NhbGVk VmlzaWJsZUNvbnRlbnRTaXplSW5jbHVkaW5nT2JzY3VyZWRBcmVhKFNjcm9sbGFibGVBcmVhOjpJ bmNsdWRlU2Nyb2xsYmFycyk7Ci0gICAgb3ZlcmxheVBhZ2UoKS0+c2V0UGFnZVNjYWxlRmFjdG9y KG1fcGFnZS5wYWdlU2NhbGVGYWN0b3IoKSwgSW50UG9pbnQoKSk7Ci0gICAgZnJhbWVWaWV3RnVs bFNpemUuc2NhbGUobV9wYWdlLnBhZ2VTY2FsZUZhY3RvcigpKTsKICAgICBvdmVybGF5Vmlldy0+ cmVzaXplKGZyYW1lVmlld0Z1bGxTaXplKTsKIAogICAgIC8vIENsZWFyIGNhbnZhcyBhbmQgcGFp bnQgdGhpbmdzLgo=