147175 2015-07-21 17:39:32 -0700 Web Inspector: [Mac] "Open Image In New Window" context menu item does nothing on an image 2015-07-21 18:51:02 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1111147 0 joepeck 2015-07-21 17:39:32 -0700 * SUMMARY "Open Image In New Window" context menu item does nothing on an image * STEPS TO REPRODUCE 1. Inspect webkit.org 2. Select an image resource 3. Right click the image 4. Select the "Open Image in New Window" context menu => nothing happens * NOTES - Context Menus that don't work should be removed by default. - Ultimately we should include better context menus (more like Safari). For instance a "Save Image As" menu item would be useful here, and apparently done by Safari not WebKit. 1111148 1 joepeck 2015-07-21 17:39:58 -0700 <rdar://problem/5870858> 1111150 2 257224 joepeck 2015-07-21 17:41:47 -0700 Created attachment 257224 [PATCH] Proposed Fix 1111182 3 257224 commit-queue 2015-07-21 18:50:59 -0700 Comment on attachment 257224 [PATCH] Proposed Fix Clearing flags on attachment: 257224 Committed r187146: <http://trac.webkit.org/changeset/187146> 1111183 4 commit-queue 2015-07-21 18:51:02 -0700 All reviewed patches have been landed. Closing bug. 257224 2015-07-21 17:41:47 -0700 2015-07-21 18:50:59 -0700 [PATCH] Proposed Fix context-menus.patch text/plain 5657 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBhZTQ2NTg4Li43MDY4M2EyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTUtMDctMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbTWFjXSAiT3BlbiBJbWFnZSBJbiBO ZXcgV2luZG93IiBjb250ZXh0IG1lbnUgaXRlbSBkb2VzIG5vdGhpbmcgb24gYW4gaW1hZ2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzE3NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tOgorICAgICAgICAoLVtXZWJJbnNwZWN0b3JXaW5k b3dDb250cm9sbGVyIHdlYlZpZXc6Y29udGV4dE1lbnVJdGVtc0ZvckVsZW1lbnQ6ZGVmYXVsdE1l bnVJdGVtczpdKToKKyAgICAgICAgUmVtb3ZlIGRlZmF1bHQgY29udGV4dCBtZW51cyB0aGF0IHdv bid0IHdvcmsgaW4gdGhlIGluc3BlY3RvciBwYWdlLgorCiAyMDE1LTA3LTIxICBCcmFkeSBFaWRz b24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggV2ViUHJlZmVyZW5jZXMgaW5m aW5pdGUgcmVjdXJzaW9uIGludHJvZHVjZWQgaW4gcjE4NjIzMi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbSBiL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbQppbmRleCAw Yjc0NTAzLi44MDYwMDNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3Vw cG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29y ZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCkBAIC00MCw3ICs0MCw3IEBACiAjaW1wb3J0 ICJXZWJQb2xpY3lEZWxlZ2F0ZS5oIgogI2ltcG9ydCAiV2ViUXVvdGFNYW5hZ2VyLmgiCiAjaW1w b3J0ICJXZWJTZWN1cml0eU9yaWdpblByaXZhdGUuaCIKLSNpbXBvcnQgIldlYlVJRGVsZWdhdGUu aCIKKyNpbXBvcnQgIldlYlVJRGVsZWdhdGVQcml2YXRlLmgiCiAjaW1wb3J0ICJXZWJWaWV3SW50 ZXJuYWwuaCIKICNpbXBvcnQgPGFsZ29yaXRobT4KICNpbXBvcnQgPGJpbmRpbmdzL1NjcmlwdFZh bHVlLmg+CkBAIC03MzcsNiArNzM3LDI4IEBAIHZvaWQgV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGll bnQ6OmFwcGVuZChjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZFVSTCwgY29uc3QgU3RyaW5nCiAgICAg ZGF0YWJhc2VRdW90YU1hbmFnZXIucXVvdGEgPSBzdGQ6Om1heDx1bnNpZ25lZCBsb25nIGxvbmc+ KDUgKiAxMDI0ICogMTAyNCwgZGF0YWJhc2VRdW90YU1hbmFnZXIudXNhZ2UgKiAxLjI1KTsKIH0K IAorLSAoTlNBcnJheSAqKXdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIgY29udGV4dE1lbnVJdGVt c0ZvckVsZW1lbnQ6KE5TRGljdGlvbmFyeSAqKWVsZW1lbnQgZGVmYXVsdE1lbnVJdGVtczooTlNB cnJheSAqKWRlZmF1bHRNZW51SXRlbXMKK3sKKyAgICBOU011dGFibGVBcnJheSAqbWVudUl0ZW1z ID0gW1tOU011dGFibGVBcnJheSBhbGxvY10gaW5pdF07CisKKyAgICBmb3IgKE5TTWVudUl0ZW0g Kml0ZW0gaW4gZGVmYXVsdE1lbnVJdGVtcykgeworICAgICAgICBzd2l0Y2ggKGl0ZW0udGFnKSB7 CisgICAgICAgIGNhc2UgV2ViTWVudUl0ZW1UYWdPcGVuTGlua0luTmV3V2luZG93OgorICAgICAg ICBjYXNlIFdlYk1lbnVJdGVtVGFnT3BlbkltYWdlSW5OZXdXaW5kb3c6CisgICAgICAgIGNhc2Ug V2ViTWVudUl0ZW1UYWdPcGVuRnJhbWVJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBXZWJNZW51 SXRlbVRhZ09wZW5NZWRpYUluTmV3V2luZG93OgorICAgICAgICBjYXNlIFdlYk1lbnVJdGVtVGFn RG93bmxvYWRMaW5rVG9EaXNrOgorICAgICAgICBjYXNlIFdlYk1lbnVJdGVtVGFnRG93bmxvYWRJ bWFnZVRvRGlzazoKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAg ICAgICAgW21lbnVJdGVtcyBhZGRPYmplY3Q6aXRlbV07CisgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgfQorICAgIH0KKworICAgIHJldHVybiBbbWVudUl0ZW1zIGF1dG9yZWxlYXNlXTsKK30K KwogLy8gTUFSSzogLQogLy8gTUFSSzogUG9saWN5IGRlbGVnYXRlCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA0 ZGE2NTM4Li45Yjg0YWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDctMjEg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbTWFjXSAiT3BlbiBJbWFnZSBJbiBOZXcgV2luZG93IiBjb250ZXh0IG1lbnUgaXRl bSBkb2VzIG5vdGhpbmcgb24gYW4gaW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NzE3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5t bToKKyAgICAgICAgKFdlYktpdDo6Z2V0Q29udGV4dE1lbnVGcm9tUHJvcG9zZWRNZW51KToKKyAg ICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRlSW5zcGVjdG9y UGFnZSk6CisgICAgICAgIFJlbW92ZSBkZWZhdWx0IGNvbnRleHQgbWVudXMgdGhhdCB3b24ndCB3 b3JrIGluIHRoZSBpbnNwZWN0b3IgcGFnZS4KKwogMjAxNS0wNy0yMSAgRGFuaWVsIEJhdGVzICA8 ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUKG1fc3VzcGVuZE1lc3NhZ2VDb3Vu dCA+PSAwKSBmYWlscyBpbiBQcm9jZXNzVGhyb3R0bGVyOjpkaWRDYW5jZWxQcm9jZXNzU3VzcGVu c2lvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3Bl Y3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0 b3JQcm94eU1hYy5tbQppbmRleCBiMzg5OGYyLi40NWQ4OTVlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KQEAgLTI5LDYg KzI5LDggQEAKICNpZiBQTEFURk9STShNQUMpICYmIFdLX0FQSV9FTkFCTEVECiAKICNpbXBvcnQg IldLQVBJQ2FzdC5oIgorI2ltcG9ydCAiV0tBcnJheS5oIgorI2ltcG9ydCAiV0tDb250ZXh0TWVu dUl0ZW0uaCIKICNpbXBvcnQgIldLSW5zcGVjdG9yUHJpdmF0ZU1hYy5oIgogI2ltcG9ydCAiV0tN dXRhYmxlQXJyYXkuaCIKICNpbXBvcnQgIldLT3BlblBhbmVsUGFyYW1ldGVycy5oIgpAQCAtMjQ5 LDYgKzI1MSwzMCBAQCBzdGF0aWMgdm9pZCBydW5PcGVuUGFuZWwoV0tQYWdlUmVmIHBhZ2UsIFdL RnJhbWVSZWYgZnJhbWUsIFdLT3BlblBhbmVsUGFyYW1ldGVycwogICAgICAgICBjb21wbGV0aW9u SGFuZGxlcihbb3BlblBhbmVsIHJ1bk1vZGFsXSk7CiB9CiAKK3N0YXRpYyB2b2lkIGdldENvbnRl eHRNZW51RnJvbVByb3Bvc2VkTWVudShXS1BhZ2VSZWYgcGFnZVJlZiwgV0tBcnJheVJlZiBwcm9w b3NlZE1lbnVSZWYsIFdLQXJyYXlSZWYqIG5ld01lbnVSZWYsIFdLSGl0VGVzdFJlc3VsdFJlZiwg V0tUeXBlUmVmLCBjb25zdCB2b2lkKikKK3sKKyAgICBXS011dGFibGVBcnJheVJlZiBtZW51SXRl bXMgPSBXS011dGFibGVBcnJheUNyZWF0ZSgpOworCisgICAgc2l6ZV90IGNvdW50ID0gV0tBcnJh eUdldFNpemUocHJvcG9zZWRNZW51UmVmKTsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGNv dW50OyArK2kpIHsKKyAgICAgICAgV0tDb250ZXh0TWVudUl0ZW1SZWYgY29udGV4dE1lbnVJdGVt ID0gc3RhdGljX2Nhc3Q8V0tDb250ZXh0TWVudUl0ZW1SZWY+KFdLQXJyYXlHZXRJdGVtQXRJbmRl eChwcm9wb3NlZE1lbnVSZWYsIGkpKTsKKyAgICAgICAgc3dpdGNoIChXS0NvbnRleHRNZW51SXRl bUdldFRhZyhjb250ZXh0TWVudUl0ZW0pKSB7CisgICAgICAgIGNhc2Uga1dLQ29udGV4dE1lbnVJ dGVtVGFnT3BlbkxpbmtJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0 ZW1UYWdPcGVuSW1hZ2VJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0 ZW1UYWdPcGVuRnJhbWVJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0 ZW1UYWdPcGVuTWVkaWFJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0 ZW1UYWdEb3dubG9hZExpbmtUb0Rpc2s6CisgICAgICAgIGNhc2Uga1dLQ29udGV4dE1lbnVJdGVt VGFnRG93bmxvYWRJbWFnZVRvRGlzazoKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBkZWZh dWx0OgorICAgICAgICAgICAgV0tBcnJheUFwcGVuZEl0ZW0obWVudUl0ZW1zLCBjb250ZXh0TWVu dUl0ZW0pOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICB9CisKKyAgICAqbmV3 TWVudVJlZiA9IG1lbnVJdGVtczsKK30KKwogdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6YXR0YWNo bWVudFZpZXdEaWRDaGFuZ2UoTlNWaWV3ICpvbGRWaWV3LCBOU1ZpZXcgKm5ld1ZpZXcpCiB7CiAg ICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSByZW1vdmVPYnNlcnZlcjpt X2luc3BlY3RvclByb3h5T2JqQ0FkYXB0ZXIuZ2V0KCkgbmFtZTpOU1ZpZXdGcmFtZURpZENoYW5n ZU5vdGlmaWNhdGlvbiBvYmplY3Q6b2xkVmlld107CkBAIC00NzAsNiArNDk2LDE4IEBAIFdlYlBh Z2VQcm94eSogV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRlSW5zcGVjdG9yUGFnZSgp CiAKICAgICBXS1BhZ2VTZXRQYWdlVUlDbGllbnQodG9BUEkoaW5zcGVjdG9yUGFnZSksICZ1aUNs aWVudC5iYXNlKTsKIAorICAgIFdLUGFnZUNvbnRleHRNZW51Q2xpZW50VjMgY29udGV4dE1lbnVD bGllbnQgPSB7CisgICAgICAgIHsgMywgdGhpcyB9LAorICAgICAgICAwLCAvLyBnZXRDb250ZXh0 TWVudUZyb21Qcm9wb3NlZE1lbnVfZGVwcmVjYXRlZEZvclVzZVdpdGhWMAorICAgICAgICAwLCAv LyBjdXN0b21Db250ZXh0TWVudUl0ZW1TZWxlY3RlZAorICAgICAgICAwLCAvLyBjb250ZXh0TWVu dURpc21pc3NlZAorICAgICAgICBnZXRDb250ZXh0TWVudUZyb21Qcm9wb3NlZE1lbnUsCisgICAg ICAgIDAsIC8vIHNob3dDb250ZXh0TWVudQorICAgICAgICAwLCAvLyBoaWRlQ29udGV4dE1lbnUK KyAgICB9OworCisgICAgV0tQYWdlU2V0UGFnZUNvbnRleHRNZW51Q2xpZW50KHRvQVBJKGluc3Bl Y3RvclBhZ2UpLCAmY29udGV4dE1lbnVDbGllbnQuYmFzZSk7CisKICAgICByZXR1cm4gaW5zcGVj dG9yUGFnZTsKIH0KIAo=