147160 2015-07-21 13:08:29 -0700 Add newTarget accessor to JS constructor written in C++ 2015-07-21 17:31:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=146926 P2 Normal --- 1 ysuzuki ysuzuki benjamin commit-queue darin fpizlo ggaren saam oldest_to_newest 1111024 0 ysuzuki 2015-07-21 13:08:29 -0700 Add newTarget accessor to JS constructor written in C++ 1111041 1 257199 ysuzuki 2015-07-21 13:31:32 -0700 Created attachment 257199 Patch 1111070 2 ysuzuki 2015-07-21 14:50:25 -0700 This is necessary for https://bugs.webkit.org/show_bug.cgi?id=146926 1111098 3 257199 ggaren 2015-07-21 15:54:40 -0700 Comment on attachment 257199 Patch r=me 1111141 4 257199 commit-queue 2015-07-21 17:30:58 -0700 Comment on attachment 257199 Patch Clearing flags on attachment: 257199 Committed r187142: <http://trac.webkit.org/changeset/187142> 1111142 5 commit-queue 2015-07-21 17:31:03 -0700 All reviewed patches have been landed. Closing bug. 257199 2015-07-21 13:31:32 -0700 2015-07-21 17:30:58 -0700 Patch bug-147160-20150721133019.patch text/plain 6933 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OTlkZDA0ZWE4NjgwM2Q0MTRmZjY0NjQ2ZGI3MTQ4NzgwODViNDMxLi42MDY3MGVjZDIzODM4ZTAx MDhkYWViYWI3ODBhZjZlYzY1Y2ZmNzJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMCBAQAorMjAxNS0wNy0yMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBBZGQgbmV3VGFyZ2V0IGFjY2Vzc29yIHRvIEpTIGNvbnN0cnVjdG9y IHdyaXR0ZW4gaW4gQysrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDcxNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYEV4ZWNTdGF0ZSNuZXdUYXJnZXQoKWAgd2hpY2ggcmV0 dXJucyBgbmV3LnRhcmdldGAgZGVmaW5lZCBpbiBFQ01BMjYyIDZ0aC4KKyAgICAgICAgSXQgZW5h YmxlcyBzb21lIEMrKyBjb25zdHJ1Y3RvcnMgKGxpa2UgSW50bC5YWFggY29uc3RydWN0b3JzKSB0 byBsZXZlcmFnZSB0aGlzIHRvIGNvbXBsZXRlCisgICAgICAgIGl0cyBpbXBsZW1lbnRhdGlvbi4K KworICAgICAgICBXaGVuIHRoZSBjb25zdHJ1Y3RvciBpcyBjYWxsZWQsIHx0aGlzfCBpbiB0aGUg YXJndW1lbnRzIGlzIHVzZWQgZm9yIHN0b3JpbmcgbmV3LnRhcmdldCBpbnN0ZWFkLgorICAgICAg ICBTbyBieSBhZGRpbmcgdGhlIGFjY2Vzc29yIGZvciB8dGhpc3wsIEpTIGNvbnN0cnVjdG9yIHdy aXR0ZW4gaW4gQysrIGNhbiBhY2Nlc3MgbmV3LnRhcmdldC4KKworICAgICAgICBBbmQgYXQgdGhl IHNhbWUgdGltZSwgdGhpcyBwYXRjaCBleHRlbmRzIHRoZSBleGlzdGluZyBgY29uc3RydWN0YCB0 byBhY2NlcHQgbmV3LnRhcmdldCB2YWx1ZS4KKyAgICAgICAgSXQgaXMgY29ycmVzcG9uZGluZyB0 byB0aGUgc3BlYydzIENvbnN0cnVjdCBhYnN0cmFjdCBvcGVyYXRpb24uCisKKyAgICAgICAgKiBp bnRlcnByZXRlci9DYWxsRnJhbWUuaDoKKyAgICAgICAgKEpTQzo6RXhlY1N0YXRlOjpuZXdUYXJn ZXQpOgorICAgICAgICAqIGludGVycHJldGVyL0ludGVycHJldGVyLmNwcDoKKyAgICAgICAgKEpT Qzo6SW50ZXJwcmV0ZXI6OmV4ZWN1dGVDb25zdHJ1Y3QpOgorICAgICAgICAqIGludGVycHJldGVy L0ludGVycHJldGVyLmg6CisgICAgICAgICogcnVudGltZS9Db25zdHJ1Y3REYXRhLmNwcDoKKyAg ICAgICAgKEpTQzo6Y29uc3RydWN0KToKKyAgICAgICAgKiBydW50aW1lL0NvbnN0cnVjdERhdGEu aDoKKyAgICAgICAgKEpTQzo6Y29uc3RydWN0KToKKwogMjAxNS0wNy0yMSAgS2VpdGggTWlsbGVy ICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgdGhl IG5ldy50YXJnZXQgc3ludGF4LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL0NhbGxGcmFtZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L0NhbGxGcmFtZS5oCmluZGV4IDgwNmNjZWFkNmZiMzNmNDRlOGIzMzM4ODIzYzRlYTNiMmJmYjZm ZDQuLmFmYThkM2NhNzE1OTE0ZDEwZmVmNmZmYjEwNTJhMjUzYTY4YzY5Y2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmgKQEAgLTI1MSw2ICsyNTEs MTAgQEAgbmFtZXNwYWNlIEpTQyAgewogICAgICAgICBKU1ZhbHVlIHRoaXNWYWx1ZSgpIHsgcmV0 dXJuIHRoaXNbdGhpc0FyZ3VtZW50T2Zmc2V0KCldLmpzVmFsdWUoKTsgfQogICAgICAgICB2b2lk IHNldFRoaXNWYWx1ZShKU1ZhbHVlIHZhbHVlKSB7IHRoaXNbdGhpc0FyZ3VtZW50T2Zmc2V0KCld ID0gdmFsdWU7IH0KIAorICAgICAgICAvLyBVbmRlciB0aGUgY29uc3RydWN0b3IgaW1wbGVtZW50 ZWQgaW4gQysrLCB0aGlzVmFsdWUgaG9sZHMgdGhlIG5ld1RhcmdldCBpbnN0ZWFkIG9mIHRoZSBh dXRvbWF0aWNhbGx5IGNvbnN0cnVjdGVkIHZhbHVlLgorICAgICAgICAvLyBUaGUgcmVzdWx0IG9m IHRoaXMgZnVuY3Rpb24gaXMgb25seSBlZmZlY3RpdmUgdW5kZXIgdGhlICJjb25zdHJ1Y3QiIGNv bnRleHQuCisgICAgICAgIEpTVmFsdWUgbmV3VGFyZ2V0KCkgeyByZXR1cm4gdGhpc1ZhbHVlKCk7 IH0KKwogICAgICAgICBKU1ZhbHVlIGFyZ3VtZW50QWZ0ZXJDYXB0dXJlKHNpemVfdCBhcmd1bWVu dCk7CiAKICAgICAgICAgc3RhdGljIGludCBvZmZzZXRGb3Ioc2l6ZV90IGFyZ3VtZW50Q291bnRJ bmNsdWRpbmdUaGlzKSB7IHJldHVybiBhcmd1bWVudENvdW50SW5jbHVkaW5nVGhpcyArIEpTU3Rh Y2s6OlRoaXNBcmd1bWVudCAtIDE7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50 ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCmluZGV4IDY4NzE0MGU2OTVjOTcwNjU1OTk2ZDllODg2 ZjEyNDFhNjIzZjIxZjMuLmJmOTRiOTBlYjkzYjliZjYzMDZlZTI1ZGViZTIwNmExYzkxODBkYmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRl ci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVy LmNwcApAQCAtOTc2LDcgKzk3Niw3IEBAIEpTVmFsdWUgSW50ZXJwcmV0ZXI6OmV4ZWN1dGVDYWxs KENhbGxGcmFtZSogY2FsbEZyYW1lLCBKU09iamVjdCogZnVuY3Rpb24sIENhbGxUCiAgICAgcmV0 dXJuIGNoZWNrZWRSZXR1cm4ocmVzdWx0KTsKIH0KIAotSlNPYmplY3QqIEludGVycHJldGVyOjpl eGVjdXRlQ29uc3RydWN0KENhbGxGcmFtZSogY2FsbEZyYW1lLCBKU09iamVjdCogY29uc3RydWN0 b3IsIENvbnN0cnVjdFR5cGUgY29uc3RydWN0VHlwZSwgY29uc3QgQ29uc3RydWN0RGF0YSYgY29u c3RydWN0RGF0YSwgY29uc3QgQXJnTGlzdCYgYXJncykKK0pTT2JqZWN0KiBJbnRlcnByZXRlcjo6 ZXhlY3V0ZUNvbnN0cnVjdChDYWxsRnJhbWUqIGNhbGxGcmFtZSwgSlNPYmplY3QqIGNvbnN0cnVj dG9yLCBDb25zdHJ1Y3RUeXBlIGNvbnN0cnVjdFR5cGUsIGNvbnN0IENvbnN0cnVjdERhdGEmIGNv bnN0cnVjdERhdGEsIGNvbnN0IEFyZ0xpc3QmIGFyZ3MsIEpTVmFsdWUgbmV3VGFyZ2V0KQogewog ICAgIFZNJiB2bSA9IGNhbGxGcmFtZS0+dm0oKTsKICAgICBBU1NFUlQoIWNhbGxGcmFtZS0+aGFk RXhjZXB0aW9uKCkpOwpAQCAtMTAyMSw3ICsxMDIxLDcgQEAgSlNPYmplY3QqIEludGVycHJldGVy OjpleGVjdXRlQ29uc3RydWN0KENhbGxGcmFtZSogY2FsbEZyYW1lLCBKU09iamVjdCogY29uc3Ry dWMKICAgICAgICAgcmV0dXJuIHRocm93VGVybWluYXRlZEV4ZWN1dGlvbkV4Y2VwdGlvbihjYWxs RnJhbWUpOwogCiAgICAgUHJvdG9DYWxsRnJhbWUgcHJvdG9DYWxsRnJhbWU7Ci0gICAgcHJvdG9D YWxsRnJhbWUuaW5pdChuZXdDb2RlQmxvY2ssIGNvbnN0cnVjdG9yLCBjb25zdHJ1Y3RvciwgYXJn c0NvdW50LCBhcmdzLmRhdGEoKSk7CisgICAgcHJvdG9DYWxsRnJhbWUuaW5pdChuZXdDb2RlQmxv Y2ssIGNvbnN0cnVjdG9yLCBuZXdUYXJnZXQsIGFyZ3NDb3VudCwgYXJncy5kYXRhKCkpOwogCiAg ICAgaWYgKExlZ2FjeVByb2ZpbGVyKiBwcm9maWxlciA9IHZtLmVuYWJsZWRQcm9maWxlcigpKQog ICAgICAgICBwcm9maWxlci0+d2lsbEV4ZWN1dGUoY2FsbEZyYW1lLCBjb25zdHJ1Y3Rvcik7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5oCmluZGV4 IGVmNGVjMGQ2NmMwNGRkMjhmYzlkYzA1NDQ0ODgzMGM3NjkwZjUyNDMuLmFkOWRmNmZjNzFkOGRk OTAwNWMxYTNjMTJlZWMwNDJiMzgxOTg0NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5oCkBAIC0yMDgsNyArMjA4LDcgQEAgbmFtZXNwYWNl IEpTQyB7CiAKICAgICAgICAgSlNWYWx1ZSBleGVjdXRlKFByb2dyYW1FeGVjdXRhYmxlKiwgQ2Fs bEZyYW1lKiwgSlNPYmplY3QqIHRoaXNPYmopOwogICAgICAgICBKU1ZhbHVlIGV4ZWN1dGVDYWxs KENhbGxGcmFtZSosIEpTT2JqZWN0KiBmdW5jdGlvbiwgQ2FsbFR5cGUsIGNvbnN0IENhbGxEYXRh JiwgSlNWYWx1ZSB0aGlzVmFsdWUsIGNvbnN0IEFyZ0xpc3QmKTsKLSAgICAgICAgSlNPYmplY3Qq IGV4ZWN1dGVDb25zdHJ1Y3QoQ2FsbEZyYW1lKiwgSlNPYmplY3QqIGZ1bmN0aW9uLCBDb25zdHJ1 Y3RUeXBlLCBjb25zdCBDb25zdHJ1Y3REYXRhJiwgY29uc3QgQXJnTGlzdCYpOworICAgICAgICBK U09iamVjdCogZXhlY3V0ZUNvbnN0cnVjdChDYWxsRnJhbWUqLCBKU09iamVjdCogZnVuY3Rpb24s IENvbnN0cnVjdFR5cGUsIGNvbnN0IENvbnN0cnVjdERhdGEmLCBjb25zdCBBcmdMaXN0JiwgSlNW YWx1ZSBuZXdUYXJnZXQpOwogICAgICAgICBKU1ZhbHVlIGV4ZWN1dGUoRXZhbEV4ZWN1dGFibGUq LCBDYWxsRnJhbWUqLCBKU1ZhbHVlIHRoaXNWYWx1ZSwgSlNTY29wZSopOwogCiAgICAgICAgIHZv aWQgZ2V0QXJndW1lbnRzRGF0YShDYWxsRnJhbWUqLCBKU0Z1bmN0aW9uKiYsIHB0cmRpZmZfdCYg Zmlyc3RQYXJhbWV0ZXJJbmRleCwgUmVnaXN0ZXIqJiBhcmd2LCBpbnQmIGFyZ2MpOwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uc3RydWN0RGF0YS5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zdHJ1Y3REYXRhLmNwcAppbmRleCA3NDQ1 Y2M2OTg0M2IzNWQzMWRiYjdjYWI5ZDk1ZmRlYTI2Mzg5YzVmLi42MDEwZTYzNTZjYWEzZWQ2M2Yy NzNiYjY5ZjFlZWM3OGZmMGRmNzViIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9Db25zdHJ1Y3REYXRhLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9Db25zdHJ1Y3REYXRhLmNwcApAQCAtMzQsMTAgKzM0LDEwIEBACiAKIG5hbWVzcGFjZSBK U0MgewogCi1KU09iamVjdCogY29uc3RydWN0KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSBjb25z dHJ1Y3Rvck9iamVjdCwgQ29uc3RydWN0VHlwZSBjb25zdHJ1Y3RUeXBlLCBjb25zdCBDb25zdHJ1 Y3REYXRhJiBjb25zdHJ1Y3REYXRhLCBjb25zdCBBcmdMaXN0JiBhcmdzKQorSlNPYmplY3QqIGNv bnN0cnVjdChFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgY29uc3RydWN0b3JPYmplY3QsIENvbnN0 cnVjdFR5cGUgY29uc3RydWN0VHlwZSwgY29uc3QgQ29uc3RydWN0RGF0YSYgY29uc3RydWN0RGF0 YSwgY29uc3QgQXJnTGlzdCYgYXJncywgSlNWYWx1ZSBuZXdUYXJnZXQpCiB7CiAgICAgQVNTRVJU KGNvbnN0cnVjdFR5cGUgPT0gQ29uc3RydWN0VHlwZUpTIHx8IGNvbnN0cnVjdFR5cGUgPT0gQ29u c3RydWN0VHlwZUhvc3QpOwotICAgIHJldHVybiBleGVjLT5pbnRlcnByZXRlcigpLT5leGVjdXRl Q29uc3RydWN0KGV4ZWMsIGFzT2JqZWN0KGNvbnN0cnVjdG9yT2JqZWN0KSwgY29uc3RydWN0VHlw ZSwgY29uc3RydWN0RGF0YSwgYXJncyk7CisgICAgcmV0dXJuIGV4ZWMtPmludGVycHJldGVyKCkt PmV4ZWN1dGVDb25zdHJ1Y3QoZXhlYywgYXNPYmplY3QoY29uc3RydWN0b3JPYmplY3QpLCBjb25z dHJ1Y3RUeXBlLCBjb25zdHJ1Y3REYXRhLCBhcmdzLCBuZXdUYXJnZXQpOwogfQogCiB9IC8vIG5h bWVzcGFjZSBKU0MKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Nv bnN0cnVjdERhdGEuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbnN0cnVjdERh dGEuaAppbmRleCA4ZDRlZDhmMjhjN2UxZWNkODc5Y2JjMGYyZjRmZWZkMTRjNGMxNTU4Li4xN2Ux YTVkYWVhMWFhMWIzYTQ0NjczZmNjZmFmN2QwOWU4ZmU3ZjdhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zdHJ1Y3REYXRhLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQ29uc3RydWN0RGF0YS5oCkBAIC01Niw3ICs1NiwxMiBAQCB1bmlv biBDb25zdHJ1Y3REYXRhIHsKICAgICB9IGpzOwogfTsKIAotSlNfRVhQT1JUX1BSSVZBVEUgSlNP YmplY3QqIGNvbnN0cnVjdChFeGVjU3RhdGUqLCBKU1ZhbHVlIGNvbnN0cnVjdG9yLCBDb25zdHJ1 Y3RUeXBlLCBjb25zdCBDb25zdHJ1Y3REYXRhJiwgY29uc3QgQXJnTGlzdCYpOworSlNfRVhQT1JU X1BSSVZBVEUgSlNPYmplY3QqIGNvbnN0cnVjdChFeGVjU3RhdGUqLCBKU1ZhbHVlIGNvbnN0cnVj dG9yLCBDb25zdHJ1Y3RUeXBlLCBjb25zdCBDb25zdHJ1Y3REYXRhJiwgY29uc3QgQXJnTGlzdCYs IEpTVmFsdWUgbmV3VGFyZ2V0KTsKKworQUxXQVlTX0lOTElORSBKU09iamVjdCogY29uc3RydWN0 KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSBjb25zdHJ1Y3Rvck9iamVjdCwgQ29uc3RydWN0VHlw ZSBjb25zdHJ1Y3RUeXBlLCBjb25zdCBDb25zdHJ1Y3REYXRhJiBjb25zdHJ1Y3REYXRhLCBjb25z dCBBcmdMaXN0JiBhcmdzKQoreworICAgIHJldHVybiBjb25zdHJ1Y3QoZXhlYywgY29uc3RydWN0 b3JPYmplY3QsIGNvbnN0cnVjdFR5cGUsIGNvbnN0cnVjdERhdGEsIGFyZ3MsIGNvbnN0cnVjdG9y T2JqZWN0KTsKK30KIAogfSAvLyBuYW1lc3BhY2UgSlNDCiAK