147141 2015-07-20 23:21:41 -0700 [Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build with ENABLE_TOUCH_EVENTS=ON 2015-07-21 16:16:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho commit-queue oldest_to_newest 1110904 0 sungmann.cho 2015-07-20 23:21:41 -0700 Build ToT with ENABLE_TOUCH_EVENTS=ON on Windows breaks at: WebView.cpp ..\..\win\WebView.cpp(2835): error C2259: 'WebChromeClient' : cannot instantiate abstract class due to following members: 'void WebCore::ChromeClient::needTouchEvents(bool)' : is abstract D:\FOSS\WebKit\WebKitBuild\Debug_WinCairo\Include\WebCore/ChromeClient.h(371) : see declaration of 'WebCore::ChromeClient::needTouchEvents' WebChromeClient needs needTouchEvents(). 1110906 1 257164 sungmann.cho 2015-07-20 23:25:27 -0700 Created attachment 257164 Patch 1111104 2 257164 commit-queue 2015-07-21 16:16:02 -0700 Comment on attachment 257164 Patch Clearing flags on attachment: 257164 Committed r187132: <http://trac.webkit.org/changeset/187132> 1111105 3 commit-queue 2015-07-21 16:16:05 -0700 All reviewed patches have been landed. Closing bug. 257164 2015-07-20 23:25:27 -0700 2015-07-21 16:16:02 -0700 Patch bug-147141-20150721152413.patch text/plain 1364 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggM2JmNjcyMzVm YmQwM2FlMTQ5M2NjZTExOTJhMjI0NDJlMGM1NGI0MS4uYWI0YjhkMDdhODA2M2EyOGE2NWJlNzNi OTg2MTg0MGFhNWU1ZTJiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1 LTA3LTIwICBTdW5nbWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAg ICAgICBbV2luXSBBZGQgbmVlZFRvdWNoRXZlbnRzKCkgc3R1YiB0byBXZWJDaHJvbWVDbGllbnQu aCBmb3IgYSBzdWNjZXNzZnVsIGJ1aWxkIHdpdGggRU5BQkxFX1RPVUNIX0VWRU5UUz1PTgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MTQxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9XZWJDaHJvbWVDbGllbnQuaDoKKwogMjAxNS0wNy0xOSAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxODcwMDIpOiBCcm9rZSB0 aGUgV2luZG93cyBidWlsZDogUmVkdWNlIFBhc3NSZWZQdHIgaW4gV2ViS2l0MiAtIDMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5o IGIvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmgKaW5k ZXggZjYzYWNlZmFkMzFjNzAyNjk3ODNjMDU3ZDk0MmJhZjFiY2FjYmVjMy4uMTAzMmY4OWNmM2Rk MjVmOTVjOWI3YzFmYWUxMGE4YzUwODY1ODNiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93 aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC93 aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmgKQEAgLTE2MCw2ICsxNjAsMTAgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBleGl0RnVsbFNjcmVlbkZvckVsZW1lbnQoV2ViQ29y ZTo6RWxlbWVudCopOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQorICAgIHZp cnR1YWwgdm9pZCBuZWVkVG91Y2hFdmVudHMoYm9vbCkgb3ZlcnJpZGUgeyB9CisjZW5kaWYKKwog ICAgIHZpcnR1YWwgdm9pZCB3aGVlbEV2ZW50SGFuZGxlcnNDaGFuZ2VkKGJvb2wpIG92ZXJyaWRl IHsgfQogCiAgICAgV2ViVmlldyogd2ViVmlldygpIHsgcmV0dXJuIG1fd2ViVmlldzsgfQo=