147139 2015-07-20 19:54:03 -0700 API::Session should clean up its storage in the network process when destroyed. 2015-07-21 12:55:47 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kling kling andersca ap commit-queue sam oldest_to_newest 1110875 0 kling 2015-07-20 19:54:03 -0700 <rdar://problem/21838764> 1110876 1 257157 kling 2015-07-20 20:02:18 -0700 Created attachment 257157 Proposed patch 1110878 2 cdumez 2015-07-20 20:03:54 -0700 *** Bug 147138 has been marked as a duplicate of this bug. *** 1110880 3 257157 ap 2015-07-20 20:17:12 -0700 Comment on attachment 257157 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=257157&action=review > Source/WebKit2/ChangeLog:3 > + API::Session should clean up its storage in the network process when destroyed. Shouldn't it do the same for WebContent processes? 1110882 4 257157 kling 2015-07-20 20:27:52 -0700 Comment on attachment 257157 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=257157&action=review >> Source/WebKit2/ChangeLog:3 >> + API::Session should clean up its storage in the network process when destroyed. > > Shouldn't it do the same for WebContent processes? Hm, for the WebContent processes I only see calls that send: Messages::WebProcess::EnsurePrivateBrowsingSession(SessionID::legacyPrivateSessionID()) So they always use the same SessionID, never anything created by WKSessionCreate() 1110883 5 257157 ap 2015-07-20 20:39:08 -0700 Comment on attachment 257157 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=257157&action=review >>> Source/WebKit2/ChangeLog:3 >>> + API::Session should clean up its storage in the network process when destroyed. >> >> Shouldn't it do the same for WebContent processes? > > Hm, for the WebContent processes I only see calls that send: > > Messages::WebProcess::EnsurePrivateBrowsingSession(SessionID::legacyPrivateSessionID()) > > So they always use the same SessionID, never anything created by WKSessionCreate() It looks like WebContent processes get the session ID using WebPage::SetSessionID messages. I don't know why it's done differently for these processes now, would consult with Anders. 1110960 6 andersca 2015-07-21 10:36:46 -0700 (In reply to comment #5) > Comment on attachment 257157 [details] > It looks like WebContent processes get the session ID using > WebPage::SetSessionID messages. I don't know why it's done differently for > these processes now, would consult with Anders. I think it's less important for the web processes since they have a much shorter lifespan (usually). Going forward, WKSessionRef should go away in favor of WebsiteDataStore, and it should be impossible to change sessions after the fact (since we haven't supported that feature since Mountain Lion). 1110992 7 257157 kling 2015-07-21 12:01:58 -0700 Comment on attachment 257157 Proposed patch Thanks for the comment, Anders. cq+'ing. 1111013 8 257157 commit-queue 2015-07-21 12:55:42 -0700 Comment on attachment 257157 Proposed patch Clearing flags on attachment: 257157 Committed r187115: <http://trac.webkit.org/changeset/187115> 1111014 9 commit-queue 2015-07-21 12:55:47 -0700 All reviewed patches have been landed. Closing bug. 257157 2015-07-20 20:02:18 -0700 2015-07-21 12:55:42 -0700 Proposed patch bug-147139.diff text/plain 1685 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyN2U1ODEzLi5lZjUxNDRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTUtMDctMjAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEFQSTo6U2Vzc2lvbiBzaG91bGQgY2xlYW4gdXAgaXRzIHN0b3JhZ2UgaW4gdGhlIG5ldHdv cmsgcHJvY2VzcyB3aGVuIGRlc3Ryb3llZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9i LzE0NzEzOT4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxODM4NzY0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUgflNlc3Npb24oKSBzZW5k IGEgRGVzdHJveVByaXZhdGVCcm93c2luZ1Nlc3Npb24gbWVzc2FnZSB0byBhbGwgbmV0d29ya2lu ZyBwcm9jZXNzZXMKKyAgICAgICAgZm9yIGVwaGVtZXJhbCBzZXNzaW9ucy4gVGhpcyBwbHVncyBh IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiBsZWFrIHRoYXQgY291bGQgcmV0YWluIGEgbGFyZ2UKKyAg ICAgICAgQ0ZOZXR3b3JrIG9iamVjdCBncmFwaC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv QVBJU2Vzc2lvbi5jcHA6CisgICAgICAgIChBUEk6OlNlc3Npb246On5TZXNzaW9uKToKKwogMjAx NS0wNy0yMCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW1NlY2NvbXBdIFNob3VsZCBiZSBlYXNpZXIgdG8gZGVidWcgYmxvY2tlZCBzeXNjYWxs cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElTZXNzaW9uLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQVBJU2Vzc2lvbi5jcHAKaW5kZXggYzY3 NGQyMS4uYTI5NmU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9B UElTZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0FQSVNlc3Np b24uY3BwCkBAIC0yOCw2ICsyOCwxMSBAQAogCiAjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KIAor I2lmIEVOQUJMRShORVRXT1JLX1BST0NFU1MpCisjaW5jbHVkZSAiTmV0d29ya1Byb2Nlc3NNZXNz YWdlcy5oIgorI2luY2x1ZGUgIldlYlByb2Nlc3NQb29sLmgiCisjZW5kaWYKKwogbmFtZXNwYWNl IEFQSSB7CiAKIHN0YXRpYyB1aW50NjRfdCBnZW5lcmF0ZUlEKCkKQEAgLTc1LDYgKzgwLDEyIEBA IFdlYkNvcmU6OlNlc3Npb25JRCBTZXNzaW9uOjpnZXRJRCgpIGNvbnN0CiAKIFNlc3Npb246On5T ZXNzaW9uKCkKIHsKKyNpZiBFTkFCTEUoTkVUV09SS19QUk9DRVNTKQorICAgIGlmIChtX3Nlc3Np b25JRC5pc0VwaGVtZXJhbCgpKSB7CisgICAgICAgIGZvciAoYXV0byYgcHJvY2Vzc1Bvb2wgOiBX ZWJLaXQ6OldlYlByb2Nlc3NQb29sOjphbGxQcm9jZXNzUG9vbHMoKSkKKyAgICAgICAgICAgIHBy b2Nlc3NQb29sLT5zZW5kVG9OZXR3b3JraW5nUHJvY2VzcyhNZXNzYWdlczo6TmV0d29ya1Byb2Nl c3M6OkRlc3Ryb3lQcml2YXRlQnJvd3NpbmdTZXNzaW9uKG1fc2Vzc2lvbklEKSk7CisgICAgfQor I2VuZGlmCiB9CiAKIH0gLy8gbmFtZXNwYWNlIEFQSQo=