147115 2015-07-20 11:41:53 -0700 Fix the !ENABLE(DETAILS_ELEMENT) build after r186598 2015-07-21 12:23:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146549 1 ossy ossy aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario ossy samuel_white oldest_to_newest 1110689 0 ossy 2015-07-20 11:41:53 -0700 http://trac.webkit.org/changeset/186598 broke the !ENABLE(DETAILS_ELEMENT) build: lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/accessibility/AccessibilityNodeObject.cpp.o):AccessibilityNodeObject.cpp:function WebCore::AccessibilityNodeObject::setIsExpanded(bool): error: undefined reference to 'WebCore::HTMLDetailsElement::toggleOpen()' collect2: error: ld returned 1 exit status The problem is that WebCore::HTMLDetailsElement::toggleOpen() is defined inside ENABLE(DETAILS_ELEMENT), but used unconditionally in AccessibilityNodeObject.cpp. 1110690 1 257111 ossy 2015-07-20 11:43:27 -0700 Created attachment 257111 Patch 1110969 2 ossy 2015-07-21 11:05:41 -0700 ping? 1110998 3 257111 commit-queue 2015-07-21 12:23:17 -0700 Comment on attachment 257111 Patch Clearing flags on attachment: 257111 Committed r187112: <http://trac.webkit.org/changeset/187112> 1110999 4 commit-queue 2015-07-21 12:23:21 -0700 All reviewed patches have been landed. Closing bug. 257111 2015-07-20 11:43:27 -0700 2015-07-21 12:23:17 -0700 Patch bug-147115-20150720114213.patch text/plain 1545 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRiOTE1NzVjOGY0YTJl MDI2YTllNjc2NjU1OGQyMWIwYjUyOGVlMC4uNjQwYmFlODY5YzA0Nzc3N2EzMWFmNzExMGRhZjRh MmQzMjZlZmRjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA3LTIwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKERFVEFJTFNfRUxFTUVOVCkgYnVpbGQgYWZ0ZXIgcjE4NjU5OAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MTE1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlOb2RlT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlOb2Rl T2JqZWN0OjpzZXRJc0V4cGFuZGVkKToKKwogMjAxNS0wNy0yMCAgQWxleCBDaHJpc3RlbnNlbiAg PGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlc3VycmVjdCBDTWFrZSBidWls ZCBvbiBXaW5kb3dzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAppbmRleCA1NzBjNDg1NTBhZDEzMDQ2MGE2ZDE4 OWI5MWE2OWY5MDRiYmZjZjRlLi43NDc4MjFmM2E5YTIwZjQxYTVjMjE2ZGYyOTRiMTI4MGQwYzBi OWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlOb2RlT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlOb2RlT2JqZWN0LmNwcApAQCAtMTYxMiwxMSArMTYxMiwxNSBAQCB1bnNpZ25lZCBB Y2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6aGllcmFyY2hpY2FsTGV2ZWwoKSBjb25zdAogCiB2b2lk IEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjpzZXRJc0V4cGFuZGVkKGJvb2wgZXhwYW5kKQogewor I2lmIEVOQUJMRShERVRBSUxTX0VMRU1FTlQpCiAgICAgaWYgKGlzPEhUTUxEZXRhaWxzRWxlbWVu dD4obm9kZSgpKSkgewogICAgICAgICBhdXRvJiBkZXRhaWxzID0gZG93bmNhc3Q8SFRNTERldGFp bHNFbGVtZW50Pigqbm9kZSgpKTsKICAgICAgICAgaWYgKGV4cGFuZCAhPSBkZXRhaWxzLmlzT3Bl bigpKQogICAgICAgICAgICAgZGV0YWlscy50b2dnbGVPcGVuKCk7CiAgICAgfQorI2Vsc2UKKyAg ICBVTlVTRURfUEFSQU0oZXhwYW5kKTsKKyNlbmRpZgogfQogICAgIAogLy8gV2hlbiBidWlsZGlu ZyB0aGUgdGV4dFVuZGVyRWxlbWVudCBmb3IgYW4gb2JqZWN0LCBkZXRlcm1pbmUgd2hldGhlciBv ciBub3QK