147104 2015-07-20 02:57:04 -0700 Remove RenderTheme::shouldShowPlaceholderWhenFocused() 2015-07-20 22:35:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned darin gustavo mrobinson rniwa oldest_to_newest 1110588 0 cgarcia 2015-07-20 02:57:04 -0700 GTK+ is the only port that returns false in shouldShowPlaceholderWhenFocused(). That's inconsistent with all other browsers that show the placeholder text even for focused entries in all platforms. We should change the GTK+ port behaviour, but that would leave all implementations of shouldShowPlaceholderWhenFocused returning true, so let's just remove it. 1110589 1 257084 cgarcia 2015-07-20 02:59:43 -0700 Created attachment 257084 Patch This makes the GTK+ port consistent with all other browsers, but inconsistent with GTK+ itself, I'll write a patch for GTK+. 1110590 2 cgarcia 2015-07-20 03:07:39 -0700 See https://bugzilla.gnome.org/show_bug.cgi?id=752622 1110896 3 cgarcia 2015-07-20 22:35:18 -0700 Committed r187095: <http://trac.webkit.org/changeset/187095> 257084 2015-07-20 02:59:43 -0700 2015-07-20 08:06:35 -0700 Patch wk-placeholder.diff text/plain 7108 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3N2NiN2UyLi40Y2YzZGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzYg QEAKIDIwMTUtMDctMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJlbW92ZSBSZW5kZXJUaGVtZTo6c2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hl bkZvY3VzZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ3MTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgR1RLKyBpcyB0aGUgb25seSBwb3J0IHRoYXQgcmV0dXJucyBmYWxzZSBpbgorICAgICAgICBz aG91bGRTaG93UGxhY2Vob2xkZXJXaGVuRm9jdXNlZCgpLiBUaGF0J3MgaW5jb25zaXN0ZW50IHdp dGggYWxsCisgICAgICAgIG90aGVyIGJyb3dzZXJzIHRoYXQgc2hvdyB0aGUgcGxhY2Vob2xkZXIg dGV4dCBldmVuIGZvciBmb2N1c2VkCisgICAgICAgIGVudHJpZXMgaW4gYWxsIHBsYXRmb3Jtcy4g V2Ugc2hvdWxkIGNoYW5nZSB0aGUgR1RLKyBwb3J0CisgICAgICAgIGJlaGF2aW91ciwgYnV0IHRo YXQgd291bGQgbGVhdmUgYWxsIGltcGxlbWVudGF0aW9ucyBvZgorICAgICAgICBzaG91bGRTaG93 UGxhY2Vob2xkZXJXaGVuRm9jdXNlZCByZXR1cm5pbmcgdHJ1ZSwgc28gbGV0J3MganVzdAorICAg ICAgICByZW1vdmUgaXQuCisKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojpw bGFjZWhvbGRlclNob3VsZEJlVmlzaWJsZSk6CisgICAgICAgIERvIG5vdCBjb25zaWRlciB3aGV0 aGVyIHRoZSBlbnRyeSBpcyBmb2N1c2VkIG9yIG5vdC4KKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWUuaDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lOjpzaG91bGRTaG93UGxhY2Vob2xkZXJXaGVuRm9j dXNlZCk6IERlbGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmg6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVGhlbWVJT1M6OnNob3VsZFNob3dQbGFjZWhvbGRlcldoZW5Gb2N1c2VkKTogRGVsZXRl ZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaDoKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyVGhlbWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZU1h Yzo6c2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQpOiBEZWxldGVkLgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJUaGVtZVNhZmFyaS5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGhlbWVTYWZhcmk6OnNob3VsZFNob3dQbGFjZWhvbGRlcldoZW5Gb2N1c2VkKTogRGVsZXRlZC4K KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaDoKKworMjAxNS0wNy0yMCAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10g UGFzcyBhIEdzdEluc3RhbGxQbHVnaW5zQ29udGV4dCB0byBnc3RfaW5zdGFsbF9wbHVnaW5zX2Fz eW5jCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcx MDMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1Db250cm9s RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVt ZW50LmNwcAppbmRleCA3N2M3MzEzLi41MzRhMGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcApAQCAtMTUwLDEwICsxNTAsNyBA QCBib29sIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpwbGFjZWhvbGRlclNob3VsZEJlVmlz aWJsZSgpIGNvbnN0CiB7CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBpcyB1c2VkIGJ5IHRoZSBzdHls ZSByZXNvbHZlciB0byBtYXRjaCB0aGUgOnBsYWNlaG9sZGVyLXNob3duIHBzZXVkbyBjbGFzcy4K ICAgICAvLyBTaW5jZSBpdCBpcyB1c2VkIGZvciBzdHlsaW5nLCBpdCBtdXN0IG5vdCB1c2UgYW55 IHZhbHVlIGRlcGVuZGluZyBvbiB0aGUgc3R5bGUuCi0gICAgcmV0dXJuIHN1cHBvcnRzUGxhY2Vo b2xkZXIoKQotICAgICAgICAmJiBpc0VtcHR5VmFsdWUoKQotICAgICAgICAmJiAhaXNQbGFjZWhv bGRlckVtcHR5KCkKLSAgICAgICAgJiYgKGRvY3VtZW50KCkuZm9jdXNlZEVsZW1lbnQoKSAhPSB0 aGlzIHx8IChkb2N1bWVudCgpLnBhZ2UoKS0+dGhlbWUoKS5zaG91bGRTaG93UGxhY2Vob2xkZXJX aGVuRm9jdXNlZCgpKSk7CisgICAgcmV0dXJuIHN1cHBvcnRzUGxhY2Vob2xkZXIoKSAmJiBpc0Vt cHR5VmFsdWUoKSAmJiAhaXNQbGFjZWhvbGRlckVtcHR5KCk7CiB9CiAKIHZvaWQgSFRNTFRleHRG b3JtQ29udHJvbEVsZW1lbnQ6OnVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eSgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCmluZGV4IDcwNjM2MjYuLjRm MjY3NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVt ZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5o CkBAIC0xNzUsNyArMTc1LDYgQEAgcHVibGljOgogI2lmIEVOQUJMRShWSURFT19UUkFDSykKICAg ICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNDbG9zZWRDYXB0aW9uaW5nKCkgY29uc3Qgb3ZlcnJpZGUg eyByZXR1cm4gdHJ1ZTsgfQogI2VuZGlmCi0gICAgdmlydHVhbCBib29sIHNob3VsZFNob3dQbGFj ZWhvbGRlcldoZW5Gb2N1c2VkKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gdHJ1ZTsgfQogCiAg ICAgdm9pZCBzZXRUaGVtZVBhdGgoY29uc3QgU3RyaW5nJik7CiAgICAgU3RyaW5nIHRoZW1lUGF0 aCgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaAppbmRleCA5MjI0 NmY1Li4wMWNiOGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaApAQCAt MjI4LDcgKzIyOCw2IEBAIHB1YmxpYzoKICAgICB2b2lkIHBhaW50U2xpZGVyVGlja3MoY29uc3Qg UmVuZGVyT2JqZWN0JiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogI2VuZGlm CiAKLSAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQoKSBj b25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRIYXZlU3BpbkJ1 dHRvbihIVE1MSW5wdXRFbGVtZW50JikgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIHNob3VsZEhh dmVDYXBzTG9ja0luZGljYXRvcihIVE1MSW5wdXRFbGVtZW50JikgY29uc3Q7CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmgKaW5kZXggYTQ0Yjc1MC4uZGMwNGUzZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmgKQEAgLTEwMiw3ICsx MDIsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCBDb2xvciBwbGF0Zm9ybVRhcEhpZ2hsaWdo dENvbG9yKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gMHg0RDFBMUExQTsgfQogI2VuZGlmCiAK LSAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQoKSBjb25z dCBvdmVycmlkZTsKICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkSGF2ZVNwaW5CdXR0b24oSFRNTElu cHV0RWxlbWVudCYpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRIYXZl Q2Fwc0xvY2tJbmRpY2F0b3IoSFRNTElucHV0RWxlbWVudCYpIGNvbnN0IG92ZXJyaWRlOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0gYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0KaW5kZXggNTQ0OGY2My4u ZWExMGE4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQpA QCAtMTA3MywxMSArMTA3Myw2IEBAIENvbG9yIFJlbmRlclRoZW1lSU9TOjpwbGF0Zm9ybUluYWN0 aXZlU2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKCkgY29uc3QKICAgICByZXR1cm4gQ29sb3I6OnRy YW5zcGFyZW50OwogfQogCi1ib29sIFJlbmRlclRoZW1lSU9TOjpzaG91bGRTaG93UGxhY2Vob2xk ZXJXaGVuRm9jdXNlZCgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIGJvb2wgUmVu ZGVyVGhlbWVJT1M6OnNob3VsZEhhdmVTcGluQnV0dG9uKEhUTUxJbnB1dEVsZW1lbnQmKSBjb25z dAogewogICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZU1hYy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lTWFjLmgKaW5kZXggZTA1Yjg3YS4uZjg5ZTNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRoZW1lTWFjLmgKQEAgLTE2Miw3ICsxNjIsNiBAQCBwcm90ZWN0ZWQ6CiAgICAg dmlydHVhbCBib29sIHN1cHBvcnRzQ2xvc2VkQ2FwdGlvbmluZygpIGNvbnN0IG92ZXJyaWRlIHsg cmV0dXJuIHRydWU7IH0KICNlbmRpZgogCi0gICAgdmlydHVhbCBib29sIHNob3VsZFNob3dQbGFj ZWhvbGRlcldoZW5Gb2N1c2VkKCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCBib29sIHNo b3VsZEhhdmVDYXBzTG9ja0luZGljYXRvcihIVE1MSW5wdXRFbGVtZW50JikgY29uc3Qgb3ZlcnJp ZGU7CiAKICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRTbmFwc2hvdHRlZFBsdWdpbk92ZXJsYXkoY29u c3QgUmVuZGVyT2JqZWN0JiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpIG92ZXJy aWRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IDA2 ZTIzNWYuLjQ3OTVhYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVN YWMubW0KQEAgLTE5MzYsMTEgKzE5MzYsNiBAQCB2b2lkIFJlbmRlclRoZW1lTWFjOjphZGp1c3RT bGlkZXJUaHVtYlNpemUoUmVuZGVyU3R5bGUmIHN0eWxlLCBFbGVtZW50KikgY29uc3QKICAgICB9 CiB9CiAKLWJvb2wgUmVuZGVyVGhlbWVNYWM6OnNob3VsZFNob3dQbGFjZWhvbGRlcldoZW5Gb2N1 c2VkKCkgY29uc3QKLXsKLSAgICByZXR1cm4gdHJ1ZTsKLX0KLQogYm9vbCBSZW5kZXJUaGVtZU1h Yzo6c2hvdWxkSGF2ZUNhcHNMb2NrSW5kaWNhdG9yKEhUTUxJbnB1dEVsZW1lbnQmIGVsZW1lbnQp IGNvbnN0CiB7CiAgICAgcmV0dXJuIGVsZW1lbnQuaXNQYXNzd29yZEZpZWxkKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVTYWZhcmkuaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVNhZmFyaS5oCmluZGV4IGIyODAwYjguLjYw ZjEyMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVNh ZmFyaS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVNhZmFyaS5o CkBAIC0xNDAsOCArMTQwLDYgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgYm9vbCBwYWludE1l dGVyKGNvbnN0IFJlbmRlck9iamVjdCYsIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJlY3Qm KSBvdmVycmlkZTsKICNlbmRpZgogCi0gICAgdmlydHVhbCBib29sIHNob3VsZFNob3dQbGFjZWhv bGRlcldoZW5Gb2N1c2VkKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQotCiBwcml2YXRlOgogICAg IFJlbmRlclRoZW1lU2FmYXJpKCk7CiAgICAgdmlydHVhbCB+UmVuZGVyVGhlbWVTYWZhcmkoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5oIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmgKaW5kZXggZDE2MmQ4Mi4u NGI2Yjc2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l V2luLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmgKQEAg LTEzNCw4ICsxMzQsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIHBhaW50TWV0ZXIoY29u c3QgUmVuZGVyT2JqZWN0JiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpIG92ZXJy aWRlOwogI2VuZGlmCiAKLSAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hl bkZvY3VzZWQoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVlOyB9Ci0KIHByaXZhdGU6CiAg ICAgZW51bSBDb250cm9sU3ViUGFydCB7CiAgICAgICAgIE5vbmUsCg==