147101 2015-07-19 21:39:46 -0700 Unexpected ABI diffference between armv7 and armv7s in WebCore::GraphicsLayerCA::~GraphicsLayerCA() 2015-07-20 15:10:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen benjamin commit-queue dino sam simon.fraser thorton webkit-bug-importer oldest_to_newest 1110563 0 ddkilzer 2015-07-19 21:39:46 -0700 Unexpected ABI diffference between armv7 and armv7s in WebCore::GraphicsLayerCA::~GraphicsLayerCA() results in two different symbols: __ZThn568_N7WebCore15GraphicsLayerCAD0Ev __ZThn576_N7WebCore15GraphicsLayerCAD0Ev This is due to the following code in Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: #if CPU(APPLE_ARMV7S) || defined(TRANSFORMATION_MATRIX_USE_X86_64_SSE2) #if COMPILER(MSVC) __declspec(align(16)) typedef double Matrix4[4][4]; #else typedef double Matrix4[4][4] __attribute__((aligned (16))); #endif #else typedef double Matrix4[4][4]; #endif We should simply use the same alignment on armv7 to fix this. 1110564 1 ddkilzer 2015-07-19 21:40:06 -0700 <rdar://problem/21867029> 1110565 2 257078 ddkilzer 2015-07-19 21:56:28 -0700 Created attachment 257078 Patch v1 1110694 3 257078 achristensen 2015-07-20 11:51:42 -0700 Comment on attachment 257078 Patch v1 TransformationMatrix.cpp has a corresponding #elif CPU(APPLE_ARMV7S) which should be changed with this. 1110719 4 ddkilzer 2015-07-20 12:49:26 -0700 (In reply to comment #3) > Comment on attachment 257078 [details] > Patch v1 > > TransformationMatrix.cpp has a corresponding #elif CPU(APPLE_ARMV7S) which > should be changed with this. The assembly in TransformationMatrix.cpp in the #elif CPU(APPLE_ARMV7S) may use instructions that aren't available on non-armv7s platforms. In that case, we fall back to the C code in the #else clause. Ben Poulain needs to review this change. Moving back to r?. 1110736 5 257078 msaboff 2015-07-20 13:26:07 -0700 Comment on attachment 257078 Patch v1 r=me 1110739 6 benjamin 2015-07-20 13:31:50 -0700 +1 from me too. The ARMV7S in TransformationMatrix.cpp has to stay. 1110740 7 257078 achristensen 2015-07-20 13:32:44 -0700 Comment on attachment 257078 Patch v1 ok, makes sense. I just thought it may have been overlooked. 1110756 8 257078 commit-queue 2015-07-20 14:21:53 -0700 Comment on attachment 257078 Patch v1 Clearing flags on attachment: 257078 Committed r187034: <http://trac.webkit.org/changeset/187034> 1110757 9 commit-queue 2015-07-20 14:21:56 -0700 All reviewed patches have been landed. Closing bug. 1110775 10 ddkilzer 2015-07-20 15:10:31 -0700 (In reply to comment #7) > Comment on attachment 257078 [details] > Patch v1 > > ok, makes sense. I just thought it may have been overlooked. It was a good question! I had overlooked it until you mentioned it, but it turns out we shouldn't change it as noted above. 257078 2015-07-19 21:56:28 -0700 2015-07-20 14:21:53 -0700 Patch v1 bug-147101-20150719215515.patch text/plain 1560 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQwNDJlNGZiMDE0ZGUz MTAwNTdjOWIyMDU3NDk5NDUyZjI4NmU2NS4uMTdhNWQ0MTdiOTQ2ZjA0ZDRmYjlmM2U2OGZhNjNm OTA5YTY4MTllOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTA3LTE5ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAgICAgICAgVW5leHBlY3RlZCBBQkkg ZGlmZmZlcmVuY2UgYmV0d2VlbiBhcm12NyBhbmQgYXJtdjdzIGluIFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXJDQTo6fkdyYXBoaWNzTGF5ZXJDQSgpCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9i LzE0NzEwMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguaDog QWxpZ24KKyAgICAgICAgTWF0cml4NCBvbiBib3RoIGFybXY3IGFuZCBhcm12N3MuCisKKzIwMTUt MDctMTkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKwogICAgICAgICBSRUdS RVNTSU9OIChyMTg3MDA4KTogQ0dQYXRoQ3JlYXRlTXV0YWJsZUNvcHlCeVRyYW5zZm9ybWluZ1Bh dGgoKSBpcyBub3QgYXZhaWxhYmxlIG9uIFdpbmRvd3MKICAgICAgICAgPGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcwNzc+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXgu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3Jt YXRpb25NYXRyaXguaAppbmRleCAwM2Y5Y2QwYTg3MzIyZjYyMzQ4MGYwZGQ0YzAzZTU3N2ZlNmNh ZTA0Li4xOWQwYWRkOWFiODNkMjUyZDQ5OGE1Yzc2MWE4ODc4OTM3MmRjNDE1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0 aW9uTWF0cml4LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNm b3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCkBAIC02NSw3ICs2NSw3IEBAIGNsYXNzIFRyYW5z Zm9ybWF0aW9uTWF0cml4IHsKICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoK IAotI2lmIENQVShBUFBMRV9BUk1WN1MpIHx8IGRlZmluZWQoVFJBTlNGT1JNQVRJT05fTUFUUklY X1VTRV9YODZfNjRfU1NFMikKKyNpZiAoUExBVEZPUk0oSU9TKSAmJiBDUFUoQVJNX1RIVU1CMikp IHx8IGRlZmluZWQoVFJBTlNGT1JNQVRJT05fTUFUUklYX1VTRV9YODZfNjRfU1NFMikKICNpZiBD T01QSUxFUihNU1ZDKQogICAgIF9fZGVjbHNwZWMoYWxpZ24oMTYpKSB0eXBlZGVmIGRvdWJsZSBN YXRyaXg0WzRdWzRdOwogI2Vsc2UK