147091 2015-07-19 11:22:15 -0700 Media Session: test 'Transient Solo' interruptions 2015-07-29 12:56:52 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson mrajca webkit-bug-importer oldest_to_newest 1110503 0 mrajca 2015-07-19 11:22:15 -0700 'Transient Solo' interruptions should pause/unpause active media elements. 1110504 1 webkit-bug-importer 2015-07-19 11:22:44 -0700 <rdar://problem/21892120> 1110505 2 257064 mrajca 2015-07-19 11:24:47 -0700 Created attachment 257064 Patch 1112422 3 257064 eric.carlson 2015-07-27 09:23:08 -0700 Comment on attachment 257064 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257064&action=review > LayoutTests/media/session/transient-solo-interruptions.html:14 > + if (window.testRunner) { > + testRunner.dumpAsText(); > + testRunner.waitUntilDone(); > + } Nit: this isn't necessary because you include video-test.js. > LayoutTests/media/session/transient-solo-interruptions.html:16 > + window.jsTestIsAsync = true; Nit: this is unnecessary, it isn't used by the video testing harness. > LayoutTests/media/session/transient-solo-interruptions.html:30 > + document.getElementById("video").play(); Nit: there is only one <video> so you can just use "video" instead of searching for the element. > LayoutTests/media/session/transient-solo-interruptions.html:35 > + document.getElementById("video").onplaying = null; Ditto. 1113146 4 mrajca 2015-07-29 12:53:12 -0700 (In reply to comment #3) > Comment on attachment 257064 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257064&action=review > > > LayoutTests/media/session/transient-solo-interruptions.html:14 > > + if (window.testRunner) { > > + testRunner.dumpAsText(); > > + testRunner.waitUntilDone(); > > + } > > Nit: this isn't necessary because you include video-test.js. Removed. > > > LayoutTests/media/session/transient-solo-interruptions.html:16 > > + window.jsTestIsAsync = true; > > Nit: this is unnecessary, it isn't used by the video testing harness. Removed. > > > LayoutTests/media/session/transient-solo-interruptions.html:30 > > + document.getElementById("video").play(); > > Nit: there is only one <video> so you can just use "video" instead of > searching for the element. Changed. > > > LayoutTests/media/session/transient-solo-interruptions.html:35 > > + document.getElementById("video").onplaying = null; > > Ditto. 1113147 5 mrajca 2015-07-29 12:56:52 -0700 Committed r187552: <http://trac.webkit.org/changeset/187552> 257064 2015-07-19 11:24:47 -0700 2015-07-27 09:23:08 -0700 Patch bug-147091-20150719112332.patch text/plain 5488 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MDA2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTkzMzE5ZDA1ZGI0MzJmZDUzZjJk NDU3ODEyMmViMDk2YmI4ZjE4NS4uODQ3YWU4NDM4MDczOTAwODA4MzNmY2MxMDdhYTU0ODY0MGI4 NzIzYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTA3LTE5ICBNYXR0IFJhamNhICA8bXJh amNhQGFwcGxlLmNvbT4KIAorICAgICAgICBNZWRpYSBTZXNzaW9uOiB0ZXN0ICdUcmFuc2llbnQg U29sbycgaW50ZXJydXB0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ3MDkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBtZWRpYS9zZXNzaW9uL3RyYW5zaWVudC1zb2xvLWludGVycnVwdGlvbnMt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS9zZXNzaW9uL3RyYW5zaWVudC1z b2xvLWludGVycnVwdGlvbnMuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rl c3RFeHBlY3RhdGlvbnM6IE1lZGlhIFNlc3Npb24gc3VwcG9ydCBpcyBkaXNhYmxlZCBieSBkZWZh dWx0LgorCisyMDE1LTA3LTE5ICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKwogICAg ICAgICBNZWRpYSBTZXNzaW9uOiBhZGQgc3VwcG9ydCBmb3IgZHVja2luZyBtZWRpYSBlbGVtZW50 cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MDg5 CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3Nlc3Npb24vdHJhbnNpZW50LXNvbG8t aW50ZXJydXB0aW9ucy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9zZXNzaW9uL3Ry YW5zaWVudC1zb2xvLWludGVycnVwdGlvbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM4NjZl OTc4ZmFiOTEzZGU1YTQ1MjMxOGVmY2FkOWUyNjcwYWM3MjMKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9tZWRpYS9zZXNzaW9uL3RyYW5zaWVudC1zb2xvLWludGVycnVwdGlvbnMtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTggQEAKKydUcmFuc2llbnQgU29sbycgaW50ZXJydXB0aW9u IGV2ZW50cyBzaG91bGQgcGF1c2UgZWxlbWVudHMgYmVsb25naW5nIHRvICdDb250ZW50JyBtZWRp YSBzZXNzaW9ucy4KKworCitXYWl0aW5nIGZvciBDb250ZW50IG1lZGlhIHRvIGJlZ2luIHBsYXlp bmcuCitFVkVOVChjYW5wbGF5dGhyb3VnaCkKK01lZGlhIGJlZ2FuIHBsYXlpbmcuCitFWFBFQ1RF RCAoaW50ZXJuYWxzLm1lZGlhU2Vzc2lvbkN1cnJlbnRTdGF0ZShzZXNzaW9uKSA9PSAnYWN0aXZl JykgT0sKK0VYUEVDVEVEIChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidmlkZW8iKS5wYXVzZWQg PT0gJ2ZhbHNlJykgT0sKK1NlbmRpbmcgJ1RyYW5zaWVudCBTb2xvJyBzdGFydC1vZi1pbnRlcnJ1 cHRpb24gbm90aWZpY2F0aW9uLgorUlVOKGludGVybmFscy5zZW5kTWVkaWFTZXNzaW9uU3RhcnRP ZkludGVycnVwdGlvbk5vdGlmaWNhdGlvbigidHJhbnNpZW50LXNvbG8iKSkKK0VYUEVDVEVEIChp bnRlcm5hbHMubWVkaWFTZXNzaW9uQ3VycmVudFN0YXRlKHNlc3Npb24pID09ICdpbnRlcnJ1cHRl ZCcpIE9LCitFWFBFQ1RFRCAoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInZpZGVvIikucGF1c2Vk ID09ICd0cnVlJykgT0sKK1NlbmRpbmcgJ1RyYW5zaWVudCBTb2xvJyBlbmQtb2YtaW50ZXJydXB0 aW9uIG5vdGlmaWNhdGlvbi4KK1JVTihpbnRlcm5hbHMuc2VuZE1lZGlhU2Vzc2lvbkVuZE9mSW50 ZXJydXB0aW9uTm90aWZpY2F0aW9uKCJ0cmFuc2llbnQtc29sbyIpKQorRVhQRUNURUQgKGludGVy bmFscy5tZWRpYVNlc3Npb25DdXJyZW50U3RhdGUoc2Vzc2lvbikgPT0gJ2FjdGl2ZScpIE9LCitF WFBFQ1RFRCAoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInZpZGVvIikucGF1c2VkID09ICdmYWxz ZScpIE9LCitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9zZXNz aW9uL3RyYW5zaWVudC1zb2xvLWludGVycnVwdGlvbnMuaHRtbCBiL0xheW91dFRlc3RzL21lZGlh L3Nlc3Npb24vdHJhbnNpZW50LXNvbG8taW50ZXJydXB0aW9ucy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZh YmE2YmMzOTgzM2FiMTVjOThjMTZhZWE5Mjc0NzczNTZjYmFmNjgKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9tZWRpYS9zZXNzaW9uL3RyYW5zaWVudC1zb2xvLWludGVycnVwdGlvbnMu aHRtbApAQCAtMCwwICsxLDY0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cisg ICAgPHNjcmlwdCBzcmM9Ii4uL3ZpZGVvLXRlc3QuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQg c3JjPSIuLi9tZWRpYS1maWxlLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHR5cGU9InRleHQv amF2YXNjcmlwdCI+CisgICAgICAgIHZhciBzZXNzaW9uOworICAgIAorICAgICAgICBmdW5jdGlv biBydW5UZXN0KCkgCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5l cikgeworICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAg ICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICAgICAgfQorCisgICAg ICAgICAgICB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisKKyAgICAgICAgICAgIHNlc3Np b24gPSBuZXcgTWVkaWFTZXNzaW9uKCJjb250ZW50Iik7CisKKyAgICAgICAgICAgIGNvbnNvbGVX cml0ZSgiV2FpdGluZyBmb3IgQ29udGVudCBtZWRpYSB0byBiZWdpbiBwbGF5aW5nLiIpCisgICAg ICAgICAgICB2YXIgdmlkZW8gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidmlkZW8iKTsKKyAg ICAgICAgICAgIHdhaXRGb3JFdmVudCgnY2FucGxheXRocm91Z2gnLCBiZWdpblBsYXlpbmcpOwor ICAgICAgICAgICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiLi4vY29udGVu dC9jb3VudGluZyIpOworICAgICAgICAgICAgdmlkZW8uc2Vzc2lvbiA9IHNlc3Npb247CisgICAg ICAgICAgICB2aWRlby5vbnBsYXlpbmcgPSBiZWdhblBsYXlpbmc7CisgICAgICAgIH0KKyAgICAg ICAgCisgICAgICAgIGZ1bmN0aW9uIGJlZ2luUGxheWluZyhldmVudCkKKyAgICAgICAgeworICAg ICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInZpZGVvIikucGxheSgpOworICAgICAg ICB9CisKKyAgICAgICAgZnVuY3Rpb24gYmVnYW5QbGF5aW5nKGV2ZW50KQorICAgICAgICB7Cisg ICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidmlkZW8iKS5vbnBsYXlpbmcgPSBu dWxsOworICAgICAgICAgICAgCisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIk1lZGlhIGJlZ2Fu IHBsYXlpbmcuIik7CisKKyAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAg ICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCdpbnRlcm5hbHMubWVkaWFTZXNzaW9uQ3VycmVudFN0 YXRlKHNlc3Npb24pJywgImFjdGl2ZSIpOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgn ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInZpZGVvIikucGF1c2VkJywgZmFsc2UpOworCisgICAg ICAgICAgICAgICAgY29uc29sZVdyaXRlKCJTZW5kaW5nICdUcmFuc2llbnQgU29sbycgc3RhcnQt b2YtaW50ZXJydXB0aW9uIG5vdGlmaWNhdGlvbi4iKTsKKyAgICAgICAgICAgICAgICBydW4oJ2lu dGVybmFscy5zZW5kTWVkaWFTZXNzaW9uU3RhcnRPZkludGVycnVwdGlvbk5vdGlmaWNhdGlvbigi dHJhbnNpZW50LXNvbG8iKScpOworCisgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCdpbnRl cm5hbHMubWVkaWFTZXNzaW9uQ3VycmVudFN0YXRlKHNlc3Npb24pJywgImludGVycnVwdGVkIik7 CisgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi dmlkZW8iKS5wYXVzZWQnLCB0cnVlKTsKKworICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgi U2VuZGluZyAnVHJhbnNpZW50IFNvbG8nIGVuZC1vZi1pbnRlcnJ1cHRpb24gbm90aWZpY2F0aW9u LiIpOworICAgICAgICAgICAgICAgIHJ1bignaW50ZXJuYWxzLnNlbmRNZWRpYVNlc3Npb25FbmRP ZkludGVycnVwdGlvbk5vdGlmaWNhdGlvbigidHJhbnNpZW50LXNvbG8iKScpOworCisgICAgICAg ICAgICAgICAgdGVzdEV4cGVjdGVkKCdpbnRlcm5hbHMubWVkaWFTZXNzaW9uQ3VycmVudFN0YXRl KHNlc3Npb24pJywgImFjdGl2ZSIpOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgnZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoInZpZGVvIikucGF1c2VkJywgZmFsc2UpOworICAgICAgICAg ICAgfQorICAgICAgICAgICAgCisgICAgICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgIH0KKyAg ICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKyAgICA8cD4n VHJhbnNpZW50IFNvbG8nIGludGVycnVwdGlvbiBldmVudHMgc2hvdWxkIHBhdXNlIGVsZW1lbnRz IGJlbG9uZ2luZyB0byAnQ29udGVudCcgbWVkaWEgc2Vzc2lvbnMuPC9wPgorICAgIDx2aWRlbyBp ZD0idmlkZW8iIC8+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCmluZGV4IDAxZTMzODAzZTY2Y2E5Y2Q4ZjYwNjU2ZTE3NTc1M2JmYmRi MzlkOTEuLmQ4NThlZmY4YjA4YjAyM2VkMzFkMWMxMzhlNzM4NDA3NzgyOGI5MTcgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC05OTcsNiArOTk3LDcgQEAg bWVkaWEvc2Vzc2lvbi9jb250ZW50LWludGVycnVwdGlvbnMuaHRtbAogbWVkaWEvc2Vzc2lvbi9j b250cm9scy1leGlzdGVuY2UuaHRtbAogbWVkaWEvc2Vzc2lvbi9kZWZhdWx0LXNlc3Npb24uaHRt bAogbWVkaWEvc2Vzc2lvbi90cmFuc2llbnQtaW50ZXJydXB0aW9ucy5odG1sCittZWRpYS9zZXNz aW9uL3RyYW5zaWVudC1zb2xvLWludGVycnVwdGlvbnMuaHRtbAogCiAjIFRoaXMgdGVzdCByZXF1 aXJlcyBnZW5lcmF0aW9uIG9mIHByb2dyZXNzIGV2ZW50cyBkdXJpbmcgbG9hZGluZwogd2Via2l0 Lm9yZy9iLzEwMDk4NCBtZWRpYS9wcm9ncmVzcy1ldmVudHMtZ2VuZXJhdGVkLWNvcnJlY3RseS5o dG1sIFsgRmFpbHVyZSBdCg==