147090 2015-07-19 10:51:41 -0700 Parser::parseFunctionInfo hits RELEASE_ASSERT for Arrow Functions 2015-07-19 12:32:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam basile_clement benjamin commit-queue fpizlo ggaren mark.lam mmirman msaboff oliver ysuzuki oldest_to_newest 1110496 0 saam 2015-07-19 10:51:41 -0700 This assertion hits: "RELEASE_ASSERT(mode == NormalFunctionMode || mode == MethodMode);" because this is how we parse arrow functions: template <typename LexerType> template <class TreeBuilder> TreeExpression Parser<LexerType>::parseArrowFunctionExpression(TreeBuilder& context) { JSTokenLocation location; unsigned functionKeywordStart = tokenStart(); location = tokenLocation(); ParserFunctionInfo<TreeBuilder> info; info.name = &m_vm->propertyNames->nullIdentifier; failIfFalse((parseFunctionInfo(context, FunctionNoRequirements, ArrowFunctionMode, true, ConstructorKind::None, SuperBinding::NotNeeded, functionKeywordStart, info, ArrowFunctionParseType)), "Cannot parse arrow function expression"); return context.createArrowFunctionExpr(location, info); } We need to remove this line from the function: "info.name = &m_vm->propertyNames->nullIdentifier;" 1110500 1 saam 2015-07-19 11:01:16 -0700 (In reply to comment #0) > This assertion hits: "RELEASE_ASSERT(mode == NormalFunctionMode || mode == > MethodMode);" > because this is how we parse arrow functions: > > template <typename LexerType> > template <class TreeBuilder> TreeExpression > Parser<LexerType>::parseArrowFunctionExpression(TreeBuilder& context) > { > JSTokenLocation location; > > unsigned functionKeywordStart = tokenStart(); > location = tokenLocation(); > ParserFunctionInfo<TreeBuilder> info; > info.name = &m_vm->propertyNames->nullIdentifier; > failIfFalse((parseFunctionInfo(context, FunctionNoRequirements, > ArrowFunctionMode, true, ConstructorKind::None, SuperBinding::NotNeeded, > functionKeywordStart, info, ArrowFunctionParseType)), "Cannot parse arrow > function expression"); > > return context.createArrowFunctionExpr(location, info); > } > > We need to remove this line from the function: > "info.name = &m_vm->propertyNames->nullIdentifier;" This is a wrong assessment. We need to assign the nullIdentifier and allow the assert to not disqualify arrow functions. 1110501 2 257063 saam 2015-07-19 11:13:27 -0700 Created attachment 257063 patch 1110506 3 257063 ysuzuki 2015-07-19 11:42:05 -0700 Comment on attachment 257063 patch View in context: https://bugs.webkit.org/attachment.cgi?id=257063&action=review r+ > Source/JavaScriptCore/parser/Parser.cpp:1716 > if (functionScope->strictMode() && functionInfo.name) { Even arrow function has functionInfo.name (nullIdentifier). We need to refactor the use cases for functionInfo.name's nullptr-ness. 1110511 4 257063 commit-queue 2015-07-19 12:32:53 -0700 Comment on attachment 257063 patch Clearing flags on attachment: 257063 Committed r187014: <http://trac.webkit.org/changeset/187014> 1110512 5 commit-queue 2015-07-19 12:32:56 -0700 All reviewed patches have been landed. Closing bug. 257063 2015-07-19 11:13:27 -0700 2015-07-19 12:32:53 -0700 patch c-backup.diff text/plain 4966 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg3MDEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTA3LTE5ICBTYWFtIGJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBQYXJzZXI6OnBhcnNlRnVuY3Rpb25JbmZvIGhpdHMgUkVMRUFTRV9BU1NFUlQgZm9yIEFy cm93IEZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ3MDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXJyb3dGdW5jdGlvbidzIGhhdmUgdGhlcmUgUGFyc2VyRnVuY3Rpb25JbmZvICJuYW1l IiBmaWVsZCB0byAKKyAgICAgICAgYmUgYSBub24tbnVsbCBwb2ludGVyLiBUaGlzIGlzIG9idmlv dXNseSBhbGxvd2VkIGFuZCB2YWxpZCBleGNlcHQgd2UgCisgICAgICAgIGhhZCBhIFJFTEVBU0Vf QVNTRVJUIHRoYXQgY2xhaW1lZCBvdGhlcndpc2UuIFRoaXMgaXMgYSBtaXN0YWtlLiAKKworICAg ICAgICBOb3RlOiBBcnJvd0Z1bmN0aW9uJ3Mgd2lsbCBuZXZlciBhY3R1YWxseSBoYXZlIGEgZnVu Y3Rpb24gbmFtZTsKKyAgICAgICAgdGhlcmUgUGFyc2VyRnVuY3Rpb25JbmZvICJuYW1lIiBmaWVs ZCB3aWxsIGJlIHRoZSBlbXB0eSBzdHJpbmcuIAorICAgICAgICBUaGlzIGlzIG5vdCBiZSBtaXN0 YWtlbiB3aXRoIHRoZSBuYW1lIGZpZWxkIGJlaW5nIGEgbnVsbCBwb2ludGVyLgorCisgICAgICAg ICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5cGU+Ojpw YXJzZUZ1bmN0aW9uSW5mbyk6CisKIDIwMTUtMDctMTggIFNhYW0gYmFyYXRpICA8c2FhbWJhcmF0 aTFAZ21haWwuY29tPgogCiAgICAgICAgIFtFUzZdIEFkZCBzdXBwb3J0IGZvciBibG9jayBzY29w ZSBjb25zdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAkocmV2 aXNpb24gMTg3MDEyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNzE0LDcgKzE3MTQsNyBAQCB0ZW1wbGF0ZSA8Y2xhc3MgVHJl ZUJ1aWxkZXI+IGJvb2wgUGFyc2VyCiAgICAgZmFpbElmRmFsc2UoZnVuY3Rpb25JbmZvLmJvZHks ICJDYW5ub3QgcGFyc2UgdGhlIGJvZHkgb2YgdGhpcyAiLCBzdHJpbmdGb3JGdW5jdGlvbk1vZGUo bW9kZSkpOwogICAgIGNvbnRleHQuc2V0RW5kT2Zmc2V0KGZ1bmN0aW9uSW5mby5ib2R5LCBtX2xl eGVyLT5jdXJyZW50T2Zmc2V0KCkpOwogICAgIGlmIChmdW5jdGlvblNjb3BlLT5zdHJpY3RNb2Rl KCkgJiYgZnVuY3Rpb25JbmZvLm5hbWUpIHsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQobW9kZSA9 PSBOb3JtYWxGdW5jdGlvbk1vZGUgfHwgbW9kZSA9PSBNZXRob2RNb2RlKTsKKyAgICAgICAgUkVM RUFTRV9BU1NFUlQobW9kZSA9PSBOb3JtYWxGdW5jdGlvbk1vZGUgfHwgbW9kZSA9PSBNZXRob2RN b2RlIHx8IG1vZGUgPT0gQXJyb3dGdW5jdGlvbk1vZGUpOwogICAgICAgICBzZW1hbnRpY0ZhaWxJ ZlRydWUobV92bS0+cHJvcGVydHlOYW1lcy0+YXJndW1lbnRzID09ICpmdW5jdGlvbkluZm8ubmFt ZSwgIiciLCBmdW5jdGlvbkluZm8ubmFtZS0+aW1wbCgpLCAiJyBpcyBub3QgYSB2YWxpZCBmdW5j dGlvbiBuYW1lIGluIHN0cmljdCBtb2RlIik7CiAgICAgICAgIHNlbWFudGljRmFpbElmVHJ1ZSht X3ZtLT5wcm9wZXJ0eU5hbWVzLT5ldmFsID09ICpmdW5jdGlvbkluZm8ubmFtZSwgIiciLCBmdW5j dGlvbkluZm8ubmFtZS0+aW1wbCgpLCAiJyBpcyBub3QgYSB2YWxpZCBmdW5jdGlvbiBuYW1lIGlu IHN0cmljdCBtb2RlIik7CiAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTg3MDEyKQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUt MDctMTkgIFNhYW0gYmFyYXRpICA8c2FhbWJhcmF0aTFAZ21haWwuY29tPgorCisgICAgICAgIFBh cnNlcjo6cGFyc2VGdW5jdGlvbkluZm8gaGl0cyBSRUxFQVNFX0FTU0VSVCBmb3IgQXJyb3cgRnVu Y3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDcwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGpzL2Fycm93ZnVuY3Rpb24tc3RyaWN0LW1vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBqcy9hcnJvd2Z1bmN0aW9uLXN0cmljdC1tb2RlLmh0bWw6IEFkZGVkLgorICAgICAgICAq IGpzL3NjcmlwdC10ZXN0cy9hcnJvd2Z1bmN0aW9uLXN0cmljdC1tb2RlLmpzOiBBZGRlZC4KKyAg ICAgICAgKGZvbyk6CisKIDIwMTUtMDctMTggIFNhYW0gYmFyYXRpICA8c2FhbWJhcmF0aTFAZ21h aWwuY29tPgogCiAgICAgICAgIFtFUzZdIEFkZCBzdXBwb3J0IGZvciBibG9jayBzY29wZSBjb25z dApJbmRleDogTGF5b3V0VGVzdHMvanMvYXJyb3dmdW5jdGlvbi1zdHJpY3QtbW9kZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvYXJyb3dmdW5jdGlvbi1zdHJpY3Qt bW9kZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9qcy9hcnJvd2Z1 bmN0aW9uLXN0cmljdC1tb2RlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsx LDE3IEBACitUZXN0cyBmb3IgRVM2IGFycm93IGZ1bmN0aW9uLCBtYWtlIHN1cmUgcGFyc2luZyBp cyBPSyBpbiBzdHJpY3QgbW9kZS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BB U1MgZjEoMTApIGlzIDEwCitQQVNTIGYyKDIwKSBpcyAyMAorUEFTUyBmMygxMCwgMjApIGlzIDMw CitQQVNTIGY0KDIwLCAyMCkgaXMgNDAKK1BBU1MgZm9vKHggPT4geCArIDEpIGlzIDExCitQQVNT IGZvbygoeCkgPT4geCArIDEpIGlzIDExCitQQVNTIGZvbyh4ID0+IHsgcmV0dXJuIHggKyAxOyB9 KSBpcyAxMQorUEFTUyBmb28oKHgpID0+IHsgcmV0dXJuIHggKyAxOyB9KSBpcyAxMQorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91 dFRlc3RzL2pzL2Fycm93ZnVuY3Rpb24tc3RyaWN0LW1vZGUuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9qcy9hcnJvd2Z1bmN0aW9uLXN0cmljdC1tb2RlLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9qcy9hcnJvd2Z1bmN0aW9uLXN0cmljdC1tb2RlLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRG Ly9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0IHNy Yz0ic2NyaXB0LXRlc3RzL2Fycm93ZnVuY3Rpb24tc3RyaWN0LW1vZGUuanMiPjwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2Fycm93ZnVu Y3Rpb24tc3RyaWN0LW1vZGUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvc2NyaXB0 LXRlc3RzL2Fycm93ZnVuY3Rpb24tc3RyaWN0LW1vZGUuanMJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvYXJyb3dmdW5jdGlvbi1zdHJpY3QtbW9kZS5qcwkod29y a2luZyBjb3B5KQpAQCAtMCwwICsxLDI0IEBACisidXNlIHN0cmljdCI7CisKK2Rlc2NyaXB0aW9u KCdUZXN0cyBmb3IgRVM2IGFycm93IGZ1bmN0aW9uLCBtYWtlIHN1cmUgcGFyc2luZyBpcyBPSyBp biBzdHJpY3QgbW9kZS4nKTsKKwordmFyIGYxID0geCA9PiB4Oworc2hvdWxkQmUoImYxKDEwKSIs ICIxMCIpOworCit2YXIgZjIgPSAoeCkgPT4geDsKK3Nob3VsZEJlKCJmMigyMCkiLCAiMjAiKTsK KwordmFyIGYzID0gKHgsIHkpID0+IHggKyB5Oworc2hvdWxkQmUoImYzKDEwLCAyMCkiLCAiMzAi KTsKKwordmFyIGY0ID0gKHgsIHkpID0+IHsgcmV0dXJuIHggKyB5OyB9Oworc2hvdWxkQmUoImY0 KDIwLCAyMCkiLCAiNDAiKTsKKworZnVuY3Rpb24gZm9vKGYpIHsKKyAgICByZXR1cm4gZigxMCk7 Cit9CisKK3Nob3VsZEJlKCJmb28oeCA9PiB4ICsgMSkiLCAiMTEiKTsKK3Nob3VsZEJlKCJmb28o KHgpID0+IHggKyAxKSIsICIxMSIpOworc2hvdWxkQmUoImZvbyh4ID0+IHsgcmV0dXJuIHggKyAx OyB9KSIsICIxMSIpOworc2hvdWxkQmUoImZvbygoeCkgPT4geyByZXR1cm4geCArIDE7IH0pIiwg IjExIik7Cg==