14709 2007-07-22 01:43:00 -0700 document.write in onload fails 2007-09-26 21:27:46 -0700 1 1 1 Unclassified WebKit DOM 523.x (Safari 3) Mac OS X 10.4 RESOLVED DUPLICATE 8961 http://dscoder.com/documentwritetestcase.html P2 Normal --- 1 catfish.man webkit-unassigned ap aroben mrowe sornalatha.rathnasamy vincent.bradley oldest_to_newest 4093 0 catfish.man 2007-07-22 01:43:00 -0700 The linked url shows "success" on the page in firefox, but is blank in webkit. It uses document.write in onload on the <body>. In addition, having the document.write in onload will also cause a subsequent document.write to fail. For example <body onload="document.write('success')"><script type="text/javascript">document.write('success');</script></body> will print nothing, but if the onload on the body is removed, it will print success. 4085 1 aroben 2007-07-22 01:46:21 -0700 The second example you describe shows a document.write happening *previous* to the one in the onload handler. The body of the <script> element will be executed as soon as it is parsed, which will happen before the onload event fires. My guess is that the document.write inside the <script> executes correctly, but then the document is cleared when the document.write in the onload handler does an implicit document.open. But this is just speculation. 3129 2 15809 sornalatha.rathnasamy 2007-08-02 11:24:28 -0700 Created attachment 15809 close the write content when the doc is closed 3130 3 sornalatha.rathnasamy 2007-08-02 11:25:15 -0700 (In reply to comment #2) > Created an attachment (id=15809) [edit] > close the write content when the doc is closed http://bugs.webkit.org/show_bug.cgi?id=14821 is a duplicate of this bug. 3106 4 darin 2007-08-02 18:48:53 -0700 *** Bug 14821 has been marked as a duplicate of this bug. *** 3107 5 15809 darin 2007-08-02 18:49:29 -0700 Comment on attachment 15809 close the write content when the doc is closed This patch is not for TOT. Must be for the S60 branch. 3097 6 15809 mrowe 2007-08-03 01:46:25 -0700 Comment on attachment 15809 close the write content when the doc is closed I'm going to mark this r- as the patch is for the S60 branch while the bug was reported against trunk. This means that the patch does not address the bug that was reported. 3057 7 15809 sornalatha.rathnasamy 2007-08-03 05:51:43 -0700 Comment on attachment 15809 close the write content when the doc is closed this patch is applicable to tiger branch as well not just S60. Could someone please review ? 3058 8 15809 sornalatha.rathnasamy 2007-08-03 05:51:49 -0700 Comment on attachment 15809 close the write content when the doc is closed this patch is applicable to tiger branch as well not just S60. Could someone please review ? 2997 9 15809 mrowe 2007-08-06 02:38:20 -0700 Comment on attachment 15809 close the write content when the doc is closed As mentioned, the bug is reported against trunk so a patch for the Tiger branch does not resolve the bug. 2999 10 ap 2007-08-06 04:23:46 -0700 Also, the patch for TOT should include a test case and a ChangeLog entry. Please see <http://webkit.org/coding/contributing.html> for information on contributing code. 2322 11 15964 sornalatha.rathnasamy 2007-08-14 11:57:39 -0700 Created attachment 15964 close the stream after write by appending </html> for the corresponding <html> tag added in write() 2313 12 ap 2007-08-14 13:22:51 -0700 The patch still doesn't have a test, so it cannot be landed. However, I'm leaving the review flag on for someone to review code changes. BTW, this seems to be a duplicate of bug 8961. 2311 13 15968 sornalatha.rathnasamy 2007-08-14 13:29:23 -0700 Created attachment 15968 test case test case 2062 14 15968 mrowe 2007-08-17 23:26:06 -0700 Comment on attachment 15968 test case Your test case should be included in the patch, along with the expected results. It seems that this test should also be a text-only test rather than dumping the rendertree. 2060 15 15964 mrowe 2007-08-17 23:36:16 -0700 Comment on attachment 15964 close the stream after write by appending </html> for the corresponding <html> tag added in write() Your ChangeLog entries should include information about the change as well as a reference to the bug is being fixed, as well as your name rather than "webcore" in the header line. The name "m_beginWriteStream" seems less than ideal. It reads more like a function name due to it starting with a verb. I can't suggest a better name as I'm not entirely clear on what the purpose of the variable is. 1949 16 15964 sam 2007-08-19 17:38:25 -0700 Comment on attachment 15964 close the stream after write by appending </html> for the corresponding <html> tag added in write() As noted above, this needs a more detailed ChangeLog and an included test case. r- 1933 17 mjs 2007-08-19 21:43:03 -0700 I'm not sure the basic approach here is right: a) Writing a </html> close tag shouldn't be necessary to have the written contents actually appear; the fact that it is likely indicates some deeper problem. b) This probably means that certain kinds of document.write *after* onload won't work right either, and there isn't code around to write the </html> in such cases. 57135 18 ap 2007-09-26 21:27:46 -0700 This bug doesn't seem active anymore; actually closing as a duplicate. *** This bug has been marked as a duplicate of 8961 *** 15809 2007-08-02 11:24:28 -0700 2007-08-14 11:57:39 -0700 close the write content when the doc is closed bugzilla_14709.patch text/plain 1495 sornalatha.rathnasamy SW5kZXg6IFdlYkNvcmUva2h0bWwveG1sL2RvbV9kb2NpbXBsLmNwcA0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t IFdlYkNvcmUva2h0bWwveG1sL2RvbV9kb2NpbXBsLmNwcAkocmV2aXNpb24gMjQ3ODEpDQorKysg V2ViQ29yZS9raHRtbC94bWwvZG9tX2RvY2ltcGwuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMzg2 LDYgKzM4Niw3IEBADQogICAgIG1fbWFya2Vycy5zZXRBdXRvRGVsZXRlKHRydWUpOwogCiAgICAg bV9mYXN0RGlzcGxheU1vZGUgPSBmYWxzZTsKKyAgICBtX2JlZ2luV3JpdGVTdHJlYW0gPSBmYWxz ZTsKIAogICAgIHN0YXRpYyBpbnQgZG9jSUQgPSAwOwogICAgIG1fZG9jSUQgPSBkb2NJRCsrOwpA QCAtMTYzMiw2ICsxNjMzLDEwIEBADQogICAgICAgICAvLyBGSVhNRTogdGhpcyBjaGVjayBtYXkg bm8gbG9uZ2VyIGJlIG5lY2Vzc2FyeSwgc2luY2Ugbm93IGl0IHNob3VsZCBiZSBpbXBvc3NpYmxl CiAgICAgICAgIC8vIGZvciBwYXJzaW5nIHRvIGJlIGZhbHNlIHdoaWxlIHN0aWwgd2FpdGluZyBm b3Igc2NyaXB0cwogICAgICAgICBpZiAobV90b2tlbml6ZXIgJiYgIW1fdG9rZW5pemVyLT5pc1dh aXRpbmdGb3JTY3JpcHRzKCkpIHsKKyAgICAgICAgICAgIGlmICggbV9iZWdpbldyaXRlU3RyZWFt ICkgeworICAgICAgICAgICAgICAgIHdyaXRlKFFTdHJpbmc6OmZyb21MYXRpbjEoIjwvaHRtbD4i KSk7CisgICAgICAgICAgICAgICAgbV9iZWdpbldyaXRlU3RyZWFtID0gZmFsc2U7CisgICAgICAg ICAgICB9CiAgICAgICAgICAgICBkZWxldGUgbV90b2tlbml6ZXI7CiAgICAgICAgICAgICBtX3Rv a2VuaXplciA9IDA7CiAgICAgICAgIH0KQEAgLTE3MTMsNiArMTcxOCw3IEBADQogICAgIGlmICgh bV90b2tlbml6ZXIpIHsKICAgICAgICAgb3BlbigpOwogICAgICAgICB3cml0ZShRU3RyaW5nOjpm cm9tTGF0aW4xKCI8aHRtbD4iKSk7CisgICAgICAgIG1fYmVnaW5Xcml0ZVN0cmVhbSA9IHRydWU7 CiAgICAgfQogCiAjaWZkZWYgTk9LSUFfQ0hBTkdFUwpJbmRleDogV2ViQ29yZS9raHRtbC94bWwv ZG9tX2RvY2ltcGwuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUva2h0bWwveG1sL2RvbV9kb2Np bXBsLmgJKHJldmlzaW9uIDI0NzgxKQ0KKysrIFdlYkNvcmUva2h0bWwveG1sL2RvbV9kb2NpbXBs LmgJKHdvcmtpbmcgY29weSkNCkBAIC04MTQsNiArODE0LDcgQEANCiAgICAgYm9vbCBtX2hhc0Rh c2hib2FyZFJlZ2lvbnM7CiAgICAgYm9vbCBtX2Rhc2hib2FyZFJlZ2lvbnNEaXJ0eTsKICAgICBi b29sIG1fZmFzdERpc3BsYXlNb2RlOworICAgIGJvb2wgbV9iZWdpbldyaXRlU3RyZWFtOwogCiAg ICAgUVB0ckRpY3Q8IFFEaWN0PEhUTUxJbnB1dEVsZW1lbnRJbXBsPiA+ICptX3NlbGVjdGVkUmFk aW9CdXR0b25zOwogCg== 15964 2007-08-14 11:57:39 -0700 2007-08-19 17:38:25 -0700 close the stream after write by appending </html> for the corresponding <html> tag added in write() 14709.patch text/plain 2968 sornalatha.rathnasamy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTA3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMDgtMTQgIHdlYmNvcmUgIDxzb3JuYWxhdGhhLnJhdGhuYXNh bXlAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3 MDkgCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9j dW1lbnQ6OkRvY3VtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpyZW1vdmVkTGFz dFJlZik6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6aW1wbGljaXRDbG9zZSk6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6d3JpdGUpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5o OgorCiAyMDA3LTA4LTE0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQnJhZHkgYW5kIERyLiBIYXJyaXNvbi4KSW5kZXg6IFdlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlz aW9uIDI1MDY5KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zMzUsNiArMzM1LDcgQEAgRG9jdW1lbnQ6OkRvY3VtZW50KERPTUltcGxlbWVudGF0aW9uKiBp bQogCiAgICAgc3RhdGljIGludCBkb2NJRCA9IDA7CiAgICAgbV9kb2NJRCA9IGRvY0lEKys7Cisg ICAgbV9iZWdpbldyaXRlU3RyZWFtID0gZmFsc2U7CiB9CiAKIHZvaWQgRG9jdW1lbnQ6OnJlbW92 ZWRMYXN0UmVmKCkKQEAgLTE0MjMsNiArMTQyNCwxMSBAQCB2b2lkIERvY3VtZW50OjppbXBsaWNp dENsb3NlKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChtX3Rva2VuaXplciAm JiAhbV90b2tlbml6ZXItPmlzV2FpdGluZ0ZvclNjcmlwdHMoKSAmJiBtX2JlZ2luV3JpdGVTdHJl YW0pIHsKKyAgICAgICAgd3JpdGUoRGVwcmVjYXRlZFN0cmluZygiPC9odG1sPiIpKTsKKyAgICAg ICAgbV9iZWdpbldyaXRlU3RyZWFtID0gZmFsc2U7CisgICAgfQorCiAgICAgZnJhbWUoKS0+bG9h ZGVyKCktPmNoZWNrQ2FsbEltcGxpY2l0Q2xvc2UoKTsKIAogICAgIC8vIE5vdyBkbyBvdXIgcGFp bnRpbmcvbGF5b3V0LCBidXQgb25seSBpZiB3ZSBhcmVuJ3QgaW4gYSBzdWJmcmFtZSBvciBpZiB3 ZSdyZSBpbiBhIHN1YmZyYW1lCkBAIC0xNTE4LDYgKzE1MjQsNyBAQCB2b2lkIERvY3VtZW50Ojp3 cml0ZShjb25zdCBTdHJpbmcmIHRleHQpCiAgICAgICAgIGlmICghbV90b2tlbml6ZXIpCiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIHdyaXRlKERlcHJlY2F0ZWRTdHJpbmcoIjxodG1sPiIp KTsKKyAgICAgICAgbV9iZWdpbldyaXRlU3RyZWFtID0gdHJ1ZTsKICAgICB9CiAgICAgbV90b2tl bml6ZXItPndyaXRlKHRleHQsIGZhbHNlKTsKICAgICAKSW5kZXg6IFdlYkNvcmUvZG9tL0RvY3Vt ZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRG9jdW1lbnQuaAkocmV2aXNpb24gMjUw NjkpCisrKyBXZWJDb3JlL2RvbS9Eb2N1bWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC04OTAsNiAr ODkwLDcgQEAgcHJpdmF0ZToKICNpZiBVU0UoTE9XX0JBTkRXSURUSF9ESVNQTEFZKQogICAgIGJv b2wgbV9pbkxvd0JhbmR3aWR0aERpc3BsYXk7CiAjZW5kaWYKKyAgICBib29sIG1fYmVnaW5Xcml0 ZVN0cmVhbTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IExheW91dFRlc3Rz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9u IDI1MDcwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTAgQEAKKzIwMDctMDgtMTQgIHdlYmNvcmUgIDxzb3JuYWxhdGhhLnJhdGhuYXNhbXlAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcwOQorCisgICAgICAgICog ZmFzdC9keW5hbWljLzAxMC1leHBlY3RlZC50eHQ6CisKIDIwMDctMDgtMTMgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9keW5hbWljLzAxMC1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9keW5hbWljLzAxMC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDI1MDY5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9keW5hbWljLzAxMC1leHBlY3RlZC50eHQJKHdv cmtpbmcgY29weSkKQEAgLTUsMyArNSw0IEBAIGxheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAog ICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAogICAgICAgUmVuZGVy VGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMTF4MTgKICAgICAgICAgdGV4dCBydW4gYXQgKDAs MCkgd2lkdGggMTE6ICJCIgorICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUg MHgwCg== 15968 2007-08-14 13:29:23 -0700 2007-08-17 23:26:06 -0700 test case write.html text/html 413 sornalatha.rathnasamy PGh0bWw+DQoNCjxoZWFkPg0KICA8dGl0bGU+ZG9jdW1lbnQgd3JpdGU8L3RpdGxlPg0KPC9oZWFk Pg0KDQo8Ym9keSBvbmxvYWQ9J2V4KCk7Jz4NCg0KPCEtLWNvbnRlbnQtLT4NCjxwPjE8L3A+DQo8 cD4yPC9wPg0KPHA+MzwvcD4NCjxwPjQ8L3A+DQo8cD41PC9wPg0KPHA+NjwvcD4NCjxwPjc8L3A+ DQo8cD44PC9wPg0KPHA+OTwvcD4NCjxwPjEwPC9wPg0KPHA+MTE8L3A+DQo8cD4xMjwvcD4NCg0K PHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPg0KZnVuY3Rpb24gZXgoKSB7DQogCWRvY3Vt ZW50LndyaXRlKCJ0aGVyZSBhcmUgIiArIGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJw IikubGVuZ3RoICsgIiB0YWdzIGluIHRoZSBkb2N1bWVudCIpOw0KDQp9DQo8L3NjcmlwdD4NCjwv Ym9keT4NCjwvaHRtbD4=