147085 2015-07-18 23:12:43 -0700 -[AVPlayerItem currentTime] and -[AVPlayer isExternalPlaybackActive] deadlock 2015-07-20 22:42:13 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan crogers eric.carlson jer.noble jonlee webkit-bug-importer oldest_to_newest 1110458 0 adachan 2015-07-18 23:12:43 -0700 Repro steps: https://files.scene.org/get/parties/2015/solskogen15/demo_newschool/primitive-_-i_want_to_see_other_worlds.html.zip Extract, open the HTML In Safari, for “Fullscreen?” click “No” Web process hangs in MediaPlayerPrivateAVFoundationObjC::currentMediaTime() The main thread is stuck here: #0 0x00007fff8b613f02 in __psynch_mutexwait () ... #6 0x00007fff9ad38eb3 in -[AVPlayerItem currentTime] () #7 0x0000000111fbf42b in WebCore::MediaPlayerPrivateAVFoundationObjC::currentMediaTime() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1288 #8 0x0000000111fa6ec2 in WebCore::MediaPlayer::currentTime() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/platform/graphics/MediaPlayer.cpp:535 #9 0x0000000111576986 in WebCore::HTMLMediaElement::refreshCachedTime() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:2584 #10 0x000000011157c2fe in WebCore::HTMLMediaElement::currentMediaTime() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:2671 #11 0x0000000111581907 in WebCore::HTMLMediaElement::endedPlayback() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:4586 #12 0x00000001115883ac in WebCore::HTMLMediaElement::couldPlayIfEnoughData() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:4558 #13 0x000000011157d688 in WebCore::HTMLMediaElement::potentiallyPlaying() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:4544 #14 0x000000011157dddf in WebCore::HTMLMediaElement::updatePlayState() at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:4676 #15 0x0000000111581e5b in WebCore::HTMLMediaElement::playInternal() at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:2893 #16 0x0000000111581c40 in WebCore::HTMLMediaElement::play() at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:2839 #17 0x0000000111b0a4e1 in WebCore::jsHTMLMediaElementPrototypeFunctionPlay(JSC::ExecState*) at /Volumes/Data/Users/adachan/Build/Debug/DerivedSources/WebCore/JSHTMLMediaElement.cpp:1531 The audio I/O thread is stuck here: #0 0x00007fff8b60e932 in semaphore_wait_trap () ... #7 0x00007fff9ada0423 in -[AVPlayer isExternalPlaybackActive] () #8 0x0000000111fc904c in WebCore::MediaPlayerPrivateAVFoundationObjC::isCurrentPlaybackTargetWireless() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2743 #9 0x0000000111fa7f8b in WebCore::MediaPlayer::isCurrentPlaybackTargetWireless() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/platform/graphics/MediaPlayer.cpp:859 #10 0x000000011158dadc in WebCore::HTMLMediaElement::mediaState() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:6392 #11 0x000000011158dd2c in non-virtual thunk to WebCore::HTMLMediaElement::mediaState() const at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:6384 #12 0x000000011100b696 in WebCore::Document::updateIsPlayingMedia() at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/dom/Document.cpp:3496 #13 0x0000000110b4bb0d in WebCore::AudioContext::isPlayingAudioDidChange() at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/Modules/webaudio/AudioContext.cpp:1080 #14 0x0000000110b69074 in WebCore::AudioDestinationNode::updateIsEffectivelyPlayingAudio() at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:128 #15 0x0000000110b68f53 in WebCore::AudioDestinationNode::setIsSilent(bool) at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:117 #16 0x0000000110b68ecf in WebCore::AudioDestinationNode::render(WebCore::AudioBus*, WebCore::AudioBus*, unsigned long) at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:98 #17 0x0000000110b68f9f in non-virtual thunk to WebCore::AudioDestinationNode::render(WebCore::AudioBus*, WebCore::AudioBus*, unsigned long) at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:56 #18 0x0000000110b687d4 in WebCore::AudioDestinationMac::render(unsigned int, AudioBufferList*) at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp:165 #19 0x0000000110b68607 in WebCore::AudioDestinationMac::inputProc(void*, unsigned int*, AudioTimeStamp const*, unsigned int, unsigned int, AudioBufferList*) at /Volumes/Data/Users/adachan/WebKit/OpenSource/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp:189 #20 0x000000012b97a0b3 in AUInputElement::PullInput(unsigned int&, AudioTimeStamp const&, unsigned int, unsigned int) () The audio I/O thread should never call into WebCore in a render callback, since the call into WebCore might block and we'll end up with a deadlock. We should make sure that call is done asynchronously on the main thread. 1110461 1 adachan 2015-07-18 23:28:58 -0700 <rdar://problem/21878275> 1110462 2 adachan 2015-07-18 23:48:59 -0700 Eric Carlson suggested this change: void AudioContext::isPlayingAudioDidChange() { - document()->updateIsPlayingMedia(); + RefPtr<AudioContext> strongThis(this); + callOnMainThread([strongThis] { + strongThis->document()->updateIsPlayingMedia(); + }); } I could reproduce this deadlock before this change, and could not reproduce the deadlock anymore after this change. Posting a patch very soon. 1110463 3 257056 adachan 2015-07-18 23:51:04 -0700 Created attachment 257056 Patch Fix as suggested by Eric. Thanks Eric! 1110665 4 adachan 2015-07-20 11:10:02 -0700 Committed: http://trac.webkit.org/changeset/187025 1110850 5 257056 darin 2015-07-20 17:44:35 -0700 Comment on attachment 257056 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257056&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:1076 > + strongThis->document()->updateIsPlayingMedia(); What guarantees that document() is non-null later when this is called on the main thread? It seems we could have a problem if this is pending when the audio context’s document is destroyed. 1110889 6 adachan 2015-07-20 21:55:59 -0700 That's a good point. I'll post a followup patch to address that. 1110891 7 257160 adachan 2015-07-20 21:57:09 -0700 Created attachment 257160 Followup patch Add a null check for document() in case the audio context's document has been destroyed by the time it's called on the main thread. 1110897 8 adachan 2015-07-20 22:42:13 -0700 Thanks Eric! Follow-up patch has been committed: http://trac.webkit.org/changeset/187098 257056 2015-07-18 23:51:04 -0700 2015-07-20 10:22:23 -0700 Patch 0001-Fix-deadlock-between-AVPlayerItem-currentTime-and-AV.patch text/plain 2489 adachan RnJvbSBlNjAxMjVjY2RmMzgyMmQxMjc2MWZhYzQ0NDkyNmQ5NTgzNDFkZGI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IFNh dCwgMTggSnVsIDIwMTUgMjM6Mzg6MjYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXggZGVhZGxv Y2sgYmV0d2VlbiAtW0FWUGxheWVySXRlbSBjdXJyZW50VGltZV0gYW5kCiAtW0FWUGxheWVyIGlz RXh0ZXJuYWxQbGF5YmFja0FjdGl2ZV0KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDcwODUgPHJkYXI6Ly9wcm9ibGVtLzIxODc4Mjc1PgoKUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgoqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcDoKKFdlYkNv cmU6OkF1ZGlvQ29udGV4dDo6aXNQbGF5aW5nQXVkaW9EaWRDaGFuZ2UpOgpDYWxsIERvY3VtZW50 Ojp1cGRhdGVJc1BsYXlpbmdNZWRpYSgpIG9uIHRoZSBtYWluIHRocmVhZCwgc2luY2Ugd2UgY291 bGQgYmUgb24gdGhlIGF1ZGlvIEkvTwp0aHJlYWQgaGVyZSBhbmQgdGhlIERvY3VtZW50Ojp1cGRh dGVJc1BsYXlpbmdNZWRpYSgpIGNhbGwgY291bGQgYmxvY2ssIGNhdXNpbmcgYSBkZWFkbG9jay4K LS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgfCAx MyArKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29u dGV4dC5jcHAgfCAgNyArKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzRkYmY4NzcuLmJjNGVkN2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNS0wNy0xOCAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggZGVhZGxvY2sgYmV0d2VlbiAtW0FWUGxheWVySXRlbSBjdXJy ZW50VGltZV0gYW5kIC1bQVZQbGF5ZXIgaXNFeHRlcm5hbFBsYXliYWNrQWN0aXZlXQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MDg1CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yMTg3ODI3NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6aXNQbGF5aW5nQXVkaW9EaWRDaGFuZ2Up OgorICAgICAgICBDYWxsIERvY3VtZW50Ojp1cGRhdGVJc1BsYXlpbmdNZWRpYSgpIG9uIHRoZSBt YWluIHRocmVhZCwgc2luY2Ugd2UgY291bGQgYmUgb24gdGhlIGF1ZGlvIEkvTworICAgICAgICB0 aHJlYWQgaGVyZSBhbmQgdGhlIERvY3VtZW50Ojp1cGRhdGVJc1BsYXlpbmdNZWRpYSgpIGNhbGwg Y291bGQgYmxvY2ssIGNhdXNpbmcgYSBkZWFkbG9jay4KKwogMjAxNS0wNy0xOCAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxODY5NzYp OiBVc2UgcGlGbG9hdCBpbnN0ZWFkIG9mIE1fUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAppbmRleCAyMzIzNGE2Li42M2IyNTAxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCkBA IC0xMDY5LDcgKzEwNjksMTIgQEAgdm9pZCBBdWRpb0NvbnRleHQ6OnBhZ2VNdXRlZFN0YXRlRGlk Q2hhbmdlKCkKIAogdm9pZCBBdWRpb0NvbnRleHQ6OmlzUGxheWluZ0F1ZGlvRGlkQ2hhbmdlKCkK IHsKLSAgICBkb2N1bWVudCgpLT51cGRhdGVJc1BsYXlpbmdNZWRpYSgpOworICAgIC8vIE1ha2Ug c3VyZSB0byBjYWxsIERvY3VtZW50Ojp1cGRhdGVJc1BsYXlpbmdNZWRpYSgpIG9uIHRoZSBtYWlu IHRocmVhZCwgc2luY2UKKyAgICAvLyB3ZSBjb3VsZCBiZSBvbiB0aGUgYXVkaW8gSS9PIHRocmVh ZCBoZXJlIGFuZCB0aGUgY2FsbCBpbnRvIFdlYkNvcmUgY291bGQgYmxvY2suCisgICAgUmVmUHRy PEF1ZGlvQ29udGV4dD4gc3Ryb25nVGhpcyh0aGlzKTsKKyAgICBjYWxsT25NYWluVGhyZWFkKFtz dHJvbmdUaGlzXSB7CisgICAgICAgIHN0cm9uZ1RoaXMtPmRvY3VtZW50KCktPnVwZGF0ZUlzUGxh eWluZ01lZGlhKCk7CisgICAgfSk7CiB9CiAKIHZvaWQgQXVkaW9Db250ZXh0OjpmaXJlQ29tcGxl dGlvbkV2ZW50KCkKLS0gCjIuMy44IChBcHBsZSBHaXQtNTgpCgo= 257160 2015-07-20 21:57:09 -0700 2015-07-20 22:12:11 -0700 Followup patch 0001-Follow-up-to-my-earlier-fix-for-r147085.patch text/plain 2163 adachan RnJvbSAyMDZkY2YyMmRiY2NhMjhiMTU5Y2RlYWNkNGE0ZTUyMjcwYzNmZDAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IE1v biwgMjAgSnVsIDIwMTUgMjE6NTM6MjEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGb2xsb3ctdXAg dG8gbXkgZWFybGllciBmaXggZm9yIHIxNDcwODUKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDcwODUKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBNb2R1 bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHA6CihXZWJDb3JlOjpBdWRpb0NvbnRleHQ6Omlz UGxheWluZ0F1ZGlvRGlkQ2hhbmdlKToKTnVsbC1jaGVjayBkb2N1bWVudCgpIGJlZm9yZSBkZXJl ZmVyZW5jaW5nIGl0IGluIGNhc2UgdGhlIGF1ZGlvIGNvbnRleHQncyBkb2N1bWVudCBpcyBkZXN0 cm95ZWQKYnkgdGhlIHRpbWUgdGhlIGNvZGUgYmxvY2sgaXMgY2FsbGVkIG9uIHRoZSBtYWluIHRo cmVhZC4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgfCAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVk aW9Db250ZXh0LmNwcCB8ICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgwMDI5MWYuLjcyN2QwY2QgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wNy0yMCAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxl LmNvbT4KKworICAgICAgICBGb2xsb3ctdXAgdG8gbXkgZWFybGllciBmaXggZm9yIHIxNDcwODUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzA4NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxl cy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250 ZXh0Ojppc1BsYXlpbmdBdWRpb0RpZENoYW5nZSk6CisgICAgICAgIE51bGwtY2hlY2sgZG9jdW1l bnQoKSBiZWZvcmUgZGVyZWZlcmVuY2luZyBpdCBpbiBjYXNlIHRoZSBhdWRpbyBjb250ZXh0J3Mg ZG9jdW1lbnQgaXMgZGVzdHJveWVkCisgICAgICAgIGJ5IHRoZSB0aW1lIHRoZSBjb2RlIGJsb2Nr IGlzIGNhbGxlZCBvbiB0aGUgbWFpbiB0aHJlYWQuCisKIDIwMTUtMDctMjAgIE5hbiBXYW5nICA8 bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogU2VsZWN0aW9uIGNoYW5nZSBhcyBhIHJl c3VsdCBvZiBmb2N1c2luZyBhbiBlbGVtZW50IG1heSBjYXVzZSBTYWZhcmkgdG8gY3Jhc2gKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAppbmRl eCA2M2IyNTAxLi4yZmM2Mzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJh dWRpby9BdWRpb0NvbnRleHQuY3BwCkBAIC0xMDczLDcgKzEwNzMsOCBAQCB2b2lkIEF1ZGlvQ29u dGV4dDo6aXNQbGF5aW5nQXVkaW9EaWRDaGFuZ2UoKQogICAgIC8vIHdlIGNvdWxkIGJlIG9uIHRo ZSBhdWRpbyBJL08gdGhyZWFkIGhlcmUgYW5kIHRoZSBjYWxsIGludG8gV2ViQ29yZSBjb3VsZCBi bG9jay4KICAgICBSZWZQdHI8QXVkaW9Db250ZXh0PiBzdHJvbmdUaGlzKHRoaXMpOwogICAgIGNh bGxPbk1haW5UaHJlYWQoW3N0cm9uZ1RoaXNdIHsKLSAgICAgICAgc3Ryb25nVGhpcy0+ZG9jdW1l bnQoKS0+dXBkYXRlSXNQbGF5aW5nTWVkaWEoKTsKKyAgICAgICAgaWYgKHN0cm9uZ1RoaXMtPmRv Y3VtZW50KCkpCisgICAgICAgICAgICBzdHJvbmdUaGlzLT5kb2N1bWVudCgpLT51cGRhdGVJc1Bs YXlpbmdNZWRpYSgpOwogICAgIH0pOwogfQogCi0tIAoyLjMuOCAoQXBwbGUgR2l0LTU4KQoK