147076 2015-07-18 17:52:48 -0700 MiniBrowser window title is just "Window" when page has no <title> 2015-07-18 20:46:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue mitz sam simon.fraser thorton oldest_to_newest 1110408 0 simon.fraser 2015-07-18 17:52:48 -0700 MiniBrowser window title is just "Window" when page has no <title> 1110409 1 257038 simon.fraser 2015-07-18 17:53:43 -0700 Created attachment 257038 Patch 1110413 2 257038 thorton 2015-07-18 18:43:33 -0700 Comment on attachment 257038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309 > + title = url.lastPathComponent; I'm assuming this was written for file:// URLs? It's going to look pretty silly on the web. > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:312 > + [self.window setTitle:[title stringByAppendingString:@" [WK1]"]]; Dots? 1110415 3 simon.fraser 2015-07-18 19:12:28 -0700 (In reply to comment #2) > Comment on attachment 257038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257038&action=review > > > Tools/MiniBrowser/mac/WK1BrowserWindowController.m:309 > > + title = url.lastPathComponent; > > I'm assuming this was written for file:// URLs? It's going to look pretty > silly on the web. Don't care! 1110434 4 257038 commit-queue 2015-07-18 20:39:03 -0700 Comment on attachment 257038 Patch Clearing flags on attachment: 257038 Committed r187007: <http://trac.webkit.org/changeset/187007> 1110435 5 commit-queue 2015-07-18 20:39:08 -0700 All reviewed patches have been landed. Closing bug. 1110436 6 257038 mitz 2015-07-18 20:46:27 -0700 Comment on attachment 257038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257038&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:527 > + [self updateTitle:nil]; Is this needed? It sounds like a bug if it is. 257038 2015-07-18 17:53:43 -0700 2015-07-18 20:39:03 -0700 Patch bug-147076-20150718175231.patch text/plain 4483 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MDAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjUzYmYyYmU2MWM1ZTNiYTFlZGZjNzRjYWEzNmM2MWI2 NGYzNmUzOC4uNGQzMDM2NmE3MjQ4MWNjZmE2NmVhNjJlNDE4NWI5YTBmMjAzZGQ1OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE1LTA3LTE4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIE1pbmlCcm93c2VyIHdpbmRvdyB0aXRsZSBpcyBqdXN0ICJXaW5kb3ciIHdoZW4g cGFnZSBoYXMgbm8gPHRpdGxlPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ3MDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIAorICAgICAgICBNYWtlIE1pbmlCcm93c2VyIHdpbmRvd3Mgc2hvdyB0aGUgZmls ZW5hbWUgZnJvbSB0aGUgVVJMIGlmIHdlIG5ldmVyIGdldCBhIHRpdGxlIGNoYW5nZWQKKyAgICAg ICAgbm90aWZpY2F0aW9uLgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL1dLMUJyb3dzZXJX aW5kb3dDb250cm9sbGVyLm06CisgICAgICAgICgtW1dLMUJyb3dzZXJXaW5kb3dDb250cm9sbGVy IHVwZGF0ZVRpdGxlOl0pOgorICAgICAgICAoLVtXSzFCcm93c2VyV2luZG93Q29udHJvbGxlciB3 ZWJWaWV3OmRpZENvbW1pdExvYWRGb3JGcmFtZTpdKToKKyAgICAgICAgKC1bV0sxQnJvd3Nlcldp bmRvd0NvbnRyb2xsZXIgd2ViVmlldzpkaWRSZWNlaXZlVGl0bGU6Zm9yRnJhbWU6XSk6CisgICAg ICAgICogTWluaUJyb3dzZXIvbWFjL1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyLm06CisgICAg ICAgICgtW1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyIHVwZGF0ZVRpdGxlOl0pOgorICAgICAg ICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxlciBvYnNlcnZlVmFsdWVGb3JLZXlQYXRoOm9m T2JqZWN0OmNoYW5nZTpjb250ZXh0Ol0pOgorICAgICAgICAoLVtXSzJCcm93c2VyV2luZG93Q29u dHJvbGxlciB3ZWJWaWV3OmRpZENvbW1pdE5hdmlnYXRpb246XSk6CisKIDIwMTUtMDctMTcgIEFu ZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEZ1cnRoZXIgdGln aHRlbiB0aGUgc2FuZGJveCBhcm91bmQgcGFnZXMgZmV0Y2hlZCB3aXRoIENvbnRlbnQtRGlzcG9z aXRpb246IGF0dGFjaG1lbnQKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL21hYy9XSzFC cm93c2VyV2luZG93Q29udHJvbGxlci5tIGIvVG9vbHMvTWluaUJyb3dzZXIvbWFjL1dLMUJyb3dz ZXJXaW5kb3dDb250cm9sbGVyLm0KaW5kZXggMTAzZDYyNmZiYTQ4ZmM5NWFhYjQwMmRhMDQ4MjI0 ZDQyYjM1YTRlYy4uY2ZmZDdmYjA3MjI1NjFjYjY2MjA2Y2NkMjYxZmE5OTk5YjY1ODVkNCAxMDA2 NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvbWFjL1dLMUJyb3dzZXJXaW5kb3dDb250cm9sbGVy Lm0KKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvbWFjL1dLMUJyb3dzZXJXaW5kb3dDb250cm9sbGVy Lm0KQEAgLTMwMiw2ICszMDIsMTYgQEAgLSAodm9pZCl3ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVy IGRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWU6KFdlYkZyYW1lICopZnIKIHsKIH0KIAor LSAodm9pZCl1cGRhdGVUaXRsZTooTlNTdHJpbmcgKil0aXRsZQoreworICAgIGlmICghdGl0bGUp IHsKKyAgICAgICAgTlNVUkwgKnVybCA9IF93ZWJWaWV3Lm1haW5GcmFtZS5kYXRhU291cmNlLnJl cXVlc3QuVVJMOworICAgICAgICB0aXRsZSA9IHVybC5sYXN0UGF0aENvbXBvbmVudDsKKyAgICB9 CisgICAgCisgICAgW3NlbGYud2luZG93IHNldFRpdGxlOlt0aXRsZSBzdHJpbmdCeUFwcGVuZGlu Z1N0cmluZzpAIiBbV0sxXSJdXTsKK30KKwogLSAodm9pZCl3ZWJWaWV3OihXZWJWaWV3ICopc2Vu ZGVyIGRpZENvbW1pdExvYWRGb3JGcmFtZTooV2ViRnJhbWUgKilmcmFtZQogewogICAgIGlmIChm cmFtZSAhPSBbc2VuZGVyIG1haW5GcmFtZV0pCkBAIC0zMDksNiArMzE5LDggQEAgLSAodm9pZCl3 ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIGRpZENvbW1pdExvYWRGb3JGcmFtZTooV2ViRnJhbWUg KilmcmFtZQogCiAgICAgTlNVUkwgKmNvbW1pdHRlZFVSTCA9IFtbW2ZyYW1lIGRhdGFTb3VyY2Vd IHJlcXVlc3RdIFVSTF07CiAgICAgW3VybFRleHQgc2V0U3RyaW5nVmFsdWU6W2NvbW1pdHRlZFVS TCBhYnNvbHV0ZVN0cmluZ11dOworCisgICAgW3NlbGYgdXBkYXRlVGl0bGU6bmlsXTsKIH0KIAog LSAodm9pZCl3ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIGRpZFJlY2VpdmVUaXRsZTooTlNTdHJp bmcgKil0aXRsZSBmb3JGcmFtZTooV2ViRnJhbWUgKilmcmFtZQpAQCAtMzE2LDcgKzMyOCw3IEBA IC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBkaWRSZWNlaXZlVGl0bGU6KE5TU3Ry aW5nICopdGl0bGUgZm9yRnJhbWU6KFdlCiAgICAgaWYgKGZyYW1lICE9IFtzZW5kZXIgbWFpbkZy YW1lXSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgW3NlbGYud2luZG93IHNldFRpdGxlOlt0aXRs ZSBzdHJpbmdCeUFwcGVuZGluZ1N0cmluZzpAIiBbV0sxXSJdXTsKKyAgICBbc2VsZiB1cGRhdGVU aXRsZTp0aXRsZV07CiB9CiAKIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBydW5K YXZhU2NyaXB0QWxlcnRQYW5lbFdpdGhNZXNzYWdlOihOU1N0cmluZyAqKW1lc3NhZ2UgaW5pdGlh dGVkQnlGcmFtZTooV2ViRnJhbWUgKilmcmFtZQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dz ZXIvbWFjL1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0gYi9Ub29scy9NaW5pQnJvd3Nlci9t YWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQppbmRleCBjOGU4Zjk1YTk4YjdiYmI4NTE4 M2Y2Yzg2NTcwOWIxZTY2M2QxZjkyLi43ZDI5ZWViMzE3M2ExZDdmYWRlNTZkNjA5Mzk2ZjU1ZjNi YjUzZjJjIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRv d0NvbnRyb2xsZXIubQorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRv d0NvbnRyb2xsZXIubQpAQCAtMzcxLDEzICszNzEsMjEgQEAgLSAodm9pZClkaWRDaGFuZ2VTZXR0 aW5ncwogICAgIHByZWZlcmVuY2VzLl92aXNpYmxlRGVidWdPdmVybGF5UmVnaW9ucyA9IHZpc2li bGVPdmVybGF5UmVnaW9uczsKIH0KIAorLSAodm9pZCl1cGRhdGVUaXRsZTooTlNTdHJpbmcgKil0 aXRsZQoreworICAgIGlmICghdGl0bGUpCisgICAgICAgIHRpdGxlID0gX3dlYlZpZXcuVVJMLmxh c3RQYXRoQ29tcG9uZW50OworICAgIAorICAgIHNlbGYud2luZG93LnRpdGxlID0gW05TU3RyaW5n IHN0cmluZ1dpdGhGb3JtYXQ6QCIlQCVAIFtXSzIgJWRdIiwgX2lzUHJpdmF0ZUJyb3dzaW5nV2lu ZG93ID8gQCLwn5mIICIgOiBAIiIsIHRpdGxlLCBfd2ViVmlldy5fd2ViUHJvY2Vzc0lkZW50aWZp ZXJdOworfQorCiAtICh2b2lkKW9ic2VydmVWYWx1ZUZvcktleVBhdGg6KE5TU3RyaW5nICopa2V5 UGF0aCBvZk9iamVjdDooaWQpb2JqZWN0IGNoYW5nZTooTlNEaWN0aW9uYXJ5ICopY2hhbmdlIGNv bnRleHQ6KHZvaWQgKiljb250ZXh0CiB7CiAgICAgaWYgKGNvbnRleHQgIT0ga2V5VmFsdWVPYnNl cnZpbmdDb250ZXh0IHx8IG9iamVjdCAhPSBfd2ViVmlldykKICAgICAgICAgcmV0dXJuOwogCiAg ICAgaWYgKFtrZXlQYXRoIGlzRXF1YWxUb1N0cmluZzpAInRpdGxlIl0pCi0gICAgICAgIHNlbGYu d2luZG93LnRpdGxlID0gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCIlQCVAIFtXSzIgJWRd IiwgX2lzUHJpdmF0ZUJyb3dzaW5nV2luZG93ID8gQCLwn5mIICIgOiBAIiIsIF93ZWJWaWV3LnRp dGxlLCBfd2ViVmlldy5fd2ViUHJvY2Vzc0lkZW50aWZpZXJdOworICAgICAgICBbc2VsZiB1cGRh dGVUaXRsZTpfd2ViVmlldy50aXRsZV07CiAgICAgZWxzZSBpZiAoW2tleVBhdGggaXNFcXVhbFRv U3RyaW5nOkAiVVJMIl0pCiAgICAgICAgIFtzZWxmIHVwZGF0ZVRleHRGaWVsZEZyb21VUkw6X3dl YlZpZXcuVVJMXTsKIH0KQEAgLTUxNiw2ICs1MjQsNyBAQCAtICh2b2lkKXdlYlZpZXc6KFdLV2Vi VmlldyAqKXdlYlZpZXcgZGlkRmFpbFByb3Zpc2lvbmFsTmF2aWdhdGlvbjooV0tOYXZpZ2F0aW9u CiAtICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgZGlkQ29tbWl0TmF2aWdhdGlv bjooV0tOYXZpZ2F0aW9uICopbmF2aWdhdGlvbgogewogICAgIExPRyhAImRpZENvbW1pdE5hdmln YXRpb246ICVAIiwgbmF2aWdhdGlvbik7CisgICAgW3NlbGYgdXBkYXRlVGl0bGU6bmlsXTsKIH0K IAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZEZpbmlzaExvYWRpbmdO YXZpZ2F0aW9uOihXS05hdmlnYXRpb24gKiluYXZpZ2F0aW9uCg==