147055 2015-07-17 15:54:45 -0700 REGRESSION (r186964): Crash in WebKit2.CloseFromWithinCreatePage 2015-07-17 21:04:32 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P1 Normal --- 1 mitz mitz achristensen sam oldest_to_newest 1110246 0 mitz 2015-07-17 15:54:45 -0700 http://trac.webkit.org/r186964 introduced a crash in WebKit2.CloseFromWithinCreatePage. 1110248 1 257002 mitz 2015-07-17 16:02:08 -0700 Created attachment 257002 Patch 1110251 2 257002 achristensen 2015-07-17 16:05:48 -0700 Comment on attachment 257002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257002&action=review > Source/WebKit2/ChangeLog:9 > + (WebKit::WebPageProxy::createNewPage): Grab the main frame’s URL before calling out to the non-ascii ' 1110252 3 mitz 2015-07-17 16:07:03 -0700 Fixed in <http://trac.webkit.org/r186969>. 1110323 4 ap 2015-07-17 20:53:47 -0700 Does this need a Radar? 1110326 5 mitz 2015-07-17 21:04:32 -0700 (In reply to comment #4) > Does this need a Radar? No, the fix is part of fixing the Radar for the change that caused the regression. 257002 2015-07-17 16:02:08 -0700 2015-07-17 16:05:48 -0700 Patch bug-147055-20150717160057.patch text/plain 1961 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Njk2NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTE3ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE4Njk2NCk6 IENyYXNoIGluIFdlYktpdDIuQ2xvc2VGcm9tV2l0aGluQ3JlYXRlUGFnZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3MDU1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpjcmVhdGVOZXdQYWdlKTog R3JhYiB0aGUgbWFpbiBmcmFtZeKAmXMgVVJMIGJlZm9yZSBjYWxsaW5nIG91dCB0byB0aGUKKyAg ICAgICAgY2xpZW50LCB3aG8gbWF5IGRlc3Ryb3kgdGhlIGZyYW1lLgorCiAyMDE1LTA3LTE3ICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBwYXJ0IG9m IDxyZGFyOi8vcHJvYmxlbS8yMTgwMzc4MT4gVGhlIGV4dGVybmFsIFVSTCBwb2xpY3kgaXMgbm90 IHJlcG9ydGVkIGNvcnJlY3RseSBpbiBuYXZpZ2F0aW9uIGFjdGlvbnMgdGhhdCBjcmVhdGUgbmV3 IHdpbmRvd3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CShyZXZpc2lvbiAxODY5NjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUyNiw2ICszNTI2LDggQEAgdm9pZCBXZWJQYWdl UHJveHk6OmNyZWF0ZU5ld1BhZ2UodWludDY0XwogICAgIFdlYkZyYW1lUHJveHkqIGZyYW1lID0g bV9wcm9jZXNzLT53ZWJGcmFtZShmcmFtZUlEKTsKICAgICBNRVNTQUdFX0NIRUNLKGZyYW1lKTsK IAorICAgIGF1dG8gbWFpbkZyYW1lVVJMID0gbV9tYWluRnJhbWUtPnVybCgpOworCiAgICAgUmVm UHRyPFdlYlBhZ2VQcm94eT4gbmV3UGFnZSA9IG1fdWlDbGllbnQtPmNyZWF0ZU5ld1BhZ2UodGhp cywgZnJhbWUsIHNlY3VyaXR5T3JpZ2luRGF0YSwgcmVxdWVzdCwgd2luZG93RmVhdHVyZXMsIG5h dmlnYXRpb25BY3Rpb25EYXRhKTsKICAgICBpZiAoIW5ld1BhZ2UpIHsKICAgICAgICAgbmV3UGFn ZUlEID0gMDsKQEAgLTM1MzYsNyArMzUzOCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpjcmVhdGVO ZXdQYWdlKHVpbnQ2NF8KICAgICBuZXdQYWdlUGFyYW1ldGVycyA9IG5ld1BhZ2UtPmNyZWF0aW9u UGFyYW1ldGVycygpOwogCiAgICAgV2Vic2l0ZURhdGFTdG9yZTo6Y2xvbmVTZXNzaW9uRGF0YSgq dGhpcywgKm5ld1BhZ2UpOwotICAgIG5ld1BhZ2UtPm1fc2hvdWxkU3VwcHJlc3NBcHBMaW5rc0lu TmV4dE5hdmlnYXRpb25Qb2xpY3lEZWNpc2lvbiA9IHByb3RvY29sSG9zdEFuZFBvcnRBcmVFcXVh bChVUkwoUGFyc2VkVVJMU3RyaW5nLCBtX21haW5GcmFtZS0+dXJsKCkpLCByZXF1ZXN0LnVybCgp KTsKKyAgICBuZXdQYWdlLT5tX3Nob3VsZFN1cHByZXNzQXBwTGlua3NJbk5leHROYXZpZ2F0aW9u UG9saWN5RGVjaXNpb24gPSBwcm90b2NvbEhvc3RBbmRQb3J0QXJlRXF1YWwoVVJMKFBhcnNlZFVS TFN0cmluZywgbWFpbkZyYW1lVVJMKSwgcmVxdWVzdC51cmwoKSk7CiB9CiAgICAgCiB2b2lkIFdl YlBhZ2VQcm94eTo6c2hvd1BhZ2UoKQo=