147025 2015-07-16 18:39:17 -0700 Web Inspector: REGRESSION (r186218) ScriptTimelineRecord attempts to access null property 2015-07-16 21:00:40 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1110046 0 mattbaker 2015-07-16 18:39:17 -0700 * SUMMARY ScriptTimelineRecord attempts to access null property. * STEPS TO REPRODUCE 1. Create a new timeline recording, one which includes script calls (Reloading daringfireball.net is sufficient) 2. Select the JavaScript & Events timeline 3. Select the Rendering Frames view => ScriptTimelineRecord:107: nodePayload has a property "calls", but it's null. * NOTES When the exception is thrown the nodePayload appears to be a ProfileNode rather than payload data. This explains why it has a "calls" property, however I'm not sure why we have a ProfileNode here, rather than payload data. 1110047 1 webkit-bug-importer 2015-07-16 18:39:50 -0700 <rdar://problem/21868062> 1110062 2 256950 joepeck 2015-07-16 19:35:46 -0700 Created attachment 256950 [PATCH] Proposed Fix 1110079 3 256950 commit-queue 2015-07-16 21:00:36 -0700 Comment on attachment 256950 [PATCH] Proposed Fix Clearing flags on attachment: 256950 Committed r186926: <http://trac.webkit.org/changeset/186926> 1110080 4 commit-queue 2015-07-16 21:00:40 -0700 All reviewed patches have been landed. Closing bug. 256950 2015-07-16 19:35:46 -0700 2015-07-16 21:00:36 -0700 [PATCH] Proposed Fix patch-2.patch text/plain 2983 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY1ZWJhMzUuLjI1MmU3ZDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDE1LTA3LTE2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTiAocjE4NjIxOCkgU2NyaXB0VGltZWxpbmVSZWNvcmQgYXR0ZW1wdHMgdG8gYWNjZXNzIG51 bGwgcHJvcGVydHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NzAyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBpc3N1ZSBoZXJlIHdhcyB0d28gU2NyaXB0VGltZWxpbmVSZWNvcmQncyB3ZXJlIGNy ZWF0ZWQgZm9yIHRoZSBzYW1lCisgICAgICAgIHByb2ZpbGUgcGF5bG9hZC4gV2hlbiB0aGUgZmly c3QgU2NyaXB0VGltZWxpbmVSZWNvcmQgcHJvY2Vzc2VkIHRoZQorICAgICAgICBwYXlsb2FkIHRv IGNyZWF0ZSBhIFByb2ZpbGUgd2UgbW9kaWZpZWQgdGhlIHBheWxvYWQsIHRoZW4gd2hlbiB0aGUK KyAgICAgICAgc2Vjb25kIFNjcmlwdFRpbWVsaW5lUmVjb3JkIHRyaWVzIHRvIHByb2Nlc3MgdGhl IHBheWxvYWQgdGhlIGRhdGEgaXMKKyAgICAgICAgaW4gYW4gdW5leHBlY3RlZCBzdGF0ZSBhbmQg aXQgY3Jhc2hlcy4KKworICAgICAgICBUaGUgc29sdXRpb24gaGVyZSBpcyB0byBzdGFzaCB0aGUg cmVzdWx0IG9uIHRoZSBwYXlsb2FkLCBzbyB3aGVuIHRoZQorICAgICAgICBwYXlsb2FkIGlzIHNo YXJlZCB3ZSBjYW4ganVzdCBpbW1lZGlhdGVseSBqdW1wIHRvIHRoZSByZXN1bHRpbmcgUHJvZmls ZS4KKyAgICAgICAgVGhlIGxvbmdlciB0ZXJtIHNvbHV0aW9uIHdpbGwgYmUgdG8gc2hhcmUgaGln aGVyIGxldmVsIG9iamVjdHMgYW5kIG5vdAorICAgICAgICBhdHRlbXB0IHRvIHByb2Nlc3MgdGhl IHBheWxvYWQgbXVsdGlwbGUgdGltZXMuIFRoYXQgaXMgdHJhY2tlZCBieToKKyAgICAgICAgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzE0NzAyOT4gV2ViIEluc3BlY3RvcjogQmV0dGVyIHNoYXJlIG9i amVjdHMgZ2VuZXJhdGVkIGZyb20gdGltZWxpbmUgZXZlbnRzIChSZWNvcmRzKQorCisgICAgICAg ICogVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0VGltZWxpbmVSZWNvcmQuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU2NyaXB0VGltZWxpbmVSZWNvcmQucHJvdG90eXBlLl9pbml0aWFsaXpl UHJvZmlsZUZyb21QYXlsb2FkKToKKyAgICAgICAgV2hlbiBwcm9jZXNzaW5nIHRoZSBwcm9maWxl IHBheWxvYWQsIHN0b3JlIHRoZSBQcm9maWxlIG9uIHRoZSBwYXlsb2FkCisgICAgICAgIHNvIGlm IGFub3RoZXIgU2NyaXB0VGltZWxpbmVSZWNvcmQgaGFzIHRoYXQgcGF5bG9hZCB0aGV5IGNhbiBh dm9pZAorICAgICAgICByZS1wcm9jZXNzaW5nIGl0LgorCisyMDE1LTA3LTE2ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVG90 YWwgU2l6ZSBvZiBSZXNvdXJjZXMgbnVtYmVyIGluIGRhc2hib2FyZCBpcyB3cm9uZyAoZG9lcyBu b3QgdXBkYXRlIGR1cmluZyBsb2FkKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ3MDI3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5q cwppbmRleCBiNWQ3OThjLi43ZTIzMTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0VGltZWxpbmVSZWNvcmQuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFRpbWVsaW5lUmVj b3JkLmpzCkBAIC03Myw2ICs3MywxMyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0VGltZWxpbmVSZWNv cmQgPSBjbGFzcyBTY3JpcHRUaW1lbGluZVJlY29yZCBleHRlbmRzIFdlYkluc3BlYwogICAgICAg ICBpZiAodGhpcy5fcHJvZmlsZSB8fCAhdGhpcy5fcHJvZmlsZVBheWxvYWQpCiAgICAgICAgICAg ICByZXR1cm47CiAKKyAgICAgICAgLy8gRklYTUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDcw Mjk+IFdlYiBJbnNwZWN0b3I6IEJldHRlciBzaGFyZSBvYmplY3RzIGdlbmVyYXRlZCBmcm9tIHRp bWVsaW5lIGV2ZW50cyAoUmVjb3JkcykKKyAgICAgICAgaWYgKHRoaXMuX3Byb2ZpbGVQYXlsb2Fk Ll9fcHJvZmlsZSkgeworICAgICAgICAgICAgdGhpcy5fcHJvZmlsZSA9IHRoaXMuX3Byb2ZpbGVQ YXlsb2FkLl9fcHJvZmlsZTsKKyAgICAgICAgICAgIHRoaXMuX3Byb2ZpbGVQYXlsb2FkID0gdW5k ZWZpbmVkOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKICAgICAgICAgdmFyIHBh eWxvYWQgPSB0aGlzLl9wcm9maWxlUGF5bG9hZDsKICAgICAgICAgdGhpcy5fcHJvZmlsZVBheWxv YWQgPSB1bmRlZmluZWQ7CiAKQEAgLTE0NCw3ICsxNTEsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0 VGltZWxpbmVSZWNvcmQgPSBjbGFzcyBTY3JpcHRUaW1lbGluZVJlY29yZCBleHRlbmRzIFdlYklu c3BlYwogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5fcHJvZmlsZSA9 IG5ldyBXZWJJbnNwZWN0b3IuUHJvZmlsZShyb290Tm9kZXMpOworICAgICAgICB0aGlzLl9wcm9m aWxlID0gcGF5bG9hZC5fX3Byb2ZpbGUgPSBuZXcgV2ViSW5zcGVjdG9yLlByb2ZpbGUocm9vdE5v ZGVzKTsKICAgICB9CiB9OwogCg==