147019 2015-07-16 14:42:59 -0700 Fix disappearing position:fixed elemnets in fixed layout mode 2015-08-04 07:57:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 147627 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1109982 0 simon.fraser 2015-07-16 14:42:59 -0700 Fix disappearing position:fixed elemnets in fixed layout mode 1109985 1 256929 simon.fraser 2015-07-16 14:48:55 -0700 Created attachment 256929 Patch 1109986 2 256929 thorton 2015-07-16 14:51:30 -0700 Comment on attachment 256929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256929&action=review > Source/WebCore/ChangeLog:3 > + Fix disappearing position:fixed elemnets in fixed layout mode elemnets > Source/WebCore/rendering/RenderLayerCompositor.cpp:2745 > + viewBounds = m_renderView.unscaledDocumentRect(); we want to use the document rect and not the scrolled fixed layout size? I guess it doesn't really matter, this will only ever be bigger 1109989 3 simon.fraser 2015-07-16 14:56:21 -0700 https://trac.webkit.org/r186911 rdar://problem/21822541 256929 2015-07-16 14:48:55 -0700 2015-07-16 14:51:30 -0700 Patch bug-147019-20150716144746.patch text/plain 6733 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2Nzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdlZWJlZjBkNWNiZmFk YTA1MzdkMDgzZGQ4NjY0N2Q4ZjJkZWQzYi4uYjI2NTMyYTlkMGNmYTM0ODkxY2I3OGZjZDM2MGNm N2QxOTFkZjRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA3LTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBkaXNhcHBl YXJpbmcgcG9zaXRpb246Zml4ZWQgZWxlbW5ldHMgaW4gZml4ZWQgbGF5b3V0IG1vZGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzAxOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0 aW5nL2ZpeGVkLXdpdGgtZml4ZWQtbGF5b3V0Lmh0bWwKKyAgICAgICAgCisgICAgICAgIFdoZW4g aW4gZml4ZWQgbGF5b3V0IG1vZGUsIGFuZCBiZWluZyBzY2FsZWQgZG93biwgdmlld3BvcnRDb25z dHJhaW5lZFZpc2libGVDb250ZW50UmVjdCgpIGlzCisgICAgICAgIHRoZSB3cm9uZyB0aGluZyB0 byB1c2UgdG8gZGV0ZXJtaW5lIGlmIHBvc2l0aW9uOmZpeGVkIGVsZW1lbnRzIGFyZSBjbGlwcGVk IG91dC4gSW4gdGhpcyBjYXNlLAorICAgICAgICB1c2UgdGhlIHNpbXBsZXIgZG9jdW1lbnQgYm91 bmRzIChiZWZvcmUgc2NhbGluZykuCisgICAgICAgIAorICAgICAgICBJbiB0aGUgbG9uZyB0ZXJt LCAgdGhlcmUgbmVlZHMgdG8gYmUgYW4gZXF1aXZhbGVudCBvZiB2aWV3cG9ydENvbnN0cmFpbmVk VmlzaWJsZUNvbnRlbnRSZWN0KCkKKyAgICAgICAgdGhhdCBnaXZlcyBhbiBhcHByb3ByaWF0ZSBy ZWN0IHRoYXQgY2FuIGJlIHVzZWQgaGVyZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3Np dG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nRm9yUG9zaXRpb24pOgorCiAyMDE1LTA3LTEzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgV0syXSBX aGVuIGNob29zaW5nIGFuIGluaXRpYWwgdmlld3BvcnQgc2NhbGUsIHRha2Ugb3ZlcmZsb3cgb24g dGhlIDxib2R5PiBpbnRvIGFjY291bnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggYjllMDYyYWYzZmYxODE4YmJhYTFiNzQy OTg1ODAyZjdkNjUxNTNlYS4uMDQzYTI0YTFjMjA3OTBmOGVjYjQyMWRkOGI4OTVhMTkwMzIyMzU4 ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKQEAgLTI3MzksNyArMjczOSwxMiBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRv cjo6cmVxdWlyZXNDb21wb3NpdGluZ0ZvclBvc2l0aW9uKFJlbmRlckxheWVyTW9kZWxPYmplYwog ICAgIH0KIAogICAgIC8vIEZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzIHRoYXQgYXJlIGludmlzaWJs ZSBpbiB0aGUgY3VycmVudCB2aWV3IGRvbid0IGdldCB0aGVpciBvd24gbGF5ZXIuCi0gICAgTGF5 b3V0UmVjdCB2aWV3Qm91bmRzID0gbV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLnZpZXdwb3J0Q29u c3RyYWluZWRWaXNpYmxlQ29udGVudFJlY3QoKTsKKyAgICAvLyBGSVhNRTogV2Ugc2hvdWxkbid0 IGhhdmUgdG8gY2hlY2sgdXNlRml4ZWRMYXlvdXQoKSBoZXJlOyBvbmUgb2YgdGhlIHZpZXdwb3J0 IHJlY3RzIG5lZWRzIHRvIGdpdmUgdGhlIGNvcnJlY3QgYW5zd2VyLgorICAgIExheW91dFJlY3Qg dmlld0JvdW5kczsKKyAgICBpZiAobV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLnVzZUZpeGVkTGF5 b3V0KCkpCisgICAgICAgIHZpZXdCb3VuZHMgPSBtX3JlbmRlclZpZXcudW5zY2FsZWREb2N1bWVu dFJlY3QoKTsKKyAgICBlbHNlCisgICAgICAgIHZpZXdCb3VuZHMgPSBtX3JlbmRlclZpZXcuZnJh bWVWaWV3KCkudmlld3BvcnRDb25zdHJhaW5lZFZpc2libGVDb250ZW50UmVjdCgpOwogICAgIExh eW91dFJlY3QgbGF5ZXJCb3VuZHMgPSBsYXllci5jYWxjdWxhdGVMYXllckJvdW5kcygmbGF5ZXIs IExheW91dFNpemUoKSwgUmVuZGVyTGF5ZXI6OlVzZUxvY2FsQ2xpcFJlY3RJZlBvc3NpYmxlIHwg UmVuZGVyTGF5ZXI6OkluY2x1ZGVMYXllckZpbHRlck91dHNldHMgfCBSZW5kZXJMYXllcjo6VXNl RnJhZ21lbnRCb3hlc0V4Y2x1ZGluZ0NvbXBvc2l0aW5nCiAgICAgICAgIHwgUmVuZGVyTGF5ZXI6 OkV4Y2x1ZGVIaWRkZW5EZXNjZW5kYW50cyB8IFJlbmRlckxheWVyOjpEb250Q29uc3RyYWluRm9y TWFzayB8IFJlbmRlckxheWVyOjpJbmNsdWRlQ29tcG9zaXRlZERlc2NlbmRhbnRzKTsKICAgICAv LyBNYXAgdG8gbV9yZW5kZXJWaWV3IHRvIGlnbm9yZSBwYWdlIHNjYWxlLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGViZjM4 MTA0NDg3MzcyY2U3ZDk2ZjVlODg4MGE3MThiMjE0NTRkY2MuLjZlOGNmYTFlZTEwYWVhZDE2YTJj YzUwYjk1NmIzOTRiZmRmZTYzOTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wNy0xNiAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggZGlz YXBwZWFyaW5nIHBvc2l0aW9uOmZpeGVkIGVsZW1uZXRzIGluIGZpeGVkIGxheW91dCBtb2RlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDcwMTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRl c3Qgd2l0aCBmb3VyIGZpeGVkIGVsZW1lbnRzIGluIGZpeGVkIGxheW91dCBtb2RlLgorCisgICAg ICAgICogY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1maXhlZC1sYXlvdXQtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBjb21wb3NpdGluZy9maXhlZC13aXRoLWZpeGVkLWxheW91dC5odG1s OiBBZGRlZC4KKwogMjAxNS0wNy0xMyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBbV2luXSBTa2lwIGZhaWxpbmcgdGFibGUtcmVsYXRlZCBBWCB0ZXN0cwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1maXhlZC1sYXlv dXQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1maXhl ZC1sYXlvdXQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjgwNDJiZDVhYmE0NTk1ZGY2ZTQ1MzM4 MDkwNzgyMTA1MGYyMzE2MGQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3Np dGluZy9maXhlZC13aXRoLWZpeGVkLWxheW91dC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzNSBA QAorVG9wIExlZnQgUmlnaHQgYm90dG9tCisoR3JhcGhpY3NMYXllcgorICAoYW5jaG9yIDAuMDAg MC4wMCkKKyAgKGJvdW5kcyA4MDYuMDAgMTYxNi4wMCkKKyAgKGNoaWxkcmVuIDEKKyAgICAoR3Jh cGhpY3NMYXllcgorICAgICAgKGFuY2hvciAwLjAwIDAuMDApCisgICAgICAoYm91bmRzIDEwMDgu MDAgMjAyMS4wMCkKKyAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAgICAgKHRyYW5zZm9ybSBb MC44MCAwLjAwIDAuMDAgMC4wMF0gWzAuMDAgMC44MCAwLjAwIDAuMDBdIFswLjAwIDAuMDAgMS4w MCAwLjAwXSBbMC4wMCAwLjAwIDAuMDAgMS4wMF0pCisgICAgICAoY2hpbGRyZW4gNAorICAgICAg ICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgIChib3VuZHMgMTAwMC4wMCAxMDAuMDApCisgICAg ICAgICAgKGRyYXdzQ29udGVudCAxKQorICAgICAgICApCisgICAgICAgIChHcmFwaGljc0xheWVy CisgICAgICAgICAgKHBvc2l0aW9uIDAuMDAgMjAwLjAwKQorICAgICAgICAgIChib3VuZHMgMTAw LjAwIDEwMC4wMCkKKyAgICAgICAgICAoZHJhd3NDb250ZW50IDEpCisgICAgICAgICkKKyAgICAg ICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgICAgICAocG9zaXRpb24gOTAwLjAwIDIwMC4wMCkKKyAg ICAgICAgICAoYm91bmRzIDEwMC4wMCAxMDAuMDApCisgICAgICAgICAgKGRyYXdzQ29udGVudCAx KQorICAgICAgICApCisgICAgICAgIChHcmFwaGljc0xheWVyCisgICAgICAgICAgKHBvc2l0aW9u IDAuMDAgMTkwMC4wMCkKKyAgICAgICAgICAoYm91bmRzIDEwMDAuMDAgMTAwLjAwKQorICAgICAg ICAgIChkcmF3c0NvbnRlbnQgMSkKKyAgICAgICAgKQorICAgICAgKQorICAgICkKKyAgKQorKQor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9maXhlZC13aXRoLWZpeGVkLWxh eW91dC5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0aC1maXhlZC1sYXlv dXQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi45YzA2NzEyZGY2ZGMyNDliZGI4NzZjZDk5NGVmMTgxYzM4ZDdm ODRiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtd2l0 aC1maXhlZC1sYXlvdXQuaHRtbApAQCAtMCwwICsxLDg3IEBACis8IURPQ1RZUEUgaHRtbD4KKwor PGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAgIGJvZHkgeworICAgICAgICAgICAg aGVpZ2h0OiAyMDAwcHg7CisgICAgICAgICAgICB3aWR0aDogMTAwMHB4OworICAgICAgICB9Cisg ICAgICAgIAorICAgICAgICAuZml4ZWQgeworICAgICAgICAgICAgcG9zaXRpb246IGZpeGVkOwor ICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAgIHdpZHRoOiAxMDBweDsKKyAg ICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMCwgMCwgMCwgMC41KTsKKyAgICAgICAg fQorICAgICAgICAKKyAgICAgICAgLnRvcCwgLmJvdHRvbSB7CisgICAgICAgICAgICBsZWZ0OiAw OworICAgICAgICAgICAgd2lkdGg6IDEwMCU7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAg IC5sZWZ0LCAucmlnaHQgeworICAgICAgICAgICAgdG9wOiAyMDBweDsKKyAgICAgICAgfQorICAg ICAgICAKKyAgICAgICAgLnRvcCB7CisgICAgICAgICAgICB0b3A6IDA7CisgICAgICAgIH0KKyAg ICAgICAgCisgICAgICAgIC5ib3R0b20geworICAgICAgICAgICAgYm90dG9tOiAwOworICAgICAg ICB9CisgICAgICAgIC5sZWZ0IHsKKyAgICAgICAgICAgIGxlZnQ6IDA7CisgICAgICAgIH0KKyAg ICAgICAgLnJpZ2h0IHsKKyAgICAgICAgICAgIHJpZ2h0OiAwOworICAgICAgICB9CisgICAgPC9z dHlsZT4KKyAgICA8c2NyaXB0PgorICAgICAgICAKKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVu bmVyKSB7CisgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAg IHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICB9CisKKyAgICAgICAgaWYgKHdp bmRvdy5pbnRlcm5hbHMpIHsKKyAgICAgICAgICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRBY2Nl bGVyYXRlZENvbXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQodHJ1ZSk7CisgICAgICAg ICAgICBpbnRlcm5hbHMuc2V0VXNlRml4ZWRMYXlvdXQodHJ1ZSk7CisgICAgICAgICAgICBpbnRl cm5hbHMuc2V0Rml4ZWRMYXlvdXRTaXplKDEwMDAsIDIwMDApOworICAgICAgICAgICAgdmFyIHNj YWxlID0gODAwIC8gMTAwMDsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLnNjYWxlUGFnZUJ5KHNj YWxlLCBzY2FsZSk7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIGZ1bmN0aW9uIGRvVGVz dCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkg eworICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJsYXllclRyZWUiKS5p bm5lclRleHQgPSB3aW5kb3cuaW50ZXJuYWxzLmxheWVyVHJlZUFzVGV4dChkb2N1bWVudCk7Cisg ICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgICAgICB9LCAw KTsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIo J2xvYWQnLCBkb1Rlc3QsIGZhbHNlKTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5Pgor Cis8ZGl2IGNsYXNzPSJ0b3AgZml4ZWQiPgorICAgIFRvcAorPC9kaXY+CisKKzxkaXYgY2xhc3M9 ImxlZnQgZml4ZWQiPgorICAgIExlZnQKKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJyaWdodCBmaXhl ZCI+CisgICAgUmlnaHQKKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJib3R0b20gZml4ZWQiPgorICAg IGJvdHRvbQorPC9kaXY+CisKKzxwcmUgaWQ9ImxheWVyVHJlZSI+PC9wcmU+Cis8L2JvZHk+Cis8 L2h0bWw+Cg==