147015 2015-07-16 14:12:13 -0700 WebsiteDataStore operations need to grab background assertions 2015-07-20 10:10:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca mitz oldest_to_newest 1109963 0 andersca 2015-07-16 14:12:13 -0700 WebsiteDataStore operations need to grab background assertions 1109964 1 256924 andersca 2015-07-16 14:12:43 -0700 Created attachment 256924 Patch 1109975 2 256924 mitz 2015-07-16 14:34:23 -0700 Comment on attachment 256924 Patch We normally have the callers create the callbacks using the create function that takes an activity token. That’s why we added that parameter. Can you follow that established pattern in this case? 1109978 3 mitz 2015-07-16 14:39:25 -0700 (In reply to comment #2) > Comment on attachment 256924 [details] > Patch > > We normally have the callers create the callbacks using the create function > that takes an activity token. That’s why we added that parameter. Can you > follow that established pattern in this case? I forgot to mention that we normally do this using CallbackMap. 1110154 4 andersca 2015-07-17 10:34:20 -0700 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 256924 [details] > > Patch > > > > We normally have the callers create the callbacks using the create function > > that takes an activity token. That’s why we added that parameter. Can you > > follow that established pattern in this case? > > I forgot to mention that we normally do this using CallbackMap. I'm not going to make such an invasive change at this point. 1110202 5 256924 sam 2015-07-17 14:06:35 -0700 Comment on attachment 256924 Patch Seems worth adding FIXMEs about using CallbackMap in the future. 1110645 6 andersca 2015-07-20 10:09:28 -0700 Committed r187023: <http://trac.webkit.org/changeset/187023> 1110646 7 andersca 2015-07-20 10:10:49 -0700 (In reply to comment #5) > Comment on attachment 256924 [details] > Patch > > Seems worth adding FIXMEs about using CallbackMap in the future. The ability to do async messages with replies should be built into IPC::Connection, not layered on top of it. 256924 2015-07-16 14:12:43 -0700 2015-07-17 14:06:00 -0700 Patch bug-147015-20150716141134.patch text/plain 5340 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzliMmRlNWRhYjRiNTYw ZjhmODMyYTljODcwOTE2MmFkY2YzNWY1MS4uMjdkMGYzYjM5ZjE4MzM4Njg5MzlhZDFlNjA3YTli Y2M2ODg0YmE3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA3LTE2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vic2l0ZURhdGFT dG9yZSBvcGVyYXRpb25zIG5lZWQgdG8gZ3JhYiBiYWNrZ3JvdW5kIGFzc2VydGlvbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzAxNQorICAgICAg ICByZGFyOi8vcHJvYmxlbS8yMTc5OTAxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94 eS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzUHJveHk6OmZldGNoV2Vic2l0 ZURhdGEpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc1Byb3h5OjpkZWxldGVXZWJz aXRlRGF0YSk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzUHJveHk6OmRlbGV0ZVdl YnNpdGVEYXRhRm9yT3JpZ2lucyk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94 eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6ZmV0Y2hXZWJzaXRlRGF0 YSk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6ZGVsZXRlV2Vic2l0ZURhdGEp OgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmRlbGV0ZVdlYnNpdGVEYXRhRm9y T3JpZ2lucyk6CisKIDIwMTUtMDctMTYgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFtMaW51eF0gU2VjY29tcDogZml4IC1XbWlzbWF0Y2hlZC10 YWdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3Jr UHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdv cmtQcm9jZXNzUHJveHkuY3BwCmluZGV4IDA4ZDFlNTE4N2Q2YTg1MjkzNThhMGE0ZDZhOWM1YTVm NjdmZThkNDguLmZmOTY1MDc2ODgzZmU0MWY1YjVhMWVlMzRlMzE1NjdkYjc3NDk3YWUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJv eHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9j ZXNzUHJveHkuY3BwCkBAIC0xMjUsNyArMTI1LDExIEBAIHZvaWQgTmV0d29ya1Byb2Nlc3NQcm94 eTo6ZmV0Y2hXZWJzaXRlRGF0YShTZXNzaW9uSUQgc2Vzc2lvbklELCBXZWJzaXRlRGF0YVR5cGVz CiAgICAgQVNTRVJUKGNhblNlbmRNZXNzYWdlKCkpOwogCiAgICAgdWludDY0X3QgY2FsbGJhY2tJ RCA9IGdlbmVyYXRlQ2FsbGJhY2tJRCgpOwotICAgIG1fcGVuZGluZ0ZldGNoV2Vic2l0ZURhdGFD YWxsYmFja3MuYWRkKGNhbGxiYWNrSUQsIFdURjo6bW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwor ICAgIGF1dG8gdG9rZW4gPSB0aHJvdHRsZXIoKS5iYWNrZ3JvdW5kQWN0aXZpdHlUb2tlbigpOwor CisgICAgbV9wZW5kaW5nRmV0Y2hXZWJzaXRlRGF0YUNhbGxiYWNrcy5hZGQoY2FsbGJhY2tJRCwg W3Rva2VuLCBjb21wbGV0aW9uSGFuZGxlcl0oV2Vic2l0ZURhdGEgd2Vic2l0ZURhdGEpIHsKKyAg ICAgICAgY29tcGxldGlvbkhhbmRsZXIoV1RGOjptb3ZlKHdlYnNpdGVEYXRhKSk7CisgICAgfSk7 CiAKICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQcm9jZXNzOjpGZXRjaFdlYnNpdGVEYXRhKHNlc3Np b25JRCwgZGF0YVR5cGVzLCBjYWxsYmFja0lEKSwgMCk7CiB9CkBAIC0xMzMsOCArMTM3LDExIEBA IHZvaWQgTmV0d29ya1Byb2Nlc3NQcm94eTo6ZmV0Y2hXZWJzaXRlRGF0YShTZXNzaW9uSUQgc2Vz c2lvbklELCBXZWJzaXRlRGF0YVR5cGVzCiB2b2lkIE5ldHdvcmtQcm9jZXNzUHJveHk6OmRlbGV0 ZVdlYnNpdGVEYXRhKFdlYkNvcmU6OlNlc3Npb25JRCBzZXNzaW9uSUQsIFdlYnNpdGVEYXRhVHlw ZXMgZGF0YVR5cGVzLCBzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1lX3BvaW50IG1vZGlm aWVkU2luY2UsICBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGNvbXBsZXRpb25IYW5kbGVyKQogewog ICAgIGF1dG8gY2FsbGJhY2tJRCA9IGdlbmVyYXRlQ2FsbGJhY2tJRCgpOworICAgIGF1dG8gdG9r ZW4gPSB0aHJvdHRsZXIoKS5iYWNrZ3JvdW5kQWN0aXZpdHlUb2tlbigpOwogCi0gICAgbV9wZW5k aW5nRGVsZXRlV2Vic2l0ZURhdGFDYWxsYmFja3MuYWRkKGNhbGxiYWNrSUQsIFdURjo6bW92ZShj b21wbGV0aW9uSGFuZGxlcikpOworICAgIG1fcGVuZGluZ0RlbGV0ZVdlYnNpdGVEYXRhQ2FsbGJh Y2tzLmFkZChjYWxsYmFja0lELCBbdG9rZW4sIGNvbXBsZXRpb25IYW5kbGVyXSB7CisgICAgICAg IGNvbXBsZXRpb25IYW5kbGVyKCk7CisgICAgfSk7CiAgICAgc2VuZChNZXNzYWdlczo6TmV0d29y a1Byb2Nlc3M6OkRlbGV0ZVdlYnNpdGVEYXRhKHNlc3Npb25JRCwgZGF0YVR5cGVzLCBtb2RpZmll ZFNpbmNlLCBjYWxsYmFja0lEKSwgMCk7CiB9CiAKQEAgLTE0Myw3ICsxNTAsMTEgQEAgdm9pZCBO ZXR3b3JrUHJvY2Vzc1Byb3h5OjpkZWxldGVXZWJzaXRlRGF0YUZvck9yaWdpbnMoU2Vzc2lvbklE IHNlc3Npb25JRCwgV2Vic2kKICAgICBBU1NFUlQoY2FuU2VuZE1lc3NhZ2UoKSk7CiAKICAgICB1 aW50NjRfdCBjYWxsYmFja0lEID0gZ2VuZXJhdGVDYWxsYmFja0lEKCk7Ci0gICAgbV9wZW5kaW5n RGVsZXRlV2Vic2l0ZURhdGFGb3JPcmlnaW5zQ2FsbGJhY2tzLmFkZChjYWxsYmFja0lELCBXVEY6 Om1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICBhdXRvIHRva2VuID0gdGhyb3R0bGVyKCku YmFja2dyb3VuZEFjdGl2aXR5VG9rZW4oKTsKKworICAgIG1fcGVuZGluZ0RlbGV0ZVdlYnNpdGVE YXRhRm9yT3JpZ2luc0NhbGxiYWNrcy5hZGQoY2FsbGJhY2tJRCwgW3Rva2VuLCBjb21wbGV0aW9u SGFuZGxlcl0geworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcigpOworICAgIH0pOwogCiAgICAg VmVjdG9yPFNlY3VyaXR5T3JpZ2luRGF0YT4gb3JpZ2luRGF0YTsKICAgICBmb3IgKGF1dG8mIG9y aWdpbiA6IG9yaWdpbnMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJv eHkuY3BwCmluZGV4IDBmYjBiMDNmOGE5YjcxNjljNWY5OTYyMTJhMjM4ZWNmYWIwYzlmN2MuLmFi OTZlODIxNDljODY1YWI2ZDhhNTI4MzRiZjE4YmIxNDEwZGY1MTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCkBAIC03MTMsNyArNzEzLDExIEBAIHZv aWQgV2ViUHJvY2Vzc1Byb3h5OjpmZXRjaFdlYnNpdGVEYXRhKFNlc3Npb25JRCBzZXNzaW9uSUQs IFdlYnNpdGVEYXRhVHlwZXMgZGF0CiAgICAgQVNTRVJUKGNhblNlbmRNZXNzYWdlKCkpOwogCiAg ICAgdWludDY0X3QgY2FsbGJhY2tJRCA9IGdlbmVyYXRlQ2FsbGJhY2tJRCgpOwotICAgIG1fcGVu ZGluZ0ZldGNoV2Vic2l0ZURhdGFDYWxsYmFja3MuYWRkKGNhbGxiYWNrSUQsIFdURjo6bW92ZShj b21wbGV0aW9uSGFuZGxlcikpOworICAgIGF1dG8gdG9rZW4gPSB0aHJvdHRsZXIoKS5iYWNrZ3Jv dW5kQWN0aXZpdHlUb2tlbigpOworCisgICAgbV9wZW5kaW5nRmV0Y2hXZWJzaXRlRGF0YUNhbGxi YWNrcy5hZGQoY2FsbGJhY2tJRCwgW3Rva2VuLCBjb21wbGV0aW9uSGFuZGxlcl0oV2Vic2l0ZURh dGEgd2Vic2l0ZURhdGEpIHsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoV1RGOjptb3ZlKHdl YnNpdGVEYXRhKSk7CisgICAgfSk7CiAKICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQcm9jZXNzOjpG ZXRjaFdlYnNpdGVEYXRhKHNlc3Npb25JRCwgZGF0YVR5cGVzLCBjYWxsYmFja0lEKSwgMCk7CiB9 CkBAIC03MjMsOCArNzI3LDExIEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpkZWxldGVXZWJzaXRl RGF0YShTZXNzaW9uSUQgc2Vzc2lvbklELCBXZWJzaXRlRGF0YVR5cGVzIGRhCiAgICAgQVNTRVJU KGNhblNlbmRNZXNzYWdlKCkpOwogCiAgICAgdWludDY0X3QgY2FsbGJhY2tJRCA9IGdlbmVyYXRl Q2FsbGJhY2tJRCgpOworICAgIGF1dG8gdG9rZW4gPSB0aHJvdHRsZXIoKS5iYWNrZ3JvdW5kQWN0 aXZpdHlUb2tlbigpOwogCi0gICAgbV9wZW5kaW5nRGVsZXRlV2Vic2l0ZURhdGFDYWxsYmFja3Mu YWRkKGNhbGxiYWNrSUQsIFdURjo6bW92ZShjb21wbGV0aW9uSGFuZGxlcikpOworICAgIG1fcGVu ZGluZ0RlbGV0ZVdlYnNpdGVEYXRhQ2FsbGJhY2tzLmFkZChjYWxsYmFja0lELCBbdG9rZW4sIGNv bXBsZXRpb25IYW5kbGVyXSB7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKCk7CisgICAgfSk7 CiAgICAgc2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzczo6RGVsZXRlV2Vic2l0ZURhdGEoc2Vzc2lv bklELCBkYXRhVHlwZXMsIG1vZGlmaWVkU2luY2UsIGNhbGxiYWNrSUQpLCAwKTsKIH0KIApAQCAt NzMzLDcgKzc0MCwxMSBAQCB2b2lkIFdlYlByb2Nlc3NQcm94eTo6ZGVsZXRlV2Vic2l0ZURhdGFG b3JPcmlnaW5zKFNlc3Npb25JRCBzZXNzaW9uSUQsIFdlYnNpdGVEYQogICAgIEFTU0VSVChjYW5T ZW5kTWVzc2FnZSgpKTsKIAogICAgIHVpbnQ2NF90IGNhbGxiYWNrSUQgPSBnZW5lcmF0ZUNhbGxi YWNrSUQoKTsKLSAgICBtX3BlbmRpbmdEZWxldGVXZWJzaXRlRGF0YUZvck9yaWdpbnNDYWxsYmFj a3MuYWRkKGNhbGxiYWNrSUQsIFdURjo6bW92ZShjb21wbGV0aW9uSGFuZGxlcikpOworICAgIGF1 dG8gdG9rZW4gPSB0aHJvdHRsZXIoKS5iYWNrZ3JvdW5kQWN0aXZpdHlUb2tlbigpOworCisgICAg bV9wZW5kaW5nRGVsZXRlV2Vic2l0ZURhdGFGb3JPcmlnaW5zQ2FsbGJhY2tzLmFkZChjYWxsYmFj a0lELCBbdG9rZW4sIGNvbXBsZXRpb25IYW5kbGVyXSB7CisgICAgICAgIGNvbXBsZXRpb25IYW5k bGVyKCk7CisgICAgfSk7CiAKICAgICBWZWN0b3I8U2VjdXJpdHlPcmlnaW5EYXRhPiBvcmlnaW5E YXRhOwogICAgIGZvciAoYXV0byYgb3JpZ2luIDogb3JpZ2lucykK