147014 2015-07-16 14:04:57 -0700 Make MediaPlayerPrivateMediaStreamAVFObjC rely on pre rendered platformLayers 2015-07-22 13:52:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID InRadar, PlatformOnly P2 Normal --- 147011 1 mdaiter mdaiter bfulgham eric.carlson jonlee mdaiter webkit-bug-importer webkit.review.bot oldest_to_newest 1109957 0 mdaiter 2015-07-16 14:04:57 -0700 Currently, the MediaPlayerPrivateMediaStreamAVFObjC class relies on generating PlatformLayers on the fly from calls to the AVVideoPreviewCaptureLayer class. Switching over to an easier method to make sure that the system can easily grab rendered images to display from a more efficient method of grabbing frames from the camera wrapper class. 1109958 1 webkit-bug-importer 2015-07-16 14:07:24 -0700 <rdar://problem/21862276> 1109966 2 256925 mdaiter 2015-07-16 14:16:32 -0700 Created attachment 256925 Patch 1111317 3 256925 bfulgham 2015-07-22 09:47:51 -0700 Comment on attachment 256925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256925&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:178 > + return (PlatformLayer*)static_cast<AVVideoCaptureSource*>(m_MediaStreamPrivate->client()->getVideoTracks().at(0)->source())->previewLayer(); Why are you removing the FIXME comment? this is still just getting the first webcam, isn't it? Or is this post-user-selection? 1111319 4 256925 mdaiter 2015-07-22 09:49:55 -0700 Comment on attachment 256925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256925&action=review >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:178 >> + return (PlatformLayer*)static_cast<AVVideoCaptureSource*>(m_MediaStreamPrivate->client()->getVideoTracks().at(0)->source())->previewLayer(); > > Why are you removing the FIXME comment? this is still just getting the first webcam, isn't it? Or is this post-user-selection? This is actually outdated. The getVideoTracks() and getAudioTracks() removal bug should take care of this, so that we don't need to check getVideoTracks(). 256925 2015-07-16 14:16:32 -0700 2015-07-22 13:52:42 -0700 Patch bug-147014-20150716141526.patch text/plain 2192 mdaiter U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RhMDM5ZTI2NzRmYTlh OGI0ODNlNWQ2NmQxMWMwY2EzNDc0YmQ0Yi4uNWRlMmNlYmNmOGI5NTI5MTcxMDJlYWE4Y2NhMzBh YTA2NTg4ZWM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTE2ICBNYXR0 aGV3IERhaXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgTWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFTdHJlYW0gcmVseSBvbiBwcmVyZW5kZXJlZCBwcmV2aWV3TGF5ZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzAxNAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjE4NjIyNzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24v b2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW06CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6OnBsYXRmb3JtTGF5 ZXIpOiBDaGFuZ2UKKyAgICAgICAgc2VsZWN0aW9uIG9mIHBsYXRmb3JtTGF5ZXIKKwogMjAxNS0w Ny0xNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGwgb3V0IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE4NjkwMy4gSXQg YnJva2UgdGhlIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZP YmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDLm1tCmluZGV4IGJlNzhmYTEw NTdhNzczYTVkOTk5OTM3ZmY1MjM2NGYwMGIzM2M4OTcuLmNiMzFkYWRmZTA2ZGZmZDQ1ODEzODli ZDUwNTE3ZjY0MWRmYzIxMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZG T2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW0KQEAgLTE3NCwx MSArMTc0LDggQEAgUGxhdGZvcm1MYXllciogTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1B VkZPYmpDOjpwbGF0Zm9ybUxheWVyKCkgY29uc3QKIHsKICAgICBpZiAoIW1fTWVkaWFTdHJlYW1Q cml2YXRlKQogICAgICAgICByZXR1cm4gTWVkaWFQbGF5ZXJQcml2YXRlSW50ZXJmYWNlOjpwbGF0 Zm9ybUxheWVyKCk7Ci0gICAgZm9yIChhdXRvIHRyYWNrIDogbV9NZWRpYVN0cmVhbVByaXZhdGUt PmNsaWVudCgpLT5nZXRWaWRlb1RyYWNrcygpKSB7Ci0gICAgICAgIC8vIEZJWE1FKDE0Njg1OCk6 IEp1c3QgZ3JhYiB0aGUgZmlyc3Qgd2ViY2FtIGZvciBub3csIHdlIGNhbiBtYW5hZ2UgbW9yZSBs YXRlcgotICAgICAgICBBVlZpZGVvQ2FwdHVyZVNvdXJjZSogY2FwdHVyZSA9IChBVlZpZGVvQ2Fw dHVyZVNvdXJjZSopdHJhY2stPnNvdXJjZSgpOwotICAgICAgICByZXR1cm4gKFBsYXRmb3JtTGF5 ZXIqKVtnZXRBVkNhcHR1cmVWaWRlb1ByZXZpZXdMYXllckNsYXNzKCkgbGF5ZXJXaXRoU2Vzc2lv bjpjYXB0dXJlLT5zZXNzaW9uKCldOwotICAgIH0KKyAgICBpZiAoIW1fTWVkaWFTdHJlYW1Qcml2 YXRlLT5jbGllbnQoKS0+Z2V0VmlkZW9UcmFja3MuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4g KFBsYXRmb3JtTGF5ZXIqKXN0YXRpY19jYXN0PEFWVmlkZW9DYXB0dXJlU291cmNlKj4obV9NZWRp YVN0cmVhbVByaXZhdGUtPmNsaWVudCgpLT5nZXRWaWRlb1RyYWNrcygpLmF0KDApLT5zb3VyY2Uo KSktPnByZXZpZXdMYXllcigpOwogICAgIHJldHVybiBNZWRpYVBsYXllclByaXZhdGVJbnRlcmZh Y2U6OnBsYXRmb3JtTGF5ZXIoKTsKIH0KIAo=