146991 2015-07-15 17:55:26 -0700 Web Inspector: [Mac] Save dialog not working when inspector is docked 2015-07-16 17:30:22 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck andersca commit-queue graouts joepeck jonowells mattbaker nvasilyev sam simon.fraser thorton timothy webkit-bug-importer oldest_to_newest 1109786 0 joepeck 2015-07-15 17:55:26 -0700 * SUMMARY [Mac] Save dialog not working when trying to save from text editor * STEPS TO REPRODUCE 1. Inspect a local test page with scripts 2. Dock inspector 3. Select a script 4. Modify the script 5. Hit ⌘S to present save dialog 6. Save in the dialog => save panel does not dismiss * NOTES - NSSavePanel/NSOpenPanel handlers expect non-null window argument, hanging is when they are given a null argument. 1109787 1 joepeck 2015-07-15 17:55:36 -0700 <rdar://problem/21834578> 1109798 2 256885 joepeck 2015-07-15 18:31:46 -0700 Created attachment 256885 [PATCH] Proposed Fix 1109799 3 commit-queue 2015-07-15 18:33:04 -0700 Attachment 256885 did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:350: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:713: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:237: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:625: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1109874 4 256885 burg 2015-07-16 09:28:22 -0700 Comment on attachment 256885 [PATCH] Proposed Fix LGTM, would like Tim to take a peek though. 1109923 5 joepeck 2015-07-16 11:26:35 -0700 Will need at least a nod from a WK2 Owner. 1110034 6 256885 commit-queue 2015-07-16 17:30:18 -0700 Comment on attachment 256885 [PATCH] Proposed Fix Clearing flags on attachment: 256885 Committed r186919: <http://trac.webkit.org/changeset/186919> 1110035 7 commit-queue 2015-07-16 17:30:22 -0700 All reviewed patches have been landed. Closing bug. 256885 2015-07-15 18:31:46 -0700 2015-07-16 17:30:18 -0700 [PATCH] Proposed Fix dialogs.patch text/plain 6211 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBkNThjNzJhLi41NTU2YzE4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTUtMDctMTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbTWFjXSBTYXZlIGRpYWxvZyBub3Qg d29ya2luZyB3aGVuIGluc3BlY3RvciBpcyBkb2NrZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Njk5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xp ZW50Lm1tOgorICAgICAgICAoV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ6OnNhdmUpOgorICAg ICAgICAoLVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIHdlYlZpZXc6cnVuT3BlblBhbmVs Rm9yRmlsZUJ1dHRvbldpdGhSZXN1bHRMaXN0ZW5lcjphbGxvd011bHRpcGxlRmlsZXM6XSk6Cisg ICAgICAgIFdoZW4gdGhlIHdpbmRvdyBpcyBuaWwgKGRvY2tlZCkgdXNlIGEgbm9uLXdpbmRvdyB2 ZXJzaW9uIG9mIHJ1bm5pbmcgdGhlIGRpYWxvZy4KKwogMjAxNS0wNy0xNCAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB3a1BvcHVwTWVudSBm cm9tIFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2U7IGl0J3Mgbm90IGNhbGxlZCBmcm9tIFdlYkNvcmUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3Rv ckNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3Rv ckNsaWVudC5tbQppbmRleCAyYTNkMWZkLi4wYjc0NTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0KKysrIGIvU291cmNl L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCkBAIC0zNDcs MTIgKzM0NywxOCBAQCB2b2lkIFdlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50OjpzYXZlKGNvbnN0 IFN0cmluZyYgc3VnZ2VzdGVkVVJMLCBjb25zdCBTdHJpbmcmCiAgICAgcGFuZWwubmFtZUZpZWxk U3RyaW5nVmFsdWUgPSBwbGF0Zm9ybVVSTC5sYXN0UGF0aENvbXBvbmVudDsKICAgICBwYW5lbC5k aXJlY3RvcnlVUkwgPSBbcGxhdGZvcm1VUkwgVVJMQnlEZWxldGluZ0xhc3RQYXRoQ29tcG9uZW50 XTsKIAotICAgIFtwYW5lbCBiZWdpblNoZWV0TW9kYWxGb3JXaW5kb3c6W1ttX3dpbmRvd0NvbnRy b2xsZXIgd2ViVmlld10gd2luZG93XSBjb21wbGV0aW9uSGFuZGxlcjpeKE5TSW50ZWdlciByZXN1 bHQpIHsKKyAgICBhdXRvIGNvbXBsZXRpb25IYW5kbGVyID0gXihOU0ludGVnZXIgcmVzdWx0KSB7 CiAgICAgICAgIGlmIChyZXN1bHQgPT0gTlNGaWxlSGFuZGxpbmdQYW5lbENhbmNlbEJ1dHRvbikK ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgQVNTRVJUKHJlc3VsdCA9PSBOU0ZpbGVIYW5k bGluZ1BhbmVsT0tCdXR0b24pOwogICAgICAgICBzYXZlVG9VUkwocGFuZWwuVVJMKTsKLSAgICB9 XTsKKyAgICB9OworCisgICAgTlNXaW5kb3cgKndpbmRvdyA9IFtbbV93aW5kb3dDb250cm9sbGVy IHdlYlZpZXddIHdpbmRvd107CisgICAgaWYgKHdpbmRvdykKKyAgICAgICAgW3BhbmVsIGJlZ2lu U2hlZXRNb2RhbEZvcldpbmRvdzp3aW5kb3cgY29tcGxldGlvbkhhbmRsZXI6Y29tcGxldGlvbkhh bmRsZXJdOworICAgIGVsc2UKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoW3BhbmVsIHJ1bk1v ZGFsXSk7CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ6OmFwcGVuZChjb25z dCBTdHJpbmcmIHN1Z2dlc3RlZFVSTCwgY29uc3QgU3RyaW5nJiBjb250ZW50KQpAQCAtNzA0LDcg KzcxMCw3IEBAIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBydW5PcGVuUGFuZWxG b3JGaWxlQnV0dG9uV2l0aFJlc3VsdExpc3RlbmVyOihpCiAgICAgcGFuZWwuY2FuQ2hvb3NlRmls ZXMgPSBZRVM7CiAgICAgcGFuZWwuYWxsb3dzTXVsdGlwbGVTZWxlY3Rpb24gPSBhbGxvd011bHRp cGxlRmlsZXM7CiAKLSAgICBbcGFuZWwgYmVnaW5TaGVldE1vZGFsRm9yV2luZG93Ol93ZWJWaWV3 LndpbmRvdyBjb21wbGV0aW9uSGFuZGxlcjpeKE5TSW50ZWdlciByZXN1bHQpIHsKKyAgICBhdXRv IGNvbXBsZXRpb25IYW5kbGVyID0gXihOU0ludGVnZXIgcmVzdWx0KSB7CiAgICAgICAgIGlmIChy ZXN1bHQgPT0gTlNGaWxlSGFuZGxpbmdQYW5lbENhbmNlbEJ1dHRvbikgewogICAgICAgICAgICAg W3Jlc3VsdExpc3RlbmVyIGNhbmNlbF07CiAgICAgICAgICAgICByZXR1cm47CkBAIC03MTMsMTEg KzcxOSwxNiBAQCAtICh2b2lkKXdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIgcnVuT3BlblBhbmVs Rm9yRmlsZUJ1dHRvbldpdGhSZXN1bHRMaXN0ZW5lcjooaQogCiAgICAgICAgIE5TQXJyYXkgKlVS THMgPSBwYW5lbC5VUkxzOwogICAgICAgICBOU011dGFibGVBcnJheSAqZmlsZW5hbWVzID0gW05T TXV0YWJsZUFycmF5IGFycmF5V2l0aENhcGFjaXR5OlVSTHMuY291bnRdOwotICAgICAgICBmb3Ig KE5TVVJMICpVUkwgaW4gVVJMcykgeworICAgICAgICBmb3IgKE5TVVJMICpVUkwgaW4gVVJMcykK ICAgICAgICAgICAgIFtmaWxlbmFtZXMgYWRkT2JqZWN0OlVSTC5wYXRoXTsKLSAgICAgICAgfQor CiAgICAgICAgIFtyZXN1bHRMaXN0ZW5lciBjaG9vc2VGaWxlbmFtZXM6ZmlsZW5hbWVzXTsKLSAg ICB9XTsKKyAgICB9OworCisgICAgaWYgKF93ZWJWaWV3LndpbmRvdykKKyAgICAgICAgW3BhbmVs IGJlZ2luU2hlZXRNb2RhbEZvcldpbmRvdzpfd2ViVmlldy53aW5kb3cgY29tcGxldGlvbkhhbmRs ZXI6Y29tcGxldGlvbkhhbmRsZXJdOworICAgIGVsc2UKKyAgICAgICAgY29tcGxldGlvbkhhbmRs ZXIoW3BhbmVsIHJ1bk1vZGFsXSk7CiB9CiAKIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNl bmRlciBmcmFtZTooV2ViRnJhbWUgKilmcmFtZSBleGNlZWRlZERhdGFiYXNlUXVvdGFGb3JTZWN1 cml0eU9yaWdpbjooV2ViU2VjdXJpdHlPcmlnaW4gKilvcmlnaW4gZGF0YWJhc2U6KE5TU3RyaW5n ICopZGF0YWJhc2VJZGVudGlmaWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzk0MDllOS4uNmQxY2M4ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTE1ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW01hY10gU2F2ZSBk aWFsb2cgbm90IHdvcmtpbmcgd2hlbiBpbnNwZWN0b3IgaXMgZG9ja2VkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY5OTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViSW5z cGVjdG9yUHJveHlNYWMubW06CisgICAgICAgIChXZWJLaXQ6OnJ1bk9wZW5QYW5lbCk6CisgICAg ICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybVNhdmUpOgorICAgICAgICBX aGVuIHRoZSB3aW5kb3cgaXMgbmlsIChkb2NrZWQpIHVzZSBhIG5vbi13aW5kb3cgdmVyc2lvbiBv ZiBydW5uaW5nIHRoZSBkaWFsb2cuCisKIDIwMTUtMDctMTUgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbmFtZSBQQUNLQUdFX0xP Q0FMRV9ESVIgdG8gTE9DQUxFRElSCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQppbmRleCBlOWJkMjg1Li4zMTc0YjBhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlN YWMubW0KQEAgLTIzNCw4ICsyMzQsNyBAQCBzdGF0aWMgdm9pZCBydW5PcGVuUGFuZWwoV0tQYWdl UmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJhbWUsIFdLT3BlblBhbmVsUGFyYW1ldGVycwogCiAgICAg V0tSZXRhaW4obGlzdGVuZXIpOwogCi0gICAgLy8gSWYgdGhlIGluc3BlY3RvciBpcyBkZXRhY2hl ZCwgdGhlbiBvcGVuUGFuZWwgd2lsbCBiZSB3aW5kb3ctbW9kYWw7IG90aGVyd2lzZSwgb3BlblBh bmVsIGlzIG9wZW5lZCBpbiBhIG5ldyB3aW5kb3cuCi0gICAgW29wZW5QYW5lbCBiZWdpblNoZWV0 TW9kYWxGb3JXaW5kb3c6d2ViSW5zcGVjdG9yUHJveHktPmluc3BlY3RvcldpbmRvdygpIGNvbXBs ZXRpb25IYW5kbGVyOl4oTlNJbnRlZ2VyIHJlc3VsdCkgeworICAgIGF1dG8gY29tcGxldGlvbkhh bmRsZXIgPSBeKE5TSW50ZWdlciByZXN1bHQpIHsKICAgICAgICAgaWYgKHJlc3VsdCA9PSBOU0Zp bGVIYW5kbGluZ1BhbmVsT0tCdXR0b24pIHsKICAgICAgICAgICAgIFdLTXV0YWJsZUFycmF5UmVm IGZpbGVVUkxzID0gV0tNdXRhYmxlQXJyYXlDcmVhdGUoKTsKIApAQCAtMjUyLDcgKzI1MSwxMiBA QCBzdGF0aWMgdm9pZCBydW5PcGVuUGFuZWwoV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJh bWUsIFdLT3BlblBhbmVsUGFyYW1ldGVycwogICAgICAgICAgICAgV0tPcGVuUGFuZWxSZXN1bHRM aXN0ZW5lckNhbmNlbChsaXN0ZW5lcik7CiAKICAgICAgICAgV0tSZWxlYXNlKGxpc3RlbmVyKTsK LSAgICB9XTsKKyAgICB9OworCisgICAgaWYgKHdlYkluc3BlY3RvclByb3h5LT5pbnNwZWN0b3JX aW5kb3coKSkKKyAgICAgICAgW29wZW5QYW5lbCBiZWdpblNoZWV0TW9kYWxGb3JXaW5kb3c6d2Vi SW5zcGVjdG9yUHJveHktPmluc3BlY3RvcldpbmRvdygpIGNvbXBsZXRpb25IYW5kbGVyOmNvbXBs ZXRpb25IYW5kbGVyXTsKKyAgICBlbHNlCisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFtvcGVu UGFuZWwgcnVuTW9kYWxdKTsKIH0KIAogdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6YXR0YWNobWVu dFZpZXdEaWRDaGFuZ2UoTlNWaWV3ICpvbGRWaWV3LCBOU1ZpZXcgKm5ld1ZpZXcpCkBAIC02MTgs MTIgKzYyMiwxNyBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybVNhdmUoY29uc3Qg U3RyaW5nJiBzdWdnZXN0ZWRVUkwsIGNvbnN0IFN0cmluZyYgYwogICAgIHBhbmVsLm5hbWVGaWVs ZFN0cmluZ1ZhbHVlID0gcGxhdGZvcm1VUkwubGFzdFBhdGhDb21wb25lbnQ7CiAgICAgcGFuZWwu ZGlyZWN0b3J5VVJMID0gW3BsYXRmb3JtVVJMIFVSTEJ5RGVsZXRpbmdMYXN0UGF0aENvbXBvbmVu dF07CiAKLSAgICBbcGFuZWwgYmVnaW5TaGVldE1vZGFsRm9yV2luZG93Om1faW5zcGVjdG9yV2lu ZG93LmdldCgpIGNvbXBsZXRpb25IYW5kbGVyOl4oTlNJbnRlZ2VyIHJlc3VsdCkgeworICAgIGF1 dG8gY29tcGxldGlvbkhhbmRsZXIgPSBeKE5TSW50ZWdlciByZXN1bHQpIHsKICAgICAgICAgaWYg KHJlc3VsdCA9PSBOU0ZpbGVIYW5kbGluZ1BhbmVsQ2FuY2VsQnV0dG9uKQogICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICBBU1NFUlQocmVzdWx0ID09IE5TRmlsZUhhbmRsaW5nUGFuZWxPS0J1 dHRvbik7CiAgICAgICAgIHNhdmVUb1VSTChwYW5lbC5VUkwpOwotICAgIH1dOworICAgIH07CisK KyAgICBpZiAobV9pbnNwZWN0b3JXaW5kb3cpCisgICAgICAgIFtwYW5lbCBiZWdpblNoZWV0TW9k YWxGb3JXaW5kb3c6bV9pbnNwZWN0b3JXaW5kb3cuZ2V0KCkgY29tcGxldGlvbkhhbmRsZXI6Y29t cGxldGlvbkhhbmRsZXJdOworICAgIGVsc2UKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoW3Bh bmVsIHJ1bk1vZGFsXSk7CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQXBw ZW5kKGNvbnN0IFN0cmluZyYgc3VnZ2VzdGVkVVJMLCBjb25zdCBTdHJpbmcmIGNvbnRlbnQpCg==