146989 2015-07-15 16:00:26 -0700 [Win] 64-bit Build Failure 2015-07-15 17:32:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham bfulgham mark.lam saam oldest_to_newest 1109755 0 bfulgham 2015-07-15 16:00:26 -0700 The 64-bit Windows build fails due to a missing CCallHelpers.h method. 1109757 1 256874 bfulgham 2015-07-15 16:02:22 -0700 Created attachment 256874 Patch 1109760 2 256874 mark.lam 2015-07-15 16:14:37 -0700 Comment on attachment 256874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256874&action=review r=me > Source/JavaScriptCore/jit/CCallHelpers.h:1537 > +#if OS(WINDOWS) && CPU(X86_64) I think this #if is not needed because this function is always valid for the NUMBER_OF_ARGUMENT_REGISTERS == 4 case. However, since this function seems to only be needed by Windows for now, I’m ok with leaving the #if in. 1109766 3 saam 2015-07-15 16:36:14 -0700 (In reply to comment #0) > The 64-bit Windows build fails due to a missing CCallHelpers.h method. Thanks Brent. 1109779 4 256874 bfulgham 2015-07-15 17:31:32 -0700 Comment on attachment 256874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256874&action=review >> Source/JavaScriptCore/jit/CCallHelpers.h:1537 >> +#if OS(WINDOWS) && CPU(X86_64) > > I think this #if is not needed because this function is always valid for the NUMBER_OF_ARGUMENT_REGISTERS == 4 case. However, since this function seems to only be needed by Windows for now, I’m ok with leaving the #if in. OK. I'll remove it while landing. 1109780 5 bfulgham 2015-07-15 17:32:28 -0700 Committed r186876: <http://trac.webkit.org/changeset/186876> 256874 2015-07-15 16:02:22 -0700 2015-07-15 16:14:37 -0700 Patch bug-146989-20150715161439.patch text/plain 1506 bfulgham SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg2ODY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE1LTA3LTE1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIDY0LWJpdCBCdWlsZCBGYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY5ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9DQ2FsbEhlbHBlcnMuaDoKKyAgICAgICAgKEpT Qzo6Q0NhbGxIZWxwZXJzOjpzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUpOiBBZGQgbWlzc2lu ZworICAgICAgICBkZWNsYXJhdGlvbiBmb3IgNjQtYml0IHR5cGUgb24gNC1hcmd1bWVudCByZWdp c3RlciBtYWNoaW5lcyAobGlrZQorICAgICAgICBXaW5kb3dzKS4KKwogMjAxNS0wNy0xNSAgU2Fh bSBiYXJhdGkgIDxzYWFtYmFyYXRpMUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTNl0gaW1wbGVt ZW50IGJsb2NrIHNjb3BpbmcgdG8gZW5hYmxlICdsZXQnCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0NDYWxsSGVscGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgJKHJldmlzaW9uIDE4Njg2MykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1MzQsNiAr MTUzNCwxNCBAQCBwdWJsaWM6CiAgICAgICAgIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShh cmcxLCBhcmcyLCBhcmczKTsKICAgICB9CiAKKyNpZiBPUyhXSU5ET1dTKSAmJiBDUFUoWDg2XzY0 KQorICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoVHJ1 c3RlZEltbVB0ciBhcmcxLCBHUFJSZWcgYXJnMiwgVHJ1c3RlZEltbVB0ciBhcmczLCBUcnVzdGVk SW1tNjQgYXJnNCkKKyAgICB7CisgICAgICAgIHBva2UoYXJnNCwgUE9LRV9BUkdVTUVOVF9PRkZT RVQpOworICAgICAgICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJn Myk7CisgICAgfQorI2VuZGlmCisKICAgICBBTFdBWVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVu dHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW1QdHIgYXJnMSwgR1BSUmVnIGFyZzIsIFRydXN0ZWRJ bW0zMiBhcmczLCBUcnVzdGVkSW1tUHRyIGFyZzQpCiAgICAgewogICAgICAgICBwb2tlKGFyZzQs IFBPS0VfQVJHVU1FTlRfT0ZGU0VUKTsK