146985 2015-07-15 15:45:07 -0700 In getUserMedia(), make sure a request has titles of devices which user can choose from. 2016-01-25 14:16:38 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID InRadar, PlatformOnly P2 Normal --- 1 mdaiter mdaiter bfulgham eric.carlson jeremyj-wk jonlee mdaiter webkit-bug-importer webkit.review.bot oldest_to_newest 1109745 0 mdaiter 2015-07-15 15:45:07 -0700 When presenting getUserMedia, the user should be informed of the device he or she is opening. This patch enables the passing of a list of strings from WebCore to WebKit2, enabling browsers to pull an available list of devices so a user can see options from which he or she can choose. 1109747 1 webkit-bug-importer 2015-07-15 15:46:29 -0700 <rdar://problem/21844415> 1109751 2 256871 mdaiter 2015-07-15 15:52:22 -0700 Created attachment 256871 Patch 1109817 3 256871 eric.carlson 2015-07-15 20:08:51 -0700 Comment on attachment 256871 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256871&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:127 > void UserMediaRequest::constraintsValidated() > { Is this necessary to get titles? > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:134 > + Vector<RefPtr<TrackSourceInfo>> trackSourcesInfo = AVCaptureDeviceManager::singleton().getSourcesInfo(""); If so, this code is cross platform so I think you need to add a new virtual method to RealtimeMediaSourceCenter that calls [platform manager].getSourcesInfo() > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:138 > + AVCaptureDeviceManager::singleton().verifyConstraintsForMediaType(RealtimeMediaSource::Audio, protectedAudio.get(), invalidConstraint); Ditto, but for verifyConstraintsForMediaType. > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:145 > + AVCaptureDeviceManager::singleton().verifyConstraintsForMediaType(RealtimeMediaSource::Video, protectedVideo.get(), invalidConstraint); Ditto. 1158499 4 jonlee 2016-01-25 14:16:38 -0800 This is handled elsewhere. 256871 2015-07-15 15:52:22 -0700 2015-07-15 20:08:51 -0700 Patch bug-146985-20150715155114.patch text/plain 4336 mdaiter U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmM4NzQzOTY0NGRhZGQw NDNmYWM2NTllMDQ1ZDA4OTYxZDQzM2U2Ny4uYTQ1MWExNmJkMDk2OGFiZGE1NmY0NDNkZDQ2YjUy MTJkZWE1OGNkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA3LTE1ICBNYXR0 aGV3IERhaXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBVc2VyTWVk aWFSZXF1ZXN0IHRvIHNlZSB0aXRsZXMgb2YgZGV2aWNlcyBhdmFpbGFibGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Njk4NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMjE4NDQ0MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VXNlck1lZGlhUmVxdWVzdDo6Y29uc3RyYWludHNWYWxpZGF0 ZWQpOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5oOgor ICAgICAgICAoV2ViQ29yZTo6VXNlck1lZGlhUmVxdWVzdDo6bGFiZWxzKToKKwogMjAxNS0wNy0x NSAgSmlueW91bmcgSHVyICA8aHVyLmltc0BuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIFtXaW5D YWlyb10gZm9udCBmYWxsYmFjayBub3Qgd29ya2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKaW5kZXggMmRlMjU5 YTFiNjY0YmE5MmM1MTA3ODg2Y2FkNDYwODRiNzljMzkwOS4uMzk1ODM3YjU0MTA3ZjNiYjVlYmQy ZWMzODhlZmM3NmYxYzRkYWU3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwCkBAIC0zNyw2ICszNyw3IEBACiAK ICNpbmNsdWRlICJVc2VyTWVkaWFSZXF1ZXN0LmgiCiAKKyNpbmNsdWRlICJBVkNhcHR1cmVEZXZp Y2VNYW5hZ2VyLmgiCiAjaW5jbHVkZSAiRGljdGlvbmFyeS5oIgogI2luY2x1ZGUgIkRvY3VtZW50 LmgiCiAjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgpAQCAtNDYsNiArNDcsNyBAQAogI2luY2x1 ZGUgIk1lZGlhQ29uc3RyYWludHNJbXBsLmgiCiAjaW5jbHVkZSAiTWVkaWFTdHJlYW0uaCIKICNp bmNsdWRlICJNZWRpYVN0cmVhbVByaXZhdGUuaCIKKyNpbmNsdWRlICJNZWRpYVN0cmVhbVRyYWNr U291cmNlc1JlcXVlc3RDbGllbnQuaCIKICNpbmNsdWRlICJOYXZpZ2F0b3JVc2VyTWVkaWFFcnJv ckNhbGxiYWNrLmgiCiAjaW5jbHVkZSAiTmF2aWdhdG9yVXNlck1lZGlhU3VjY2Vzc0NhbGxiYWNr LmgiCiAjaW5jbHVkZSAiUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlci5oIgpAQCAtMTI0LDEwICsx MjYsMzEgQEAgdm9pZCBVc2VyTWVkaWFSZXF1ZXN0OjpzdGFydCgpCiB2b2lkIFVzZXJNZWRpYVJl cXVlc3Q6OmNvbnN0cmFpbnRzVmFsaWRhdGVkKCkKIHsKICAgICBSZWZQdHI8VXNlck1lZGlhUmVx dWVzdD4gcHJvdGVjdGVkVGhpcyh0aGlzKTsKLSAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90ZWN0 ZWRUaGlzXSB7CisgICAgUmVmUHRyPE1lZGlhQ29uc3RyYWludHM+IHByb3RlY3RlZEF1ZGlvKG1f YXVkaW9Db25zdHJhaW50cyk7CisgICAgUmVmUHRyPE1lZGlhQ29uc3RyYWludHM+IHByb3RlY3Rl ZFZpZGVvKG1fdmlkZW9Db25zdHJhaW50cyk7CisgICAgY2FsbE9uTWFpblRocmVhZChbcHJvdGVj dGVkVGhpcywgcHJvdGVjdGVkVmlkZW8sIHByb3RlY3RlZEF1ZGlvXSB7CiAgICAgICAgIC8vIDIg LSBUaGUgY29uc3RyYWludHMgYXJlIHZhbGlkLCBhc2sgdGhlIHVzZXIgZm9yIGFjY2VzcyB0byBt ZWRpYS4KLSAgICAgICAgaWYgKFVzZXJNZWRpYUNvbnRyb2xsZXIqIGNvbnRyb2xsZXIgPSBwcm90 ZWN0ZWRUaGlzLT5tX2NvbnRyb2xsZXIpCisgICAgICAgIGlmIChVc2VyTWVkaWFDb250cm9sbGVy KiBjb250cm9sbGVyID0gcHJvdGVjdGVkVGhpcy0+bV9jb250cm9sbGVyKSB7CisgICAgICAgICAg ICBWZWN0b3I8UmVmUHRyPFRyYWNrU291cmNlSW5mbz4+IHRyYWNrU291cmNlc0luZm8gPSBBVkNh cHR1cmVEZXZpY2VNYW5hZ2VyOjpzaW5nbGV0b24oKS5nZXRTb3VyY2VzSW5mbygiIik7CisgICAg ICAgICAgICBmb3IgKGF1dG8gdHJhY2sgOiB0cmFja1NvdXJjZXNJbmZvKSB7CisgICAgICAgICAg ICAgICAgaWYgKHByb3RlY3RlZEF1ZGlvKSB7CisgICAgICAgICAgICAgICAgICAgIFN0cmluZyBp bnZhbGlkQ29uc3RyYWludDsKKyAgICAgICAgICAgICAgICAgICAgQVZDYXB0dXJlRGV2aWNlTWFu YWdlcjo6c2luZ2xldG9uKCkudmVyaWZ5Q29uc3RyYWludHNGb3JNZWRpYVR5cGUoUmVhbHRpbWVN ZWRpYVNvdXJjZTo6QXVkaW8sIHByb3RlY3RlZEF1ZGlvLmdldCgpLCBpbnZhbGlkQ29uc3RyYWlu dCk7CisgICAgICAgICAgICAgICAgICAgIGlmICghaW52YWxpZENvbnN0cmFpbnQuaXNFbXB0eSgp KQorICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIGlmIChwcm90ZWN0ZWRWaWRlbykgewor ICAgICAgICAgICAgICAgICAgICBTdHJpbmcgaW52YWxpZENvbnN0cmFpbnQ7CisgICAgICAgICAg ICAgICAgICAgIEFWQ2FwdHVyZURldmljZU1hbmFnZXI6OnNpbmdsZXRvbigpLnZlcmlmeUNvbnN0 cmFpbnRzRm9yTWVkaWFUeXBlKFJlYWx0aW1lTWVkaWFTb3VyY2U6OlZpZGVvLCBwcm90ZWN0ZWRW aWRlby5nZXQoKSwgaW52YWxpZENvbnN0cmFpbnQpOworICAgICAgICAgICAgICAgICAgICBpZiAo IWludmFsaWRDb25zdHJhaW50LmlzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGNv bnRpbnVlOworICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgIHByb3RlY3RlZFRo aXMtPm1fbGFiZWxzLmFwcGVuZCh0cmFjay0+bGFiZWwoKSk7CisgICAgICAgICAgICB9CiAgICAg ICAgICAgICBjb250cm9sbGVyLT5yZXF1ZXN0UGVybWlzc2lvbigqcHJvdGVjdGVkVGhpcy5nZXQo KSk7CisgICAgICAgIH0KICAgICB9KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuaAppbmRleCAwZDBkNDRhOGZjNTM3 YmNmM2EzODcyYmQwMWZkNzNkZjA5NjBiNzUxLi4zMDQ2OTYyZmE1NGJkMTdkOWQ1NDM0M2ZjYmVj Y2I1MmI0NmQ0NDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL1VzZXJNZWRpYVJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuaApAQCAtNjksNiArNjksOCBAQCBwdWJsaWM6CiAKICAg ICBib29sIHJlcXVpcmVzQXVkaW8oKSBjb25zdCB7IHJldHVybiBtX2F1ZGlvQ29uc3RyYWludHM7 IH0KICAgICBib29sIHJlcXVpcmVzVmlkZW8oKSBjb25zdCB7IHJldHVybiBtX3ZpZGVvQ29uc3Ry YWludHM7IH0KKyAgICAKKyAgICBWZWN0b3I8U3RyaW5nPiBsYWJlbHMoKSBjb25zdCB7IHJldHVy biBtX2xhYmVsczsgfQogCiBwcml2YXRlOgogICAgIFVzZXJNZWRpYVJlcXVlc3QoU2NyaXB0RXhl Y3V0aW9uQ29udGV4dCosIFVzZXJNZWRpYUNvbnRyb2xsZXIqLCBQYXNzUmVmUHRyPE1lZGlhQ29u c3RyYWludHM+IGF1ZGlvQ29uc3RyYWludHMsIFBhc3NSZWZQdHI8TWVkaWFDb25zdHJhaW50cz4g dmlkZW9Db25zdHJhaW50cywgTWVkaWFEZXZpY2VzOjpQcm9taXNlJiYpOwpAQCAtODYsNiArODgs OCBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxNZWRpYUNvbnN0cmFpbnRzPiBtX2F1ZGlvQ29uc3Ry YWludHM7CiAgICAgUmVmUHRyPE1lZGlhQ29uc3RyYWludHM+IG1fdmlkZW9Db25zdHJhaW50czsK IAorICAgIFZlY3RvcjxTdHJpbmc+IG1fbGFiZWxzOworICAgIAogICAgIFVzZXJNZWRpYUNvbnRy b2xsZXIqIG1fY29udHJvbGxlcjsKIAogICAgIE1lZGlhRGV2aWNlczo6UHJvbWlzZSBtX3Byb21p c2U7Cg==