146952 2015-07-14 17:12:57 -0700 Analysis tasks that start at the very first data point doesn't load 2015-10-09 03:29:34 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 rniwa rniwa cdumez dbates dewei_zhu kling oldest_to_newest 1109524 0 rniwa 2015-07-14 17:12:57 -0700 JavaScript blows up :( 1109528 1 256812 rniwa 2015-07-14 17:18:36 -0700 Created attachment 256812 Fixes the bug 1109824 2 256812 dbates 2015-07-15 22:30:32 -0700 Comment on attachment 256812 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=256812&action=review > Websites/perf.webkit.org/public/v2/data.js:534 > + if (!('seriesIndex' in endPoint)) This is not correct. Notice that the existing logic prevented indexing into this._series with a negative index. > Websites/perf.webkit.org/public/v2/data.js:541 > + if (!('seriesIndex' in endPoint)) I take it you meant to write "point" instead of "endPoint" in the expression for this if-statement. 1109825 3 dbates 2015-07-15 22:32:39 -0700 (In reply to comment #2) > Comment on attachment 256812 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256812&action=review > > > Websites/perf.webkit.org/public/v2/data.js:534 > > + if (!('seriesIndex' in endPoint)) > > [...] Notice that the existing logic prevented indexing into > this._series with a negative index. I meant to write: Notice that the existing logic prevented indexing into this._series with a negative index when point.seriesIndex == 0. 1131872 4 rniwa 2015-10-09 03:29:34 -0700 This patch is obsolete now. 256812 2015-07-14 17:18:36 -0700 2015-07-15 22:30:32 -0700 Fixes the bug bug-146952-20150714171730.patch text/plain 1943 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTg2ODI2KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTA3LTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEFuYWx5c2lzIHRhc2tzIHRoYXQgc3RhcnQgYXQgdGhlIHZlcnkgZmlyc3QgZGF0 YSBwb2ludCBkb2Vzbid0IGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0Njk1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENoZWNrIHdoZXRoZXIgdGhlIHByb3BlcnR5IGV4aXN0cyBpbnN0ZWFkIG9m IHdoZXRoZXIgdGhlIHZhbHVlIGV2YWx1YXRlcyB0byBmYWxzZSBzaW5jZQorICAgICAgICBzZXJp ZXNJbmRleCBvZiAwIGFsc28gZXZhbHVhdGVzIHRvIGZhbHNlLgorCisgICAgICAgICogcHVibGlj L3YyL2RhdGEuanM6CisgICAgICAgIChUaW1lU2VyaWVzLnByb3RvdHlwZS5zZXJpZXNCZXR3ZWVu UG9pbnRzKToKKyAgICAgICAgKFRpbWVTZXJpZXMucHJvdG90eXBlLnByZXZpb3VzUG9pbnQpOgor ICAgICAgICAoVGltZVNlcmllcy5wcm90b3R5cGUubmV4dFBvaW50KToKKwogMjAxNS0wNy0xMyAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggYSB0eXBvLgpJ bmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9kYXRhLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvZGF0YS5qcwkocmV2aXNp b24gMTg2ODI2KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9kYXRhLmpz CSh3b3JraW5nIGNvcHkpCkBAIC00NzcsNyArNDc3LDcgQEAgVGltZVNlcmllcy5wcm90b3R5cGUu ZmluZFBvaW50QWZ0ZXJUaW1lIAogCiBUaW1lU2VyaWVzLnByb3RvdHlwZS5zZXJpZXNCZXR3ZWVu UG9pbnRzID0gZnVuY3Rpb24gKHN0YXJ0UG9pbnQsIGVuZFBvaW50KQogewotICAgIGlmICghc3Rh cnRQb2ludC5zZXJpZXNJbmRleCB8fCAhZW5kUG9pbnQuc2VyaWVzSW5kZXgpCisgICAgaWYgKCEo J3Nlcmllc0luZGV4JyBpbiBzdGFydFBvaW50KSB8fCAhKCdzZXJpZXNJbmRleCcgaW4gZW5kUG9p bnQpKQogICAgICAgICByZXR1cm4gbnVsbDsKICAgICByZXR1cm4gdGhpcy5fc2VyaWVzLnNsaWNl KHN0YXJ0UG9pbnQuc2VyaWVzSW5kZXgsIGVuZFBvaW50LnNlcmllc0luZGV4ICsgMSk7CiB9CkBA IC01MzEsMTQgKzUzMSwxNCBAQCBUaW1lU2VyaWVzLnByb3RvdHlwZS5sYXN0UG9pbnQgPSBmdW5j dGlvCiAKIFRpbWVTZXJpZXMucHJvdG90eXBlLnByZXZpb3VzUG9pbnQgPSBmdW5jdGlvbiAocG9p bnQpCiB7Ci0gICAgaWYgKCFwb2ludC5zZXJpZXNJbmRleCkKKyAgICBpZiAoISgnc2VyaWVzSW5k ZXgnIGluIGVuZFBvaW50KSkKICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgcmV0dXJuIHRoaXMu X3Nlcmllc1twb2ludC5zZXJpZXNJbmRleCAtIDFdOwogfQogCiBUaW1lU2VyaWVzLnByb3RvdHlw ZS5uZXh0UG9pbnQgPSBmdW5jdGlvbiAocG9pbnQpCiB7Ci0gICAgaWYgKCFwb2ludC5zZXJpZXNJ bmRleCkKKyAgICBpZiAoISgnc2VyaWVzSW5kZXgnIGluIGVuZFBvaW50KSkKICAgICAgICAgcmV0 dXJuIG51bGw7CiAgICAgcmV0dXJuIHRoaXMuX3Nlcmllc1twb2ludC5zZXJpZXNJbmRleCArIDFd OwogfQo=