146947 2015-07-14 15:17:47 -0700 Fix the 32 bit build after r186817 2015-07-15 07:11:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146916 1 wenson_hsieh webkit-unassigned achristensen commit-queue oldest_to_newest 1109489 0 wenson_hsieh 2015-07-14 15:17:47 -0700 I broke the 32-bit build! Since I don't have commit rights yet, I will post a patch to this bug and get it committed. 1109503 1 256805 wenson_hsieh 2015-07-14 15:55:43 -0700 Created attachment 256805 Patch 1109508 2 256808 wenson_hsieh 2015-07-14 16:01:37 -0700 Created attachment 256808 Patch 1109517 3 256808 commit-queue 2015-07-14 16:51:28 -0700 Comment on attachment 256808 Patch Clearing flags on attachment: 256808 Committed r186825: <http://trac.webkit.org/changeset/186825> 1109518 4 commit-queue 2015-07-14 16:51:30 -0700 All reviewed patches have been landed. Closing bug. 256805 2015-07-14 15:55:43 -0700 2015-07-14 16:01:34 -0700 Patch bug-146947-20150714155436.patch text/plain 2641 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2ODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y1YmZlOGFiY2M2YWIy NmFjYmI3Yjc4NTczMzNkNDgxMzA1ODQ1Ny4uYTdjOGE2M2IyMWU4Y2ViMGFkMmE2MTBlNDUyY2M2 NTU2ZWU5MzM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTA3LTE0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCB0aGUgMzIg Yml0IGJ1aWxkIGFmdGVyIHIxODY4MTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0Njk0NworCisgICAgICAgIENoYW5nZWQgQ0dSZWN0IHRvIE5TUmVj dC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL21hYy9UaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnBhaW50QnV0dG9uKToK KworMjAxNS0wNy0xNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKwog ICAgICAgICBJbnB1dCBidXR0b25zIHJlbmRlcmVkIGF0IHRoZSB3cm9uZyBzaXplIHdoZW4gcGlu Y2hpbmctdG8tem9vbQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2OTE2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9U aGVtZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5tbQppbmRl eCA0YjI3NzllMzYxYzc0MTZkMDFlNWE4OGRhM2E0NGVkYTZhY2QwOTUzLi5mNDlkMWU2NDUxYTA0 M2Q4M2JlOWY3ZGY5MTNlMWZlN2QzMDgxMWU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1RoZW1lTWFjLm1tCkBAIC01OTIsMTkgKzU5MiwyMCBAQCBzdGF0aWMgdm9pZCBwYWludEJ1dHRv bihDb250cm9sUGFydCBwYXJ0LCBDb250cm9sU3RhdGVzKiBjb250cm9sU3RhdGVzLCBHcmFwaGlj cwogICAgIH0gZWxzZSBpZiAoW3ByZXZpb3VzRGVmYXVsdEJ1dHRvbkNlbGwgaXNFcXVhbDpidXR0 b25DZWxsXSkKICAgICAgICAgW3dpbmRvdyBzZXREZWZhdWx0QnV0dG9uQ2VsbDpuaWxdOwogCisg ICAgRmxvYXRSZWN0IGRyYXdGcm9tSW1hZ2VCdWZmZXJSZWN0KGZvY3VzVGhpY2tuZXNzLCBmb2N1 c1RoaWNrbmVzcywgaW5mbGF0ZWRSZWN0LndpZHRoKCksIGluZmxhdGVkUmVjdC5oZWlnaHQoKSk7 CiAgICAgaWYgKHNob3VsZFVzZUltYWdlQnVmZmVyKSB7Ci0gICAgICAgIFtidXR0b25DZWxsIGRy YXdXaXRoRnJhbWU6Q0dSZWN0TWFrZShmb2N1c1RoaWNrbmVzcywgZm9jdXNUaGlja25lc3MsIGlu ZmxhdGVkUmVjdC53aWR0aCgpLCBpbmZsYXRlZFJlY3QuaGVpZ2h0KCkpIGluVmlldzp2aWV3XTsK KyAgICAgICAgW2J1dHRvbkNlbGwgZHJhd1dpdGhGcmFtZTpOU1JlY3QoZHJhd0Zyb21JbWFnZUJ1 ZmZlclJlY3QpIGluVmlldzp2aWV3XTsKICAgICAgICAgaWYgKCEoc3RhdGVzICYgQ29udHJvbFN0 YXRlczo6Rm9jdXNTdGF0ZSkpCiAgICAgICAgICAgICBjb250ZXh0LT5kcmF3SW1hZ2VCdWZmZXIo aW1hZ2VCdWZmZXIuZ2V0KCksIENvbG9yU3BhY2VEZXZpY2VSR0IsIGluZmxhdGVkUmVjdC5sb2Nh dGlvbigpIC0gRmxvYXRTaXplKGZvY3VzVGhpY2tuZXNzLCBmb2N1c1RoaWNrbmVzcykpOwogICAg IH0gZWxzZQotICAgICAgICBbYnV0dG9uQ2VsbCBkcmF3V2l0aEZyYW1lOkNHUmVjdChpbmZsYXRl ZFJlY3QpIGluVmlldzp2aWV3XTsKKyAgICAgICAgW2J1dHRvbkNlbGwgZHJhd1dpdGhGcmFtZTpO U1JlY3QoaW5mbGF0ZWRSZWN0KSBpblZpZXc6dmlld107CiAgICAgCiAgICAgaWYgKHN0YXRlcyAm IENvbnRyb2xTdGF0ZXM6OkZvY3VzU3RhdGUpIHsKICAgICAgICAgaWYgKHNob3VsZFVzZUltYWdl QnVmZmVyKSB7Ci0gICAgICAgICAgICBkcmF3Q2VsbEZvY3VzUmluZyhidXR0b25DZWxsLCBDR1Jl Y3RNYWtlKGZvY3VzVGhpY2tuZXNzLCBmb2N1c1RoaWNrbmVzcywgaW5mbGF0ZWRSZWN0LndpZHRo KCksIGluZmxhdGVkUmVjdC5oZWlnaHQoKSksIHZpZXcpOworICAgICAgICAgICAgZHJhd0NlbGxG b2N1c1JpbmcoYnV0dG9uQ2VsbCwgTlNSZWN0KGRyYXdGcm9tSW1hZ2VCdWZmZXJSZWN0KSwgdmll dyk7CiAgICAgICAgICAgICBjb250ZXh0LT5kcmF3SW1hZ2VCdWZmZXIoaW1hZ2VCdWZmZXIuZ2V0 KCksIENvbG9yU3BhY2VEZXZpY2VSR0IsIGluZmxhdGVkUmVjdC5sb2NhdGlvbigpIC0gRmxvYXRT aXplKGZvY3VzVGhpY2tuZXNzLCBmb2N1c1RoaWNrbmVzcykpOwogICAgICAgICB9IGVsc2UKLSAg ICAgICAgICAgIGRyYXdDZWxsRm9jdXNSaW5nKGJ1dHRvbkNlbGwsIGluZmxhdGVkUmVjdCwgdmll dyk7CisgICAgICAgICAgICBkcmF3Q2VsbEZvY3VzUmluZyhidXR0b25DZWxsLCBOU1JlY3QoaW5m bGF0ZWRSZWN0KSwgdmlldyk7CiAgICAgfQogICAgIAogICAgIGNvbnRyb2xTdGF0ZXMtPnNldE5l ZWRzUmVwYWludChmYWxzZSk7Cg== 256808 2015-07-14 16:01:37 -0700 2015-07-14 16:51:28 -0700 Patch bug-146947-20150714160031.patch text/plain 2596 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2ODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q3ZjU2YTk2NmYzMTE3 OWExYTQ2ZTc0ZDVmNGJkOWUwYzA1ZTlkMi4uYTQ3ZTg0Y2RmM2U1ODg0NzEzMWQyZGYyOGU5NTUx M2ExNWE1NDYxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTE0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCB0aGUgMzIg Yml0IGJ1aWxkIGFmdGVyIHIxODY4MTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0Njk0NworCisgICAgICAgIENoYW5nZWQgQ0dSZWN0IHRvIE5TUmVj dC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL21hYy9UaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnBhaW50QnV0dG9uKToK KwogMjAxNS0wNy0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSB3a1BvcHVwTWVudSBmcm9tIFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2U7IGl0 J3Mgbm90IGNhbGxlZCBmcm9tIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9UaGVtZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVt ZU1hYy5tbQppbmRleCA0YjI3NzllMzYxYzc0MTZkMDFlNWE4OGRhM2E0NGVkYTZhY2QwOTUzLi5m NDlkMWU2NDUxYTA0M2Q4M2JlOWY3ZGY5MTNlMWZlN2QzMDgxMWU2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCkBAIC01OTIsMTkgKzU5MiwyMCBAQCBzdGF0aWMgdm9p ZCBwYWludEJ1dHRvbihDb250cm9sUGFydCBwYXJ0LCBDb250cm9sU3RhdGVzKiBjb250cm9sU3Rh dGVzLCBHcmFwaGljcwogICAgIH0gZWxzZSBpZiAoW3ByZXZpb3VzRGVmYXVsdEJ1dHRvbkNlbGwg aXNFcXVhbDpidXR0b25DZWxsXSkKICAgICAgICAgW3dpbmRvdyBzZXREZWZhdWx0QnV0dG9uQ2Vs bDpuaWxdOwogCisgICAgRmxvYXRSZWN0IGRyYXdGcm9tSW1hZ2VCdWZmZXJSZWN0KGZvY3VzVGhp Y2tuZXNzLCBmb2N1c1RoaWNrbmVzcywgaW5mbGF0ZWRSZWN0LndpZHRoKCksIGluZmxhdGVkUmVj dC5oZWlnaHQoKSk7CiAgICAgaWYgKHNob3VsZFVzZUltYWdlQnVmZmVyKSB7Ci0gICAgICAgIFti dXR0b25DZWxsIGRyYXdXaXRoRnJhbWU6Q0dSZWN0TWFrZShmb2N1c1RoaWNrbmVzcywgZm9jdXNU aGlja25lc3MsIGluZmxhdGVkUmVjdC53aWR0aCgpLCBpbmZsYXRlZFJlY3QuaGVpZ2h0KCkpIGlu Vmlldzp2aWV3XTsKKyAgICAgICAgW2J1dHRvbkNlbGwgZHJhd1dpdGhGcmFtZTpOU1JlY3QoZHJh d0Zyb21JbWFnZUJ1ZmZlclJlY3QpIGluVmlldzp2aWV3XTsKICAgICAgICAgaWYgKCEoc3RhdGVz ICYgQ29udHJvbFN0YXRlczo6Rm9jdXNTdGF0ZSkpCiAgICAgICAgICAgICBjb250ZXh0LT5kcmF3 SW1hZ2VCdWZmZXIoaW1hZ2VCdWZmZXIuZ2V0KCksIENvbG9yU3BhY2VEZXZpY2VSR0IsIGluZmxh dGVkUmVjdC5sb2NhdGlvbigpIC0gRmxvYXRTaXplKGZvY3VzVGhpY2tuZXNzLCBmb2N1c1RoaWNr bmVzcykpOwogICAgIH0gZWxzZQotICAgICAgICBbYnV0dG9uQ2VsbCBkcmF3V2l0aEZyYW1lOkNH UmVjdChpbmZsYXRlZFJlY3QpIGluVmlldzp2aWV3XTsKKyAgICAgICAgW2J1dHRvbkNlbGwgZHJh d1dpdGhGcmFtZTpOU1JlY3QoaW5mbGF0ZWRSZWN0KSBpblZpZXc6dmlld107CiAgICAgCiAgICAg aWYgKHN0YXRlcyAmIENvbnRyb2xTdGF0ZXM6OkZvY3VzU3RhdGUpIHsKICAgICAgICAgaWYgKHNo b3VsZFVzZUltYWdlQnVmZmVyKSB7Ci0gICAgICAgICAgICBkcmF3Q2VsbEZvY3VzUmluZyhidXR0 b25DZWxsLCBDR1JlY3RNYWtlKGZvY3VzVGhpY2tuZXNzLCBmb2N1c1RoaWNrbmVzcywgaW5mbGF0 ZWRSZWN0LndpZHRoKCksIGluZmxhdGVkUmVjdC5oZWlnaHQoKSksIHZpZXcpOworICAgICAgICAg ICAgZHJhd0NlbGxGb2N1c1JpbmcoYnV0dG9uQ2VsbCwgTlNSZWN0KGRyYXdGcm9tSW1hZ2VCdWZm ZXJSZWN0KSwgdmlldyk7CiAgICAgICAgICAgICBjb250ZXh0LT5kcmF3SW1hZ2VCdWZmZXIoaW1h Z2VCdWZmZXIuZ2V0KCksIENvbG9yU3BhY2VEZXZpY2VSR0IsIGluZmxhdGVkUmVjdC5sb2NhdGlv bigpIC0gRmxvYXRTaXplKGZvY3VzVGhpY2tuZXNzLCBmb2N1c1RoaWNrbmVzcykpOwogICAgICAg ICB9IGVsc2UKLSAgICAgICAgICAgIGRyYXdDZWxsRm9jdXNSaW5nKGJ1dHRvbkNlbGwsIGluZmxh dGVkUmVjdCwgdmlldyk7CisgICAgICAgICAgICBkcmF3Q2VsbEZvY3VzUmluZyhidXR0b25DZWxs LCBOU1JlY3QoaW5mbGF0ZWRSZWN0KSwgdmlldyk7CiAgICAgfQogICAgIAogICAgIGNvbnRyb2xT dGF0ZXMtPnNldE5lZWRzUmVwYWludChmYWxzZSk7Cg==