146925 2015-07-13 18:14:08 -0700 Remove unused HistoryItem copy constructor. 2015-07-13 18:24:29 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 kling kling kling oldest_to_newest 1109302 0 kling 2015-07-13 18:14:08 -0700 Looks like nobody uses HistoryItem's copy constructor. 1109303 1 256753 kling 2015-07-13 18:16:02 -0700 Created attachment 256753 Patch 1109305 2 kling 2015-07-13 18:24:29 -0700 Oops, not unused. 256753 2015-07-13 18:16:02 -0700 2015-07-13 18:16:02 -0700 Patch bug-146925.diff text/plain 5672 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyN2VlYmVmLi5iY2QyNjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTUtMDctMTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSB1bnVzZWQgSGlzdG9yeUl0ZW0gY29weSBjb25zdHJ1Y3Rvci4KKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0NjkyNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBIaXN0b3J5SXRlbSdzIGNvcHkgY29uc3RydWN0b3IgaGFk IG5vIGNsaWVudHMsIHNvIHJlbW92ZSBpdC4KKyAgICAgICAgQWxzbyByZW1vdmUgRm9ybURhdGEn cyBjb3B5IGNvbnN0cnVjdG9yIHNpbmNlIHRoaXMgcGF0Y2ggcmVtb3ZlcyBpdHMgb25seSBjbGll bnQuCisKKyAgICAgICAgKiBoaXN0b3J5L0hpc3RvcnlJdGVtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Okhpc3RvcnlJdGVtOjpIaXN0b3J5SXRlbSk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3Jl OjpIaXN0b3J5SXRlbTo6Y29weSk6IERlbGV0ZWQuCisgICAgICAgICogaGlzdG9yeS9IaXN0b3J5 SXRlbS5oOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvRm9ybURhdGEuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Rm9ybURhdGE6OkZvcm1EYXRhKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNv cmU6OkZvcm1EYXRhOjpjb3B5KTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3Jr L0Zvcm1EYXRhLmg6CisKIDIwMTUtMDctMTMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBXSzJdIFdoZW4gY2hvb3NpbmcgYW4gaW5pdGlhbCB2 aWV3cG9ydCBzY2FsZSwgdGFrZSBvdmVyZmxvdyBvbiB0aGUgPGJvZHk+IGludG8gYWNjb3VudApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9IaXN0b3J5SXRlbS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcAppbmRleCA4YWI1ZTg2Li5iMGE1Y2Vi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcApAQCAtMTM2LDQ3ICsxMzYs NiBAQCBIaXN0b3J5SXRlbTo6fkhpc3RvcnlJdGVtKCkKICAgICBpY29uRGF0YWJhc2UoKS5yZWxl YXNlSWNvbkZvclBhZ2VVUkwobV91cmxTdHJpbmcpOwogfQogCi1pbmxpbmUgSGlzdG9yeUl0ZW06 Okhpc3RvcnlJdGVtKGNvbnN0IEhpc3RvcnlJdGVtJiBpdGVtKQotICAgIDogUmVmQ291bnRlZDxI aXN0b3J5SXRlbT4oKQotICAgICwgbV91cmxTdHJpbmcoaXRlbS5tX3VybFN0cmluZykKLSAgICAs IG1fb3JpZ2luYWxVUkxTdHJpbmcoaXRlbS5tX29yaWdpbmFsVVJMU3RyaW5nKQotICAgICwgbV9y ZWZlcnJlcihpdGVtLm1fcmVmZXJyZXIpCi0gICAgLCBtX3RhcmdldChpdGVtLm1fdGFyZ2V0KQot ICAgICwgbV9wYXJlbnQoaXRlbS5tX3BhcmVudCkKLSAgICAsIG1fdGl0bGUoaXRlbS5tX3RpdGxl KQotICAgICwgbV9kaXNwbGF5VGl0bGUoaXRlbS5tX2Rpc3BsYXlUaXRsZSkKLSAgICAsIG1fc2Ny b2xsUG9pbnQoaXRlbS5tX3Njcm9sbFBvaW50KQotICAgICwgbV9wYWdlU2NhbGVGYWN0b3IoaXRl bS5tX3BhZ2VTY2FsZUZhY3RvcikKLSAgICAsIG1fbGFzdFZpc2l0V2FzRmFpbHVyZShpdGVtLm1f bGFzdFZpc2l0V2FzRmFpbHVyZSkKLSAgICAsIG1faXNUYXJnZXRJdGVtKGl0ZW0ubV9pc1Rhcmdl dEl0ZW0pCi0gICAgLCBtX2l0ZW1TZXF1ZW5jZU51bWJlcihpdGVtLm1faXRlbVNlcXVlbmNlTnVt YmVyKQotICAgICwgbV9kb2N1bWVudFNlcXVlbmNlTnVtYmVyKGl0ZW0ubV9kb2N1bWVudFNlcXVl bmNlTnVtYmVyKQotICAgICwgbV9mb3JtQ29udGVudFR5cGUoaXRlbS5tX2Zvcm1Db250ZW50VHlw ZSkKLSAgICAsIG1fcHJ1bmluZ1JlYXNvbihQcnVuaW5nUmVhc29uOjpOb25lKQotI2lmIFBMQVRG T1JNKElPUykKLSAgICAsIG1fc2NhbGUoaXRlbS5tX3NjYWxlKQotICAgICwgbV9zY2FsZUlzSW5p dGlhbChpdGVtLm1fc2NhbGVJc0luaXRpYWwpCi0gICAgLCBtX2Jvb2ttYXJrSUQoaXRlbS5tX2Jv b2ttYXJrSUQpCi0gICAgLCBtX3NoYXJlZExpbmtVbmlxdWVJZGVudGlmaWVyKGl0ZW0ubV9zaGFy ZWRMaW5rVW5pcXVlSWRlbnRpZmllcikKLSNlbmRpZgotewotICAgIGlmIChpdGVtLm1fZm9ybURh dGEpCi0gICAgICAgIG1fZm9ybURhdGEgPSBpdGVtLm1fZm9ybURhdGEtPmNvcHkoKTsKLSAgICAg ICAgCi0gICAgdW5zaWduZWQgc2l6ZSA9IGl0ZW0ubV9jaGlsZHJlbi5zaXplKCk7Ci0gICAgbV9j aGlsZHJlbi5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KHNpemUpOwotICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBzaXplOyArK2kpCi0gICAgICAgIG1fY2hpbGRyZW4udW5jaGVja2VkQXBwZW5k KGl0ZW0ubV9jaGlsZHJlbltpXS0+Y29weSgpKTsKLQotICAgIGlmIChpdGVtLm1fcmVkaXJlY3RV UkxzKQotICAgICAgICBtX3JlZGlyZWN0VVJMcyA9IHN0ZDo6bWFrZV91bmlxdWU8VmVjdG9yPFN0 cmluZz4+KCppdGVtLm1fcmVkaXJlY3RVUkxzKTsKLX0KLQotUmVmPEhpc3RvcnlJdGVtPiBIaXN0 b3J5SXRlbTo6Y29weSgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgSGlzdG9y eUl0ZW0oKnRoaXMpKTsKLX0KLQogdm9pZCBIaXN0b3J5SXRlbTo6cmVzZXQoKQogewogICAgIGlj b25EYXRhYmFzZSgpLnJlbGVhc2VJY29uRm9yUGFnZVVSTChtX3VybFN0cmluZyk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmggYi9Tb3VyY2UvV2ViQ29y ZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmgKaW5kZXggM2FhY2MyYS4uODcyODcyMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9IaXN0b3J5SXRlbS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2hpc3RvcnkvSGlzdG9yeUl0ZW0uaApAQCAtNzksOCArNzksNiBAQCBwdWJsaWM6CiAgICAg CiAgICAgV0VCQ09SRV9FWFBPUlQgfkhpc3RvcnlJdGVtKCk7CiAKLSAgICBXRUJDT1JFX0VYUE9S VCBSZWY8SGlzdG9yeUl0ZW0+IGNvcHkoKSBjb25zdDsKLQogICAgIC8vIFJlc2V0cyB0aGUgSGlz dG9yeUl0ZW0gdG8gaXRzIGluaXRpYWwgc3RhdGUsIGFzIHJldHVybmVkIGJ5IGNyZWF0ZSgpLgog ICAgIHZvaWQgcmVzZXQoKTsKICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvRm9ybURhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9Gb3JtRGF0YS5jcHAKaW5kZXggZjdlMTJjMi4uNzg4ZDU1MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAKQEAgLTQ1LDIzICs0NSw2IEBAIGlubGlu ZSBGb3JtRGF0YTo6Rm9ybURhdGEoKQogewogfQogCi1pbmxpbmUgRm9ybURhdGE6OkZvcm1EYXRh KGNvbnN0IEZvcm1EYXRhJiBkYXRhKQotICAgIDogUmVmQ291bnRlZDxGb3JtRGF0YT4oKQotICAg ICwgbV9lbGVtZW50cyhkYXRhLm1fZWxlbWVudHMpCi0gICAgLCBtX2lkZW50aWZpZXIoZGF0YS5t X2lkZW50aWZpZXIpCi0gICAgLCBtX2Fsd2F5c1N0cmVhbShmYWxzZSkKLSAgICAsIG1fY29udGFp bnNQYXNzd29yZERhdGEoZGF0YS5tX2NvbnRhaW5zUGFzc3dvcmREYXRhKQotewotICAgIC8vIFdl IHNob3VsZG4ndCBiZSBjb3B5aW5nIEZvcm1EYXRhIHRoYXQgaGFzbid0IGFscmVhZHkgcmVtb3Zl ZCBpdHMgZ2VuZXJhdGVkIGZpbGVzCi0gICAgLy8gYnV0IGp1c3QgaW4gY2FzZSwgbWFrZSBzdXJl IHRoZSBuZXcgRm9ybURhdGEgaXMgcmVhZHkgdG8gZ2VuZXJhdGUgaXRzIG93biBmaWxlcy4KLSAg ICBmb3IgKEZvcm1EYXRhRWxlbWVudCYgZWxlbWVudCA6IG1fZWxlbWVudHMpIHsKLSAgICAgICAg aWYgKGVsZW1lbnQubV90eXBlID09IEZvcm1EYXRhRWxlbWVudDo6VHlwZTo6RW5jb2RlZEZpbGUp IHsKLSAgICAgICAgICAgIGVsZW1lbnQubV9nZW5lcmF0ZWRGaWxlbmFtZSA9IFN0cmluZygpOwot ICAgICAgICAgICAgZWxlbWVudC5tX293bnNHZW5lcmF0ZWRGaWxlID0gZmFsc2U7Ci0gICAgICAg IH0KLSAgICB9Ci19Ci0KIEZvcm1EYXRhOjp+Rm9ybURhdGEoKQogewogICAgIC8vIFRoaXMgY2xl YW51cCBzaG91bGQndmUgaGFwcGVuZWQgd2hlbiB0aGUgZm9ybSBzdWJtaXNzaW9uIGZpbmlzaGVk LgpAQCAtMTEwLDExICs5Myw2IEBAIFBhc3NSZWZQdHI8Rm9ybURhdGE+IEZvcm1EYXRhOjpjcmVh dGVNdWx0aVBhcnQoY29uc3QgRm9ybURhdGFMaXN0JiBsaXN0LCBjb25zdCBUCiAgICAgcmV0dXJu IHJlc3VsdC5yZWxlYXNlKCk7CiB9CiAKLVBhc3NSZWZQdHI8Rm9ybURhdGE+IEZvcm1EYXRhOjpj b3B5KCkgY29uc3QKLXsKLSAgICByZXR1cm4gYWRvcHRSZWYobmV3IEZvcm1EYXRhKCp0aGlzKSk7 Ci19Ci0KIFBhc3NSZWZQdHI8Rm9ybURhdGE+IEZvcm1EYXRhOjpkZWVwQ29weSgpIGNvbnN0CiB7 CiAgICAgUmVmUHRyPEZvcm1EYXRhPiBmb3JtRGF0YShjcmVhdGUoKSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmgKaW5kZXggMmRkMDdiMS4uY2I3ZTBkZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRm9ybURhdGEuaApAQCAtMjAyLDkgKzIw Miw2IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxGb3JtRGF0YT4gY3JlYXRlTXVs dGlQYXJ0KGNvbnN0IEZvcm1EYXRhTGlzdCYsIGNvbnN0IFRleHRFbmNvZGluZyYsIERvY3VtZW50 Kik7CiAgICAgV0VCQ09SRV9FWFBPUlQgfkZvcm1EYXRhKCk7CiAKLSAgICAvLyBGSVhNRTogQm90 aCB0aGVzZSBmdW5jdGlvbnMgcGVyZm9ybSBhIGRlZXAgY29weSBvZiBtX2VsZW1lbnRzLCBidXQg ZGlmZmVyIGluIGhhbmRsaW5nIG9mIG90aGVyIGRhdGEgbWVtYmVycy4KLSAgICAvLyBIb3cgbXVj aCBvZiB0aGF0IGlzIGludGVudGlvbmFsPyBXZSBuZWVkIGJldHRlciBuYW1lcyB0aGF0IGV4cGxh aW4gdGhlIGRpZmZlcmVuY2UuCi0gICAgUGFzc1JlZlB0cjxGb3JtRGF0YT4gY29weSgpIGNvbnN0 OwogICAgIFBhc3NSZWZQdHI8Rm9ybURhdGE+IGRlZXBDb3B5KCkgY29uc3Q7CiAKICAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBFbmNvZGVyPgpAQCAtMjU0LDcgKzI1MSw2IEBAIHB1YmxpYzoKIAogcHJp dmF0ZToKICAgICBGb3JtRGF0YSgpOwotICAgIEZvcm1EYXRhKGNvbnN0IEZvcm1EYXRhJik7CiAK ICAgICB2b2lkIGFwcGVuZEtleVZhbHVlUGFpckl0ZW1zKGNvbnN0IEZvcm1EYXRhTGlzdCYsIGNv bnN0IFRleHRFbmNvZGluZyYsIGJvb2wgaXNNdWx0aVBhcnRGb3JtLCBEb2N1bWVudCosIEVuY29k aW5nVHlwZSA9IEZvcm1VUkxFbmNvZGVkKTsKIAo=