146920 2015-07-13 15:46:12 -0700 Cleanup: Avoid extraneous increment and decrement of reference count of ScriptArguments in ConsoleClient 2015-07-13 16:12:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates burg joepeck timothy oldest_to_newest 1109253 0 dbates 2015-07-13 15:46:12 -0700 Avoid extraneous ref/deref for ScriptArguments. 1109254 1 256735 dbates 2015-07-13 15:47:02 -0700 Created attachment 256735 Patch 1109269 2 256735 burg 2015-07-13 16:04:49 -0700 Comment on attachment 256735 Patch r=me, thanks for cleanup! 1109273 3 256735 dbates 2015-07-13 16:12:13 -0700 Comment on attachment 256735 Patch Clearing flags on attachment: 256735 Committed r186794: <http://trac.webkit.org/changeset/186794> 1109274 4 dbates 2015-07-13 16:12:18 -0700 All reviewed patches have been landed. Closing bug. 256735 2015-07-13 15:47:02 -0700 2015-07-13 16:12:13 -0700 Patch bug-146920-20150713154556.patch text/plain 3110 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2Njg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZTAyYTA1OTEyZDA0NGE1NWI2NzIwZGJhNDAzM2FkZmYwYTgwOTUzLi44YzYzMDFhZjNkYTBlYWRj OWZjZmFhY2QyOGYzNmY1MTcxMjk2Y2ExIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNy0xMyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CisKKyAgICAgICAgQ2xlYW51cDogQXZvaWQgZXh0cmFuZW91cyBpbmNyZW1lbnQgYW5kIGRlY3Jl bWVudCBvZiByZWZlcmVuY2UgY291bnQgb2YgU2NyaXB0QXJndW1lbnRzIGluIENvbnNvbGVDbGll bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Njky MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBsb2NhbCB2YXJpYWJsZSBSZWZQdHI8U2NyaXB0QXJndW1lbnRzPiBhbmQgY29weSBjb25zdHJ1 Y3RvciBjYWxsIHdpdGggYW4gYXJndW1lbnQgdGhhdAorICAgICAgICB3YXMgaW5pdGlhbGl6ZWQg d2l0aCBhbiBydmFsdWUgcmVmZXJlbmNlLiBUaGUgYXJndW1lbnQgaXRzZWxmIGlzIGFuIGx2YWx1 ZSByZWZlcmVuY2UuCisKKyAgICAgICAgKiBydW50aW1lL0NvbnNvbGVDbGllbnQuY3BwOgorICAg ICAgICAoSlNDOjpDb25zb2xlQ2xpZW50OjpwcmludENvbnNvbGVNZXNzYWdlV2l0aEFyZ3VtZW50 cyk6CisgICAgICAgIChKU0M6OkNvbnNvbGVDbGllbnQ6OmludGVybmFsTWVzc2FnZVdpdGhUeXBl QW5kTGV2ZWwpOgorCiAyMDE1LTA3LTA5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBTeW1ib2xUYWJsZTo6ZW50cnlGb3IoKSBzaG91bGQgZG8gYSBib3VuZHMgY2hl Y2sgYmVmb3JlIGluZGV4aW5nIGludG8gdGhlIGxvY2FsVG9FbnRyeSB2ZWN0b3IuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xlQ2xpZW50LmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbnNvbGVDbGllbnQuY3BwCmluZGV4IDMxYjQ4 YjIyMmY4YTRhYzI4YjFhYzJmZjBmMWMzZjk0M2FmYWMzNGMuLmIyNTVhYTIwODcyZTVjZDAyMzY4 ZGY4ZTAxYWY0MWJkZWM0MzZkZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0NvbnNvbGVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbnNvbGVDbGllbnQuY3BwCkBAIC0xNDYsMTAgKzE0Niw4IEBAIHZvaWQgQ29uc29sZUNs aWVudDo6cHJpbnRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlIHNvdXJjZSwgTWVzc2FnZVR5 cGUgdHlwZSwKICAgICBXVEZMb2dBbHdheXMoIiVzIiwgYnVpbGRlci50b1N0cmluZygpLnV0Zjgo KS5kYXRhKCkpOwogfQogCi12b2lkIENvbnNvbGVDbGllbnQ6OnByaW50Q29uc29sZU1lc3NhZ2VX aXRoQXJndW1lbnRzKE1lc3NhZ2VTb3VyY2Ugc291cmNlLCBNZXNzYWdlVHlwZSB0eXBlLCBNZXNz YWdlTGV2ZWwgbGV2ZWwsIEpTQzo6RXhlY1N0YXRlKiBleGVjLCBSZWZQdHI8U2NyaXB0QXJndW1l bnRzPiYmIHBycEFyZ3VtZW50cykKK3ZvaWQgQ29uc29sZUNsaWVudDo6cHJpbnRDb25zb2xlTWVz c2FnZVdpdGhBcmd1bWVudHMoTWVzc2FnZVNvdXJjZSBzb3VyY2UsIE1lc3NhZ2VUeXBlIHR5cGUs IE1lc3NhZ2VMZXZlbCBsZXZlbCwgSlNDOjpFeGVjU3RhdGUqIGV4ZWMsIFJlZlB0cjxTY3JpcHRB cmd1bWVudHM+JiYgYXJndW1lbnRzKQogewotICAgIFJlZlB0cjxTY3JpcHRBcmd1bWVudHM+IGFy Z3VtZW50cyA9IHBycEFyZ3VtZW50czsKLQogICAgIGJvb2wgaXNUcmFjZU1lc3NhZ2UgPSB0eXBl ID09IE1lc3NhZ2VUeXBlOjpUcmFjZTsKICAgICBzaXplX3Qgc3RhY2tTaXplID0gaXNUcmFjZU1l c3NhZ2UgPyBTY3JpcHRDYWxsU3RhY2s6Om1heENhbGxTdGFja1NpemVUb0NhcHR1cmUgOiAxOwog ICAgIFJlZlB0cjxTY3JpcHRDYWxsU3RhY2s+IGNhbGxTdGFjayhjcmVhdGVTY3JpcHRDYWxsU3Rh Y2tGb3JDb25zb2xlKGV4ZWMsIHN0YWNrU2l6ZSkpOwpAQCAtMTkxLDEzICsxODksMTIgQEAgdm9p ZCBDb25zb2xlQ2xpZW50OjpwcmludENvbnNvbGVNZXNzYWdlV2l0aEFyZ3VtZW50cyhNZXNzYWdl U291cmNlIHNvdXJjZSwgTWVzc2EKICAgICB9CiB9CiAKLXZvaWQgQ29uc29sZUNsaWVudDo6aW50 ZXJuYWxNZXNzYWdlV2l0aFR5cGVBbmRMZXZlbChNZXNzYWdlVHlwZSB0eXBlLCBNZXNzYWdlTGV2 ZWwgbGV2ZWwsIEpTQzo6RXhlY1N0YXRlKiBleGVjLCBSZWZQdHI8U2NyaXB0QXJndW1lbnRzPiYm IHBycEFyZ3VtZW50cywgQXJndW1lbnRSZXF1aXJlbWVudCBhcmd1bWVudFJlcXVpcmVtZW50KQor dm9pZCBDb25zb2xlQ2xpZW50OjppbnRlcm5hbE1lc3NhZ2VXaXRoVHlwZUFuZExldmVsKE1lc3Nh Z2VUeXBlIHR5cGUsIE1lc3NhZ2VMZXZlbCBsZXZlbCwgSlNDOjpFeGVjU3RhdGUqIGV4ZWMsIFJl ZlB0cjxTY3JpcHRBcmd1bWVudHM+JiYgYXJndW1lbnRzLCBBcmd1bWVudFJlcXVpcmVtZW50IGFy Z3VtZW50UmVxdWlyZW1lbnQpCiB7Ci0gICAgUmVmUHRyPFNjcmlwdEFyZ3VtZW50cz4gYXJndW1l bnRzID0gcHJwQXJndW1lbnRzOwogICAgIGlmIChhcmd1bWVudFJlcXVpcmVtZW50ID09IEFyZ3Vt ZW50UmVxdWlyZWQgJiYgIWFyZ3VtZW50cy0+YXJndW1lbnRDb3VudCgpKQogICAgICAgICByZXR1 cm47CiAKLSAgICBtZXNzYWdlV2l0aFR5cGVBbmRMZXZlbCh0eXBlLCBsZXZlbCwgZXhlYywgYXJn dW1lbnRzLnJlbGVhc2UoKSk7CisgICAgbWVzc2FnZVdpdGhUeXBlQW5kTGV2ZWwodHlwZSwgbGV2 ZWwsIGV4ZWMsIFdURjo6bW92ZShhcmd1bWVudHMpKTsKIH0KIAogdm9pZCBDb25zb2xlQ2xpZW50 Ojpsb2dXaXRoTGV2ZWwoRXhlY1N0YXRlKiBleGVjLCBSZWZQdHI8U2NyaXB0QXJndW1lbnRzPiYm IGFyZ3VtZW50cywgTWVzc2FnZUxldmVsIGxldmVsKQo=