146919 2015-07-13 15:28:42 -0700 Web Inspector: Uncaught exception in inspector for some ConsoleMessages 2015-07-13 16:54:30 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts hi joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1109247 0 joepeck 2015-07-13 15:28:42 -0700 * SUMMARY Uncaught exception in inspector for engine generated ConsoleMessages with just message text and no parameters or stack trace. TypeError: undefined is not an object (evaluating 'this._message.parameters.length') (ConsoleMessageView.js) When a security message is logged, inspector² shows uncaught exception * NOTES Fallout from bug 146377. 1109248 1 256733 joepeck 2015-07-13 15:29:38 -0700 Created attachment 256733 [PATCH] Proposed Fix 1109268 2 256733 burg 2015-07-13 16:03:09 -0700 Comment on attachment 256733 [PATCH] Proposed Fix r=me 1109285 3 256733 commit-queue 2015-07-13 16:54:25 -0700 Comment on attachment 256733 [PATCH] Proposed Fix Clearing flags on attachment: 256733 Committed r186796: <http://trac.webkit.org/changeset/186796> 1109286 4 commit-queue 2015-07-13 16:54:30 -0700 All reviewed patches have been landed. Closing bug. 256733 2015-07-13 15:29:38 -0700 2015-07-13 16:54:25 -0700 [PATCH] Proposed Fix null-check.patch text/plain 1524 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFkNGVjMTIuLjdjZmI0NGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIGluIGluc3BlY3RvciBmb3Igc29tZSBDb25zb2xlTWVzc2FnZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjkxOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29u c29sZU1lc3NhZ2VWaWV3LnByb3RvdHlwZS5fYXBwZW5kTG9jYXRpb25MaW5rKToKKyAgICAgICAg VGhlIHBhcmFtZXRlcnMgbGlzdCBtYXkgbm90IGV4aXN0LCBzbyBudWxsIGNoZWNrIGl0IGJlZm9y ZSB1c2UuCisKIDIwMTUtMDctMTEgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcHJvdmUgcnVudGltZSBvZiBwc2V1ZG8tZWxlbWVu dCBzaWRlYmFyIHN0eWxlIG9yZGVyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMKaW5k ZXggM2RhMjhiMy4uZGExZjc1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1lc3NhZ2VWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcwpAQCAt MzIyLDcgKzMyMiw3IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZVZpZXcgPSBjbGFzcyBD b25zb2xlTWVzc2FnZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIH0KIAotICAgICAgICBpZiAodGhpcy5fbWVzc2FnZS5wYXJhbWV0ZXJzLmxl bmd0aCA9PT0gMSkgeworICAgICAgICBpZiAodGhpcy5fbWVzc2FnZS5wYXJhbWV0ZXJzICYmIHRo aXMuX21lc3NhZ2UucGFyYW1ldGVycy5sZW5ndGggPT09IDEpIHsKICAgICAgICAgICAgIHZhciBw YXJhbWV0ZXIgPSB0aGlzLl9jcmVhdGVSZW1vdGVPYmplY3RJZk5lZWRlZCh0aGlzLl9tZXNzYWdl LnBhcmFtZXRlcnNbMF0pOwogCiAgICAgICAgICAgICBwYXJhbWV0ZXIuZmluZEZ1bmN0aW9uU291 cmNlQ29kZUxvY2F0aW9uKCkudGhlbihmdW5jdGlvbihyZXN1bHQpIHsK