146917 2015-07-13 14:46:23 -0700 iOS WebKit doesn't build. 2015-07-14 10:39:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca commit-queue mitz sam thorton oldest_to_newest 1109231 0 yongjun_zhang 2015-07-13 14:46:23 -0700 We shouldn't use deprecated UIVC API for preview. 1109233 1 256730 yongjun_zhang 2015-07-13 14:50:14 -0700 Created attachment 256730 Patch. 1109234 2 yongjun_zhang 2015-07-13 14:52:16 -0700 rdar://problem/21801544 1109236 3 256730 mitz 2015-07-13 15:00:47 -0700 Comment on attachment 256730 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=256730&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3185 > + _previewing = [window.rootViewController registerForPreviewingWithSourceView:self]; Do we need to retain this? 1109237 4 mitz 2015-07-13 15:00:55 -0700 I’ve already fixed the build in r186779 but moving off the deprecated API is better. 1109249 5 yongjun_zhang 2015-07-13 15:37:16 -0700 (In reply to comment #3) > Comment on attachment 256730 [details] > Patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256730&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3185 > > + _previewing = [window.rootViewController registerForPreviewingWithSourceView:self]; > > Do we need to retain this? yeah, I think we need to. Will Change. 1109250 6 256734 yongjun_zhang 2015-07-13 15:39:36 -0700 Created attachment 256734 Fix the conflict. 1109257 7 256734 mitz 2015-07-13 15:50:30 -0700 Comment on attachment 256734 Fix the conflict. View in context: https://bugs.webkit.org/attachment.cgi?id=256734&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197 > + _previewing.delegate = nil; > [_previewGestureRecognizer setDelegate:nil]; > _previewGestureRecognizer = nil; > + [_previewing release]; Should we do these two new things (clearing the delegate and releasing) in our -dealloc too, just in case? 1109378 8 yongjun_zhang 2015-07-14 09:42:05 -0700 (In reply to comment #7) > Comment on attachment 256734 [details] > Fix the conflict. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256734&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197 > > + _previewing.delegate = nil; > > [_previewGestureRecognizer setDelegate:nil]; > > _previewGestureRecognizer = nil; > > + [_previewing release]; > > Should we do these two new things (clearing the delegate and releasing) in > our -dealloc too, just in case? I don't think it's needed. We will do the cleanup when the view is removed from window, which should be done before dealloc. 1109395 9 256734 commit-queue 2015-07-14 10:39:06 -0700 Comment on attachment 256734 Fix the conflict. Clearing flags on attachment: 256734 Committed r186808: <http://trac.webkit.org/changeset/186808> 1109396 10 commit-queue 2015-07-14 10:39:10 -0700 All reviewed patches have been landed. Closing bug. 256730 2015-07-13 14:50:14 -0700 2015-07-13 15:39:36 -0700 Patch. ios_webkit_build_break.patch text/plain 2742 yongjun_zhang Y29tbWl0IGYwZWY5NDU1MzkzOGNmMGVkM2Q4NmQ4ZGY5YzIzNmMyZmY3N2RjYzgKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gSnVsIDEz IDE0OjQ2OjA4IDIwMTUgLTA3MDAKCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ2OTE3CiAgICBXZSBzaG91bGRuJ3QgdXNlIGRlcHJlY2F0ZWQgVUlWQyBBUEkg Zm9yIHByZXZpZXcuCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDM1M2RiNjQuLmZmYTkxZjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAxNS0wNy0xMyAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5femhh bmdAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDY5MTcKKyAgICAgICAgaU9TIFdlYktpdCBkb2Vzbid0IGJ1aWxkLgorCisgICAg ICAgIFdlIHNob3VsZG4ndCB1c2UgZGVwcmVjYXRlZCBVSVZDIEFQSSBmb3IgbGluayBwcmV2aWV3 LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaDoKKyAgICAgICAgKiBVSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50 VmlldyBfcmVnaXN0ZXJQcmV2aWV3SW5XaW5kb3c6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZp ZXcgX3VucmVnaXN0ZXJQcmV2aWV3SW5XaW5kb3c6XSk6CisKIDIwMTUtMDctMTMgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtMaW51eF0gU2Vj Y29tcEZpbHRlcnM6IGhhbmRsZSBhbHRlcm5hdGUgaW5zdGFsbCBwcmVmaXhlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u aCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u LmgKaW5kZXggNzAxMTVmZS4uMWI5ZmFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCkBAIC0xNTIsNiArMTUy LDkgQEAgZW51bSBjbGFzcyBQcmV2aWV3RWxlbWVudFR5cGUgewogICAgIENHUG9pbnQgX2xhc3RJ bnRlcmFjdGlvbkxvY2F0aW9uOwogCiAgICAgV2ViS2l0OjpXS1NlbGVjdGlvbkRyYXdpbmdJbmZv IF9sYXN0U2VsZWN0aW9uRHJhd2luZ0luZm87CisjaWYgSEFWRShMSU5LX1BSRVZJRVcpCisgICAg aWQgPFVJVmlld0NvbnRyb2xsZXJQcmV2aWV3aW5nPiBfcHJldmlld2luZzsKKyNlbmRpZgogCiAg ICAgQk9PTCBfaXNFZGl0YWJsZTsKICAgICBCT09MIF9zaG93aW5nVGV4dFN0eWxlT3B0aW9uczsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KaW5kZXggNTc2OTc3My4uMTE3M2JlNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0K QEAgLTMxODIsMTQgKzMxODIsMTYgQEAgc3RhdGljIGJvb2wgaXNBc3Npc3RhYmxlSW5wdXRUeXBl KElucHV0VHlwZSB0eXBlKQogCiAtICh2b2lkKV9yZWdpc3RlclByZXZpZXdJbldpbmRvdzooVUlX aW5kb3cgKil3aW5kb3cKIHsKLSAgICBbd2luZG93LnJvb3RWaWV3Q29udHJvbGxlciByZWdpc3Rl clByZXZpZXdTb3VyY2VWaWV3OnNlbGYgcHJldmlld2luZ0RlbGVnYXRlOnNlbGZdOwotICAgIF9w cmV2aWV3R2VzdHVyZVJlY29nbml6ZXIgPSBzZWxmLmdlc3R1cmVSZWNvZ25pemVycy5sYXN0T2Jq ZWN0OworICAgIF9wcmV2aWV3aW5nID0gW3dpbmRvdy5yb290Vmlld0NvbnRyb2xsZXIgcmVnaXN0 ZXJGb3JQcmV2aWV3aW5nV2l0aFNvdXJjZVZpZXc6c2VsZl07CisgICAgX3ByZXZpZXdpbmcuZGVs ZWdhdGUgPSBzZWxmOworICAgIF9wcmV2aWV3R2VzdHVyZVJlY29nbml6ZXIgPSBfcHJldmlld2lu Zy5wcmVzZW50YXRpb25HZXN0dXJlUmVjb2duaXplcjsKICAgICBbX3ByZXZpZXdHZXN0dXJlUmVj b2duaXplciBzZXREZWxlZ2F0ZTpzZWxmXTsKIH0KIAogLSAodm9pZClfdW5yZWdpc3RlclByZXZp ZXdJbldpbmRvdzooVUlXaW5kb3cgKil3aW5kb3cKIHsKLSAgICBbd2luZG93LnJvb3RWaWV3Q29u dHJvbGxlciB1bnJlZ2lzdGVyUHJldmlld1NvdXJjZVZpZXc6c2VsZl07CisgICAgW3dpbmRvdy5y b290Vmlld0NvbnRyb2xsZXIgdW5yZWdpc3RlclByZXZpZXdpbmc6X3ByZXZpZXdpbmddOworICAg IF9wcmV2aWV3aW5nLmRlbGVnYXRlID0gbmlsOwogICAgIFtfcHJldmlld0dlc3R1cmVSZWNvZ25p emVyIHNldERlbGVnYXRlOm5pbF07CiAgICAgX3ByZXZpZXdHZXN0dXJlUmVjb2duaXplciA9IG5p bDsKIH0K 256734 2015-07-13 15:39:36 -0700 2015-07-14 10:39:06 -0700 Fix the conflict. build_webkit-fix.patch text/plain 3077 yongjun_zhang Y29tbWl0IDA5NmEwNDgyZWEwMTRiNmZmNDc0YjllODA5YmQ0NTU1OGVjNzNiNTQKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gSnVsIDEz IDE0OjU4OjMzIDIwMTUgLTA3MDAKCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ2OTE3CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDZiM2IxMDYuLjlmNDg2MTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0wNy0xMyAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5f emhhbmdAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDY5MTcKKyAgICAgICAgaU9TIFdlYktpdCBkb2Vzbid0IGJ1aWxkLgorICAg ICAgICByZGFyOi8vcHJvYmxlbS8yMTgwMTU0NAorCisgICAgICAgIEZpeCB0aGUgYnVpbGQgLSBk b24ndCB1c2UgZGVwcmVjYXRlZCBtZXRob2RzLgorCisgICAgICAgIFJldmlld2VkIGJ5IERhbiBC ZXJuc3RlaW4uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9yZWdpc3RlclByZXZpZXdJbldpbmRvdzpd KToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfdW5yZWdpc3RlclByZXZpZXdJbldpbmRvdzpd KToKKwogMjAxNS0wNy0xMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeGVkIHRoZSBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCmluZGV4IDcwMTE1ZmUuLjFiOWZhZjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24uaApAQCAtMTUyLDYgKzE1Miw5IEBAIGVudW0gY2xhc3MgUHJldmlld0Vs ZW1lbnRUeXBlIHsKICAgICBDR1BvaW50IF9sYXN0SW50ZXJhY3Rpb25Mb2NhdGlvbjsKIAogICAg IFdlYktpdDo6V0tTZWxlY3Rpb25EcmF3aW5nSW5mbyBfbGFzdFNlbGVjdGlvbkRyYXdpbmdJbmZv OworI2lmIEhBVkUoTElOS19QUkVWSUVXKQorICAgIGlkIDxVSVZpZXdDb250cm9sbGVyUHJldmll d2luZz4gX3ByZXZpZXdpbmc7CisjZW5kaWYKIAogICAgIEJPT0wgX2lzRWRpdGFibGU7CiAgICAg Qk9PTCBfc2hvd2luZ1RleHRTdHlsZU9wdGlvbnM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGFlZTVl YmUuLjk1Mzg5ZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMzE4MiwyMiArMzE4MiwyMCBAQCBz dGF0aWMgYm9vbCBpc0Fzc2lzdGFibGVJbnB1dFR5cGUoSW5wdXRUeXBlIHR5cGUpCiAKIC0gKHZv aWQpX3JlZ2lzdGVyUHJldmlld0luV2luZG93OihVSVdpbmRvdyAqKXdpbmRvdwogewotI3ByYWdt YSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVk ICItV2RlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIgotICAgIFt3aW5kb3cucm9vdFZpZXdDb250cm9s bGVyIHJlZ2lzdGVyUHJldmlld1NvdXJjZVZpZXc6c2VsZiBwcmV2aWV3aW5nRGVsZWdhdGU6c2Vs Zl07Ci0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCi0gICAgX3ByZXZpZXdHZXN0dXJlUmVj b2duaXplciA9IHNlbGYuZ2VzdHVyZVJlY29nbml6ZXJzLmxhc3RPYmplY3Q7CisgICAgX3ByZXZp ZXdpbmcgPSBbW3dpbmRvdy5yb290Vmlld0NvbnRyb2xsZXIgcmVnaXN0ZXJGb3JQcmV2aWV3aW5n V2l0aFNvdXJjZVZpZXc6c2VsZl0gcmV0YWluXTsKKyAgICBfcHJldmlld2luZy5kZWxlZ2F0ZSA9 IHNlbGY7CisgICAgX3ByZXZpZXdHZXN0dXJlUmVjb2duaXplciA9IF9wcmV2aWV3aW5nLnByZXNl bnRhdGlvbkdlc3R1cmVSZWNvZ25pemVyOwogICAgIFtfcHJldmlld0dlc3R1cmVSZWNvZ25pemVy IHNldERlbGVnYXRlOnNlbGZdOwogfQogCiAtICh2b2lkKV91bnJlZ2lzdGVyUHJldmlld0luV2lu ZG93OihVSVdpbmRvdyAqKXdpbmRvdwogewotI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gK LSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV2RlcHJlY2F0ZWQtZGVjbGFyYXRp b25zIgotICAgIFt3aW5kb3cucm9vdFZpZXdDb250cm9sbGVyIHVucmVnaXN0ZXJQcmV2aWV3U291 cmNlVmlldzpzZWxmXTsKLSNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKyAgICBbd2luZG93 LnJvb3RWaWV3Q29udHJvbGxlciB1bnJlZ2lzdGVyUHJldmlld2luZzpfcHJldmlld2luZ107Cisg ICAgX3ByZXZpZXdpbmcuZGVsZWdhdGUgPSBuaWw7CiAgICAgW19wcmV2aWV3R2VzdHVyZVJlY29n bml6ZXIgc2V0RGVsZWdhdGU6bmlsXTsKICAgICBfcHJldmlld0dlc3R1cmVSZWNvZ25pemVyID0g bmlsOworICAgIFtfcHJldmlld2luZyByZWxlYXNlXTsKKyAgICBfcHJldmlld2luZyA9IG5pbDsK IH0KIAogLSAoVUlWaWV3Q29udHJvbGxlciAqKXByZXZpZXdWaWV3Q29udHJvbGxlckZvclBvc2l0 aW9uOihDR1BvaW50KXBvc2l0aW9uIGluU291cmNlVmlldzooVUlWaWV3ICopc291cmNlVmlldwo=