146909 2015-07-13 12:18:24 -0700 Add actions for default link preview that uses SFSafariViewController. 2015-07-14 10:27:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca commit-queue mitz sam thorton oldest_to_newest 1109167 0 yongjun_zhang 2015-07-13 12:18:24 -0700 We need to add actions for default link preview. 1109263 1 256739 yongjun_zhang 2015-07-13 15:59:20 -0700 Created attachment 256739 Patch. 1109264 2 yongjun_zhang 2015-07-13 15:59:46 -0700 <rdar://problem/21795569> 1109387 3 256739 commit-queue 2015-07-14 10:27:23 -0700 Comment on attachment 256739 Patch. Clearing flags on attachment: 256739 Committed r186806: <http://trac.webkit.org/changeset/186806> 1109388 4 commit-queue 2015-07-14 10:27:27 -0700 All reviewed patches have been landed. Closing bug. 256739 2015-07-13 15:59:20 -0700 2015-07-14 10:27:23 -0700 Patch. default_actions.patch text/plain 3679 yongjun_zhang Y29tbWl0IGJiYjVjZmI3YzFkZDk2MTZjZGVhNjEwMmEzM2FmZjQ2ZjhlOTAxYjUKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gSnVsIDEz IDE1OjUxOjA5IDIwMTUgLTA3MDAKCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ2OTA5CiAgICBBZGQgYWN0aW9ucyBmb3IgZGVmYXVsdCBsaW5rIHByZXZpZXcg dGhhdCB1c2VzIFNGU2FmYXJpVmlld0NvbnRyb2xsZXIuCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDlmNDg2MTIu LmUwNmFiNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxNS0wNy0xMyAgWW9uZ2p1 biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgogCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY5MDkKKyAgICAgICAgQWRkIGFjdGlvbnMg Zm9yIGRlZmF1bHQgbGluayBwcmV2aWV3IHRoYXQgdXNlcyBTRlNhZmFyaVZpZXdDb250cm9sbGVy LgorCisgICAgICAgIFVzZSB0aGUgbmV3IHByaXZhdGUgcHJvcGVydGllcyB0byBwcmVwYXJlIGFj dGlvbnMgZm9yIHRoZSBkZWZhdWx0IGxpbmsgcHJldmlldyBjb250cm9sbGVyLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgcHJl dmlld1ZpZXdDb250cm9sbGVyRm9yUG9zaXRpb246aW5Tb3VyY2VWaWV3Ol0pOgorCisyMDE1LTA3 LTEzICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjkxNwogICAgICAgICBp T1MgV2ViS2l0IGRvZXNuJ3QgYnVpbGQuCiAgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzIxODAxNTQ0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCmluZGV4IDk1Mzg5ZWQwLi4wMjIyNWIwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQpAQCAtMzIyMiwxMSArMzIyMiwxMiBAQCBzdGF0aWMgYm9vbCBpc0Fzc2lzdGFibGVJbnB1dFR5 cGUoSW5wdXRUeXBlIHR5cGUpCiAgICAgaWYgKGNhblNob3dMaW5rUHJldmlldykgewogICAgICAg ICBfcHJldmlld1R5cGUgPSBQcmV2aWV3RWxlbWVudFR5cGU6Okxpbms7CiAgICAgICAgIE5TVVJM ICp0YXJnZXRVUkwgPSBbTlNVUkwgX3dlYl9VUkxXaXRoV1RGU3RyaW5nOl9wb3NpdGlvbkluZm9y bWF0aW9uLnVybF07CisgICAgICAgIFJldGFpblB0cjxfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbz4g ZWxlbWVudEluZm8gPSBhZG9wdE5TKFtbX1dLQWN0aXZhdGVkRWxlbWVudEluZm8gYWxsb2NdIF9p bml0V2l0aFR5cGU6X1dLQWN0aXZhdGVkRWxlbWVudFR5cGVMaW5rIFVSTDp0YXJnZXRVUkwgbG9j YXRpb246X3Bvc2l0aW9uSW5mb3JtYXRpb24ucG9pbnQgdGl0bGU6X3Bvc2l0aW9uSW5mb3JtYXRp b24udGl0bGUgcmVjdDpfcG9zaXRpb25JbmZvcm1hdGlvbi5ib3VuZHMgaW1hZ2U6X3Bvc2l0aW9u SW5mb3JtYXRpb24uaW1hZ2UuZ2V0KCldKTsKKyAgICAgICAgUmV0YWluUHRyPE5TQXJyYXk+IGFj dGlvbnMgPSBbX2FjdGlvblNoZWV0QXNzaXN0YW50IGRlZmF1bHRBY3Rpb25zRm9yTGlua1NoZWV0 OmVsZW1lbnRJbmZvLmdldCgpXTsKICAgICAgICAgaWYgKFt1aURlbGVnYXRlIHJlc3BvbmRzVG9T ZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6cHJldmlld1ZpZXdDb250cm9sbGVyRm9yVVJMOmRl ZmF1bHRBY3Rpb25zOmVsZW1lbnRJbmZvOildKSB7CiAgICAgICAgICAgICBfaGlnaGxpZ2h0TG9u Z1ByZXNzQ2FuQ2xpY2sgPSBOTzsKLSAgICAgICAgICAgIFJldGFpblB0cjxfV0tBY3RpdmF0ZWRF bGVtZW50SW5mbz4gZWxlbWVudEluZm8gPSBhZG9wdE5TKFtbX1dLQWN0aXZhdGVkRWxlbWVudElu Zm8gYWxsb2NdIF9pbml0V2l0aFR5cGU6X1dLQWN0aXZhdGVkRWxlbWVudFR5cGVMaW5rIFVSTDp0 YXJnZXRVUkwgbG9jYXRpb246X3Bvc2l0aW9uSW5mb3JtYXRpb24ucG9pbnQgdGl0bGU6X3Bvc2l0 aW9uSW5mb3JtYXRpb24udGl0bGUgcmVjdDpfcG9zaXRpb25JbmZvcm1hdGlvbi5ib3VuZHMgaW1h Z2U6X3Bvc2l0aW9uSW5mb3JtYXRpb24uaW1hZ2UuZ2V0KCldKTsKICAgICAgICAgICAgIF9wYWdl LT5zdGFydEludGVyYWN0aW9uV2l0aEVsZW1lbnRBdFBvc2l0aW9uKF9wb3NpdGlvbkluZm9ybWF0 aW9uLnBvaW50KTsKLSAgICAgICAgICAgIHJldHVybiBbdWlEZWxlZ2F0ZSBfd2ViVmlldzpfd2Vi VmlldyBwcmV2aWV3Vmlld0NvbnRyb2xsZXJGb3JVUkw6dGFyZ2V0VVJMIGRlZmF1bHRBY3Rpb25z OltfYWN0aW9uU2hlZXRBc3Npc3RhbnQgZGVmYXVsdEFjdGlvbnNGb3JMaW5rU2hlZXQ6ZWxlbWVu dEluZm8uZ2V0KCldLmdldCgpIGVsZW1lbnRJbmZvOmVsZW1lbnRJbmZvLmdldCgpXTsKKyAgICAg ICAgICAgIHJldHVybiBbdWlEZWxlZ2F0ZSBfd2ViVmlldzpfd2ViVmlldyBwcmV2aWV3Vmlld0Nv bnRyb2xsZXJGb3JVUkw6dGFyZ2V0VVJMIGRlZmF1bHRBY3Rpb25zOmFjdGlvbnMuZ2V0KCkgZWxl bWVudEluZm86ZWxlbWVudEluZm8uZ2V0KCldOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKFt1 aURlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6cHJldmlld1Zp ZXdDb250cm9sbGVyRm9yVVJMOildKSB7CkBAIC0zMjM2LDcgKzMyMzcsMTAgQEAgc3RhdGljIGJv b2wgaXNBc3Npc3RhYmxlSW5wdXRUeXBlKElucHV0VHlwZSB0eXBlKQogI2lmIEhBVkUoU0FGQVJJ X1NFUlZJQ0VTX0ZSQU1FV09SSykKICAgICAgICAgU0ZTYWZhcmlWaWV3Q29udHJvbGxlciAqcHJl dmlld1ZpZXdDb250cm9sbGVyID0gW2FsbG9jU0ZTYWZhcmlWaWV3Q29udHJvbGxlckluc3RhbmNl KCkgaW5pdFdpdGhVUkw6dGFyZ2V0VVJMXTsKICAgICAgICAgcHJldmlld1ZpZXdDb250cm9sbGVy Ll9zaG93aW5nTGlua1ByZXZpZXcgPSBZRVM7CisgICAgICAgIHByZXZpZXdWaWV3Q29udHJvbGxl ci5fYWN0aXZhdGVkRWxlbWVudEluZm8gPSBlbGVtZW50SW5mby5nZXQoKTsKKyAgICAgICAgcHJl dmlld1ZpZXdDb250cm9sbGVyLl9wcmV2aWV3QWN0aW9ucyA9IGFjdGlvbnMuZ2V0KCk7CiAgICAg ICAgIF9oaWdobGlnaHRMb25nUHJlc3NDYW5DbGljayA9IE5POworICAgICAgICBfcGFnZS0+c3Rh cnRJbnRlcmFjdGlvbldpdGhFbGVtZW50QXRQb3NpdGlvbihfcG9zaXRpb25JbmZvcm1hdGlvbi5w b2ludCk7CiAgICAgICAgIHJldHVybiBbcHJldmlld1ZpZXdDb250cm9sbGVyIGF1dG9yZWxlYXNl XTsKICNlbHNlCiAgICAgICAgIHJldHVybiBuaWw7Cg==