146882 2015-07-11 14:50:05 -0700 Web Inspector: Type profiler shows 'Undefined' annotation for functions with no return statements 2015-08-21 20:27:38 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam bburg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1108978 0 saam 2015-07-11 14:50:05 -0700 Even though JS implicitly returns undefined, we decided not to show return types unless there is an explicit 'return <expr>' in the function. I'm not sure how this got reverted but I will fix it. 1108979 1 webkit-bug-importer 2015-07-11 14:50:18 -0700 <rdar://problem/21783141> 1120015 2 259688 saam 2015-08-21 17:36:58 -0700 Created attachment 259688 patch 1120056 3 259688 joepeck 2015-08-21 19:40:33 -0700 Comment on attachment 259688 patch r=me, Though I wonder if we could write a test for this. 1120064 4 259688 commit-queue 2015-08-21 20:27:34 -0700 Comment on attachment 259688 patch Clearing flags on attachment: 259688 Committed r188818: <http://trac.webkit.org/changeset/188818> 1120065 5 commit-queue 2015-08-21 20:27:38 -0700 All reviewed patches have been landed. Closing bug. 259688 2015-08-21 17:36:58 -0700 2015-08-21 20:27:34 -0700 patch a-backup.diff text/plain 3425 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4ODA3KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA4LTIxICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IFR5cGUgcHJvZmlsZXIgc2hvd3MgJ1VuZGVmaW5lZCcgYW5ub3RhdGlv biBmb3IgZnVuY3Rpb25zIHdpdGggbm8gcmV0dXJuIHN0YXRlbWVudHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Njg4MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9s bGVycy9UeXBlVG9rZW5Bbm5vdGF0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVHlwZVRv a2VuQW5ub3RhdG9yLnByb3RvdHlwZS5faW5zZXJ0VHlwZVRva2VuKToKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL01vZGVscy9TY3JpcHRTeW50YXhUcmVlLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlNjcmlwdFN5bnRheFRyZWUucHJvdG90eXBlLl9jcmVhdGVJbnRlcm5hbFN5bnRheFRyZWUp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdFN5bnRheFRyZWUpOgorCiAyMDE1LTA4LTIx ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGNsZWFuIHVwIHVzZXMgb2YgYG5ld2Agd2l0aCB6ZXJvLWFyZ3VtZW50IGNvbnN0cnVjdG9ycyBh bmQgZmFjdG9yeSBtZXRob2RzCkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9UeXBlVG9rZW5Bbm5vdGF0b3IuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVHlwZVRva2VuQW5u b3RhdG9yLmpzCShyZXZpc2lvbiAxODg3NjYpCisrKyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9UeXBlVG9rZW5Bbm5vdGF0b3IuanMJKHdvcmtpbmcgY29w eSkKQEAgLTEwNSw3ICsxMDUsNyBAQCBXZWJJbnNwZWN0b3IuVHlwZVRva2VuQW5ub3RhdG9yID0g Y2xhc3MgCiAgICAgICAgIC8vIElmIGEgZnVuY3Rpb24gZG9lcyBub3QgaGF2ZSBhbiBleHBsaWNp dCByZXR1cm4gc3RhdGVtZW50IHdpdGggYW4gYXJndW1lbnQgKGkuZSwgInJldHVybiB4OyIgaW5z dGVhZCBvZiAicmV0dXJuOyIpIAogICAgICAgICAvLyB0aGVuIGRvbid0IHNob3cgYSByZXR1cm4g dHlwZSB1bmxlc3Mgd2UgdGhpbmsgaXQncyBhIGNvbnN0cnVjdG9yLgogICAgICAgICB2YXIgc2Ny aXB0U3ludGF4VHJlZSA9IHRoaXMuX3NjcmlwdC5fc2NyaXB0U3ludGF4VHJlZTsKLSAgICAgICAg aWYgKCFub2RlLmF0dGFjaG1lbnRzLl9fdHlwZVRva2VuICYmIChzY3JpcHRTeW50YXhUcmVlLmNv bnRhaW5zTm9uRW1wdHlSZXR1cm5TdGF0ZW1lbnQobm9kZS5ib2R5KSB8fCAhV2ViSW5zcGVjdG9y LlR5cGVTZXQuZnJvbVBheWxvYWQoZnVuY3Rpb25SZXR1cm5UeXBlLnR5cGVTZXQpLmlzQ29udGFp bmVkSW4oV2ViSW5zcGVjdG9yLlR5cGVTZXQuVHlwZUJpdC5VbmRlZmluZWQpKSkgeworICAgICAg ICBpZiAoIW5vZGUuYXR0YWNobWVudHMuX190eXBlVG9rZW4gJiYgKHNjcmlwdFN5bnRheFRyZWUu Y29udGFpbnNOb25FbXB0eVJldHVyblN0YXRlbWVudChub2RlLmJvZHkpIHx8ICFmdW5jdGlvblJl dHVyblR5cGUudHlwZVNldC5pc0NvbnRhaW5lZEluKFdlYkluc3BlY3Rvci5UeXBlU2V0LlR5cGVC aXQuVW5kZWZpbmVkKSkpIHsKICAgICAgICAgICAgIHZhciBmdW5jdGlvbk5hbWUgPSBub2RlLmlk ID8gbm9kZS5pZC5uYW1lIDogbnVsbDsKICAgICAgICAgICAgIHZhciBvZmZzZXQgPSBub2RlLmlz R2V0dGVyT3JTZXR0ZXIgPyBub2RlLmdldHRlck9yU2V0dGVyUmFuZ2VbMF0gOiBub2RlLnJhbmdl WzBdOwogICAgICAgICAgICAgdGhpcy5faW5zZXJ0VG9rZW4ob2Zmc2V0LCBub2RlLCB0cnVlLCBX ZWJJbnNwZWN0b3IuVHlwZVRva2VuVmlldy5UaXRsZVR5cGUuUmV0dXJuU3RhdGVtZW50LCBmdW5j dGlvbk5hbWUpOwpJbmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL1NjcmlwdFN5bnRheFRyZWUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFN5bnRheFRyZWUuanMJKHJldmlzaW9uIDE4 ODc2NikKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3Jp cHRTeW50YXhUcmVlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC03MzEsOSArNzMxLDE0IEBAIFdlYklu c3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlID0gY2xhc3MgU2MKICAgICAgICAgICAgICAgICBraW5k OiBub2RlLmtpbmQsCiAgICAgICAgICAgICAgICAgc3RhdGljOiBub2RlLnN0YXRpYwogICAgICAg ICAgICAgfTsKKyAgICAgICAgICAgIGlmIChyZXN1bHQua2luZCA9PT0gImdldCIgfHwgcmVzdWx0 LmtpbmQgPT09ICJzZXQiKSB7CisgICAgICAgICAgICAgICAgY29uc3QgbGVuZ3RoID0gcmVzdWx0 LmtleS5yYW5nZVsxXSAtIHJlc3VsdC5rZXkucmFuZ2VbMF07CisgICAgICAgICAgICAgICAgcmVz dWx0LnZhbHVlLmdldHRlck9yU2V0dGVyUmFuZ2UgPSBub2RlLnJhbmdlOworICAgICAgICAgICAg ICAgIHJlc3VsdC52YWx1ZS5nZXR0ZXJPclNldHRlclJhbmdlWzFdID0gbm9kZS5yYW5nZVswXSAr IGxlbmd0aDsKKyAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIHJlc3VsdC52YWx1 ZS5nZXR0ZXJPclNldHRlclJhbmdlID0gcmVzdWx0LmtleS5yYW5nZTsKICAgICAgICAgICAgIC8v IEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQzMTcxPiBXZWIgSW5zcGVjdG9yOiBJbXBy b3ZlIFR5cGUgUHJvZmlsZXIgU3VwcG9ydCBmb3IgRVM2IFN5bnRheAogICAgICAgICAgICAgcmVz dWx0LnZhbHVlLmlzR2V0dGVyT3JTZXR0ZXIgPSB0cnVlOwotICAgICAgICAgICAgcmVzdWx0LnZh bHVlLmdldHRlck9yU2V0dGVyUmFuZ2UgPSByZXN1bHQua2V5LnJhbmdlOwogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIGNhc2UgIk5ld0V4cHJlc3Npb24iOgogICAgICAgICAgICAgcmVzdWx0 ID0gewo=