146875 2015-07-10 23:05:54 -0700 DFG::DesiredWatchpoints should accept WatchpointSetType's that aren't necessarily pointers 2015-07-10 23:42:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb mitz mmirman msaboff nrotem oliver saam sam oldest_to_newest 1108897 0 fpizlo 2015-07-10 23:05:54 -0700 In the future we'll want to add a desired watchpoint set that's something like "please watch property 'Foo' for 'deletion' on structure 'S1'", so that the "set type" is struct like "struct MySet { StringImpl* property; Mode mode; Structure* structure };". 1108898 1 256646 fpizlo 2015-07-10 23:08:22 -0700 Created attachment 256646 the patch 1108902 2 fpizlo 2015-07-10 23:42:54 -0700 Landed in http://trac.webkit.org/changeset/186706 256646 2015-07-10 23:08:22 -0700 2015-07-10 23:11:25 -0700 the patch blah.patch text/plain 5074 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg2NzA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE1LTA3LTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpEZXNpcmVkV2F0Y2hwb2ludHMgc2hvdWxkIGFjY2VwdCBXYXRjaHBvaW50U2V0VHlwZSdz IHRoYXQgYXJlbid0IG5lY2Vzc2FyaWx5IHBvaW50ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY4NzUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEluIHRoZSBmdXR1cmUgd2UnbGwgd2Fu dCB0byBhZGQgYSBkZXNpcmVkIHdhdGNocG9pbnQgc2V0IHRoYXQncyBzb21ldGhpbmcgbGlrZSAi cGxlYXNlCisgICAgICAgIHdhdGNoIHByb3BlcnR5ICdGb28nIGZvciAnZGVsZXRpb24nIG9uIHN0 cnVjdHVyZSAnUzEnIiwgc28gdGhhdCB0aGUgInNldCB0eXBlIiBpcyBzdHJ1Y3QKKyAgICAgICAg bGlrZSAic3RydWN0IE15U2V0IHsgU3RyaW5nSW1wbCogcHJvcGVydHk7IE1vZGUgbW9kZTsgU3Ry dWN0dXJlKiBzdHJ1Y3R1cmUgfTsiLgorICAgICAgICAKKyAgICAgICAgVGhpcyBpcyBhIHZlcnkg bWVjaGFuaWNhbCBjaGFuZ2UgZm9yIG5vdyAtIGFsbCBvZiB0aGUgY3VycmVudCB1c2VycyBoYXBw ZW4gdG8gdXNlIHNldHMKKyAgICAgICAgdGhhdCBhcmUgcG9pbnRlciB0eXBlZCwgc28gaXQncyBq dXN0IGEgbWF0dGVyIG9mIG1vdmluZyBzb21lICIqIidzIGFyb3VuZC4KKworICAgICAgICAqIGRm Zy9ERkdEZXNpcmVkV2F0Y2hwb2ludHMuaDoKKyAgICAgICAgKEpTQzo6REZHOjpHZW5lcmljU2V0 QWRhcHRvcjo6YWRkKToKKyAgICAgICAgKEpTQzo6REZHOjpHZW5lcmljU2V0QWRhcHRvcjo6aGFz QmVlbkludmFsaWRhdGVkKToKKyAgICAgICAgKEpTQzo6REZHOjpHZW5lcmljRGVzaXJlZFdhdGNo cG9pbnRzOjpHZW5lcmljRGVzaXJlZFdhdGNocG9pbnRzKToKKyAgICAgICAgKEpTQzo6REZHOjpH ZW5lcmljRGVzaXJlZFdhdGNocG9pbnRzOjphZGRMYXppbHkpOgorICAgICAgICAoSlNDOjpERkc6 OkdlbmVyaWNEZXNpcmVkV2F0Y2hwb2ludHM6OnJlYWxseUFkZCk6CisgICAgICAgIChKU0M6OkRG Rzo6R2VuZXJpY0Rlc2lyZWRXYXRjaHBvaW50czo6YXJlU3RpbGxWYWxpZCk6CisgICAgICAgIChK U0M6OkRGRzo6R2VuZXJpY0Rlc2lyZWRXYXRjaHBvaW50czo6aXNXYXRjaGVkKToKKyAgICAgICAg KEpTQzo6REZHOjpEZXNpcmVkV2F0Y2hwb2ludHM6OmlzV2F0Y2hlZCk6CisKIDIwMTUtMDctMTAg IEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBXYXRjaHBvaW50cyBz aG91bGQgYmUgYWxsb2NhdGVkIHdpdGggRmFzdE1hbGxvYwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdEZXNpcmVkV2F0Y2hwb2ludHMuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0Rlc2lyZWRXYXRjaHBvaW50cy5oCShyZXZpc2lvbiAxODY3 MDUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Rlc2lyZWRXYXRjaHBvaW50cy5o CSh3b3JraW5nIGNvcHkpCkBAIC0zMywxMCArMzMsNyBAQAogI2luY2x1ZGUgIkluZmVycmVkVmFs dWUuaCIKICNpbmNsdWRlICJKU0FycmF5QnVmZmVyVmlldy5oIgogI2luY2x1ZGUgIldhdGNocG9p bnQuaCIKLSNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+ Ci0jaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+Ci0jaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgog CiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKQEAgLTQ0LDExICs0MSwxMSBAQCBj bGFzcyBHcmFwaDsKIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4KIHN0cnVjdCBHZW5lcmljU2V0QWRh cHRvciB7Ci0gICAgc3RhdGljIHZvaWQgYWRkKENvZGVCbG9jayosIFQqIHNldCwgV2F0Y2hwb2lu dCogd2F0Y2hwb2ludCkKKyAgICBzdGF0aWMgdm9pZCBhZGQoQ29kZUJsb2NrKiwgVCBzZXQsIFdh dGNocG9pbnQqIHdhdGNocG9pbnQpCiAgICAgewogICAgICAgICByZXR1cm4gc2V0LT5hZGQod2F0 Y2hwb2ludCk7CiAgICAgfQotICAgIHN0YXRpYyBib29sIGhhc0JlZW5JbnZhbGlkYXRlZChUKiBz ZXQpIHsgcmV0dXJuIHNldC0+aGFzQmVlbkludmFsaWRhdGVkKCk7IH0KKyAgICBzdGF0aWMgYm9v bCBoYXNCZWVuSW52YWxpZGF0ZWQoVCBzZXQpIHsgcmV0dXJuIHNldC0+aGFzQmVlbkludmFsaWRh dGVkKCk7IH0KIH07CiAKIHN0cnVjdCBJbmZlcnJlZFZhbHVlQWRhcHRvciB7CkBAIC03Miw3ICs2 OSw3IEBAIHN0cnVjdCBBcnJheUJ1ZmZlclZpZXdXYXRjaHBvaW50QWRhcHRvciAKIHRlbXBsYXRl PHR5cGVuYW1lIFdhdGNocG9pbnRTZXRUeXBlLCB0eXBlbmFtZSBBZGFwdG9yID0gR2VuZXJpY1Nl dEFkYXB0b3I8V2F0Y2hwb2ludFNldFR5cGU+PgogY2xhc3MgR2VuZXJpY0Rlc2lyZWRXYXRjaHBv aW50cyB7CiAjaWYgIUFTU0VSVF9ESVNBQkxFRAotICAgIHR5cGVkZWYgSGFzaE1hcDxXYXRjaHBv aW50U2V0VHlwZSosIGJvb2w+IFN0YXRlTWFwOworICAgIHR5cGVkZWYgSGFzaE1hcDxXYXRjaHBv aW50U2V0VHlwZSwgYm9vbD4gU3RhdGVNYXA7CiAjZW5kaWYKIHB1YmxpYzoKICAgICBHZW5lcmlj RGVzaXJlZFdhdGNocG9pbnRzKCkKQEAgLTgwLDcgKzc3LDcgQEAgcHVibGljOgogICAgIHsKICAg ICB9CiAgICAgCi0gICAgdm9pZCBhZGRMYXppbHkoV2F0Y2hwb2ludFNldFR5cGUqIHNldCkKKyAg ICB2b2lkIGFkZExhemlseShjb25zdCBXYXRjaHBvaW50U2V0VHlwZSYgc2V0KQogICAgIHsKICAg ICAgICAgbV9zZXRzLmFkZChzZXQpOwogICAgIH0KQEAgLTg5LDMzICs4NiwyOSBAQCBwdWJsaWM6 CiAgICAgewogICAgICAgICBSRUxFQVNFX0FTU0VSVCghbV9yZWFsbHlBZGRlZCk7CiAgICAgICAg IAotICAgICAgICB0eXBlbmFtZSBIYXNoU2V0PFdhdGNocG9pbnRTZXRUeXBlKj46Oml0ZXJhdG9y IGl0ZXIgPSBtX3NldHMuYmVnaW4oKTsKLSAgICAgICAgdHlwZW5hbWUgSGFzaFNldDxXYXRjaHBv aW50U2V0VHlwZSo+OjppdGVyYXRvciBlbmQgPSBtX3NldHMuZW5kKCk7Ci0gICAgICAgIGZvciAo OyBpdGVyICE9IGVuZDsgKytpdGVyKQotICAgICAgICAgICAgQWRhcHRvcjo6YWRkKGNvZGVCbG9j aywgKml0ZXIsIGNvbW1vbi53YXRjaHBvaW50cy5hZGQoY29kZUJsb2NrKSk7CisgICAgICAgIGZv ciAoYXV0byYgc2V0IDogbV9zZXRzKQorICAgICAgICAgICAgQWRhcHRvcjo6YWRkKGNvZGVCbG9j aywgc2V0LCBjb21tb24ud2F0Y2hwb2ludHMuYWRkKGNvZGVCbG9jaykpOwogICAgICAgICAKICAg ICAgICAgbV9yZWFsbHlBZGRlZCA9IHRydWU7CiAgICAgfQogICAgIAogICAgIGJvb2wgYXJlU3Rp bGxWYWxpZCgpIGNvbnN0CiAgICAgewotICAgICAgICB0eXBlbmFtZSBIYXNoU2V0PFdhdGNocG9p bnRTZXRUeXBlKj46Oml0ZXJhdG9yIGl0ZXIgPSBtX3NldHMuYmVnaW4oKTsKLSAgICAgICAgdHlw ZW5hbWUgSGFzaFNldDxXYXRjaHBvaW50U2V0VHlwZSo+OjppdGVyYXRvciBlbmQgPSBtX3NldHMu ZW5kKCk7Ci0gICAgICAgIGZvciAoOyBpdGVyICE9IGVuZDsgKytpdGVyKSB7Ci0gICAgICAgICAg ICBpZiAoQWRhcHRvcjo6aGFzQmVlbkludmFsaWRhdGVkKCppdGVyKSkKKyAgICAgICAgZm9yIChh dXRvJiBzZXQgOiBtX3NldHMpIHsKKyAgICAgICAgICAgIGlmIChBZGFwdG9yOjpoYXNCZWVuSW52 YWxpZGF0ZWQoc2V0KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0K ICAgICAgICAgCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KICAgICAKLSAgICBib29sIGlz V2F0Y2hlZChXYXRjaHBvaW50U2V0VHlwZSogc2V0KSBjb25zdAorICAgIGJvb2wgaXNXYXRjaGVk KGNvbnN0IFdhdGNocG9pbnRTZXRUeXBlJiBzZXQpIGNvbnN0CiAgICAgewogICAgICAgICByZXR1 cm4gbV9zZXRzLmNvbnRhaW5zKHNldCk7CiAgICAgfQogCiBwcml2YXRlOgotICAgIEhhc2hTZXQ8 V2F0Y2hwb2ludFNldFR5cGUqPiBtX3NldHM7CisgICAgSGFzaFNldDxXYXRjaHBvaW50U2V0VHlw ZT4gbV9zZXRzOwogICAgIGJvb2wgbV9yZWFsbHlBZGRlZDsKIH07CiAKQEAgLTE1MywxMCArMTQ2 LDEwIEBAIHB1YmxpYzoKICAgICB9CiAgICAgCiBwcml2YXRlOgotICAgIEdlbmVyaWNEZXNpcmVk V2F0Y2hwb2ludHM8V2F0Y2hwb2ludFNldD4gbV9zZXRzOwotICAgIEdlbmVyaWNEZXNpcmVkV2F0 Y2hwb2ludHM8SW5saW5lV2F0Y2hwb2ludFNldD4gbV9pbmxpbmVTZXRzOwotICAgIEdlbmVyaWNE ZXNpcmVkV2F0Y2hwb2ludHM8SW5mZXJyZWRWYWx1ZSwgSW5mZXJyZWRWYWx1ZUFkYXB0b3I+IG1f aW5mZXJyZWRWYWx1ZXM7Ci0gICAgR2VuZXJpY0Rlc2lyZWRXYXRjaHBvaW50czxKU0FycmF5QnVm ZmVyVmlldywgQXJyYXlCdWZmZXJWaWV3V2F0Y2hwb2ludEFkYXB0b3I+IG1fYnVmZmVyVmlld3M7 CisgICAgR2VuZXJpY0Rlc2lyZWRXYXRjaHBvaW50czxXYXRjaHBvaW50U2V0Kj4gbV9zZXRzOwor ICAgIEdlbmVyaWNEZXNpcmVkV2F0Y2hwb2ludHM8SW5saW5lV2F0Y2hwb2ludFNldCo+IG1faW5s aW5lU2V0czsKKyAgICBHZW5lcmljRGVzaXJlZFdhdGNocG9pbnRzPEluZmVycmVkVmFsdWUqLCBJ bmZlcnJlZFZhbHVlQWRhcHRvcj4gbV9pbmZlcnJlZFZhbHVlczsKKyAgICBHZW5lcmljRGVzaXJl ZFdhdGNocG9pbnRzPEpTQXJyYXlCdWZmZXJWaWV3KiwgQXJyYXlCdWZmZXJWaWV3V2F0Y2hwb2lu dEFkYXB0b3I+IG1fYnVmZmVyVmlld3M7CiB9OwogCiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6REZH Cg==