146863 2015-07-10 18:01:40 -0700 Remove incorrect overriding of inputAssistantItem in WKContentView 2015-07-11 14:32:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica mitz oldest_to_newest 1108831 0 enrica 2015-07-10 18:01:40 -0700 The keyboard is entirely responsible for this and WebKit should not override it. rdar://problem/21507154 1108832 1 256631 enrica 2015-07-10 18:05:52 -0700 Created attachment 256631 Patch 1108834 2 256631 mitz 2015-07-10 18:13:04 -0700 Comment on attachment 256631 Patch r=me assuming you tested this change in isolation (without related UIKit changes). 1108944 3 enrica 2015-07-11 11:59:35 -0700 (In reply to comment #2) > Comment on attachment 256631 [details] > Patch > > r=me assuming you tested this change in isolation (without related UIKit > changes). I did. In fact the WebKit changes but itself is enough to fixe the bug. The UIKit changes are for cleanup and to fix WK1. Thank you! 1108947 4 enrica 2015-07-11 12:03:44 -0700 Committed revision 186713. 1108962 5 enrica 2015-07-11 13:41:59 -0700 Found a bug in the previous patch. Reopening. 1108964 6 256664 enrica 2015-07-11 13:56:06 -0700 Created attachment 256664 Patch2 1108970 7 256666 enrica 2015-07-11 14:28:50 -0700 Created attachment 256666 Patch3 Fix the iOS EWS. 1108971 8 enrica 2015-07-11 14:32:10 -0700 Committed revision 186716. 256631 2015-07-10 18:05:52 -0700 2015-07-10 18:13:04 -0700 Patch autofill-missing-webkit.txt text/plain 2821 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjcwMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA3LTEwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGluY29ycmVjdCBv dmVycmlkaW5nIG9mIGlucHV0QXNzaXN0YW50SXRlbSBpbiBXS0NvbnRlbnRWaWV3LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2ODYzCisgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzIxNTA3MTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVtb3ZpbmcgaW1wbGVtZW50YXRpb24gb2YgaW5wdXRBc3Npc3Rh bnRJdGVtIGFuZCBtb3ZpbmcgaW5pdGlhbGl6YXRpb24KKyAgICAgICAgb2YgZm9ybUFjY2Vzc29y eVZpZXcgdG8gaW5wdXRBY2Nlc3NvcnlWaWV3IHRvIGF2b2lkIGludGVyZmVyaW5nIHdpdGgKKyAg ICAgICAgdGhlIGtleWJvYXJkIGhhbmRsaW5nIG9mIHRoZSBhc3Npc3RhbnQgYmFyLgorCisgICAg ICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgaW5wdXRBY2Nlc3NvcnlWaWV3XSk6CisgICAgICAgICgtW1dLQ29u dGVudFZpZXcgaW5wdXRBc3Npc3RhbnRJdGVtXSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dLQ29u dGVudFZpZXcgX2lucHV0QXNzaXN0YW50SXRlbV0pOiBEZWxldGVkLgorCiAyMDE1LTA3LTEwICBU aW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBDb3Jl QW5pbWF0aW9uIGZlbmNlcyBpbnN0ZWFkIG9mIHN5bmNocm9ub3VzIElQQyB0byBzeW5jaHJvbml6 ZSByZXNpemUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAxODY2OTMpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29y a2luZyBjb3B5KQpAQCAtMjExLDEyICsyMTEsNiBAQCBAaW50ZXJmYWNlIFVJVmlldyAoVUlWaWV3 SW50ZXJuYWxIYWNrKQogKyAoQk9PTClfYWRkQ29tcGxldGlvbjoodm9pZCheKShCT09MKSljb21w bGV0aW9uOwogQGVuZAogCi0jaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0g OTAwMDAKLUBpbnRlcmZhY2UgVUlXZWJGb3JtQWNjZXNzb3J5IChTdGFnaW5nVG9SZW1vdmUpCi0t IChVSVRleHRJbnB1dEFzc2lzdGFudEl0ZW0gKilpbnB1dEFzc2lzdGFudEl0ZW07Ci1AZW5kCi0j ZW5kaWYKLQogQGludGVyZmFjZSBXS0Zvcm1JbnB1dFNlc3Npb24gOiBOU09iamVjdCA8X1dLRm9y bUlucHV0U2Vzc2lvbj4KIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoQ29udGVudFZpZXc6KFdL Q29udGVudFZpZXcgKil2aWV3IHVzZXJPYmplY3Q6KE5TT2JqZWN0IDxOU1NlY3VyZUNvZGluZz4g Kil1c2VyT2JqZWN0OwpAQCAtMTI1NiwzMyArMTI1MCwxNyBAQCAtIChCT09MKXJlcXVpcmVzQWNj ZXNzb3J5VmlldwogCiAtIChVSVZpZXcgKilpbnB1dEFjY2Vzc29yeVZpZXcKIHsKLSAgICBpZiAo IVtzZWxmIHJlcXVpcmVzQWNjZXNzb3J5Vmlld10pCi0gICAgICAgIHJldHVybiBuaWw7Ci0KICAg ICBpZiAoIV9mb3JtQWNjZXNzb3J5VmlldykgewogICAgICAgICBfZm9ybUFjY2Vzc29yeVZpZXcg PSBhZG9wdE5TKFtbVUlXZWJGb3JtQWNjZXNzb3J5IGFsbG9jXSBpbml0XSk7CiAgICAgICAgIFtf Zm9ybUFjY2Vzc29yeVZpZXcgc2V0RGVsZWdhdGU6c2VsZl07CiAgICAgfQorCisgICAgaWYgKCFb c2VsZiByZXF1aXJlc0FjY2Vzc29yeVZpZXddKQorICAgICAgICByZXR1cm4gbmlsOwogICAgIAog ICAgIHJldHVybiBfZm9ybUFjY2Vzc29yeVZpZXcuZ2V0KCk7CiB9CiAKLSNpZiBfX0lQSE9ORV9P U19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA5MDAwMAotLSAoVUlUZXh0SW5wdXRBc3Npc3RhbnRJ dGVtICopaW5wdXRBc3Npc3RhbnRJdGVtCi17Ci0gICAgaWYgKCFfZm9ybUFjY2Vzc29yeVZpZXcp IHsKLSAgICAgICAgX2Zvcm1BY2Nlc3NvcnlWaWV3ID0gYWRvcHROUyhbW1VJV2ViRm9ybUFjY2Vz c29yeSBhbGxvY10gaW5pdF0pOwotICAgICAgICBbX2Zvcm1BY2Nlc3NvcnlWaWV3IHNldERlbGVn YXRlOnNlbGZdOwotICAgIH0KLSAgICByZXR1cm4gKFtfZm9ybUFjY2Vzc29yeVZpZXcgcmVzcG9u ZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihpbnB1dEFzc2lzdGFudEl0ZW0pXSkgPyBbX2Zvcm1BY2Nl c3NvcnlWaWV3IGlucHV0QXNzaXN0YW50SXRlbV0gOiBuaWw7Ci19Ci0KLS0gKFVJVGV4dElucHV0 QXNzaXN0YW50SXRlbSAqKV9pbnB1dEFzc2lzdGFudEl0ZW0KLXsKLSAgICByZXR1cm4gW3NlbGYg aW5wdXRBc3Npc3RhbnRJdGVtXTsKLX0KLSNlbmRpZgotCiAtIChOU0FycmF5ICopc3VwcG9ydGVk UGFzdGVib2FyZFR5cGVzRm9yQ3VycmVudFNlbGVjdGlvbgogewogICAgIGlmIChfcGFnZS0+ZWRp dG9yU3RhdGUoKS5zZWxlY3Rpb25Jc05vbmUpCg== 256664 2015-07-11 13:56:06 -0700 2015-07-11 14:28:50 -0700 Patch2 autofill-missing-webkit.txt text/plain 2143 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjcxNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA3LTExICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGluY29ycmVjdCBv dmVycmlkaW5nIG9mIGlucHV0QXNzaXN0YW50SXRlbSBpbiBXS0NvbnRlbnRWaWV3LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2ODYzCisgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzIxNTA3MTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ29ycmVjdGlvbiB0byB0aGUgcGF0Y2ggaW4gcjE4NjcxMy4KKyAg ICAgICAgV2UgbmVlZCB0byBwcm92aWRlIHRoZSBpbnB1dEFzc2lzdGFudEl0ZW0gZnJvbSB0aGUg cmVzcG9uZGVyLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgaW5wdXRBY2Nlc3NvcnlWaWV3XSk6 CisKIDIwMTUtMDctMTEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxODY2ODkgYW5kIHIxODY3MTAuCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTg2NzEzKQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkK QEAgLTIxMSw2ICsyMTEsMTIgQEAgQGludGVyZmFjZSBVSVZpZXcgKFVJVmlld0ludGVybmFsSGFj aykKICsgKEJPT0wpX2FkZENvbXBsZXRpb246KHZvaWQoXikoQk9PTCkpY29tcGxldGlvbjsKIEBl bmQKIAorI2lmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDkwMDAwCitAaW50 ZXJmYWNlIFVJV2ViRm9ybUFjY2Vzc29yeSAoU3RhZ2luZ1RvUmVtb3ZlKQorLSAoaWQpaW5pdFdp dGhJbnB1dEFzc2lzdGFudEl0ZW06KFVJVGV4dElucHV0QXNzaXN0YW50SXRlbSAqKWlucHV0QXNz aXN0YW50SXRlbTsKK0BlbmQKKyNlbmRpZgorCiBAaW50ZXJmYWNlIFdLRm9ybUlucHV0U2Vzc2lv biA6IE5TT2JqZWN0IDxfV0tGb3JtSW5wdXRTZXNzaW9uPgogCiAtIChpbnN0YW5jZXR5cGUpaW5p dFdpdGhDb250ZW50VmlldzooV0tDb250ZW50VmlldyAqKXZpZXcgdXNlck9iamVjdDooTlNPYmpl Y3QgPE5TU2VjdXJlQ29kaW5nPiAqKXVzZXJPYmplY3Q7CkBAIC0xMjUxLDcgKzEyNTcsMTAgQEAg LSAoQk9PTClyZXF1aXJlc0FjY2Vzc29yeVZpZXcKIC0gKFVJVmlldyAqKWlucHV0QWNjZXNzb3J5 VmlldwogewogICAgIGlmICghX2Zvcm1BY2Nlc3NvcnlWaWV3KSB7Ci0gICAgICAgIF9mb3JtQWNj ZXNzb3J5VmlldyA9IGFkb3B0TlMoW1tVSVdlYkZvcm1BY2Nlc3NvcnkgYWxsb2NdIGluaXRdKTsK KyAgICAgICAgaWYgKFtVSVdlYkZvcm1BY2Nlc3NvcnkgaW5zdGFuY2VzUmVzcG9uZFRvU2VsZWN0 b3I6QHNlbGVjdG9yKGluaXRXaXRoSW5wdXRBc3Npc3RhbnRJdGVtOildKQorICAgICAgICAgICAg X2Zvcm1BY2Nlc3NvcnlWaWV3ID0gYWRvcHROUyhbW1VJV2ViRm9ybUFjY2Vzc29yeSBhbGxvY10g aW5pdFdpdGhJbnB1dEFzc2lzdGFudEl0ZW06W3NlbGYgaW5wdXRBc3Npc3RhbnRJdGVtXV0pOwor ICAgICAgICBlbHNlCisgICAgICAgICAgICBfZm9ybUFjY2Vzc29yeVZpZXcgPSBhZG9wdE5TKFtb VUlXZWJGb3JtQWNjZXNzb3J5IGFsbG9jXSBpbml0XSk7CiAgICAgICAgIFtfZm9ybUFjY2Vzc29y eVZpZXcgc2V0RGVsZWdhdGU6c2VsZl07CiAgICAgfQogCg== 256666 2015-07-11 14:28:50 -0700 2015-07-11 14:29:51 -0700 Patch3 autofill-missing-webkit.txt text/plain 2198 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjcxNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA3LTExICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGluY29ycmVjdCBv dmVycmlkaW5nIG9mIGlucHV0QXNzaXN0YW50SXRlbSBpbiBXS0NvbnRlbnRWaWV3LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2ODYzCisgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzIxNTA3MTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ29ycmVjdGlvbiB0byB0aGUgcGF0Y2ggaW4gcjE4NjcxMy4KKyAg ICAgICAgV2UgbmVlZCB0byBwcm92aWRlIHRoZSBpbnB1dEFzc2lzdGFudEl0ZW0gZnJvbSB0aGUg cmVzcG9uZGVyLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgaW5wdXRBY2Nlc3NvcnlWaWV3XSk6 CisKIDIwMTUtMDctMTEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxODY2ODkgYW5kIHIxODY3MTAuCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTg2NzEzKQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkK QEAgLTIxMSw2ICsyMTEsMTIgQEAgQGludGVyZmFjZSBVSVZpZXcgKFVJVmlld0ludGVybmFsSGFj aykKICsgKEJPT0wpX2FkZENvbXBsZXRpb246KHZvaWQoXikoQk9PTCkpY29tcGxldGlvbjsKIEBl bmQKIAorI2lmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDkwMDAwCitAaW50 ZXJmYWNlIFVJV2ViRm9ybUFjY2Vzc29yeSAoU3RhZ2luZ1RvUmVtb3ZlKQorLSAoaWQpaW5pdFdp dGhJbnB1dEFzc2lzdGFudEl0ZW06KFVJVGV4dElucHV0QXNzaXN0YW50SXRlbSAqKWlucHV0QXNz aXN0YW50SXRlbTsKK0BlbmQKKyNlbmRpZgorCiBAaW50ZXJmYWNlIFdLRm9ybUlucHV0U2Vzc2lv biA6IE5TT2JqZWN0IDxfV0tGb3JtSW5wdXRTZXNzaW9uPgogCiAtIChpbnN0YW5jZXR5cGUpaW5p dFdpdGhDb250ZW50VmlldzooV0tDb250ZW50VmlldyAqKXZpZXcgdXNlck9iamVjdDooTlNPYmpl Y3QgPE5TU2VjdXJlQ29kaW5nPiAqKXVzZXJPYmplY3Q7CkBAIC0xMjUxLDcgKzEyNTcsMTIgQEAg LSAoQk9PTClyZXF1aXJlc0FjY2Vzc29yeVZpZXcKIC0gKFVJVmlldyAqKWlucHV0QWNjZXNzb3J5 VmlldwogewogICAgIGlmICghX2Zvcm1BY2Nlc3NvcnlWaWV3KSB7Ci0gICAgICAgIF9mb3JtQWNj ZXNzb3J5VmlldyA9IGFkb3B0TlMoW1tVSVdlYkZvcm1BY2Nlc3NvcnkgYWxsb2NdIGluaXRdKTsK KyNpZiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA5MDAwMAorICAgICAgICBp ZiAoW1VJV2ViRm9ybUFjY2Vzc29yeSBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2VsZWN0 b3IoaW5pdFdpdGhJbnB1dEFzc2lzdGFudEl0ZW06KV0pCisgICAgICAgICAgICBfZm9ybUFjY2Vz c29yeVZpZXcgPSBhZG9wdE5TKFtbVUlXZWJGb3JtQWNjZXNzb3J5IGFsbG9jXSBpbml0V2l0aElu cHV0QXNzaXN0YW50SXRlbTpbc2VsZiBpbnB1dEFzc2lzdGFudEl0ZW1dXSk7CisgICAgICAgIGVs c2UKKyNlbmRpZgorICAgICAgICAgICAgX2Zvcm1BY2Nlc3NvcnlWaWV3ID0gYWRvcHROUyhbW1VJ V2ViRm9ybUFjY2Vzc29yeSBhbGxvY10gaW5pdF0pOwogICAgICAgICBbX2Zvcm1BY2Nlc3NvcnlW aWV3IHNldERlbGVnYXRlOnNlbGZdOwogICAgIH0KIAo=