146856 2015-07-10 14:00:58 -0700 Cleanup: Remove default constructor for WebCore::Pair() 2015-07-10 20:46:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates darin webkit-bug-importer oldest_to_newest 1108754 0 dbates 2015-07-10 14:00:58 -0700 Following up on Darin Adler's remark in bug 146852, comment 5, we should remove the default constructor for WebCore::Pair as we are not making use of it. Similarly, we can remove the setters Pair::setFirst() and Pair::setSecond() since this are unused and it seems weird to expose such setter when we do not have a default constructor. 1108755 1 webkit-bug-importer 2015-07-10 14:04:51 -0700 <rdar://problem/21773212> 1108756 2 256613 dbates 2015-07-10 14:05:32 -0700 Created attachment 256613 Patch 1108870 3 dbates 2015-07-10 20:46:25 -0700 Committed r186704: <http://trac.webkit.org/changeset/186704> 256613 2015-07-10 14:05:32 -0700 2015-07-10 17:07:54 -0700 Patch bug-146856-20150710140430.patch text/plain 2844 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDY4YmZmNmRkNmE3YmI1 MzE0NTA5MTg5YTRjZTU3ZTI4ZWY0MGYwOS4uZGU2NzkzMzFkYmMzZTU2Nzg4MjRmMTJhOTk0Mjg3 Nzg5NWNiMWExMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE1LTA3LTEwICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBDbGVhbnVwOiBSZW1vdmUg ZGVmYXVsdCBjb25zdHJ1Y3RvciBmb3IgV2ViQ29yZTo6UGFpcigpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY4NTYKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzIxNzczMjEyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZSBkZWZhdWx0IGNvbnN0cnVjdG9yIGZvciBXZWJDb3JlOjpQYWlyKCkg YW5kIHRoZSBzZXR0ZXJzIFBhaXI6OnNldHtGaXJzdCwgU2Vjb25kfSgpCisgICAgICAgIHNpbmNl IHRoZXkgYXJlIG5vdCB1c2VkIGFuZCBpdCBzZWVtcyB3ZWlyZCB0byBrZWVwIHRoZSBsYXR0ZXIg YWZ0ZXIgdGhlIHJlbW92YWwgb2YgdGhlIGZvcm1lci4KKyAgICAgICAgU2hvdWxkIGl0IHR1cm4g b3V0IHRoYXQgd2UgZmluZCBhIHVzZXIgZm9yIGhhdmluZyBhIGRlZmF1bHQgY29uc3RydWN0b3Ig YW5kL29yIHNldHRlcnMgdGhlbgorICAgICAgICB3ZSBjYW4gcmV2ZXJ0IHRoaXMgY2hhbmdlLgor CisgICAgICAgICogY3NzL1BhaXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBhaXI6OmNyZWF0ZSk6 IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpQYWlyOjpzZXRGaXJzdCk6IERlbGV0ZWQuCisg ICAgICAgIChXZWJDb3JlOjpQYWlyOjpzZXRTZWNvbmQpOiBEZWxldGVkLgorICAgICAgICAoV2Vi Q29yZTo6UGFpcjo6UGFpcik6IERlbGV0ZWQuCisKKzIwMTUtMDctMTAgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgorCiAgICAgICAgIFNlcmlhbGl6ZWQgZGVjbGFyYXRpb24gZm9y IGJhY2tncm91bmQtc2l6ZS8td2Via2l0LW1hc2stc2l6ZSBzaG91bGQgcHJlc2VydmUgaWRlbnRp Y2FsCiAgICAgICAgIHZhbHVlcyBpbnN0ZWFkIG9mIGNvYWxlc2NpbmcgdGhlbQogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMTkxCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9jc3MvUGFpci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1BhaXIuaApp bmRleCBjMDU4OGM4N2Y0ZjAyMDZmZjZlMmM3NzI3MDVkMWNhZmJlMGM1YzIxLi5lMzZlYmYxMTJl YTU1YmYyNGRiMDQzY2I0YjYyYzcyOTExNzQ1NmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvUGFpci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9QYWlyLmgKQEAgLTM5LDEwICsz OSw2IEBAIHB1YmxpYzoKICAgICAgICAgQ29hbGVzY2UKICAgICB9OwogCi0gICAgc3RhdGljIFJl ZjxQYWlyPiBjcmVhdGUoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUGFp cik7Ci0gICAgfQogICAgIHN0YXRpYyBSZWY8UGFpcj4gY3JlYXRlKFJlZlB0cjxDU1NQcmltaXRp dmVWYWx1ZT4mJiBmaXJzdCwgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiYmIHNlY29uZCkKICAg ICB7CiAgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFBhaXIoV1RGOjptb3ZlKGZpcnN0KSwg V1RGOjptb3ZlKHNlY29uZCkpKTsKQEAgLTU2LDkgKzUyLDYgQEAgcHVibGljOgogICAgIENTU1By aW1pdGl2ZVZhbHVlKiBmaXJzdCgpIGNvbnN0IHsgcmV0dXJuIG1fZmlyc3QuZ2V0KCk7IH0KICAg ICBDU1NQcmltaXRpdmVWYWx1ZSogc2Vjb25kKCkgY29uc3QgeyByZXR1cm4gbV9zZWNvbmQuZ2V0 KCk7IH0KIAotICAgIHZvaWQgc2V0Rmlyc3QoUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiYmIGZp cnN0KSB7IG1fZmlyc3QgPSBXVEY6Om1vdmUoZmlyc3QpOyB9Ci0gICAgdm9pZCBzZXRTZWNvbmQo UmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiYmIHNlY29uZCkgeyBtX3NlY29uZCA9IFdURjo6bW92 ZShzZWNvbmQpOyB9Ci0KICAgICBTdHJpbmcgY3NzVGV4dCgpIGNvbnN0CiAgICAgewogICAgICAg ICBTdHJpbmcgZmlyc3QgPSB0aGlzLT5maXJzdCgpLT5jc3NUZXh0KCk7CkBAIC03MSw3ICs2NCw2 IEBAIHB1YmxpYzoKICAgICBib29sIGVxdWFscyhjb25zdCBQYWlyJiBvdGhlcikgY29uc3QgeyBy ZXR1cm4gY29tcGFyZUNTU1ZhbHVlUHRyKG1fZmlyc3QsIG90aGVyLm1fZmlyc3QpICYmIGNvbXBh cmVDU1NWYWx1ZVB0cihtX3NlY29uZCwgb3RoZXIubV9zZWNvbmQpOyB9CiAKIHByaXZhdGU6Ci0g ICAgUGFpcigpIDogbV9maXJzdChudWxscHRyKSwgbV9zZWNvbmQobnVsbHB0cikgeyB9CiAgICAg UGFpcihSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+JiYgZmlyc3QsIFJlZlB0cjxDU1NQcmltaXRp dmVWYWx1ZT4mJiBzZWNvbmQpIDogbV9maXJzdChXVEY6Om1vdmUoZmlyc3QpKSwgbV9zZWNvbmQo V1RGOjptb3ZlKHNlY29uZCkpIHsgfQogICAgIFBhaXIoUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVl PiYmIGZpcnN0LCBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+JiYgc2Vjb25kLCBJZGVudGljYWxW YWx1ZUVuY29kaW5nIGVuY29kaW5nKSA6IG1fZmlyc3QoV1RGOjptb3ZlKGZpcnN0KSksIG1fc2Vj b25kKFdURjo6bW92ZShzZWNvbmQpKSwgbV9lbmNvZGluZyhlbmNvZGluZykgeyB9CiAK