146836 2015-07-10 10:05:43 -0700 [Mac] Unable to dismiss context menu during test runs 2015-07-24 06:08:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146888 146695 1 bfulgham bfulgham ap bfulgham thorton oldest_to_newest 1108644 0 bfulgham 2015-07-10 10:05:43 -0700 The Mac port has a number of layout tests that are skipped because they timeout. The timeout is caused by the context menu not being dismissed during the test. Some tests attempt to dismiss the context menu by trying to process an escape character, but this doesn't seem to reliably trigger the menu to be dismissed. A quick review of mac-wk2 TestExpectations shows several tests suffering from this problem: editing/selection/5354455-1.html editing/selection/5354455-2.html editing/selection/button-right-click.html editing/selection/context-menu-on-text.html editing/selection/context-menu-text-selection-lookup.html editing/selection/context-menu-text-selection.html editing/selection/empty-cell-right-click.html editing/spelling/context-menu-suggestions-multiword-selection.html editing/spelling/context-menu-suggestions-subword-selection.html editing/spelling/context-menu-suggestions.html editing/spelling/spellcheck-input-search-crash.html fast/events/context-no-deselect.html fast/events/context-nodrag.html fast/events/context-onmousedown-event.html fast/events/contextmenu-scrolled-page-with-frame.html fast/events/right-click-focus.html fast/events/selectstart-prevent-selection-on-right-click.html media/controls-right-click-on-timebar.html 1108788 1 256620 bfulgham 2015-07-10 15:41:28 -0700 Created attachment 256620 Patch 1108789 2 bfulgham 2015-07-10 15:41:56 -0700 Once this patch is landed I will reactivate the failing tests. 1108797 3 bfulgham 2015-07-10 16:11:03 -0700 Committed r186694: <http://trac.webkit.org/changeset/186694> 1108818 4 bfulgham 2015-07-10 17:15:52 -0700 It looks like editing/selection/5354455-{1,2}.html still fail due to poor Win/Unix emulation on Mac. I'll leave these skipped. 1108821 5 bfulgham 2015-07-10 17:20:46 -0700 Two more failures: editing/spelling/context-menu-suggestions-multiword-selection.html editing/spelling/context-menu-suggestions-subword-selection.html These seem to time out due to spelling support problems. 1108824 6 bfulgham 2015-07-10 17:36:41 -0700 Two last failures: fast/events/right-click-focus.html: This fails because Mac doesn't seem to shift focus when context menu is being driven in DRT/WKTR. fast/events/context-onmousedown-event.html: An actual mouse-down event isn't being emitted by DRT/WKTR. 1108825 7 bfulgham 2015-07-10 17:41:19 -0700 Unskipped tests in r186699. 256620 2015-07-10 15:41:28 -0700 2015-07-10 15:43:57 -0700 Patch bug-146836-20150710154025.patch text/plain 5017 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NjY5MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI4IEBACisyMDE1LTA3LTEwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtNYWNdIFVuYWJsZSB0byBkaXNtaXNzIGNvbnRleHQgbWVudSBkdXJpbmcg dGVzdCBydW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDY4MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTaW5jZSBDb250ZXh0IE1lbnVzIGFyZSBtb2RhbCwgdGhlIHRlc3Qgc3lzdGVtIHdvdWxkIGJs b2NrIG9uIHRoZSBkaXNwbGF5ZWQgY29udGV4dCBtZW51LAorICAgICAgICBjYXVzaW5nIHRlc3Rz IHRvIGZhaWwuIEluc3RlYWQsIHdlIHNob3VsZCBkbyB3aGF0IFdLMSB3YXMgZG9pbmcsIHdoaWNo IGlzIHRvIHBlcmZvcm0gdGhlCisgICAgICAgIG1vdXNlIGNsaWNrIGFuZCBnZW5lcmF0ZSB0aGUg bWVudSBjb250ZW50cywgYnV0IG5vdCBhc2sgQXBwS2l0IHRvIGRpc3BsYXkgaXQuCisKKyAgICAg ICAgRHJpdmUtYnkgZml4OiBXZSBkaWQgbm90IGhhbmRsZSAnZXNjYXBlJyBrZXkgcHJlc3Nlcy4g VGhpcyBpcyBhbHNvIGZpeGVkLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0V2ZW50 U2VuZGluZ0NvbnRyb2xsZXIubW06CisgICAgICAgICgtW0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIg a2V5RG93bjp3aXRoTW9kaWZpZXJzOndpdGhMb2NhdGlvbjpdKTogSGFuZGxlIHRoZSAnZXNjYXBl JyBjaGFyYWN0ZXIuCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9F dmVudFNlbmRpbmdDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6RXZlbnRTZW5kaW5nQ29u dHJvbGxlcjo6bW91c2VNb3ZlVG8pOiBLZWVwIHRyYWNrIG9mIHRoZSBjdXJyZW50IG1vdXNlIHBv c2l0aW9uLgorICAgICAgICAoV1RSOjpFdmVudFNlbmRpbmdDb250cm9sbGVyOjpjb250ZXh0Q2xp Y2spOiBEb24ndCBlbWl0IGFuIGFjdHVhbCBjb250ZXh0IG1lbnUgaW52b2NhdGlvbiBhbmQgdGhl bgorICAgICAgICBjb3B5IHRoZSBtZW51IGl0ZW1zLiBJbnN0ZWFkLCB1c2UgV0tCdW5kbGVQYWdl Q29weUNvbnRlbnRNZW51QXRQb2ludEluV2luZG93IHRvIGRvIGFsbCB0aGUgc2FtZQorICAgICAg ICB3b3JrIHdpdGhvdXQgYWN0dWFsbHkgY2FsbGluZyBvbiBBcHBLaXQgdG8gZGlzcGxheSB0aGUg bWVudS4KKyAgICAgICAgYXNrIFdlYkNvcmUgdG8gZG8gYWxsIHRoZSB3b3JrIEVYQ0VQVCBkaXNw bGF5aW5nIHRoZSBtZW51LgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5oOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv bWFjL0V2ZW50U2VuZGVyUHJveHkubW06CisgICAgICAgIChXVFI6OkV2ZW50U2VuZGVyUHJveHk6 OmtleURvd24pOiBIYW5kbGUgdGhlICdlc2NhcGUnIGNoYXJhY3Rlci4KKwogMjAxNS0wNy0wOSAg RmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEl0IHNob3VsZCBiZSBw b3NzaWJsZSB0byBydW4gdGhlIE9TUiBleGl0IGZ1enplcgpJbmRleDogVG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv RHVtcFJlbmRlclRyZWUvbWFjL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE4 NjY3OSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9FdmVudFNlbmRpbmdDb250cm9sbGVy Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC05NjgsNiArOTY4LDggQEAgLSAodm9pZClrZXlEb3duOihO U1N0cmluZyAqKWNoYXJhY3RlciB3aQogICAgICAgICBrZXlDb2RlID0gMHgwMjsKICAgICBlbHNl IGlmIChbY2hhcmFjdGVyIGlzRXF1YWxUb1N0cmluZzpAImUiXSkKICAgICAgICAga2V5Q29kZSA9 IDB4MEU7CisgICAgZWxzZSBpZiAoW2NoYXJhY3RlciBpc0VxdWFsVG9TdHJpbmc6QCJceDFiIl0p CisgICAgICAgIGtleUNvZGUgPSAweDFCOwogCiAgICAgS2V5TWFwcGluZ0VudHJ5IHRhYmxlW10g PSB7CiAgICAgICAgIHsweDJGLCAweDQxLCAnLicsIG5pbH0sCkluZGV4OiBUb29scy9XZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvRXZlbnRTZW5k aW5nQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDE4NjY3OSkKKysrIFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI1MCw2ICsyNTAsOCBAQCB2b2lkIEV2ZW50U2VuZGluZ0NvbnRyb2xsZXI6Om1v dXNlTW92ZVRvCiAgICAgV0tSZXRhaW5QdHI8V0tEb3VibGVSZWY+IHlSZWYoQWRvcHRXSywgV0tE b3VibGVDcmVhdGUoeSkpOwogICAgIFdLRGljdGlvbmFyeVNldEl0ZW0oRXZlbnRTZW5kZXJNZXNz YWdlQm9keS5nZXQoKSwgeUtleS5nZXQoKSwgeVJlZi5nZXQoKSk7CiAKKyAgICBtX3Bvc2l0aW9u ID0gV0tQb2ludE1ha2UoeCwgeSk7CisgICAgCiAgICAgV0tCdW5kbGVQYWdlUG9zdFN5bmNocm9u b3VzTWVzc2FnZShJbmplY3RlZEJ1bmRsZTo6c2luZ2xldG9uKCkucGFnZSgpLT5wYWdlKCksIEV2 ZW50U2VuZGVyTWVzc2FnZU5hbWUuZ2V0KCksIEV2ZW50U2VuZGVyTWVzc2FnZUJvZHkuZ2V0KCks IDApOwogfQogCkBAIC00NzMsMTEgKzQ3NSw3IEBAIEpTVmFsdWVSZWYgRXZlbnRTZW5kaW5nQ29u dHJvbGxlcjo6Y29udGUKICAgICBXS0J1bmRsZUZyYW1lUmVmIG1haW5GcmFtZSA9IFdLQnVuZGxl UGFnZUdldE1haW5GcmFtZShwYWdlKTsKICAgICBKU0NvbnRleHRSZWYgY29udGV4dCA9IFdLQnVu ZGxlRnJhbWVHZXRKYXZhU2NyaXB0Q29udGV4dChtYWluRnJhbWUpOwogI2lmIEVOQUJMRShDT05U RVhUX01FTlVTKQotICAgIC8vIERvIG1vdXNlIGNvbnRleHQgY2xpY2suCi0gICAgbW91c2VEb3du KDIsIDApOwotICAgIG1vdXNlVXAoMiwgMCk7Ci0KLSAgICBXS1JldGFpblB0cjxXS0FycmF5UmVm PiBtZW51RW50cmllcyA9IGFkb3B0V0soV0tCdW5kbGVQYWdlQ29weUNvbnRleHRNZW51SXRlbXMo cGFnZSkpOworICAgIFdLUmV0YWluUHRyPFdLQXJyYXlSZWY+IG1lbnVFbnRyaWVzID0gYWRvcHRX SyhXS0J1bmRsZVBhZ2VDb3B5Q29udGV4dE1lbnVBdFBvaW50SW5XaW5kb3cocGFnZSwgbV9wb3Np dGlvbikpOwogICAgIEpTVmFsdWVSZWYgYXJyYXlSZXN1bHQgPSBKU09iamVjdE1ha2VBcnJheShj b250ZXh0LCAwLCAwLCAwKTsKICAgICBKU09iamVjdFJlZiBhcnJheU9iaiA9IEpTVmFsdWVUb09i amVjdChjb250ZXh0LCBhcnJheVJlc3VsdCwgMCk7CiAgICAgc2l6ZV90IGVudHJpZXNTaXplID0g V0tBcnJheUdldFNpemUobWVudUVudHJpZXMuZ2V0KCkpOwpJbmRleDogVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9FdmVudFNlbmRpbmdDb250cm9sbGVyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9FdmVudFNlbmRpbmdD b250cm9sbGVyLmgJKHJldmlzaW9uIDE4NjY3OSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBA IC04NSw2ICs4NSw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBFdmVudFNlbmRpbmdDb250 cm9sbGVyKCk7CisgICAgV0tQb2ludCBtX3Bvc2l0aW9uOwogfTsKIAogfSAvLyBuYW1lc3BhY2Ug V1RSCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9FdmVudFNlbmRlclByb3h5Lm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL0V2ZW50U2VuZGVyUHJv eHkubW0JKHJldmlzaW9uIDE4NjY3OSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL0V2 ZW50U2VuZGVyUHJveHkubW0JKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICog Q29weXJpZ2h0IChDKSAyMDExLCAyMDE0IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyAqIENvcHlyaWdodCAoQykgMjAxMSwgMjAxNC0yMDE1IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAxMSBOb2tpYSBDb3Jwb3JhdGlvbiBhbmQvb3Ig aXRzIHN1YnNpZGlhcnkoLWllcykuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC01NjMsNiArNTYzLDgg QEAgdm9pZCBFdmVudFNlbmRlclByb3h5OjprZXlEb3duKFdLU3RyaW5nUgogICAgICAgICBrZXlD b2RlID0gMHgwMjsKICAgICBlbHNlIGlmIChbY2hhcmFjdGVyIGlzRXF1YWxUb1N0cmluZzpAImUi XSkKICAgICAgICAga2V5Q29kZSA9IDB4MEU7CisgICAgZWxzZSBpZiAoW2NoYXJhY3RlciBpc0Vx dWFsVG9TdHJpbmc6QCJceDFiIl0pCisgICAgICAgIGtleUNvZGUgPSAweDFCOwogCiAgICAgS2V5 TWFwcGluZ0VudHJ5IHRhYmxlW10gPSB7CiAgICAgICAgIHsweDJGLCAweDQxLCAnLicsIG5pbH0s Cg==