146829 2015-07-10 02:57:29 -0700 Enable STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE for GCC 2015-07-22 11:05:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 120785 1 ossy ossy achristensen andersca bfulgham commit-queue kling ossy oldest_to_newest 1108565 0 ossy 2015-07-10 02:57:29 -0700 http://trac.webkit.org/changeset/155143 disabled STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE on GCC builds due to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52702 . But this bug is already solved long time ago, we already relies on newer GCC. 1108566 1 256572 ossy 2015-07-10 02:58:21 -0700 Created attachment 256572 Patch 1108638 2 256572 darin 2015-07-10 09:52:56 -0700 Comment on attachment 256572 Patch What port is building with non-clang gcc? I’m not sure we should do the work to support that any more unless there is real benefit. 1108641 3 ossy 2015-07-10 09:54:35 -0700 (In reply to comment #2) > Comment on attachment 256572 [details] > Patch > > What port is building with non-clang gcc? I’m not sure we should do the work > to support that any more unless there is real benefit. EFL and GTK. 1108658 4 256572 andersca 2015-07-10 10:38:07 -0700 Comment on attachment 256572 Patch I think a better solution would be to just reimplement std::is_trivially_destructible in terms of std::has_trivial_destructor for MSVC and get rid of the compiler checks altogether. 1111289 5 257273 ossy 2015-07-22 08:37:06 -0700 Created attachment 257273 Patch Additionally removed the MSVC workaround since MSVC 2012 already supports std::is_trivially_destructible. 1111291 6 ossy 2015-07-22 08:41:57 -0700 (In reply to comment #5) > Created attachment 257273 [details] > Patch > > Additionally removed the MSVC workaround since MSVC 2012 already supports > std::is_trivially_destructible. And now MSVC 2013 is mandatory - https://lists.webkit.org/pipermail/webkit-dev/2013-December/025941.html 1111321 7 257273 bfulgham 2015-07-22 09:50:51 -0700 Comment on attachment 257273 Patch This looks good! Thanks. 1111349 8 257273 commit-queue 2015-07-22 11:05:32 -0700 Comment on attachment 257273 Patch Clearing flags on attachment: 257273 Committed r187167: <http://trac.webkit.org/changeset/187167> 1111350 9 commit-queue 2015-07-22 11:05:35 -0700 All reviewed patches have been landed. Closing bug. 256572 2015-07-10 02:58:21 -0700 2015-07-22 08:37:01 -0700 Patch bug-146829-20150710025718.patch text/plain 1805 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZTAyYTA1OTEyZDA0NGE1NWI2NzIwZGJhNDAzM2FkZmYwYTgwOTUzLi44ODllZTVmN2Y0NTk5NjM4 MmNiYWEyNjM0ZWMwMWYwZDE4ZGRmYzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0wNy0xMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEVuYWJsZSBTVEFUSUNfQVNTRVJUX0lTX1RSSVZJQUxMWV9ERVNUUlVD VElCTEUgZm9yIEdDQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2ODI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBoZWFwL0dDQXNzZXJ0aW9ucy5oOgorCiAyMDE1LTA3LTA5ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBTeW1ib2xUYWJsZTo6ZW50cnlGb3IoKSBzaG91 bGQgZG8gYSBib3VuZHMgY2hlY2sgYmVmb3JlIGluZGV4aW5nIGludG8gdGhlIGxvY2FsVG9FbnRy eSB2ZWN0b3IuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9HQ0Fzc2Vy dGlvbnMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0dDQXNzZXJ0aW9ucy5oCmluZGV4 IGMxNjNhMTkwYzliYTY4Y2Y5NzE4MzE5NDJiOWUzYmE0MTdlNTQxOTYuLjdmOTI4NjY2MzI5ODVh ZDEwOGExMWVkMGFmOTUxOTA0OGQzZTUyY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL0dDQXNzZXJ0aW9ucy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L0dDQXNzZXJ0aW9ucy5oCkBAIC00NSwxNCArNDUsMTEgQEAKICNkZWZpbmUgQVNTRVJUX0dDX09C SkVDVF9JTkhFUklUUyhvYmplY3QsIGNsYXNzSW5mbykgZG8geyAodm9pZClvYmplY3Q7ICh2b2lk KWNsYXNzSW5mbzsgfSB3aGlsZSAoMCkKICNlbmRpZgogCi0jaWYgQ09NUElMRVIoQ0xBTkcpCisj aWYgQ09NUElMRVIoR0NDKQogI2RlZmluZSBTVEFUSUNfQVNTRVJUX0lTX1RSSVZJQUxMWV9ERVNU UlVDVElCTEUoa2xhc3MpIHN0YXRpY19hc3NlcnQoc3RkOjppc190cml2aWFsbHlfZGVzdHJ1Y3Rp YmxlPGtsYXNzPjo6dmFsdWUsICNrbGFzcyAiIG11c3QgaGF2ZSBhIHRyaXZpYWwgZGVzdHJ1Y3Rv ciIpCiAjZWxpZiBDT01QSUxFUihNU1ZDKQogLy8gQW4gZWFybGllciB2ZXJpc29uIG9mIHRoZSBD KysxMSBzcGVjIHVzZWQgdG8gY2FsbCB0aGlzIHR5cGUgdHJhaXQgc3RkOjpoYXNfdHJpdmlhbF9k ZXN0cnVjdG9yLCBhbmQgdGhhdCdzIHdoYXQgTVNWQyB1c2VzLgogI2RlZmluZSBTVEFUSUNfQVNT RVJUX0lTX1RSSVZJQUxMWV9ERVNUUlVDVElCTEUoa2xhc3MpIHN0YXRpY19hc3NlcnQoc3RkOjpo YXNfdHJpdmlhbF9kZXN0cnVjdG9yPGtsYXNzPjo6dmFsdWUsICNrbGFzcyAiIG11c3QgaGF2ZSBh IHRyaXZpYWwgZGVzdHJ1Y3RvciIpCi0jZWxzZQotLy8gVGhpcyBpcyBub3QgZW5hYmxlZCBvbiBH Q0MgZHVlIHRvIGh0dHA6Ly9nY2MuZ251Lm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9NTI3 MDIKLSNkZWZpbmUgU1RBVElDX0FTU0VSVF9JU19UUklWSUFMTFlfREVTVFJVQ1RJQkxFKGtsYXNz KQogI2VuZGlmCiAKICNlbmRpZiAvLyBHQ0Fzc2VydGlvbnNfaAo= 257273 2015-07-22 08:37:06 -0700 2015-07-22 11:05:32 -0700 Patch bug-146829-20150722083551.patch text/plain 1754 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg3MTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YzY4NmNkNTczOTg4ODA2MzZlMjFiYzdlYjRlMzYxYzYxYmU5YmZjLi5iNjZlNTFiZjFhODU2YWQ4 NjkzOGFjNzhlNzMzYTg0YzUwNDNjOGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0wNy0yMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEVuYWJsZSBTVEFUSUNfQVNTRVJUX0lTX1RSSVZJQUxMWV9ERVNUUlVD VElCTEUgZm9yIEdDQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2ODI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBoZWFwL0dDQXNzZXJ0aW9ucy5oOgorCiAyMDE1LTA3LTIxICBZdXN1a2UgU3V6dWtp ICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIEFkZCBuZXdUYXJnZXQgYWNjZXNz b3IgdG8gSlMgY29uc3RydWN0b3Igd3JpdHRlbiBpbiBDKysKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0dDQXNzZXJ0aW9ucy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvR0NBc3NlcnRpb25zLmgKaW5kZXggYzE2M2ExOTBjOWJhNjhjZjk3MTgzMTk0MmI5ZTNi YTQxN2U1NDE5Ni4uZmNiMTM1YWM1MzI1ODhlNzIxMjk1NWEwNzk2MmEzNWE2ZGE2YzkyZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvR0NBc3NlcnRpb25zLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvR0NBc3NlcnRpb25zLmgKQEAgLTQ1LDE0ICs0NSw2 IEBACiAjZGVmaW5lIEFTU0VSVF9HQ19PQkpFQ1RfSU5IRVJJVFMob2JqZWN0LCBjbGFzc0luZm8p IGRvIHsgKHZvaWQpb2JqZWN0OyAodm9pZCljbGFzc0luZm87IH0gd2hpbGUgKDApCiAjZW5kaWYK IAotI2lmIENPTVBJTEVSKENMQU5HKQogI2RlZmluZSBTVEFUSUNfQVNTRVJUX0lTX1RSSVZJQUxM WV9ERVNUUlVDVElCTEUoa2xhc3MpIHN0YXRpY19hc3NlcnQoc3RkOjppc190cml2aWFsbHlfZGVz dHJ1Y3RpYmxlPGtsYXNzPjo6dmFsdWUsICNrbGFzcyAiIG11c3QgaGF2ZSBhIHRyaXZpYWwgZGVz dHJ1Y3RvciIpCi0jZWxpZiBDT01QSUxFUihNU1ZDKQotLy8gQW4gZWFybGllciB2ZXJpc29uIG9m IHRoZSBDKysxMSBzcGVjIHVzZWQgdG8gY2FsbCB0aGlzIHR5cGUgdHJhaXQgc3RkOjpoYXNfdHJp dmlhbF9kZXN0cnVjdG9yLCBhbmQgdGhhdCdzIHdoYXQgTVNWQyB1c2VzLgotI2RlZmluZSBTVEFU SUNfQVNTRVJUX0lTX1RSSVZJQUxMWV9ERVNUUlVDVElCTEUoa2xhc3MpIHN0YXRpY19hc3NlcnQo c3RkOjpoYXNfdHJpdmlhbF9kZXN0cnVjdG9yPGtsYXNzPjo6dmFsdWUsICNrbGFzcyAiIG11c3Qg aGF2ZSBhIHRyaXZpYWwgZGVzdHJ1Y3RvciIpCi0jZWxzZQotLy8gVGhpcyBpcyBub3QgZW5hYmxl ZCBvbiBHQ0MgZHVlIHRvIGh0dHA6Ly9nY2MuZ251Lm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/ aWQ9NTI3MDIKLSNkZWZpbmUgU1RBVElDX0FTU0VSVF9JU19UUklWSUFMTFlfREVTVFJVQ1RJQkxF KGtsYXNzKQotI2VuZGlmCiAKICNlbmRpZiAvLyBHQ0Fzc2VydGlvbnNfaAo=