146826 2015-07-10 00:27:09 -0700 [CoordinatedGraphics] Override primaryLayerID in CoordinatedGraphicsLayer 2015-07-10 17:41:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cmarcelo commit-queue kondapallykalyan lucas.de.marchi luiz noam oldest_to_newest 1108552 0 ryuan.choi 2015-07-10 00:27:09 -0700 primaryLayerID is usefull to debug layer tree using showGraphicsLayerTree() 1108558 1 256570 ryuan.choi 2015-07-10 02:23:06 -0700 Created attachment 256570 Patch 1108568 2 256570 gyuyoung.kim 2015-07-10 03:07:14 -0700 Comment on attachment 256570 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256570&action=review > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124 > + CoordinatedLayerID id() const { return m_id; } primaryLayerID() just returns id(). So I'm not 100% sure if we should continue to keep id(). r+ed for now. 1108608 3 ryuan.choi 2015-07-10 06:23:18 -0700 (In reply to comment #2) > Comment on attachment 256570 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256570&action=review > > > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124 > > + CoordinatedLayerID id() const { return m_id; } > > primaryLayerID() just returns id(). So I'm not 100% sure if we should > continue to keep id(). r+ed for now. While PlatformLayerID is uint64_t, CoordinatedGraphicsLayer uses uint32_t as id and id is widely used including IPC message. If refactoring does not have critical performance regression, we can remove id. I will check it. 1108826 4 256570 commit-queue 2015-07-10 17:41:42 -0700 Comment on attachment 256570 Patch Clearing flags on attachment: 256570 Committed r186700: <http://trac.webkit.org/changeset/186700> 1108827 5 commit-queue 2015-07-10 17:41:47 -0700 All reviewed patches have been landed. Closing bug. 256570 2015-07-10 02:23:06 -0700 2015-07-10 17:41:42 -0700 Patch bug-146826-20150710022203.patch text/plain 2751 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM1Y2JjMmM0MGRjZDNk OGEyMDk2ZDgwYjVhMzFkYTk3ZDRiNzc5My4uZmVhMjk5NTRkZWZhNTE0NjQwOTlmYTI4MDYwMDU4 ZDIxZGM3MTI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTEwICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXSBPdmVycmlkZSBwcmltYXJ5TGF5ZXJJRCBpbiBDb29yZGluYXRlZEdyYXBoaWNz TGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NjgyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NM YXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6Omlk KTogTW92ZWQgaWQgYXMgaW5saW5lIGZ1bmN0aW9uLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6aWQpOgorCiAyMDE1LTA3LTA5 ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBGb2xsb3d1cCB0 byByMTg2NjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdy YXBoaWNzTGF5ZXIuY3BwCmluZGV4IGZhYTE2NWVhZTYzODIxZWMzZDEzOWQxOGVmZWYxN2RhZTAy ODc4ZTAuLmI1MDc2NGFhMTc1YjJlNDJmM2QzMGNiNDkyY2Q1MTY5MWVlMDI0M2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9D b29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3Bw CkBAIC01MzcsMTEgKzUzNyw2IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzZXRO ZWVkc0Rpc3BsYXlJblJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0LCBTaG91CiAgICAgYWRkUmVw YWludFJlY3QocmVjdCk7CiB9CiAKLUNvb3JkaW5hdGVkTGF5ZXJJRCBDb29yZGluYXRlZEdyYXBo aWNzTGF5ZXI6OmlkKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9pZDsKLX0KLQogdm9pZCBDb29y ZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNldFNjcm9sbGFibGVBcmVhKFNjcm9sbGFibGVBcmVhKiBz Y3JvbGxhYmxlQXJlYSkKIHsKICAgICBib29sIG9sZFNjcm9sbGFibGUgPSBpc1Njcm9sbGFibGUo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9j b29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5 ZXIuaAppbmRleCAxYWE3OTA0YTgwZTZiMDc4YmRhNmE1MmE2OThiZDllZWUwN2FjY2ViLi5mMDU0 YWY1ZDc1YjkxMjA3NWQ0YjA0NzA2NWYxNDFmZmNjNmIwNjc4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRH cmFwaGljc0xheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oCkBAIC02Miw2ICs2Miw4 IEBAIHB1YmxpYzoKICAgICBleHBsaWNpdCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXIoVHlwZSwg R3JhcGhpY3NMYXllckNsaWVudCYpOwogICAgIHZpcnR1YWwgfkNvb3JkaW5hdGVkR3JhcGhpY3NM YXllcigpOwogCisgICAgUGxhdGZvcm1MYXllcklEIHByaW1hcnlMYXllcklEKCkgY29uc3Qgb3Zl cnJpZGUgeyByZXR1cm4gaWQoKTsgfQorCiAgICAgLy8gUmVpbXBsZW1lbnRhdGlvbnMgZnJvbSBH cmFwaGljc0xheWVyLmguCiAgICAgdmlydHVhbCBib29sIHNldENoaWxkcmVuKGNvbnN0IFZlY3Rv cjxHcmFwaGljc0xheWVyKj4mKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgYWRkQ2hpbGQo R3JhcGhpY3NMYXllciopIG92ZXJyaWRlOwpAQCAtMTE5LDcgKzEyMSw3IEBAIHB1YmxpYzoKICAg ICBib29sIGlzU2Nyb2xsYWJsZSgpIGNvbnN0IHsgcmV0dXJuICEhbV9zY3JvbGxhYmxlQXJlYTsg fQogICAgIHZvaWQgY29tbWl0U2Nyb2xsT2Zmc2V0KGNvbnN0IEludFNpemUmKTsKIAotICAgIENv b3JkaW5hdGVkTGF5ZXJJRCBpZCgpIGNvbnN0OworICAgIENvb3JkaW5hdGVkTGF5ZXJJRCBpZCgp IGNvbnN0IHsgcmV0dXJuIG1faWQ7IH0KIAogICAgIHZvaWQgc2V0Rml4ZWRUb1ZpZXdwb3J0KGJv b2wgaXNGaXhlZCk7CiAK