146824 2015-07-09 21:03:57 -0700 Plugin create can end up destroying its renderer. 2015-07-09 22:56:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue ddkilzer japhet kling oldest_to_newest 1108524 0 zalan 2015-07-09 21:03:57 -0700 We should check whether the renderer is still valid (like we do at setWidgetGeometry) 1108526 1 zalan 2015-07-09 21:04:59 -0700 rdar://problem/18921429 1108527 2 256564 zalan 2015-07-09 21:13:08 -0700 Created attachment 256564 Patch 1108539 3 256564 commit-queue 2015-07-09 22:56:27 -0700 Comment on attachment 256564 Patch Clearing flags on attachment: 256564 Committed r186666: <http://trac.webkit.org/changeset/186666> 1108540 4 commit-queue 2015-07-09 22:56:31 -0700 All reviewed patches have been landed. Closing bug. 256564 2015-07-09 21:13:08 -0700 2015-07-09 22:56:27 -0700 Patch bug-146824-20150709211206.patch text/plain 2608 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWJjOThmMWE2OTA2NzZk ZjhhN2U2NmEyMWY5ZDFiMjg1OGRmNjA2OS4uMGE3NGUyMTBiNTg3ZDQ1YzRhNzUwYTc1MTE5OTJj MGI0Y2JhODI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA3LTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUGx1Z2luIGNyZWF0ZSBjYW4g ZW5kIHVwIGRlc3Ryb3lpbmcgaXRzIHJlbmRlcmVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2ODI0CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE4 OTIxNDI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UGx1Z2lucyBjYW4gcnVuIGFyYml0cmFyeSBjb2RlIGR1cmluZyBpbml0aWFsaXphdGlvbi4gSWYg dGhlIHBsdWdpbgorICAgICAgICBoYXBwZW5zIHRvIGRlc3Ryb3kgdGhlIGFzc29jaWF0ZWQgbm9k ZSwgaXRzIHJlbmRlcmVyIGJlY29tZXMgaW52YWxpZC4KKyAgICAgICAgVGhpcyBwYXRjaCBjaGVj a3Mgd2hldGhlciB0aGUgcmVuZGVyZXIgc3Vydml2ZWQgdGhlIGNyZWF0ZVBsdWdpbigpIGNhbGwu CisgICAgICAgIChUaGlzIFdlYWtQdHIgcGF0dGVybiBpcyBhbHNvIHVzZWQgaW4gUmVuZGVyV2lk Z2V0IHRvIGF2b2lkIGRhbmdsaW5nIHBvaW50ZXJzLikKKworICAgICAgICBTcGVjdWxhdGl2ZSBm aXguIE5vdCByZXByb2R1Y2libGUuCisKKyAgICAgICAgKiBsb2FkZXIvU3ViZnJhbWVMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U3ViZnJhbWVMb2FkZXI6OmxvYWRQbHVnaW4pOgorCiAy MDE1LTA3LTA4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRG8g bm90IHdhc3RlIHdpbmRvdyBzZXJ2ZXIgbWVtb3J5IGZvciBwbGFjZWhvbGRlciB3aW5kb3dzIGlu aXRpYXRlZCBieSBUaGVtZU1hYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9T dWJmcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3ViZnJhbWVMb2FkZXIu Y3BwCmluZGV4IGE2ZTE1NWJjZTZiYTYxNTNiNDI2NGZhMjZkMDdlNmEyZjI5ZDhjOTQuLjQ1Njli MjVmMTI4NTNhYWQ5OWQyYWY4MzEzN2Q3ZDcwZTBlYzdlZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL1N1YmZyYW1lTG9hZGVyLmNwcApAQCAtMzkxLDEwICszOTEsMTIgQEAgRG9jdW1lbnQqIFN1 YmZyYW1lTG9hZGVyOjpkb2N1bWVudCgpIGNvbnN0CiAKIGJvb2wgU3ViZnJhbWVMb2FkZXI6Omxv YWRQbHVnaW4oSFRNTFBsdWdJbkltYWdlRWxlbWVudCYgcGx1Z2luRWxlbWVudCwgY29uc3QgVVJM JiB1cmwsIGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBwYXJh bU5hbWVzLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGFyYW1WYWx1ZXMsIGJvb2wgdXNlRmFsbGJh Y2spCiB7Ci0gICAgUmVuZGVyRW1iZWRkZWRPYmplY3QqIHJlbmRlcmVyID0gcGx1Z2luRWxlbWVu dC5yZW5kZXJFbWJlZGRlZE9iamVjdCgpOworICAgIGlmICh1c2VGYWxsYmFjaykKKyAgICAgICAg cmV0dXJuIGZhbHNlOwogCisgICAgUmVuZGVyRW1iZWRkZWRPYmplY3QqIHJlbmRlcmVyID0gcGx1 Z2luRWxlbWVudC5yZW5kZXJFbWJlZGRlZE9iamVjdCgpOwogICAgIC8vIEZJWE1FOiBUaGlzIGNv ZGUgc2hvdWxkIG5vdCBkZXBlbmQgb24gcmVuZGVyZXIhCi0gICAgaWYgKCFyZW5kZXJlciB8fCB1 c2VGYWxsYmFjaykKKyAgICBpZiAoIXJlbmRlcmVyKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICBwbHVnaW5FbGVtZW50LnN1YmZyYW1lTG9hZGVyV2lsbENyZWF0ZVBsdWdJbih1cmwpOwpA QCAtNDA4LDcgKzQxMCwxMSBAQCBib29sIFN1YmZyYW1lTG9hZGVyOjpsb2FkUGx1Z2luKEhUTUxQ bHVnSW5JbWFnZUVsZW1lbnQmIHBsdWdpbkVsZW1lbnQsIGNvbnN0IFVSTAogICAgICAgICBsb2Fk TWFudWFsbHkgPSBmYWxzZTsKICNlbmRpZgogCisgICAgV2Vha1B0cjxSZW5kZXJXaWRnZXQ+IHdl YWtSZW5kZXJlciA9IHJlbmRlcmVyLT5jcmVhdGVXZWFrUHRyKCk7CisgICAgLy8gY3JlYXRlUGx1 Z2luICptYXkqIGNhdXNlIHRoaXMgcmVuZGVyZXIgdG8gZGlzYXBwZWFyIGZyb20gdW5kZXJuZWF0 aC4KICAgICBSZWZQdHI8V2lkZ2V0PiB3aWRnZXQgPSBtX2ZyYW1lLmxvYWRlcigpLmNsaWVudCgp LmNyZWF0ZVBsdWdpbihjb250ZW50U2l6ZSwgJnBsdWdpbkVsZW1lbnQsIHVybCwgcGFyYW1OYW1l cywgcGFyYW1WYWx1ZXMsIG1pbWVUeXBlLCBsb2FkTWFudWFsbHkpOworICAgIGlmICghd2Vha1Jl bmRlcmVyKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoIXdpZGdldCkgewogICAg ICAgICBpZiAoIXJlbmRlcmVyLT5pc1BsdWdpblVuYXZhaWxhYmxlKCkpCg==