146776 2015-07-08 23:16:06 -0700 Web Inspector: Checkbox disappears when unchecking CSS background style 2015-07-09 12:26:35 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1108132 0 256461 hi 2015-07-08 23:16:06 -0700 Created attachment 256461 Test HTML Page Safari's web inspector CSS editor removes the checkbox on certain styles when clicked. * STEPS TO REPRODUCE 1. Open the attached HTML file (16214480.html) 2. Safari > Develop > Show Web Inspector > Inspect, click the div 3. Try unchecking each of the styles in the CSS editor, then rechecking them * RESULTS When you uncheck 'background', the checkbox you unchecked vanishes. This makes it difficult to re-enable the style. The problem does not occur with the other style ('color') Expected: checkboxes shouldn't mysteriously disappear * REGRESSION Tested on 13D11, Safari 7.0.2 * NOTES This problem does not occur in Google Chrome (tested on 33.0.1750.117), the checkboxes are always usable. Semi-workaround for Safari is to position the cursor in the /* background: ... */, and delete the leading "/*". This re-enables the style, but you have to be sure to also remove the trailing "*/". 1108133 1 hi 2015-07-08 23:16:20 -0700 <rdar://problem/16214480> 1108136 2 256463 hi 2015-07-08 23:22:08 -0700 Created attachment 256463 Patch 1108246 3 256463 timothy 2015-07-09 11:03:18 -0700 Comment on attachment 256463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256463&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:820 > + _createCommentedCheckboxMarker(lineHandler) Nit: lineHandle 1108259 4 256493 hi 2015-07-09 11:30:38 -0700 Created attachment 256493 Patch 1108286 5 256493 commit-queue 2015-07-09 12:26:32 -0700 Comment on attachment 256493 Patch Clearing flags on attachment: 256493 Committed r186602: <http://trac.webkit.org/changeset/186602> 1108287 6 commit-queue 2015-07-09 12:26:35 -0700 All reviewed patches have been landed. Closing bug. 256461 2015-07-08 23:16:06 -0700 2015-07-08 23:16:06 -0700 Test HTML Page 16214480.html text/html 1735 hi PGRpdiBzdHlsZT0iY29sb3I6IHllbGxvdzsgYmFja2dyb3VuZDogdHJhbnNwYXJlbnQgdXJsKGRh dGE6aW1hZ2UvcG5nO2Jhc2U2NCxpVkJPUncwS0dnb0FBQUFOU1VoRVVnQUFBQW9BQUFBZkNBWUFB QURlS1Z5VkFBQUVKR2xEUTFCSlEwTWdVSEp2Wm1sc1pRQUFPQkdGVmQ5djIxUVVQb2x2VXFRV1B5 QllSNGVLeGE5VlUxdTVHeHF0eGdaSms2WHRTaGFsNmRncUpPUTZONG1wR3dmYjZiYXFUM3VCTndi OEFVRFpBdzlJUENFTkJtSjcyZmJBdEVsVGh5cXFTVWg3Nk1RUElTYnRCVlhodTNaaUoxUEVYUFg2 eXpuZk9lYzc1MTdiUkQxZmFiV2FHVldJbHF1dW5jOGtsWk9uRnBTZVRZclNzOVJMQTlTcjZVNHRr Y3ZORWk3QkZmZk82K0VkaWdqTDdaSHUvazcySTc5Nmk5elJpU0pQd0c0VkhYMForQXhSek5ScnRr c1V2d2Y3K0dtM0J0enpIUERUTmdRQ3F3S1hmWndTZU5ISEp6MU9JVDhKanRBcTZ4V3RDTHdHUEx6 WVppKzNZVjhER01pVDRWVnVHN29pWnBHenJaSmhjcy9oTDQ5eHR6SC9EeTZiZGZUc1hZTlkrNXls dVdPNEQ0bmVLL1pVdm9rLzE3WDBIUEJMc0YrdnVVbGhmd1g0ai9yU2ZBSjRIMUgwcVpKOWRON25S MTlmclJUZUJ0NEZlOUZ3cHd0TisycDFNWHNjR0xIUjlTWHJtTWdqT05kMVp4S3pwQmVBNzFiNHRO aGo2SkdveUZOcDRHSGd3VXA5cXBsZm1uRlc1b1RkeTdOYW1jd0NJNDlrdjZmTjVJQUhnRCswcmJ5 b0JjM1NPamN6b2hieVMxZHJicTZwUWRxdW1sbFJDLzB5bVR0ZWo4Z3BiYnVWd3BRZnl3NjZkcUVa eXhaS3h0SHBKbit0Wm5wbkVkcllCYnVlRjlxUW45M1M3SFFHR0huWVA3dzZMK1lHSE50ZDFGSml0 cVBBUitoRVJDTk9GaTFpMWFsS082UlFuaktVeEwxR05qd2xNc2lFaGNQTFlURWlUOUlTYk4xNU9Z L2p4NFNNc2hlOUxhSlJwVHZIcjNDL3liRllQMVBaQWZ3ZllyUHNNQnRuRTZTd045aWI3QWhMd1Ry QkRnVUtjbTA2RlNyVGZTajE4N3hQZFZRV09rNVE4dnhBZlNpSVVjN1o3eHI2elkvK2hwcXdTeXYw STAvUU1UUmI3Uk1nQnhOb2RUZlNQcWRyYXovc0RqektCcnY0enUyK2EydDAvSEh6amQyTGJjYzJz RzdHdHNMNDJLK3hMZnh0VWdJN1lIcUtscUhLOEhiQ0NYZ2pIVDFjQWRNbERldHY0Rm5RMmxMYXNh T2w2dm1CMENNbXdUL0lQc3pTdWVIUXF2NmkvcWx1cUYrb0Y5VGZPMnFFR1R1bUpIMHFmU3Y5S0gw bmZTLzlUSXAwV2JvaS9TUmRsYjZSTGdVNXUrKzlueVhZZTY5ZllSUGRpbDFvMVd1Zk5TZFRUc3A3 NUJmbGxQeTgvTEk4RzdBVXVWOGVrNmZrdmZEc0NmYk5EUDBkdlJoMENyTnFUYlY3TGZFRUdEUVBK UWFkQnRmR1ZNV0VxM1FXV2R1Zms2WlNOc2pHMlBRanAzWmNuT1dXaW5nNm5vb25TSW52aTAvRXgr SXpBcmVldlBoZStDYXdwZ1AxL3BNVE1EbzY0RzBzVENYSU0rS2RPbkZXUmZRS2RKdlF6VjErQnQ4 T29rbXJkdFkyeWhWWDJhK3FyeWtKZk1xNE1sM1ZSNGNWelRRVnorVW9ObmU0dmNLTG95UytneUtP NkVIZSs3NUZkdDBNYmU1YlJJZi93anZyVm1oYnFCTjk3UkQxdnhyYWh2Qk9mT1l6b29zSDlicTk0 dWVqU09RR2tWTTZzTi83SGVsTDR0MTB0OUY0Z1BkVnp5ZEVPeDgzR3YrdU54bzdYeUwvRnRGbDh6 OVpBSEY0YkJzckV3QUFBQWx3U0ZsekFBQUs4QUFBQ3ZBQlFxdzBtQUFBQUVsSlJFRlVPQkZqVEVo SStNOUFCR0I1OSs0ZEVjb1lHRmorL3lmS1FBWW1vb3dES2hwQUU0bTJlbmdwL1BmdkgxR1JNN3g4 VFd6Q1pSbTQ0S0YrbmhsZVVTZ2tKRVJVd2dVQWZLSlFRZzVQQ2QwQUFBQUFTVVZPUks1Q1lJST0p IDAgMCByZXBlYXQteDsiPng8L2Rpdj4KCg== 256463 2015-07-08 23:22:08 -0700 2015-07-09 11:30:36 -0700 Patch bug-146776-20150708232106.patch text/plain 5934 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk2MzFhODMzOGQ0ZmMwODQ5NzkwODk5MWQ3YjNm MGYxNzUxZGQyNjIuLjU4NGRmMGNjOGEwOGNhMDdhMzc4OGFjODc2OTYwMmYzOWE0NWZkODIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE1LTA3LTA4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBD aGVja2JveCBkaXNhcHBlYXJzIHdoZW4gdW5jaGVja2luZyBDU1MgYmFja2dyb3VuZCBzdHlsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2Nzc2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZS5fdXBk YXRlVGV4dE1hcmtlcnMudXBkYXRlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DU1NTdHlsZURl Y2xhcmF0aW9uVGV4dEVkaXRvci5wcm90b3R5cGUuX3VwZGF0ZVRleHRNYXJrZXJzKTogTm93IHVz ZXMgX2NyZWF0ZUNvbW1lbnRlZENoZWNrYm94TWFya2VyLgorICAgICAgICAoV2ViSW5zcGVjdG9y LkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZS5fY3JlYXRlQ29tbWVudGVk Q2hlY2tib3hNYXJrZXIpOgorICAgICAgICBTY2FucyB0aGUgY29udGVudCBvZiB0aGUgZ2l2ZW4g bGluZUhhbmRsZXIgZm9yIGFueSBjb21tZW50ZWQgdGV4dCBhbmQgYWRkcyBhbiB1bnNlbGVjdGVk IGNoZWNrYm94IHRvCisgICAgICAgIHRoZSBiZWdpbm5pbmcgb2YgdGhhdCBsaW5lSGFuZGxlcidz IGxpbmUuCisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0 b3IucHJvdG90eXBlLl9yZXNldENvbnRlbnQudXBkYXRlKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5wcm90b3R5cGUuX3Jlc2V0Q29udGVudCk6 IE5vdyBhZGRzIGNvbW1lbnRlZCBjaGVja2JveCBtYXJrZXJzLgorCisyMDE1LTA3LTA4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBT dHlsZSBzaWRlYmFyIGlzIHNob3dpbmcgaW5jb3JyZWN0IHN0cmlrZXRocm91Z2hzCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY3NjgKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVE ZWNsYXJhdGlvblRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwppbmRleCAyMzViYWZi OTFlYjU1ZGVkMzdiNGIyNzk3NTZjYjZlODFmYzc2OTNiLi43YzNjMDk1MWFmOWIzYjhhYTFkNjc2 YWIyZTI5ODVmYTY2ZmM2ZWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0 aW9uVGV4dEVkaXRvci5qcwpAQCAtNzk5LDM0ICs3OTksMTAgQEAgV2ViSW5zcGVjdG9yLkNTU1N0 eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRF ZGl0b3IKICAgICAgICAgICAgIH0pOwogCiAgICAgICAgICAgICBpZiAoIXRoaXMuX2NvZGVNaXJy b3IuZ2V0T3B0aW9uKCJyZWFkT25seSIpKSB7Ci0gICAgICAgICAgICAgICAgLy8gTWF0Y2hlcyBh IGNvbW1lbnQgbGlrZTogLyogLXdlYmtpdC1mb286IGJhcjsgKi8KLSAgICAgICAgICAgICAgICB2 YXIgY29tbWVudGVkUHJvcGVydHlSZWdleCA9IC9cL1wqXHMqWy1cd10rXHMqOlxzKlteO10rOz9c cypcKlwvL2c7Ci0KICAgICAgICAgICAgICAgICAvLyBMb29rIGZvciBjb21tZW50cyB0aGF0IGxv b2sgbGlrZSBwcm9wZXJ0aWVzIGFuZCBhZGQgY2hlY2tib3hlcyBpbiBmcm9udCBvZiB0aGVtLgot ICAgICAgICAgICAgICAgIHZhciBsaW5lQ291bnQgPSB0aGlzLl9jb2RlTWlycm9yLmxpbmVDb3Vu dCgpOwotICAgICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbGluZUNvdW50OyArK2kp IHsKLSAgICAgICAgICAgICAgICAgICAgdmFyIGxpbmVDb250ZW50ID0gdGhpcy5fY29kZU1pcnJv ci5nZXRMaW5lKGkpOwotCi0gICAgICAgICAgICAgICAgICAgIHZhciBtYXRjaCA9IGNvbW1lbnRl ZFByb3BlcnR5UmVnZXguZXhlYyhsaW5lQ29udGVudCk7Ci0gICAgICAgICAgICAgICAgICAgIHdo aWxlIChtYXRjaCkgewotICAgICAgICAgICAgICAgICAgICAgICAgdmFyIGNoZWNrYm94RWxlbWVu dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7Ci0gICAgICAgICAgICAgICAgICAg ICAgICBjaGVja2JveEVsZW1lbnQudHlwZSA9ICJjaGVja2JveCI7Ci0gICAgICAgICAgICAgICAg ICAgICAgICBjaGVja2JveEVsZW1lbnQuY2hlY2tlZCA9IGZhbHNlOwotICAgICAgICAgICAgICAg ICAgICAgICAgY2hlY2tib3hFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNoYW5nZSIsIHRoaXMu X3Byb3BlcnR5Q29tbWVudENoZWNrYm94Q2hhbmdlZC5iaW5kKHRoaXMpKTsKLQotICAgICAgICAg ICAgICAgICAgICAgICAgdmFyIGZyb20gPSB7bGluZTogaSwgY2g6IG1hdGNoLmluZGV4fTsKLSAg ICAgICAgICAgICAgICAgICAgICAgIHZhciB0byA9IHtsaW5lOiBpLCBjaDogbWF0Y2guaW5kZXgg KyBtYXRjaFswXS5sZW5ndGh9OwotCi0gICAgICAgICAgICAgICAgICAgICAgICB2YXIgY2hlY2ti b3hNYXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLnNldFVuaXF1ZUJvb2ttYXJrKGZyb20sIGNoZWNr Ym94RWxlbWVudCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBjaGVja2JveE1hcmtlci5fX3By b3BlcnR5Q2hlY2tib3ggPSB0cnVlOwotCi0gICAgICAgICAgICAgICAgICAgICAgICB2YXIgY29t bWVudFRleHRNYXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLm1hcmtUZXh0KGZyb20sIHRvKTsKLQot ICAgICAgICAgICAgICAgICAgICAgICAgY2hlY2tib3hFbGVtZW50Ll9fY29tbWVudFRleHRNYXJr ZXIgPSBjb21tZW50VGV4dE1hcmtlcjsKLQotICAgICAgICAgICAgICAgICAgICAgICAgbWF0Y2gg PSBjb21tZW50ZWRQcm9wZXJ0eVJlZ2V4LmV4ZWMobGluZUNvbnRlbnQpOwotICAgICAgICAgICAg ICAgICAgICB9Ci0gICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIHRoaXMuX2NvZGVN aXJyb3IuZWFjaExpbmUoZnVuY3Rpb24obGluZUhhbmRsZXIpIHsKKyAgICAgICAgICAgICAgICAg ICAgdGhpcy5fY3JlYXRlQ29tbWVudGVkQ2hlY2tib3hNYXJrZXIobGluZUhhbmRsZXIpOworICAg ICAgICAgICAgICAgIH0uYmluZCh0aGlzKSk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAg IC8vIExvb2sgZm9yIGNvbG9ycyBhbmQgbWFrZSBzd2F0Y2hlcy4KQEAgLTg0MSw2ICs4MTcsNDEg QEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3MgQ1NT U3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IKICAgICAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iu b3BlcmF0aW9uKHVwZGF0ZS5iaW5kKHRoaXMpKTsKICAgICB9CiAKKyAgICBfY3JlYXRlQ29tbWVu dGVkQ2hlY2tib3hNYXJrZXIobGluZUhhbmRsZXIpCisgICAgeworICAgICAgICB2YXIgbGluZU51 bWJlciA9IGxpbmVIYW5kbGVyLmxpbmVObygpOworCisgICAgICAgIC8vIFNpbmNlIGxpbmVOdW1i ZXIgY2FuIGJlIDAsIGl0IGlzIGFsc28gbmVjZXNzYXJ5IHRvIGNoZWNrIGlmIGl0IGlzIGEgbnVt YmVyIGJlZm9yZSByZXR1cm5pbmcuCisgICAgICAgIGlmICghbGluZU51bWJlciAmJiBpc05hTihs aW5lTnVtYmVyKSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAvLyBNYXRjaGVzIGEg Y29tbWVudCBsaWtlOiAvKiAtd2Via2l0LWZvbzogYmFyOyAqLworICAgICAgICB2YXIgY29tbWVu dGVkUHJvcGVydHlSZWdleCA9IC9cL1wqXHMqWy1cd10rXHMqOlxzKlteO10rOz9ccypcKlwvL2c7 CisKKyAgICAgICAgdmFyIG1hdGNoID0gY29tbWVudGVkUHJvcGVydHlSZWdleC5leGVjKGxpbmVI YW5kbGVyLnRleHQpOworICAgICAgICBpZiAoIW1hdGNoKQorICAgICAgICAgICAgcmV0dXJuOwor CisgICAgICAgIHdoaWxlIChtYXRjaCkgeworICAgICAgICAgICAgdmFyIGNoZWNrYm94RWxlbWVu dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7CisgICAgICAgICAgICBjaGVja2Jv eEVsZW1lbnQudHlwZSA9ICJjaGVja2JveCI7CisgICAgICAgICAgICBjaGVja2JveEVsZW1lbnQu Y2hlY2tlZCA9IGZhbHNlOworICAgICAgICAgICAgY2hlY2tib3hFbGVtZW50LmFkZEV2ZW50TGlz dGVuZXIoImNoYW5nZSIsIHRoaXMuX3Byb3BlcnR5Q29tbWVudENoZWNrYm94Q2hhbmdlZC5iaW5k KHRoaXMpKTsKKworICAgICAgICAgICAgdmFyIGZyb20gPSB7bGluZTogbGluZU51bWJlciwgY2g6 IG1hdGNoLmluZGV4fTsKKyAgICAgICAgICAgIHZhciB0byA9IHtsaW5lOiBsaW5lTnVtYmVyLCBj aDogbWF0Y2guaW5kZXggKyBtYXRjaFswXS5sZW5ndGh9OworCisgICAgICAgICAgICB2YXIgY2hl Y2tib3hNYXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLnNldFVuaXF1ZUJvb2ttYXJrKGZyb20sIGNo ZWNrYm94RWxlbWVudCk7CisgICAgICAgICAgICBjaGVja2JveE1hcmtlci5fX3Byb3BlcnR5Q2hl Y2tib3ggPSB0cnVlOworCisgICAgICAgICAgICB2YXIgY29tbWVudFRleHRNYXJrZXIgPSB0aGlz Ll9jb2RlTWlycm9yLm1hcmtUZXh0KGZyb20sIHRvKTsKKworICAgICAgICAgICAgY2hlY2tib3hF bGVtZW50Ll9fY29tbWVudFRleHRNYXJrZXIgPSBjb21tZW50VGV4dE1hcmtlcjsKKworICAgICAg ICAgICAgbWF0Y2ggPSBjb21tZW50ZWRQcm9wZXJ0eVJlZ2V4LmV4ZWMobGluZUhhbmRsZXIudGV4 dCk7CisgICAgICAgIH0KKyAgICB9CisKICAgICBfY3JlYXRlQ29sb3JTd2F0Y2hlcyhub25hdG9t aWMsIGxpbmVOdW1iZXIpCiAgICAgewogICAgICAgICBmdW5jdGlvbiB1cGRhdGUoKQpAQCAtMTUz OSw4ICsxNTUwLDEwIEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRv ciA9IGNsYXNzIENTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yCiAgICAgICAgICAgICAgICAg dmFyIGxpbmVDb250ZW50U2Fuc1doaXRlc3BhY2UgPSBsaW5lSGFuZGxlci50ZXh0LnJlcGxhY2Uo ZmluZFdoaXRlc3BhY2UsICIiKTsKICAgICAgICAgICAgICAgICB2YXIgcHJvcGVydGllcyA9IGNz c1Byb3BlcnRpZXNNYXAuZ2V0KGxpbmVDb250ZW50U2Fuc1doaXRlc3BhY2UpOwogCi0gICAgICAg ICAgICAgICAgaWYgKCFwcm9wZXJ0aWVzKQorICAgICAgICAgICAgICAgIGlmICghcHJvcGVydGll cykgeworICAgICAgICAgICAgICAgICAgICB0aGlzLl9jcmVhdGVDb21tZW50ZWRDaGVja2JveE1h cmtlcihsaW5lSGFuZGxlcik7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg ICAgICAgICB9CiAKICAgICAgICAgICAgICAgICBmb3IgKHZhciBwcm9wZXJ0eSBvZiBwcm9wZXJ0 aWVzKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmIChwcm9wZXJ0eS5fX3JlZnJlc2hlZEFmdGVy Qmx1cikK 256493 2015-07-09 11:30:38 -0700 2015-07-09 12:26:32 -0700 Patch bug-146776-20150709112937.patch text/plain 5870 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk2MzFhODMzOGQ0ZmMwODQ5NzkwODk5MWQ3YjNm MGYxNzUxZGQyNjIuLmMyMjcxMDY3MWY1YjJhZGY5NjNlNDgyNTBlMmY0Y2YzZTU3MTY5MjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA3LTA5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD aGVja2JveCBkaXNhcHBlYXJzIHdoZW4gdW5jaGVja2luZyBDU1MgYmFja2dyb3VuZCBzdHlsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2Nzc2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZS5fdXBk YXRlVGV4dE1hcmtlcnMudXBkYXRlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DU1NTdHlsZURl Y2xhcmF0aW9uVGV4dEVkaXRvci5wcm90b3R5cGUuX3VwZGF0ZVRleHRNYXJrZXJzKTogTm93IHVz ZXMgX2NyZWF0ZUNvbW1lbnRlZENoZWNrYm94TWFya2VyLgorICAgICAgICAoV2ViSW5zcGVjdG9y LkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZS5fY3JlYXRlQ29tbWVudGVk Q2hlY2tib3hNYXJrZXIpOgorICAgICAgICBTY2FucyB0aGUgY29udGVudCBvZiB0aGUgZ2l2ZW4g bGluZUhhbmRsZSBmb3IgYW55IGNvbW1lbnRlZCB0ZXh0IGFuZCBhZGRzIGFuIHVuc2VsZWN0ZWQg Y2hlY2tib3ggdG8KKyAgICAgICAgdGhlIGJlZ2lubmluZyBvZiB0aGF0IGxpbmVIYW5kbGUncyBs aW5lLgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9y LnByb3RvdHlwZS5fcmVzZXRDb250ZW50LnVwZGF0ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu Q1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IucHJvdG90eXBlLl9yZXNldENvbnRlbnQpOiBO b3cgYWRkcyBjb21tZW50ZWQgY2hlY2tib3ggbWFya2Vycy4KKwogMjAxNS0wNy0wOCAgRGV2aW4g Um91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3R5 bGUgc2lkZWJhciBpcyBzaG93aW5nIGluY29ycmVjdCBzdHJpa2V0aHJvdWdocwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNs YXJhdGlvblRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwppbmRleCAyMzViYWZiOTFl YjU1ZGVkMzdiNGIyNzk3NTZjYjZlODFmYzc2OTNiLi5hMDA5NzJjZjAzM2M1MmMwMTU2Y2M2ODVm ZjM4MjNkNTIzZWQyOTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9u VGV4dEVkaXRvci5qcwpAQCAtNzk5LDM0ICs3OTksMTAgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxl RGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0 b3IKICAgICAgICAgICAgIH0pOwogCiAgICAgICAgICAgICBpZiAoIXRoaXMuX2NvZGVNaXJyb3Iu Z2V0T3B0aW9uKCJyZWFkT25seSIpKSB7Ci0gICAgICAgICAgICAgICAgLy8gTWF0Y2hlcyBhIGNv bW1lbnQgbGlrZTogLyogLXdlYmtpdC1mb286IGJhcjsgKi8KLSAgICAgICAgICAgICAgICB2YXIg Y29tbWVudGVkUHJvcGVydHlSZWdleCA9IC9cL1wqXHMqWy1cd10rXHMqOlxzKlteO10rOz9ccypc KlwvL2c7Ci0KICAgICAgICAgICAgICAgICAvLyBMb29rIGZvciBjb21tZW50cyB0aGF0IGxvb2sg bGlrZSBwcm9wZXJ0aWVzIGFuZCBhZGQgY2hlY2tib3hlcyBpbiBmcm9udCBvZiB0aGVtLgotICAg ICAgICAgICAgICAgIHZhciBsaW5lQ291bnQgPSB0aGlzLl9jb2RlTWlycm9yLmxpbmVDb3VudCgp OwotICAgICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbGluZUNvdW50OyArK2kpIHsK LSAgICAgICAgICAgICAgICAgICAgdmFyIGxpbmVDb250ZW50ID0gdGhpcy5fY29kZU1pcnJvci5n ZXRMaW5lKGkpOwotCi0gICAgICAgICAgICAgICAgICAgIHZhciBtYXRjaCA9IGNvbW1lbnRlZFBy b3BlcnR5UmVnZXguZXhlYyhsaW5lQ29udGVudCk7Ci0gICAgICAgICAgICAgICAgICAgIHdoaWxl IChtYXRjaCkgewotICAgICAgICAgICAgICAgICAgICAgICAgdmFyIGNoZWNrYm94RWxlbWVudCA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7Ci0gICAgICAgICAgICAgICAgICAgICAg ICBjaGVja2JveEVsZW1lbnQudHlwZSA9ICJjaGVja2JveCI7Ci0gICAgICAgICAgICAgICAgICAg ICAgICBjaGVja2JveEVsZW1lbnQuY2hlY2tlZCA9IGZhbHNlOwotICAgICAgICAgICAgICAgICAg ICAgICAgY2hlY2tib3hFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNoYW5nZSIsIHRoaXMuX3By b3BlcnR5Q29tbWVudENoZWNrYm94Q2hhbmdlZC5iaW5kKHRoaXMpKTsKLQotICAgICAgICAgICAg ICAgICAgICAgICAgdmFyIGZyb20gPSB7bGluZTogaSwgY2g6IG1hdGNoLmluZGV4fTsKLSAgICAg ICAgICAgICAgICAgICAgICAgIHZhciB0byA9IHtsaW5lOiBpLCBjaDogbWF0Y2guaW5kZXggKyBt YXRjaFswXS5sZW5ndGh9OwotCi0gICAgICAgICAgICAgICAgICAgICAgICB2YXIgY2hlY2tib3hN YXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLnNldFVuaXF1ZUJvb2ttYXJrKGZyb20sIGNoZWNrYm94 RWxlbWVudCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBjaGVja2JveE1hcmtlci5fX3Byb3Bl cnR5Q2hlY2tib3ggPSB0cnVlOwotCi0gICAgICAgICAgICAgICAgICAgICAgICB2YXIgY29tbWVu dFRleHRNYXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLm1hcmtUZXh0KGZyb20sIHRvKTsKLQotICAg ICAgICAgICAgICAgICAgICAgICAgY2hlY2tib3hFbGVtZW50Ll9fY29tbWVudFRleHRNYXJrZXIg PSBjb21tZW50VGV4dE1hcmtlcjsKLQotICAgICAgICAgICAgICAgICAgICAgICAgbWF0Y2ggPSBj b21tZW50ZWRQcm9wZXJ0eVJlZ2V4LmV4ZWMobGluZUNvbnRlbnQpOwotICAgICAgICAgICAgICAg ICAgICB9Ci0gICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIHRoaXMuX2NvZGVNaXJy b3IuZWFjaExpbmUoZnVuY3Rpb24obGluZUhhbmRsZXIpIHsKKyAgICAgICAgICAgICAgICAgICAg dGhpcy5fY3JlYXRlQ29tbWVudGVkQ2hlY2tib3hNYXJrZXIobGluZUhhbmRsZXIpOworICAgICAg ICAgICAgICAgIH0uYmluZCh0aGlzKSk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIC8v IExvb2sgZm9yIGNvbG9ycyBhbmQgbWFrZSBzd2F0Y2hlcy4KQEAgLTg0MSw2ICs4MTcsNDEgQEAg V2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3MgQ1NTU3R5 bGVEZWNsYXJhdGlvblRleHRFZGl0b3IKICAgICAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iub3Bl cmF0aW9uKHVwZGF0ZS5iaW5kKHRoaXMpKTsKICAgICB9CiAKKyAgICBfY3JlYXRlQ29tbWVudGVk Q2hlY2tib3hNYXJrZXIobGluZUhhbmRsZSkKKyAgICB7CisgICAgICAgIHZhciBsaW5lTnVtYmVy ID0gbGluZUhhbmRsZS5saW5lTm8oKTsKKworICAgICAgICAvLyBTaW5jZSBsaW5lTnVtYmVyIGNh biBiZSAwLCBpdCBpcyBhbHNvIG5lY2Vzc2FyeSB0byBjaGVjayBpZiBpdCBpcyBhIG51bWJlciBi ZWZvcmUgcmV0dXJuaW5nLgorICAgICAgICBpZiAoIWxpbmVOdW1iZXIgJiYgaXNOYU4obGluZU51 bWJlcikpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgLy8gTWF0Y2hlcyBhIGNvbW1l bnQgbGlrZTogLyogLXdlYmtpdC1mb286IGJhcjsgKi8KKyAgICAgICAgdmFyIGNvbW1lbnRlZFBy b3BlcnR5UmVnZXggPSAvXC9cKlxzKlstXHddK1xzKjpccypbXjtdKzs/XHMqXCpcLy9nOworCisg ICAgICAgIHZhciBtYXRjaCA9IGNvbW1lbnRlZFByb3BlcnR5UmVnZXguZXhlYyhsaW5lSGFuZGxl LnRleHQpOworICAgICAgICBpZiAoIW1hdGNoKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAg ICAgIHdoaWxlIChtYXRjaCkgeworICAgICAgICAgICAgdmFyIGNoZWNrYm94RWxlbWVudCA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7CisgICAgICAgICAgICBjaGVja2JveEVsZW1l bnQudHlwZSA9ICJjaGVja2JveCI7CisgICAgICAgICAgICBjaGVja2JveEVsZW1lbnQuY2hlY2tl ZCA9IGZhbHNlOworICAgICAgICAgICAgY2hlY2tib3hFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo ImNoYW5nZSIsIHRoaXMuX3Byb3BlcnR5Q29tbWVudENoZWNrYm94Q2hhbmdlZC5iaW5kKHRoaXMp KTsKKworICAgICAgICAgICAgdmFyIGZyb20gPSB7bGluZTogbGluZU51bWJlciwgY2g6IG1hdGNo LmluZGV4fTsKKyAgICAgICAgICAgIHZhciB0byA9IHtsaW5lOiBsaW5lTnVtYmVyLCBjaDogbWF0 Y2guaW5kZXggKyBtYXRjaFswXS5sZW5ndGh9OworCisgICAgICAgICAgICB2YXIgY2hlY2tib3hN YXJrZXIgPSB0aGlzLl9jb2RlTWlycm9yLnNldFVuaXF1ZUJvb2ttYXJrKGZyb20sIGNoZWNrYm94 RWxlbWVudCk7CisgICAgICAgICAgICBjaGVja2JveE1hcmtlci5fX3Byb3BlcnR5Q2hlY2tib3gg PSB0cnVlOworCisgICAgICAgICAgICB2YXIgY29tbWVudFRleHRNYXJrZXIgPSB0aGlzLl9jb2Rl TWlycm9yLm1hcmtUZXh0KGZyb20sIHRvKTsKKworICAgICAgICAgICAgY2hlY2tib3hFbGVtZW50 Ll9fY29tbWVudFRleHRNYXJrZXIgPSBjb21tZW50VGV4dE1hcmtlcjsKKworICAgICAgICAgICAg bWF0Y2ggPSBjb21tZW50ZWRQcm9wZXJ0eVJlZ2V4LmV4ZWMobGluZUhhbmRsZS50ZXh0KTsKKyAg ICAgICAgfQorICAgIH0KKwogICAgIF9jcmVhdGVDb2xvclN3YXRjaGVzKG5vbmF0b21pYywgbGlu ZU51bWJlcikKICAgICB7CiAgICAgICAgIGZ1bmN0aW9uIHVwZGF0ZSgpCkBAIC0xNTM5LDggKzE1 NTAsMTAgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xh c3MgQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IKICAgICAgICAgICAgICAgICB2YXIgbGlu ZUNvbnRlbnRTYW5zV2hpdGVzcGFjZSA9IGxpbmVIYW5kbGVyLnRleHQucmVwbGFjZShmaW5kV2hp dGVzcGFjZSwgIiIpOwogICAgICAgICAgICAgICAgIHZhciBwcm9wZXJ0aWVzID0gY3NzUHJvcGVy dGllc01hcC5nZXQobGluZUNvbnRlbnRTYW5zV2hpdGVzcGFjZSk7CiAKLSAgICAgICAgICAgICAg ICBpZiAoIXByb3BlcnRpZXMpCisgICAgICAgICAgICAgICAgaWYgKCFwcm9wZXJ0aWVzKSB7Cisg ICAgICAgICAgICAgICAgICAgIHRoaXMuX2NyZWF0ZUNvbW1lbnRlZENoZWNrYm94TWFya2VyKGxp bmVIYW5kbGVyKTsKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAg IH0KIAogICAgICAgICAgICAgICAgIGZvciAodmFyIHByb3BlcnR5IG9mIHByb3BlcnRpZXMpIHsK ICAgICAgICAgICAgICAgICAgICAgaWYgKHByb3BlcnR5Ll9fcmVmcmVzaGVkQWZ0ZXJCbHVyKQo=