146765 2015-07-08 17:41:15 -0700 [Cocoa] Report the first paint after committing a load as a rendering progress event 2015-07-09 00:03:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca simon.fraser thorton oldest_to_newest 1108025 0 mitz 2015-07-08 17:41:15 -0700 Allow clients to synchronize changes to their UI with the committed page painting for the first time (replacing the previous page) by reporting this as a rendering progress event. 1108026 1 256441 mitz 2015-07-08 17:44:30 -0700 Created attachment 256441 Add _WKRenderingProgressEventFirstPaint 1108032 2 256441 thorton 2015-07-08 18:15:14 -0700 Comment on attachment 256441 Add _WKRenderingProgressEventFirstPaint View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975 > + _navigationState->didFirstPaint(); Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases? 1108077 3 256441 mitz 2015-07-08 20:11:17 -0700 Comment on attachment 256441 Add _WKRenderingProgressEventFirstPaint View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975 >> + _navigationState->didFirstPaint(); > > Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases? I think so? It gets set to YES when the load is committed. Do you have a specific concern? 1108128 4 256441 thorton 2015-07-08 23:04:46 -0700 Comment on attachment 256441 Add _WKRenderingProgressEventFirstPaint View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review >>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975 >>> + _navigationState->didFirstPaint(); >> >> Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases? > > I think so? It gets set to YES when the load is committed. Do you have a specific concern? Not at all, just couldn't check at the time and the name is not quite so definitive. Sounds good to me! 1108142 5 mitz 2015-07-09 00:03:05 -0700 Committed <http://trac.webkit.org/r186586>. 256441 2015-07-08 17:44:30 -0700 2015-07-08 23:04:46 -0700 Add _WKRenderingProgressEventFirstPaint bug-146765-20150708174330.patch text/plain 4603 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjU0NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA3LTA4ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBSZXBvcnQgdGhlIGZp cnN0IHBhaW50IGFmdGVyIGNvbW1pdHRpbmcgYSBsb2FkIGFzIGEgcmVuZGVyaW5nIHByb2dyZXNz IGV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDY3NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNoYXJlZC9BUEkvQ29jb2EvX1dLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHMuaDogQWRkZWQgX1dL UmVuZGVyaW5nUHJvZ3Jlc3NFdmVudEZpcnN0UGFpbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9kaWRDb21taXRM YXllclRyZWU6XSk6IElmIHRoaXMgaXMgdGhlIGZpcnN0IGxheWVyIHRyZWUgY29tbWl0IHNpbmNl IHRoZSBsb2FkCisgICAgICAgIHdhcyBjb21taXR0ZWQsIGFuZCB0aGUgZGVsZWdhdGUgaXMgb2Jz ZXJ2aW5nIF9XS1JlbmRlcmluZ1Byb2dyZXNzRXZlbnRGaXJzdFBhaW50LCBjYWxsCisgICAgICAg IE5hdmlnYXRpb25TdGF0ZTo6ZGlkRmlyc3RQYWludC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9D b2NvYS9OYXZpZ2F0aW9uU3RhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvTmF2aWdh dGlvblN0YXRlLm1tOgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3RhdGU6OmRpZEZpcnN0 UGFpbnQpOiBBZGRlZC4gQ2FsbHMgLV93ZWJWaWV3OnJlbmRlcmluZ1Byb2dyZXNzRGlkQ2hhbmdl OgorICAgICAgICB3aXRoIF9XS1JlbmRlcmluZ1Byb2dyZXNzRXZlbnRGaXJzdFBhaW50LgorCiAy MDE1LTA3LTA4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAg ICAgV0tTZWN1cml0eU9yaWdpbi5oIGhhcyB3cm9uZyBhdmFpbGFiaWxpdHkgaW5mbwpJbmRleDog U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50 cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvX1dLUmVu ZGVyaW5nUHJvZ3Jlc3NFdmVudHMuaAkocmV2aXNpb24gMTg2NTI1KQorKysgU291cmNlL1dlYktp dDIvU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50cy5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMyw3ICszMyw4IEBAIHR5cGVkZWYgTlNfT1BUSU9OUyhOU1VJbnRlZ2VyLCBf V0tSZW5kZXIKICAgICBfV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50Rmlyc3RQYWludFdpdGhTaWdu aWZpY2FudEFyZWEgPSAxIDw8IDIsCiAgICAgX1dLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudFJlYWNo ZWRTZXNzaW9uUmVzdG9yYXRpb25SZW5kZXJUcmVlU2l6ZVRocmVzaG9sZCBXS19FTlVNX0FWQUlM QUJMRShXS19NQUNfVEJBLCBXS19JT1NfVEJBKSA9IDEgPDwgMywKICAgICBfV0tSZW5kZXJpbmdQ cm9ncmVzc0V2ZW50Rmlyc3RMYXlvdXRBZnRlclN1cHByZXNzZWRJbmNyZW1lbnRhbFJlbmRlcmlu ZyBXS19FTlVNX0FWQUlMQUJMRShXS19NQUNfVEJBLCBXS19JT1NfVEJBKSA9IDEgPDwgNCwKLSAg ICBfV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50Rmlyc3RQYWludEFmdGVyU3VwcHJlc3NlZEluY3Jl bWVudGFsUmVuZGVyaW5nIFdLX0VOVU1fQVZBSUxBQkxFKFdLX01BQ19UQkEsIFdLX0lPU19UQkEp ID0gMSA8PCA1CisgICAgX1dLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudEZpcnN0UGFpbnRBZnRlclN1 cHByZXNzZWRJbmNyZW1lbnRhbFJlbmRlcmluZyBXS19FTlVNX0FWQUlMQUJMRShXS19NQUNfVEJB LCBXS19JT1NfVEJBKSA9IDEgPDwgNSwKKyAgICBfV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50Rmly c3RQYWludCBXS19FTlVNX0FWQUlMQUJMRShXS19NQUNfVEJBLCBXS19JT1NfVEJBKSA9IDEgPDwg NiwKIH0gV0tfRU5VTV9BVkFJTEFCTEUoMTBfMTAsIDhfMCk7CiAKICNlbmRpZgpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHJldmlz aW9uIDE4NjUyNSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC05NzEsNiArOTcxLDggQEAgLSAodm9pZClfZGlkQ29t bWl0TGF5ZXJUcmVlOihjb25zdCBXZWJLaQogICAgICAgICBfbmVlZHNSZXNldFZpZXdTdGF0ZUFm dGVyQ29tbWl0TG9hZEZvck1haW5GcmFtZSA9IE5POwogICAgICAgICBbX3Njcm9sbFZpZXcgc2V0 Q29udGVudE9mZnNldDpbc2VsZiBfYWRqdXN0ZWRDb250ZW50T2Zmc2V0OkNHUG9pbnRaZXJvXV07 CiAgICAgICAgIFtzZWxmIF91cGRhdGVWaXNpYmxlQ29udGVudFJlY3RzXTsKKyAgICAgICAgaWYg KF9vYnNlcnZlZFJlbmRlcmluZ1Byb2dyZXNzRXZlbnRzICYgX1dLUmVuZGVyaW5nUHJvZ3Jlc3NF dmVudEZpcnN0UGFpbnQpCisgICAgICAgICAgICBfbmF2aWdhdGlvblN0YXRlLT5kaWRGaXJzdFBh aW50KCk7CiAgICAgfQogCiAgICAgYm9vbCBpc1RyYW5zYWN0aW9uQWZ0ZXJQYWdlUmVzdG9yZSA9 IGxheWVyVHJlZVRyYW5zYWN0aW9uLnRyYW5zYWN0aW9uSUQoKSA+PSBfZmlyc3RUcmFuc2FjdGlv bklEQWZ0ZXJQYWdlUmVzdG9yZTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2Nv YS9OYXZpZ2F0aW9uU3RhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLmgJKHJldmlzaW9uIDE4NjUyNSkKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUuaAkod29ya2luZyBjb3B5KQpA QCAtNzMsNiArNzMsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBuYXZpZ2F0aW9uR2VzdHVyZURpZEVu ZChib29sIHdpbGxOYXZpZ2F0ZSwgV2ViQmFja0ZvcndhcmRMaXN0SXRlbSYpOwogICAgIHZvaWQg d2lsbFJlY29yZE5hdmlnYXRpb25TbmFwc2hvdChXZWJCYWNrRm9yd2FyZExpc3RJdGVtJik7CiAK KyAgICB2b2lkIGRpZEZpcnN0UGFpbnQoKTsKKwogcHJpdmF0ZToKICAgICBjbGFzcyBOYXZpZ2F0 aW9uQ2xpZW50IGZpbmFsIDogcHVibGljIEFQSTo6TmF2aWdhdGlvbkNsaWVudCB7CiAgICAgcHVi bGljOgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0 ZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdh dGlvblN0YXRlLm1tCShyZXZpc2lvbiAxODY1MjUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMjQsNiArMjI0 LDE4IEBAIHZvaWQgTmF2aWdhdGlvblN0YXRlOjp3aWxsUmVjb3JkTmF2aWdhdGkKICAgICBbc3Rh dGljX2Nhc3Q8aWQgPFdLTmF2aWdhdGlvbkRlbGVnYXRlUHJpdmF0ZT4+KG5hdmlnYXRpb25EZWxl Z2F0ZSkgX3dlYlZpZXc6bV93ZWJWaWV3IHdpbGxTbmFwc2hvdEJhY2tGb3J3YXJkTGlzdEl0ZW06 d3JhcHBlcihpdGVtKV07CiB9CiAKK3ZvaWQgTmF2aWdhdGlvblN0YXRlOjpkaWRGaXJzdFBhaW50 KCkKK3sKKyAgICBpZiAoIW1fbmF2aWdhdGlvbkRlbGVnYXRlTWV0aG9kcy53ZWJWaWV3UmVuZGVy aW5nUHJvZ3Jlc3NEaWRDaGFuZ2UpCisgICAgICAgIHJldHVybjsKKworICAgIGF1dG8gbmF2aWdh dGlvbkRlbGVnYXRlID0gbV9uYXZpZ2F0aW9uRGVsZWdhdGUuZ2V0KCk7CisgICAgaWYgKCFuYXZp Z2F0aW9uRGVsZWdhdGUpCisgICAgICAgIHJldHVybjsKKworICAgIFtzdGF0aWNfY2FzdDxpZCA8 V0tOYXZpZ2F0aW9uRGVsZWdhdGVQcml2YXRlPj4obmF2aWdhdGlvbkRlbGVnYXRlKSBfd2ViVmll dzptX3dlYlZpZXcgcmVuZGVyaW5nUHJvZ3Jlc3NEaWRDaGFuZ2U6X1dLUmVuZGVyaW5nUHJvZ3Jl c3NFdmVudEZpcnN0UGFpbnRdOworfQorCiBOYXZpZ2F0aW9uU3RhdGU6Ok5hdmlnYXRpb25DbGll bnQ6Ok5hdmlnYXRpb25DbGllbnQoTmF2aWdhdGlvblN0YXRlJiBuYXZpZ2F0aW9uU3RhdGUpCiAg ICAgOiBtX25hdmlnYXRpb25TdGF0ZShuYXZpZ2F0aW9uU3RhdGUpCiB7Cg==