146760 2015-07-08 17:21:41 -0700 Expose bounds of AVVideoCaptureSource 2015-07-09 11:50:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 146746 1 mdaiter mdaiter bfulgham commit-queue eric.carlson jonlee mdaiter webkit-bug-importer webkit.review.bot oldest_to_newest 1108007 0 mdaiter 2015-07-08 17:21:41 -0700 Need to expose width and height of AVVideoCaptureSource to correctly bound the box of getUserMedia() 1108011 1 webkit-bug-importer 2015-07-08 17:23:29 -0700 <rdar://problem/21736772> 1108012 2 256437 mdaiter 2015-07-08 17:24:11 -0700 Created attachment 256437 Patch 1108042 3 256437 bfulgham 2015-07-08 18:35:15 -0700 Comment on attachment 256437 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256437&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:45 > + virtual int32_t height() const { return m_height; } Why are these virtual? Are they overridden in another class? 1108245 4 256437 bfulgham 2015-07-09 11:01:12 -0700 Comment on attachment 256437 Patch r=me 1108271 5 256437 commit-queue 2015-07-09 11:49:59 -0700 Comment on attachment 256437 Patch Clearing flags on attachment: 256437 Committed r186600: <http://trac.webkit.org/changeset/186600> 1108272 6 commit-queue 2015-07-09 11:50:02 -0700 All reviewed patches have been landed. Closing bug. 256437 2015-07-08 17:24:11 -0700 2015-07-09 11:49:59 -0700 Patch bug-146760-20150708172311.patch text/plain 1760 mdaiter U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDlhOGI5YjQ3MDA3YjM1 YjljZGZjMjhiODAzMTE4OWU4MDgzNjNjNy4uMGY2YjQxODkwZTRkNDFiMGU4MTdkYjQ2YWVmY2Nj OGY1ZDhjZGIyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTA3LTA4ICBNYXR0 aGV3IERhaXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgogCisgICAgICAgIEV4cG9zZWQgQVZWaWRl b0NhcHR1cmVTb3VyY2UncyBib3VuZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0Njc2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjE3MzY3NzI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UuaDoKKyAgICAgICAgKFdl YkNvcmU6OkFWVmlkZW9DYXB0dXJlU291cmNlOjp3aWR0aCk6IE5lZWRlZCBhY2Nlc3MgdG8gdmlk ZW8gd2lkdGgKKyAgICAgICAgKFdlYkNvcmU6OkFWVmlkZW9DYXB0dXJlU291cmNlOjpoZWlnaHQp OiBOZWVkZWQgYWNjZXNzIHRvIHZpZGVvIGhlaWdodAorCisyMDE1LTA3LTA4ICBNYXR0aGV3IERh aXRlciAgPG1kYWl0ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIENsZWFyZWQgY29udGVudE1JTUVU eXBlcyBmb3IgTWVkaWFTdHJlYW1zCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDY3NTAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxNzM1Njc4Pgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlk ZW9DYXB0dXJlU291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9t YWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UuaAppbmRleCA0M2UzMDQ5NjA4MDEyM2Y5NmY0Y2E3Mjhi ODhhMjI5MzNiZjE4OWE3Li4xMWI4ZmI3MDJhNTZlZmJlZmViNDc2ZDg2YTY5ZGQwMmVjMTJmNTIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZW aWRlb0NhcHR1cmVTb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UuaApAQCAtNDAsNiArNDAsOSBAQCBwdWJsaWM6 CiAKICAgICB2aXJ0dWFsIFJlZlB0cjxSZWFsdGltZU1lZGlhU291cmNlQ2FwYWJpbGl0aWVzPiBj YXBhYmlsaXRpZXMoKSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgY2FwdHVyZU91 dHB1dERpZE91dHB1dFNhbXBsZUJ1ZmZlckZyb21Db25uZWN0aW9uKEFWQ2FwdHVyZU91dHB1dCos IENNU2FtcGxlQnVmZmVyUmVmLCBBVkNhcHR1cmVDb25uZWN0aW9uKikgb3ZlcnJpZGU7CisgICAg CisgICAgdmlydHVhbCBpbnQzMl90IHdpZHRoKCkgY29uc3QgeyByZXR1cm4gbV93aWR0aDsgfQor ICAgIHZpcnR1YWwgaW50MzJfdCBoZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX2hlaWdodDsgfQog CiBwcml2YXRlOgogICAgIEFWVmlkZW9DYXB0dXJlU291cmNlKEFWQ2FwdHVyZURldmljZSosIGNv bnN0IEF0b21pY1N0cmluZyYsIFBhc3NSZWZQdHI8TWVkaWFDb25zdHJhaW50cz4pOwo=