146759 2015-07-08 17:18:12 -0700 Web Inspector: Only record a timeline when the Timelines tab is showing 2015-07-08 18:15:17 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1107996 0 timothy 2015-07-08 17:18:12 -0700 Now that we have a Network tab, lets only record a timeline when the Timelines tab is showing. 1108000 1 webkit-bug-importer 2015-07-08 17:18:40 -0700 <rdar://problem/21736695> 1108002 2 256434 timothy 2015-07-08 17:18:54 -0700 Created attachment 256434 Patch 1108014 3 256434 joepeck 2015-07-08 17:25:09 -0700 Comment on attachment 256434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256434&action=review r=me > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:85 > + set autoCaptureOnPageLoad(autoCapture) > + { > + this._autoCaptureOnPageLoad = autoCapture; > + } When we want to move this to the backend, it would be as easy as adding a backend message here (TimelineAgent.setAutoCaptureOnPageLoad(autoCapture)). I like it! 1108031 4 256434 commit-queue 2015-07-08 18:15:10 -0700 Comment on attachment 256434 Patch Clearing flags on attachment: 256434 Committed r186561: <http://trac.webkit.org/changeset/186561> 1108033 5 commit-queue 2015-07-08 18:15:17 -0700 All reviewed patches have been landed. Closing bug. 256434 2015-07-08 17:18:54 -0700 2015-07-08 18:15:10 -0700 Patch bug-146759-20150708171753.patch text/plain 3392 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 OTg0MTQwOWY0MTJmY2U0YjZiMzAwZDcxZDM1Y2FiZDdmMGE5MmZmLi4zMjIyN2EyMWIyNmU3ZTgx MzUxNDk3ZGJmY2U4NWRmNGM2ZmRlODU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNS0wNy0wOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT25seSByZWNvcmQgYSB0aW1lbGluZSB3aGVu IHRoZSBUaW1lbGluZXMgdGFiIGlzIHNob3dpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Njc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGlu ZU1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyLnByb3Rv dHlwZS5nZXQgYXV0b0NhcHR1cmVPblBhZ2VMb2FkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZU1hbmFnZXIucHJvdG90eXBlLnNldCBhdXRvQ2FwdHVyZU9uUGFnZUxvYWQpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlci5wcm90b3R5cGUuX3N0YXJ0QXV0b0Nh cHR1cmluZyk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRl bnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVGFiQ29udGVudFZpZXcu cHJvdG90eXBlLnNob3duKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVRhYkNvbnRl bnRWaWV3LnByb3RvdHlwZS5oaWRkZW4pOgorCisyMDE1LTA3LTA4ICBUaW1vdGh5IEhhdGNoZXIg IDx0aW1vdGh5QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgcGFnZSB3 ZWlnaHQgYW5kIHRpbWUgYmFjayB0byB0aGUgdG9vbGJhciBkYXNoYm9hcmQKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Njc1NQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGlu ZU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9UaW1lbGluZU1hbmFnZXIuanMKaW5kZXggM2U5NjNiNDZiODIwZjY2ZDI4NTJhMjQwYzk2 MTBkZTQ0NzdmM2MyOC4uMjViNDhjMjBhNTA3MWQwMjA0ZjA0YTcxNDZiMWMwYTJmNTljYTVlOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvVGltZWxpbmVNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcwpAQCAtNzQsNiArNzQsMTYgQEAg V2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlciA9IGNsYXNzIFRpbWVsaW5lTWFuYWdlciBleHRl bmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgcmV0dXJuIHRoaXMuX3JlY29yZGluZ3Mu c2xpY2UoKTsKICAgICB9CiAKKyAgICBnZXQgYXV0b0NhcHR1cmVPblBhZ2VMb2FkKCkKKyAgICB7 CisgICAgICAgIHJldHVybiB0aGlzLl9hdXRvQ2FwdHVyZU9uUGFnZUxvYWQ7CisgICAgfQorCisg ICAgc2V0IGF1dG9DYXB0dXJlT25QYWdlTG9hZChhdXRvQ2FwdHVyZSkKKyAgICB7CisgICAgICAg IHRoaXMuX2F1dG9DYXB0dXJlT25QYWdlTG9hZCA9IGF1dG9DYXB0dXJlOworICAgIH0KKwogICAg IGlzQ2FwdHVyaW5nKCkKICAgICB7CiAgICAgICAgIHJldHVybiB0aGlzLl9pc0NhcHR1cmluZzsK QEAgLTUwNCw2ICs1MTQsOSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyID0gY2xhc3Mg VGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgX3N0YXJ0 QXV0b0NhcHR1cmluZyhldmVudCkKICAgICB7CisgICAgICAgIGlmICghdGhpcy5fYXV0b0NhcHR1 cmVPblBhZ2VMb2FkKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgICAgIGlmICgh ZXZlbnQudGFyZ2V0LmlzTWFpbkZyYW1lKCkgfHwgKHRoaXMuX2lzQ2FwdHVyaW5nICYmICF0aGlz Ll9hdXRvQ2FwdHVyaW5nTWFpblJlc291cmNlKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanMKaW5kZXggYzE2ZjEzOTZmZjMx YjRiMjFkMmNjOTU2MmU5NjBmYThiY2IwZjRhMS4uMTRlZWM1YzI2MTAzYjc5YWM2N2NhZGRhNzc0 N2Y4MDY3OGNkYTE1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCkBA IC00Miw2ICs0MiwyMCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVUYWJDb250ZW50Vmlldy5wcm90 b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVGltZWxpbmVUYWJDb250ZW50 Vmlldy5UeXBlOwogICAgIH0sCiAKKyAgICBzaG93bjogZnVuY3Rpb24oKQorICAgIHsKKyAgICAg ICAgV2ViSW5zcGVjdG9yLkNvbnRlbnRCcm93c2VyVGFiQ29udGVudFZpZXcucHJvdG90eXBlLnNo b3duLmNhbGwodGhpcyk7CisKKyAgICAgICAgV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5h dXRvQ2FwdHVyZU9uUGFnZUxvYWQgPSB0cnVlOworICAgIH0sCisKKyAgICBoaWRkZW46IGZ1bmN0 aW9uKCkKKyAgICB7CisgICAgICAgIFdlYkluc3BlY3Rvci5Db250ZW50QnJvd3NlclRhYkNvbnRl bnRWaWV3LnByb3RvdHlwZS5oaWRkZW4uY2FsbCh0aGlzKTsKKworICAgICAgICBXZWJJbnNwZWN0 b3IudGltZWxpbmVNYW5hZ2VyLmF1dG9DYXB0dXJlT25QYWdlTG9hZCA9IGZhbHNlOworICAgIH0s CisKICAgICBjYW5TaG93UmVwcmVzZW50ZWRPYmplY3Q6IGZ1bmN0aW9uKHJlcHJlc2VudGVkT2Jq ZWN0KQogICAgIHsKICAgICAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nKQo=