146745 2015-07-08 16:00:31 -0700 Media Session: report to chrome client 'hasActiveMediaElements' changes 2015-07-09 09:30:02 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson mrajca webkit-bug-importer oldest_to_newest 1107921 0 mrajca 2015-07-08 16:00:31 -0700 Whenever a media session's set of active media elements changes, we need notify chrome client when: - we no longer have any active media elements - a media element becomes active for the first time 1107922 1 webkit-bug-importer 2015-07-08 16:01:31 -0700 <rdar://problem/21734934> 1108050 2 256448 mrajca 2015-07-08 18:57:06 -0700 Created attachment 256448 Patch 1108073 3 256448 eric.carlson 2015-07-08 20:01:09 -0700 Comment on attachment 256448 Patch Are these testable? 1108209 4 mrajca 2015-07-09 09:24:03 -0700 (In reply to comment #3) > Comment on attachment 256448 [details] > Patch > > Are these testable? I filed a separate bug (Bug 146787) for this. 1108211 5 mrajca 2015-07-09 09:30:02 -0700 Committed r186593: <http://trac.webkit.org/changeset/186593> 256448 2015-07-08 18:57:06 -0700 2015-07-08 20:01:09 -0700 Patch bug-146745-20150708185606.patch text/plain 6156 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVmZjRkOWM1ZTljZjU4 MjZiYzgxNjZlYmNmNzc1NTA0MDk5NjMyOS4uNjNlYzE3YzRjNjNkMzk0ZTUyOWNmMjUzYmRkZTQ1 MWNiMzU2YTNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA3LTA4ICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiByZXBv cnQgdG8gY2hyb21lIGNsaWVudCAnaGFzQWN0aXZlTWVkaWFFbGVtZW50cycgY2hhbmdlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NzQ1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL21l ZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uY3BwOiBBbGwgdXBkYXRlcyB0byBhY3RpdmUgbWVkaWEg ZWxlbWVudHMgYXJlIG5vdyBmdW5uZWxlZCB0aHJvdWdoIGEgaGVscGVyCisgICAgICAgICAgbWV0 aG9kIHRoYXQgd2lsbCBpbnZva2UgdGhlICdoYXNNZWRpYVNlc3Npb25XaXRoQWN0aXZlTWVkaWFF bGVtZW50c0RpZENoYW5nZScgY2FsbGJhY2sgd2hlbiBuZWNlc3NhcnkuCisgICAgICAgIChXZWJD b3JlOjpNZWRpYVNlc3Npb246OnJlbW92ZU1lZGlhRWxlbWVudCk6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVNlc3Npb246OmNoYW5nZUFjdGl2ZU1lZGlhRWxlbWVudHMpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTZXNzaW9uOjphZGRBY3RpdmVNZWRpYUVsZW1lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTZXNzaW9uOjpyZWxlYXNlU2Vzc2lvbik6CisgICAgICAgICogTW9kdWxlcy9t ZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmg6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Np b24vTWVkaWFTZXNzaW9uTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Np b25NYW5hZ2VyOjpoYXNBY3RpdmVNZWRpYUVsZW1lbnRzKToKKyAgICAgICAgKiBNb2R1bGVzL21l ZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb25NYW5hZ2VyLmg6CisKIDIwMTUtMDctMDggIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgUGluZ0xvYWRlcnMgdG8g dGhlIE5ldHdvcmtpbmdQcm9jZXNzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5jcHAKaW5kZXggZjlkNTA5MGMxM2Q3NzcwODkzYmRm MzA5ZGFjZDQ3YWZiNjBhYTEzZi4uZDUyZThkOWFiZGZkZmFiYTkxZWZhMzRiM2IzMzI2ZjYzMDRi MmY1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVk aWFTZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9N ZWRpYVNlc3Npb24uY3BwCkBAIC0xMTUsMTQgKzExNSwzMyBAQCB2b2lkIE1lZGlhU2Vzc2lvbjo6 cmVtb3ZlTWVkaWFFbGVtZW50KEhUTUxNZWRpYUVsZW1lbnQmIGVsZW1lbnQpCiAgICAgQVNTRVJU KG1fcGFydGljaXBhdGluZ0VsZW1lbnRzLmNvbnRhaW5zKCZlbGVtZW50KSk7CiAgICAgbV9wYXJ0 aWNpcGF0aW5nRWxlbWVudHMucmVtb3ZlKCZlbGVtZW50KTsKIAotICAgIG1fYWN0aXZlUGFydGlj aXBhdGluZ0VsZW1lbnRzLnJlbW92ZSgmZWxlbWVudCk7CisgICAgY2hhbmdlQWN0aXZlTWVkaWFF bGVtZW50cyhbJl0oKSB7CisgICAgICAgIG1fYWN0aXZlUGFydGljaXBhdGluZ0VsZW1lbnRzLnJl bW92ZSgmZWxlbWVudCk7CisgICAgfSk7CisKICAgICBpZiAobV9pdGVyYXRlZEFjdGl2ZVBhcnRp Y2lwYXRpbmdFbGVtZW50cykKICAgICAgICAgbV9pdGVyYXRlZEFjdGl2ZVBhcnRpY2lwYXRpbmdF bGVtZW50cy0+cmVtb3ZlKCZlbGVtZW50KTsKIH0KIAordm9pZCBNZWRpYVNlc3Npb246OmNoYW5n ZUFjdGl2ZU1lZGlhRWxlbWVudHMoc3RkOjpmdW5jdGlvbjx2b2lkKHZvaWQpPiB3b3JrZXIpCit7 CisgICAgaWYgKFBhZ2UgKnBhZ2UgPSBtX2RvY3VtZW50LnBhZ2UoKSkgeworICAgICAgICBib29s IGhhZEFjdGl2ZU1lZGlhRWxlbWVudHMgPSBNZWRpYVNlc3Npb25NYW5hZ2VyOjpzaW5nbGV0b24o KS5oYXNBY3RpdmVNZWRpYUVsZW1lbnRzKCk7CisKKyAgICAgICAgd29ya2VyKCk7CisKKyAgICAg ICAgYm9vbCBoYXNBY3RpdmVNZWRpYUVsZW1lbnRzID0gTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2lu Z2xldG9uKCkuaGFzQWN0aXZlTWVkaWFFbGVtZW50cygpOworICAgICAgICBpZiAoaGFkQWN0aXZl TWVkaWFFbGVtZW50cyAhPSBoYXNBY3RpdmVNZWRpYUVsZW1lbnRzKQorICAgICAgICAgICAgcGFn ZS0+Y2hyb21lKCkuY2xpZW50KCkuaGFzTWVkaWFTZXNzaW9uV2l0aEFjdGl2ZU1lZGlhRWxlbWVu dHNEaWRDaGFuZ2UoaGFzQWN0aXZlTWVkaWFFbGVtZW50cyk7CisgICAgfSBlbHNlCisgICAgICAg IHdvcmtlcigpOworfQorCiB2b2lkIE1lZGlhU2Vzc2lvbjo6YWRkQWN0aXZlTWVkaWFFbGVtZW50 KEhUTUxNZWRpYUVsZW1lbnQmIGVsZW1lbnQpCiB7Ci0gICAgbV9hY3RpdmVQYXJ0aWNpcGF0aW5n RWxlbWVudHMuYWRkKCZlbGVtZW50KTsKKyAgICBjaGFuZ2VBY3RpdmVNZWRpYUVsZW1lbnRzKFsm XSgpIHsKKyAgICAgICAgbV9hY3RpdmVQYXJ0aWNpcGF0aW5nRWxlbWVudHMuYWRkKCZlbGVtZW50 KTsKKyAgICB9KTsKIH0KIAogYm9vbCBNZWRpYVNlc3Npb246OmlzTWVkaWFFbGVtZW50QWN0aXZl KEhUTUxNZWRpYUVsZW1lbnQmIGVsZW1lbnQpCkBAIC0xMzAsNyArMTQ5LDcgQEAgYm9vbCBNZWRp YVNlc3Npb246OmlzTWVkaWFFbGVtZW50QWN0aXZlKEhUTUxNZWRpYUVsZW1lbnQmIGVsZW1lbnQp CiAgICAgcmV0dXJuIG1fYWN0aXZlUGFydGljaXBhdGluZ0VsZW1lbnRzLmNvbnRhaW5zKCZlbGVt ZW50KTsKIH0KIAotYm9vbCBNZWRpYVNlc3Npb246Omhhc0FjdGl2ZU1lZGlhRWxlbWVudHMoKQor Ym9vbCBNZWRpYVNlc3Npb246Omhhc0FjdGl2ZU1lZGlhRWxlbWVudHMoKSBjb25zdAogewogICAg IHJldHVybiAhbV9hY3RpdmVQYXJ0aWNpcGF0aW5nRWxlbWVudHMuaXNFbXB0eSgpOwogfQpAQCAt MTcxLDggKzE5MCwxMCBAQCB2b2lkIE1lZGlhU2Vzc2lvbjo6cmVsZWFzZVNlc3Npb24oKQogICAg IC8vIDEuIExldCBtZWRpYSBzZXNzaW9uIGJlIHRoZSBjdXJyZW50IG1lZGlhIHNlc3Npb24uCiAg ICAgLy8gMi4gSW5kZWZpbml0ZWx5IHBhdXNlIGFsbCBvZiBtZWRpYSBzZXNzaW9uJ3MgYWN0aXZl IHBhcnRpY2lwYXRpbmcgbWVkaWEgZWxlbWVudHMuCiAgICAgLy8gMy4gUmVzZXQgbWVkaWEgc2Vz c2lvbidzIGFjdGl2ZSBwYXJ0aWNpcGF0aW5nIG1lZGlhIGVsZW1lbnRzIHRvIGFuIGVtcHR5IGxp c3QuCi0gICAgd2hpbGUgKCFtX2FjdGl2ZVBhcnRpY2lwYXRpbmdFbGVtZW50cy5pc0VtcHR5KCkp Ci0gICAgICAgIG1fYWN0aXZlUGFydGljaXBhdGluZ0VsZW1lbnRzLnRha2VBbnkoKS0+cGF1c2Uo KTsKKyAgICBjaGFuZ2VBY3RpdmVNZWRpYUVsZW1lbnRzKFsmXSgpIHsKKyAgICAgICAgd2hpbGUg KCFtX2FjdGl2ZVBhcnRpY2lwYXRpbmdFbGVtZW50cy5pc0VtcHR5KCkpCisgICAgICAgICAgICBt X2FjdGl2ZVBhcnRpY2lwYXRpbmdFbGVtZW50cy50YWtlQW55KCktPnBhdXNlKCk7CisgICAgfSk7 CiAKICAgICAvLyA0LiBSdW4gdGhlIG1lZGlhIHNlc3Npb24gcmVsZWFzZSBhbGdvcml0aG0gZm9y IG1lZGlhIHNlc3Npb24uCiAgICAgcmVsZWFzZUludGVybmFsKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uaCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCmluZGV4IDJjZWFiZjU3 YzdmYWQ2OTIxN2ViNDUyNzQ4MTAwNjYyMDkzYTYwYzEuLjU0ZTZmMmM4MDI0MjA5MmM0NmFhNDI1 NTkwZTNkMmUwNzI4ZmFiNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCkBAIC01OCw2ICs1OCw3IEBAIHB1YmxpYzoKICAgICBN ZWRpYVJlbW90ZUNvbnRyb2xzKiBjb250cm9scyhib29sJiBpc051bGwpOwogCiAgICAgU3RhdGUg Y3VycmVudFN0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9jdXJyZW50U3RhdGU7IH0KKyAgICBib29s IGhhc0FjdGl2ZU1lZGlhRWxlbWVudHMoKSBjb25zdDsKIAogICAgIHZvaWQgc2V0TWV0YWRhdGEo Y29uc3QgRGljdGlvbmFyeSYpOwogCkBAIC04Nyw5ICs4OCw5IEBAIHByaXZhdGU6CiAgICAgdm9p ZCBhZGRNZWRpYUVsZW1lbnQoSFRNTE1lZGlhRWxlbWVudCYpOwogICAgIHZvaWQgcmVtb3ZlTWVk aWFFbGVtZW50KEhUTUxNZWRpYUVsZW1lbnQmKTsKIAorICAgIHZvaWQgY2hhbmdlQWN0aXZlTWVk aWFFbGVtZW50cyhzdGQ6OmZ1bmN0aW9uPHZvaWQodm9pZCk+KTsKICAgICB2b2lkIGFkZEFjdGl2 ZU1lZGlhRWxlbWVudChIVE1MTWVkaWFFbGVtZW50Jik7CiAgICAgYm9vbCBpc01lZGlhRWxlbWVu dEFjdGl2ZShIVE1MTWVkaWFFbGVtZW50Jik7Ci0gICAgYm9vbCBoYXNBY3RpdmVNZWRpYUVsZW1l bnRzKCk7CiAKICAgICB2b2lkIHJlbGVhc2VJbnRlcm5hbCgpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbk1hbmFnZXIu Y3BwCmluZGV4IDVkYzJmMWUxMDg3N2Y1ODI0YzE1MjY4YmU3YjE4MTRjMzZkMGFlMTguLjNmOGZj M2EyODdlN2JkYTM1N2FlMmNkMmViN2NjODUwYzk4ZmRmYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbk1hbmFnZXIu Y3BwCkBAIC00MSw2ICs0MSwxNiBAQCBNZWRpYVNlc3Npb25NYW5hZ2VyJiBNZWRpYVNlc3Npb25N YW5hZ2VyOjpzaW5nbGV0b24oKQogICAgIHJldHVybiBtYW5hZ2VyOwogfQogCitib29sIE1lZGlh U2Vzc2lvbk1hbmFnZXI6Omhhc0FjdGl2ZU1lZGlhRWxlbWVudHMoKSBjb25zdAoreworICAgIGZv ciAoYXV0byogc2Vzc2lvbiA6IG1fc2Vzc2lvbnMpIHsKKyAgICAgICAgaWYgKHNlc3Npb24tPmhh c0FjdGl2ZU1lZGlhRWxlbWVudHMoKSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0K KworICAgIHJldHVybiBmYWxzZTsKK30KKwogdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyOjphZGRN ZWRpYVNlc3Npb24oTWVkaWFTZXNzaW9uJiBzZXNzaW9uKQogewogICAgIG1fc2Vzc2lvbnMuYWRk KCZzZXNzaW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNz aW9uL01lZGlhU2Vzc2lvbk1hbmFnZXIuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz ZXNzaW9uL01lZGlhU2Vzc2lvbk1hbmFnZXIuaAppbmRleCAyODVjMzgzNDBhZDZjZDE0ZjM2MDBm NDlhMjQ5ZGY3NzRhOTY3MTBiLi5iZmZhZTU5ZDVkZGE0YmY1ODBjNWFjNzEzNDVjNzcyZDFkNmM3 YTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRp YVNlc3Npb25NYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Np b24vTWVkaWFTZXNzaW9uTWFuYWdlci5oCkBAIC00NSw2ICs0NSw4IEBAIHB1YmxpYzoKIHByaXZh dGU6CiAgICAgZnJpZW5kIGNsYXNzIE1lZGlhU2Vzc2lvbjsKIAorICAgIGJvb2wgaGFzQWN0aXZl TWVkaWFFbGVtZW50cygpIGNvbnN0OworCiAgICAgdm9pZCBhZGRNZWRpYVNlc3Npb24oTWVkaWFT ZXNzaW9uJik7CiAgICAgdm9pZCByZW1vdmVNZWRpYVNlc3Npb24oTWVkaWFTZXNzaW9uJik7CiAK