146739 2015-07-08 14:07:59 -0700 Only support image previews for clients that implement commitPreviewedImageWithURL delegate 2015-07-08 14:16:31 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin enrica sam thorton yongjun_zhang oldest_to_newest 1107879 0 bdakin 2015-07-08 14:07:59 -0700 We should only support image previews for clients that implement commitPreviewedImageWithURL delegate since there is no default commit action. rdar://problem/21692929 1107881 1 256405 bdakin 2015-07-08 14:09:59 -0700 Created attachment 256405 Patch 1107885 2 bdakin 2015-07-08 14:16:31 -0700 Thank Tim! http://trac.webkit.org/changeset/186527 256405 2015-07-08 14:09:59 -0700 2015-07-08 14:13:00 -0700 Patch for-review.txt text/plain 1701 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjUyNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA3LTA4ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBPbmx5IHN1cHBvcnQgaW1hZ2UgcHJl dmlld3MgZm9yIGNsaWVudHMgdGhhdCBpbXBsZW1lbnQgY29tbWl0UHJldmlld2VkSW1hZ2VXaXRo VVJMIAorICAgICAgICBkZWxlZ2F0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ2NzM5CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vMjE2OTI5MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZSBzaG91bGQgb25seSBzdXBwb3J0IGltYWdlIHByZXZpZXdz IGZvciBjbGllbnRzIHRoYXQgaW1wbGVtZW50IAorICAgICAgICBjb21taXRQcmV2aWV3ZWRJbWFn ZVdpdGhVUkwgZGVsZWdhdGUgc2luY2UgdGhlcmUgaXMgbm8gZGVmYXVsdCBjb21taXQgYWN0aW9u LgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgor ICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHByZXZpZXdWaWV3Q29udHJvbGxlckZvclBvc2l0aW9u OmluU291cmNlVmlldzpdKToKKwogMjAxNS0wNy0wOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgQXBwbGljYXRpb25TdGF0ZVRyYWNrZXIgYmUg cGVyIHZpZXcgaW5zdGVhZCBvZiBiZWluZyBhIHNpbmdsZXRvbgpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0JKHJldmlzaW9uIDE4NjUxNSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMjQ0LDYgKzMyNDQs OSBAQCAtIChVSVZpZXdDb250cm9sbGVyICopcHJldmlld1ZpZXdDb250cm9sCiAgICAgfQogCiAg ICAgaWYgKGNhblNob3dJbWFnZVByZXZpZXcpIHsKKyAgICAgICAgaWYgKCFbdWlEZWxlZ2F0ZSBy ZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3OmNvbW1pdFByZXZpZXdlZEltYWdl V2l0aFVSTDopXSkKKyAgICAgICAgICAgIHJldHVybiBuaWw7CisKICAgICAgICAgU3RyaW5nIGFi c29sdXRlSW1hZ2VVUkwgPSBfcG9zaXRpb25JbmZvcm1hdGlvbi5pbWFnZVVSTDsKICAgICAgICAg aWYgKGFic29sdXRlSW1hZ2VVUkwuaXNFbXB0eSgpIHx8ICEoV2ViQ29yZTo6cHJvdG9jb2xJc0lu SFRUUEZhbWlseShhYnNvbHV0ZUltYWdlVVJMKSB8fCBXZWJDb3JlOjpwcm90b2NvbElzKGFic29s dXRlSW1hZ2VVUkwsICJkYXRhIikpKQogICAgICAgICAgICAgcmV0dXJuIG5pbDsK