146736 2015-07-08 12:25:04 -0700 InteractionInformationAtPosition bounds seem wrong on many sites, affects apple.com 2015-07-08 13:21:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin enrica sam thorton yongjun_zhang oldest_to_newest 1107834 0 bdakin 2015-07-08 12:25:04 -0700 http://trac.webkit.org/changeset/186132/ changed the bounds for InteractionInformationAtPosition. The image-related changes are good, but the link-related changes feel wrong on many sites. We should revert the change for now. rdar://problem/21655549 1107841 1 256396 bdakin 2015-07-08 12:31:07 -0700 Created attachment 256396 Patch 1107861 2 bdakin 2015-07-08 13:21:35 -0700 Thank you! http://trac.webkit.org/changeset/186522 256396 2015-07-08 12:31:07 -0700 2015-07-08 13:18:41 -0700 Patch for-review.txt text/plain 2249 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjUxOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA3LTA4ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBJbnRlcmFjdGlvbkluZm9ybWF0aW9u QXRQb3NpdGlvbiBib3VuZHMgc2VlbSB3cm9uZyBvbiBtYW55IHNpdGVzLCBhZmZlY3RzIAorICAg ICAgICBhcHBsZS5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NjczNgorICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzIxNjU1NTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTg2MTMyLyBjaGFu Z2VkIHRoZSBib3VuZHMgZm9yIAorICAgICAgICBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3Np dGlvbi4gVGhlIGltYWdlLXJlbGF0ZWQgY2hhbmdlcyBhcmUgZ29vZCwgYnV0IHRoZSAKKyAgICAg ICAgbGluay1yZWxhdGVkIGNoYW5nZXMgZmVlbCB3cm9uZyBvbiBtYW55IHNpdGVzLiBXZSBzaG91 bGQgcmV2ZXJ0IHRoZSBjaGFuZ2UgZm9yIG5vdyAKKyAgICAgICAgYW5kIGp1c3QgdXNlIHRoZSBh YnNvbHV0ZUJvdW5kaW5nQm94UmVjdCgpIGZvciBub24taW1hZ2VzLgorICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbik6CisKIDIwMTUtMDctMDggIEJldGggRGFraW4gIDxi ZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhY3Rpb25zIHRvIGltYWdlIHByZXZpZXdz CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9X ZWJQYWdlSU9TLm1tCShyZXZpc2lvbiAxODY1MTUpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTIxNjQsMTUg KzIxNjQsNyBAQCB2b2lkIFdlYlBhZ2U6OmdldFBvc2l0aW9uSW5mb3JtYXRpb24oY29uCiAgICAg ICAgICAgICBpZiAoZWxlbWVudC0+cmVuZGVyZXIoKSkKICAgICAgICAgICAgICAgICBpbmZvLnRv dWNoQ2FsbG91dEVuYWJsZWQgPSBlbGVtZW50LT5yZW5kZXJlcigpLT5zdHlsZSgpLnRvdWNoQ2Fs bG91dEVuYWJsZWQoKTsKIAotICAgICAgICAgICAgaWYgKGVsZW1lbnQgPT0gbGlua0VsZW1lbnQp IHsKLSAgICAgICAgICAgICAgICBSZWZQdHI8UmFuZ2U+IGxpbmtSYW5nZSA9IHJhbmdlT2ZDb250 ZW50cygqbGlua0VsZW1lbnQpOwotICAgICAgICAgICAgICAgIFZlY3RvcjxGbG9hdFF1YWQ+IHF1 YWRzOwotICAgICAgICAgICAgICAgIGxpbmtSYW5nZS0+dGV4dFF1YWRzKHF1YWRzKTsKLSAgICAg ICAgICAgICAgICBGbG9hdFJlY3QgbGlua0JvdW5kaW5nQm94OwotICAgICAgICAgICAgICAgIGZv ciAoY29uc3QgYXV0byYgcXVhZCA6IHF1YWRzKQotICAgICAgICAgICAgICAgICAgICBsaW5rQm91 bmRpbmdCb3gudW5pdGUocXVhZC5lbmNsb3NpbmdCb3VuZGluZ0JveCgpKTsKLSAgICAgICAgICAg ICAgICBpbmZvLmJvdW5kcyA9IEludFJlY3QobGlua0JvdW5kaW5nQm94KTsKLSAgICAgICAgICAg IH0gZWxzZSBpZiAoUmVuZGVyRWxlbWVudCogcmVuZGVyZXIgPSBlbGVtZW50LT5yZW5kZXJlcigp KSB7CisgICAgICAgICAgICBpZiAoUmVuZGVyRWxlbWVudCogcmVuZGVyZXIgPSBlbGVtZW50LT5y ZW5kZXJlcigpKSB7CiAgICAgICAgICAgICAgICAgaWYgKHJlbmRlcmVyLT5pc1JlbmRlckltYWdl KCkpCiAgICAgICAgICAgICAgICAgICAgIGluZm8uYm91bmRzID0gZG93bmNhc3Q8UmVuZGVySW1h Z2U+KCpyZW5kZXJlcikuYWJzb2x1dGVDb250ZW50UXVhZCgpLmVuY2xvc2luZ0JvdW5kaW5nQm94 KCk7CiAgICAgICAgICAgICAgICAgZWxzZQo=